From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1212C369AB for ; Fri, 18 Apr 2025 10:40:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C5B72280020; Fri, 18 Apr 2025 06:40:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BE46C28001B; Fri, 18 Apr 2025 06:40:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A1004280020; Fri, 18 Apr 2025 06:40:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 7C23B28001B for ; Fri, 18 Apr 2025 06:40:17 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id E4CCC1CE0E5 for ; Fri, 18 Apr 2025 10:40:17 +0000 (UTC) X-FDA: 83346820074.12.CCF3601 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf22.hostedemail.com (Postfix) with ESMTP id 82519C000B for ; Fri, 18 Apr 2025 10:40:15 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ZDSCPsYe; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744972815; a=rsa-sha256; cv=none; b=UtD6NnSuhSIOiB2ow3fk1d51hwVMMSPmecaktZlVwkUzTTK/lCvkJOn7U96z81PLtvcw9F oNsXr3IwPzys48wjKoeVo26Q9wW8XfKRWkqeT9FHaphKsUKL0ohulfj8+giM7oj6pHgh4H 1r3Jm2wgh72vl5MJRd5jJZB10khUxiQ= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ZDSCPsYe; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744972815; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xPUlDnCCyGdj+WaGQ0gbXoHojvgutpUMexLIgSLwGMI=; b=qFdG0ATZLFWY+EkTJw13bfveIYmQnhOK1hxxiXWfIkycWPPASdybyXlYMaPW0V0UaWZ1WZ WbotabuzeWJjFH2W5NKC7D+WgIyzTACgCVhzR2njJmCLxLQZsrTZZMLeeLgHrE8kxFrl39 HMeB8TO7rY0a33qK8aXQUN1dTlsootg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1744972814; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=xPUlDnCCyGdj+WaGQ0gbXoHojvgutpUMexLIgSLwGMI=; b=ZDSCPsYecuP/DOLoabBZ1jUjxbS6Sy92imF/wz2Dq6uXFlyRuNjyAJ0iZhfeBwg4sEhPJ2 jOLgZeAELOUoqL3p2x3GhzqWTbfa0HOarRUuEapE9nZHQxJBu+czLY6o0hefnuA0qWd2XO WCq6qSSarAQ/pGn8+MjVolFAP+Dzd9Y= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-30-_eYc3YF8O1OluSRUGj9o_g-1; Fri, 18 Apr 2025 06:40:13 -0400 X-MC-Unique: _eYc3YF8O1OluSRUGj9o_g-1 X-Mimecast-MFC-AGG-ID: _eYc3YF8O1OluSRUGj9o_g_1744972812 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3913aaf1e32so815842f8f.0 for ; Fri, 18 Apr 2025 03:40:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744972812; x=1745577612; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=xPUlDnCCyGdj+WaGQ0gbXoHojvgutpUMexLIgSLwGMI=; b=Rz2tTw6rfuDlyOMyUyvHRb60O5F8ojDlU1mvz32tg1yBNKoeoN0ZpeguEV55AF3KRY d9Iv04KNd4jLm+UmqC7Y5qcpDi1H2hdaaal+geyOvz8j8stgNwutYMS9Cag1LgSdqUm2 Yi6q8Sbcdc9bKoiOn0Fjm7JjKGdSrnIr2M1g6M8OsLlviDXy5DJA79XkcCPU78SXJB03 77vK6aWmMBS/SzKDBwxmWK+bJgQQ6tDwbSVB8B104Q4XgXQKcHwkJa+naR5lo2bDskBW B3dSFET+R9PUTTFneN8XRadt2snLGxQwm9mo6l668uxDFV3U4bD5OImYP0DjBsEkiovK i4gA== X-Forwarded-Encrypted: i=1; AJvYcCXYEMznFm/5uh/AaySuKf3Q7JErqsoxnEqyrmdpAPB/rMjlOArGpqv34A2PBr35dKMn2aPHpZB1UQ==@kvack.org X-Gm-Message-State: AOJu0YxpOtulZk/7/03rdBZze/gtgWdHZYp7lelcrWJOOERq00JD3JBk LDE2JTxfa2yrEeX+W5vHVujwKia3OFMCIc5QNchqSj/uFYOT1cteHJRP18xbTcUZM6R5j4agxYp iQ4rzfwZxsxmnFIGkcBZ9DKR1/yTLmxABiwDhO4lfMzMFfLPj X-Gm-Gg: ASbGncuVM09CQdeogk2nNtQWY1bHKWPBkO+grCdOxJ/4N+dBcChLoIeyqOWaXX78eZ9 RRSjVc7gZO6CG4PhgY8OunDlmslGUI2CSeBN+qtb/wDtwc+KvOXUcp1jrrrP727inJAUdh+KwbS cI58JpGeabzE8h2eA8EXf/+jfVNgRN2zPq6KvE54dMr1JzrdKWZHaYtEcb0TsOZ98NGrp3EFukv zjTc3000j/zhOZEfhyVmiTjxTiGCayfWUvqjIyDRU5VYK6VBzX4HT5OThI1V9mrHTiPuuUzSzs1 Ad/HamPn47ZE2f3d1+7uqseI0HSdFI78S92cd2tbjCXEAIx9Y1lFr66Wux9uBnMHvSyjMoUzzt7 sS2dLabtzg6pppYDO10cgtSDq1ZF7kNeb4YobcGQ= X-Received: by 2002:a05:6000:402b:b0:38b:d7d2:12f6 with SMTP id ffacd0b85a97d-39efba2c999mr1668735f8f.2.1744972812059; Fri, 18 Apr 2025 03:40:12 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE7QkJxXK0IVmm+2E5K/7fEzuE4NJzadCM2M6LeP36yeDc+bOjhp+9VaNgLtNmRx8aZF+UFFQ== X-Received: by 2002:a05:6000:402b:b0:38b:d7d2:12f6 with SMTP id ffacd0b85a97d-39efba2c999mr1668715f8f.2.1744972811692; Fri, 18 Apr 2025 03:40:11 -0700 (PDT) Received: from ?IPV6:2003:cb:c70e:6700:cada:5396:a4f8:1434? (p200300cbc70e6700cada5396a4f81434.dip0.t-ipconnect.de. [2003:cb:c70e:6700:cada:5396:a4f8:1434]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4406d5d6f86sm17022605e9.35.2025.04.18.03.40.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Apr 2025 03:40:11 -0700 (PDT) Message-ID: <9490ed5c-f6e0-40f3-839b-7b3a5decb5f4@redhat.com> Date: Fri, 18 Apr 2025 12:40:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] mm/rmap: rename page__anon_vma to page_anon_vma for consistency To: Ye Liu , akpm@linux-foundation.org, nao.horiguchi@gmail.com, linmiaohe@huawei.com Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, harry.yoo@oracle.com, riel@surriel.com, vbabka@suse.cz, liuye@kylinos.cn References: <20250418095600.721989-1-ye.liu@linux.dev> <20250418095600.721989-2-ye.liu@linux.dev> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250418095600.721989-2-ye.liu@linux.dev> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 36DFPz1CrNd4aESaXTGlSoZGdBssFmg3BeBuGMwu7V0_1744972812 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 82519C000B X-Stat-Signature: x7ofnou7nm7y3o1k71kmtr755f9364di X-Rspam-User: X-HE-Tag: 1744972815-732974 X-HE-Meta: U2FsdGVkX18hI8l8opwvk27gj16xE05UQYPDFTLHflvvyShxz7xmHFlskhMbgtNMqdJTtahNI2xj4h+NQa92PT/T+p2jtbrR5L6bK9YeAh8ZnUy2jVet2zMLL5uKF/zrlYMa6SYo6eR8ol4YJA86jxnhKJIY5JqojPQqZ75uU0HFWknuoe9MIw9dXBSDa1mSPNIzMa9qIg7UtYlEFEQsDCxg7vxps/qmlRfCMXqebXTBlx41AfAGQhoWe7K8HrgdzWrIvQTm/+iexKdgh+Ta8V7S61WpPYyt186TO2pJNgn0ASnyI5cgKXuE/X+57WzhMryJHamG/z4wmOzH6ewBrrjyC6MzSgcvKztgWLTy5cgBhakjBut3g0z31ICdcYu8PGlMiPY++WiVJlBNBsAzFj6qz2/ApN48GhF91D0DiB54fl2XqJ3S+48vsl2pdp9VrW/XZRrfBqyxTTwH6seHN1eppWE2pzkkczOXJ5hXj6Yl13d+QOtWma+rwHF8bbq6onMJaK7X3sdPXkpU+zmRELH1caER/9Ssz6IzIdMmKISuhntAHNlLQD/aZsPZ4sGmms1kfNCnIa8ktz+RCrbUJVB015fWsO7Oevw5Mac8mUQF6TOPK1dp3ZSh+YDgFeN4nguDWb1ImwvnaI7Xcv/5TyJHJ37R1O8Ji3WHX6j7OczbTGBngfl1PudNSK9WmHBFcTW1sfDziZev09imGLTPL3BJLZMswWxHEpquIqfGqQg5DXXFWrx1PBbG/GwjVoE0kvPghn6tAcw1l3rMTQ+V8TouJ+LH3xCmkRTcmTk8MuqAQYBhLMqqTF/R6c+Rc9JxIKdUcnvfKtVzT4VfdaG5XA6OH4m5D6gcHWeK0/7zIpm5NwSLBy5MsNpglDXkoWzD5tBZTV5dMTB0gAX7DQsFOsU0t9E3it1tM85oQtZR50RHVH9YmxlO0IAQU4EZ9ljz+FGiI03dKP3fpCfU4eM Geu2UKl3 wlwi0NiMoXthbLd7DZY2RlBwGtSIwtB4UkHY5CMAXMjI02EC628fXeR1hBwyUT3nBwyS6kIWQFMHRawbQPN0vo5BXKHgNrbk/VXAdBv5IIPJIq25EgANsbvmECsMDDjUYIjELs6Dj0gMO7VAy+v9IHMnCUFewoeXWCfOyqzFLXCRoXAxzPIlb/kKEQdtzb9hjtd9qwOZwgASwlaH4gGSi0TihJNq7D44coq5PunC7v0Y0ldpRHnPJVmbgECDrcSdp2LxVIfRtT1icvgGz0u17YU7I0JFCiSF/RSm+zZ6XPtyQ3X2ArVS420+9bTnse/64DTBMAoiXZhUdLYPLIKakRwGBc0YzAeVBXNBN/kvfrHApEF4GzRkqeYnGcXsXrdSZu1gpcNCZY+tRPfkAzc3VOqj9V0oSSfnSz1XhUNx/cgYX73wZEBrFoCw8Qt5dgEkzPc5IZbRjG6XMjKLCZ/4mRfDdJNkZhpbTtDxiLN/KHJAh78j7xnaT2EcBsjzFVM1Obj7zAtM/7zDnURI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 18.04.25 11:55, Ye Liu wrote: > From: Ye Liu > > Renamed local variable page__anon_vma in page_address_in_vma() to > page_anon_vma. The previous naming convention of using double underscores > (__) is unnecessary and inconsistent with typical kernel style, which uses > single underscores to denote local variables. Also updated comments to > reflect the new variable name. > > Functionality unchanged. > > Signed-off-by: Ye Liu > --- > mm/rmap.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/mm/rmap.c b/mm/rmap.c > index 67bb273dfb80..b509c226e50d 100644 > --- a/mm/rmap.c > +++ b/mm/rmap.c > @@ -789,13 +789,13 @@ unsigned long page_address_in_vma(const struct folio *folio, > const struct page *page, const struct vm_area_struct *vma) > { > if (folio_test_anon(folio)) { > - struct anon_vma *page__anon_vma = folio_anon_vma(folio); > + struct anon_vma *page_anon_vma = folio_anon_vma(folio); I'm extremely confused why this should not simply be called "anon_vma". Why do we need the "page" in here *at all* ? -- Cheers, David / dhildenb