From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EE27C3ABBC for ; Fri, 9 May 2025 15:49:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 505DF6B009E; Fri, 9 May 2025 11:49:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4B52C6B009F; Fri, 9 May 2025 11:49:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 355866B00A0; Fri, 9 May 2025 11:49:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 16A186B009E for ; Fri, 9 May 2025 11:49:37 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 0E58E1401E6 for ; Fri, 9 May 2025 15:49:37 +0000 (UTC) X-FDA: 83423804394.21.463AD79 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf20.hostedemail.com (Postfix) with ESMTP id A528D1C000B for ; Fri, 9 May 2025 15:49:34 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=I7ODV1q6; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf20.hostedemail.com: domain of llong@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=llong@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746805774; a=rsa-sha256; cv=none; b=5ETy9KA/V1qiyWBTF1/DGqJrYrXBhPx7x1SMTkNBrGZ/yVqqvbINBJuHQlA5+jkmEW3po4 BRC76NTtSi0VgJr00O3vthXW1o1AQgdhTaZeqkrCbqxs91I/HQkFqmpfWiAiAQQxwvJPDO eV+uxsmVKw0qm9ZugJl4yOqDFqq+c5Y= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=I7ODV1q6; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf20.hostedemail.com: domain of llong@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=llong@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746805774; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bTgQu7bXXJwDyG63O7O6nk0DUKrmaXIkhDqMVuS1nM8=; b=OjPP+ilZTfpOCgPvNI7LGhtTDsRs4c784msvYDwkmvd6OAIob08V6Wus3S9rfi8PXvSYWL XhoRbnXirSIJt65LAQMMVaAYZ+VyjgH+1t7O6ptv1W1IAqtFQxfltBWoXJx72aWe+Um3sL vNvIFt9gK2x7iJGd1c9Pog2Ydx8X+5o= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1746805774; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bTgQu7bXXJwDyG63O7O6nk0DUKrmaXIkhDqMVuS1nM8=; b=I7ODV1q6PX1cLJD/nFyuIuUAB1EqyPriYOiEdQeLkTpxdpl52fZJH25hclmMaHPAO+ubTi NG5+4K9P8mJ19n5+27hG9VAfJi7CG7O7bycO7ZFXeUvFTrRz6WyWWWYEkPer1jQzKHEvHV zkRHlF6zvTRqNEn1xt/lHSr3P0P/P5A= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-339-ceSqswvkNFGMmgM9Sx_LfA-1; Fri, 09 May 2025 11:49:33 -0400 X-MC-Unique: ceSqswvkNFGMmgM9Sx_LfA-1 X-Mimecast-MFC-AGG-ID: ceSqswvkNFGMmgM9Sx_LfA_1746805772 Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-7c955be751aso374471085a.2 for ; Fri, 09 May 2025 08:49:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746805772; x=1747410572; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bTgQu7bXXJwDyG63O7O6nk0DUKrmaXIkhDqMVuS1nM8=; b=eEllPD3mzXVUOgpAlQopB/3ht9+I4O4m6jEbAD88D5//XJcI3W8AWJrTiwq3Qe0btC RahQbOjeDk7brjhGsycBZmf1m8dqY9SNZu5tzosDTV9k78uL/BjM37mxXHydAL9Fl+jV AvkuY4I2lFM2u0S3UD/588jjzYbMIdhFMmWLIjVqwuwCZrNf1qq86lfsTYIyyhvXS29t aLJFRkw9Cs7SjytOtDOcuAOjX9O4TVTi/RJu/51zIHiPAN2BewnZzfrrCyRcUuqVBlsa 4JyTltB0vDNaB+Oru/pIX7EPoI5lG84q6pCyhCediPySCSykFW7dRVjzsamQM6yyijC+ L8lw== X-Forwarded-Encrypted: i=1; AJvYcCUTbj8EkHXaJ2FtB0tl22KT9/Q+l2kzYG399ajRDY+DhXoH1WGjpqkqycFnPeh/xEHyx9xxsEfH6Q==@kvack.org X-Gm-Message-State: AOJu0Yzw44F1tlZHx7V1DB7YoCA8NxgtCc7udqc6Gjrrn6oNdDdxLjbR vQX2oY8GlFQBl7732MPupoJSADVO+cE7Hmgg8sjwEpvmWifiLw2FXDAVYMKM/gAAKmnW9hgVLe3 yKQgKon/adzgTG6EGsfpwdUlw3y2FWiH5zQIbFdrP2qJTennZ X-Gm-Gg: ASbGncvoz0PH+HiQvFzo5NgS0iHguXLNz9AZTydA+8HdTzitB456thGYV/0kSMOTTBI vRj0tPOlvYpcxYoZdDCsd9KWqYaGQjlp/GlnfLVO4x+dGSkQeYNP4uhC/736iUNlSmqjBwS6/BJ wpazHxmTHNEjrkvE2qWBd/Fpq3QL/5UKBDx6gudi8YIQiy4GruCC6Rf1SXo7db4XAsOVqT7+jxk UoUwq22+wXoj+xs+1Mkqpdr7K1vtQCc0EcvPbnjqbQzvBB//SnFbCx9qEH346G9vcaEExOzuRBE mV8o5HAgxpR5oNPjUd2wKd8St0Ol1lE6ZPHH6KvEBEcle9Bcds0FokMtnA== X-Received: by 2002:a05:620a:29c8:b0:7c7:a5e1:f204 with SMTP id af79cd13be357-7cd01178f38mr647783285a.56.1746805772434; Fri, 09 May 2025 08:49:32 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHJkQOqWjGp1exWeBQyTD+TGxOr9R3jwYtLHE0ov1mymITAbAKVgPbavKihGj+3kArRZ7+/Mw== X-Received: by 2002:a05:620a:29c8:b0:7c7:a5e1:f204 with SMTP id af79cd13be357-7cd01178f38mr647778385a.56.1746805772038; Fri, 09 May 2025 08:49:32 -0700 (PDT) Received: from ?IPV6:2601:188:c102:9c40:1f42:eb97:44d3:6e9a? ([2601:188:c102:9c40:1f42:eb97:44d3:6e9a]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7cd00f9a35dsm153891385a.54.2025.05.09.08.49.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 May 2025 08:49:31 -0700 (PDT) From: Waiman Long X-Google-Original-From: Waiman Long Message-ID: <9490adcb-de88-4ff9-9548-1fe4c246ea86@redhat.com> Date: Fri, 9 May 2025 11:49:29 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 02/12] locking/rtmutex: Move max_lock_depth into rtmutex.c To: Joel Granados , Luis Chamberlain , Petr Pavlu , Sami Tolvanen , Daniel Gomez , Kees Cook , Peter Zijlstra , Ingo Molnar , Will Deacon , Boqun Feng , "Paul E. McKenney" , Frederic Weisbecker , Neeraj Upadhyay , Joel Fernandes , Josh Triplett , Uladzislau Rezki , Steven Rostedt , Mathieu Desnoyers , Lai Jiangshan , Zqiang , Andrew Morton , "James E.J. Bottomley" , Helge Deller , Greg Kroah-Hartman , Jiri Slaby Cc: linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, rcu@vger.kernel.org, linux-mm@kvack.org, linux-parisc@vger.kernel.org, linux-serial@vger.kernel.org References: <20250509-jag-mv_ctltables_iter2-v1-0-d0ad83f5f4c3@kernel.org> <20250509-jag-mv_ctltables_iter2-v1-2-d0ad83f5f4c3@kernel.org> In-Reply-To: <20250509-jag-mv_ctltables_iter2-v1-2-d0ad83f5f4c3@kernel.org> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: AtZ1hEPLbnZqnAIqI86xQ48QW7QZRolyrVkYhEdotmY_1746805772 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: A528D1C000B X-Stat-Signature: 3wit7r5f5eep49rf84abqmdjn5agpnki X-Rspam-User: X-HE-Tag: 1746805774-88072 X-HE-Meta: U2FsdGVkX1/gkkyJEIZiOuDbEowCxk/LZPpl1AaKtJdZcqRxgK1ErzQFjEwokvzgyXK5f0zFSy4mvSeAb/OGOab0mbQTfTRnbzBtF4VIwT+XgslI53nU2kJSB8RQ/dKSm/k8KW501VE4PUJGYBWYn86tYEvKJYn6N6raJdo/LW1aZMA5HjPqF+oyH5e9wVgahhq+9LhSWDSWt9sKch8++nJIzQg8TkgfX5ThAjjs7WIvDhKp5gGVnl9aMVI0QEEoewhKxr3GMtfAtzgNXql9qM4OuWEUwxhLd0kKykveWim258YS0rchagnLIc/xRB26HKlJWKKRLt8n2Xifcm3KJBVAtjfVXn3wOg06NapfXkO1SZHexsCsU5NwnrJkDvlj4/ALg7k4wZKyfoQaPryXqNPCWiaoYbZT+P/cRaockVBd5gU7oma/SGfZzSckRYXQ9HZdWfLXOLQXR/0dcK/kI2r5a5Bvw3Bhf+IOlNB5HGYbfX9vSXebaYJxCM2bh1y9tZ+LBRHT6qXbk0iKGJamQM5YLmJ3KfaikLuIJYw8irSPHP250BJIyXyBGCxZYgUdFoOcUaC8OF9h9dshkVG/Uq16MjmoIYcEWEpLssYAi9vJS6XxiZ8hZFLP0jlZmW7XkkWXiq+/Wm/ZEuPHKUg8hVqE8OGz08XoP8Ro3sIAsBSx69OElCIYWX8Vzi6F9l/5csi/csE2Rdd6eri6mbhLkkr192uu0vjTyeJDG8Z8upT/yROsoWE53Zw5Wl0qahkR4fjDCiCEWPH5ISff1lE8IhJZKUHOpk3KfIk03o6m3Jv5kzIyZPqRlUcA7gSndPOOhYLI5EIMWxG6JtNE76xgNpODcKE4eI4Eg8apd76Q6Rnz1FTOA3jgh4CWrcdm5fff8BlUCk5nYoJCn4h6z8WrVwaaQyeK9ObaHm/r9/CK82Y63bkSEPAb5/iu4T0itABIBTfGqZ/jis89yOjIMJE wOY3bP9J Lce9KWgbEZlKPlsgmOzHOlWutJVxPN85cnOGEl4pYUwuJfkMXYMsvgygVnL1OhcK9WaPPXbqTwmYgLjHo8DW+Iyka5IRmvBagw+rtn550PbLek3LjY9AOpoDdjVux2RNPY6ePhHsDA96mSJVVDQ5yo1l7+u+BKwmcTjdWhirqhaUi/rE+UKzg6AI4OUnuBZmu7LKuTv2heOEw28QRRmxDgzdxzNYKIiN2lIP6imqJo76q2LvnnGo1WlOgWYg4yuCYlmQueZkjtTmmIPnzyLI5bpaJBPudnAEhDBRkujipNgfb9w5c8g08FgzIIsUQdawJfPRgmJAxYCVhE2SHsNfeJyKRTp3dlqyBhHWYaCNNaNOXhCK/A/EM8LWz6Kj+5AkeOnQ3bJSoY/6OrIZBDC6id/Oyi0ZibMtAFPUECsPZQ6CX/zljxi+VRyz+yETpGN/h8uJ5WK2TXfwjQVxtciHosQ7IIg5h8e/PaR9lGbNfRomH5k0pFVJBrHbJYHhZ+JicEx69zUVKBDiMxWWcEoUg3ZRv6gxCnPcZCb44VUjNK62hmuYEf7pQmgXb5RDvi7QHRMKcOqHGTavE3y3RTl91MLjQax/HJZfKm233MD6OQF4IwvrEDvCVqmnQmeIb9hOs6XLbdcs0hs8UG2MyuqNH3G5MEgITcYDgP/IiAmf3mW7AtxvxB6oNwpVSqg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 5/9/25 8:54 AM, Joel Granados wrote: > Move the max_lock_depth sysctl table element and variable into > rtmutex.c. Make the variable static as it no longer needs to be > exported. Removed the rtmutex.h include from sysctl.c. > > This is part of a greater effort to move ctl tables into their > respective subsystems which will reduce the merge conflicts in > kernel/sysctl.c. > > Signed-off-by: Joel Granados > --- > include/linux/rtmutex.h | 2 -- > kernel/locking/rtmutex.c | 23 +++++++++++++++++++++++ > kernel/locking/rtmutex_api.c | 5 ----- > kernel/sysctl.c | 12 ------------ > 4 files changed, 23 insertions(+), 19 deletions(-) > > diff --git a/include/linux/rtmutex.h b/include/linux/rtmutex.h > index 7d049883a08ace049384d70b4c97e3f4fb0e46f8..dc9a51cda97cdb6ac8e12be5209071744101b703 100644 > --- a/include/linux/rtmutex.h > +++ b/include/linux/rtmutex.h > @@ -18,8 +18,6 @@ > #include > #include > > -extern int max_lock_depth; /* for sysctl */ > - > struct rt_mutex_base { > raw_spinlock_t wait_lock; > struct rb_root_cached waiters; > diff --git a/kernel/locking/rtmutex.c b/kernel/locking/rtmutex.c > index c80902eacd797c669dedcf10966a8cff38524b50..705a0e0fd72ab8da051e4227a5b89cb3d1539524 100644 > --- a/kernel/locking/rtmutex.c > +++ b/kernel/locking/rtmutex.c > @@ -29,6 +29,29 @@ > #include "rtmutex_common.h" > #include "lock_events.h" > > +/* > + * Max number of times we'll walk the boosting chain: > + */ > +static int max_lock_depth = 1024; > + > +static const struct ctl_table rtmutex_sysctl_table[] = { > + { > + .procname = "max_lock_depth", > + .data = &max_lock_depth, > + .maxlen = sizeof(int), > + .mode = 0644, > + .proc_handler = proc_dointvec, > + }, > +}; > + > +static int __init init_rtmutex_sysctl(void) > +{ > + register_sysctl_init("kernel", rtmutex_sysctl_table); > + return 0; > +} > + > +subsys_initcall(init_rtmutex_sysctl); > + > #ifndef WW_RT > # define build_ww_mutex() (false) > # define ww_container_of(rtm) NULL > diff --git a/kernel/locking/rtmutex_api.c b/kernel/locking/rtmutex_api.c > index 191e4720e546627aed0d7ec715673b1b8753b130..2b5da8af206da6ee72df1234a4db94f5c4f6f882 100644 > --- a/kernel/locking/rtmutex_api.c > +++ b/kernel/locking/rtmutex_api.c > @@ -8,11 +8,6 @@ > #define RT_MUTEX_BUILD_MUTEX > #include "rtmutex.c" > > -/* > - * Max number of times we'll walk the boosting chain: > - */ > -int max_lock_depth = 1024; > - > /* > * Debug aware fast / slowpath lock,trylock,unlock > * > diff --git a/kernel/sysctl.c b/kernel/sysctl.c > index 473133d9651eac4ef44b8b63a44b77189818ac08..a22f35013da0d838ef421fc5d192f00d1e70fb0f 100644 > --- a/kernel/sysctl.c > +++ b/kernel/sysctl.c > @@ -59,9 +59,6 @@ > #include > #include > #endif > -#ifdef CONFIG_RT_MUTEXES > -#include > -#endif > > /* shared constants to be used in various sysctls */ > const int sysctl_vals[] = { 0, 1, 2, 3, 4, 100, 200, 1000, 3000, INT_MAX, 65535, -1 }; > @@ -1709,15 +1706,6 @@ static const struct ctl_table kern_table[] = { > .proc_handler = proc_dointvec, > }, > #endif > -#ifdef CONFIG_RT_MUTEXES > - { > - .procname = "max_lock_depth", > - .data = &max_lock_depth, > - .maxlen = sizeof(int), > - .mode = 0644, > - .proc_handler = proc_dointvec, > - }, > -#endif > #ifdef CONFIG_TREE_RCU > { > .procname = "panic_on_rcu_stall", > Acked-by: Waiman Long