From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DCBBD591A8 for ; Mon, 18 Nov 2024 17:20:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 785286B0083; Mon, 18 Nov 2024 12:20:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 70EBA6B0085; Mon, 18 Nov 2024 12:20:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5B0D16B0088; Mon, 18 Nov 2024 12:20:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 2C3FF6B0083 for ; Mon, 18 Nov 2024 12:20:27 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 9810A1A0378 for ; Mon, 18 Nov 2024 17:20:26 +0000 (UTC) X-FDA: 82799878686.04.A85F49D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf16.hostedemail.com (Postfix) with ESMTP id 759DD18000E for ; Mon, 18 Nov 2024 17:19:35 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=frUvPaZo; spf=pass (imf16.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731950244; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FHIXshzU7B/fw7mP4ANo81ZSu1pvlr9VA+iMyEA9kz8=; b=8HLFyrDcReITADUjqpQobMJ9w2RLaAyIyvjlqGvILGemmyQb+g/nqAM4kqImqTPF9DxMFN obmvjZnYcSYG7/k9//FeGkIQLeM/TVe871pHIwy/btOOn8fR24Ea45ZGZ1I+YEfjvDLEtj b+2tCyUjkFd/tl2Sm5abltOwgZxa0OI= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=frUvPaZo; spf=pass (imf16.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731950244; a=rsa-sha256; cv=none; b=yMDoPSQyLfKVIwS/Ixyc15WgNfX4PyYc9Ffhmkxi90nbrANkUHfRhnWMxdtD8OdLYReyyy 9kR91RmVmGmwS6qGf/8I8Ejh/5eCORixbGR6lcBkghp0EOPjAkjHFev1sNSR2Paq66JTUt 76QQiUcPQPZjBoEMXzQJ/UiWirHVKdo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1731950423; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FHIXshzU7B/fw7mP4ANo81ZSu1pvlr9VA+iMyEA9kz8=; b=frUvPaZo7qhuMF8AFFq6LyvBCYYeyVw/sHZbjmM8bdrupTEKmnGp8jnqDDWrrBcGzTkS8l wH2Rl9QDzvpRBdltzlDhM5eytsLURdeaOaJ6k7DZhLb8/5ASNEriuYVkTuvBGsGYooBkc/ lUkLRadLzjHYuPbCmm8Pq2TLMqcv32c= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-152-eXuZijuZMpiG0ZJ9iVPEIQ-1; Mon, 18 Nov 2024 12:20:22 -0500 X-MC-Unique: eXuZijuZMpiG0ZJ9iVPEIQ-1 X-Mimecast-MFC-AGG-ID: eXuZijuZMpiG0ZJ9iVPEIQ Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A67371955D62; Mon, 18 Nov 2024 17:20:16 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.207]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 261D5195DF81; Mon, 18 Nov 2024 17:20:08 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20241114163931.GA1928968@thelio-3990X> References: <20241114163931.GA1928968@thelio-3990X> <20241108173236.1382366-1-dhowells@redhat.com> <20241108173236.1382366-29-dhowells@redhat.com> To: Nathan Chancellor Cc: dhowells@redhat.com, Christian Brauner , Steve French , Matthew Wilcox , Jeff Layton , Gao Xiang , Dominique Martinet , Marc Dionne , Paulo Alcantara , Shyam Prasad N , Tom Talpey , Eric Van Hensbergen , Ilya Dryomov , netfs@lists.linux.dev, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 28/33] netfs: Change the read result collector to only use one work item MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <948807.1731950408.1@warthog.procyon.org.uk> Content-Transfer-Encoding: quoted-printable Date: Mon, 18 Nov 2024 17:20:08 +0000 Message-ID: <948808.1731950408@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 759DD18000E X-Stat-Signature: wf6cftm6tsahk8rca3u7p7uhwcocn4zc X-Rspam-User: X-HE-Tag: 1731950375-264911 X-HE-Meta: U2FsdGVkX1+Hy9Bd2tDaWiPbGJCS17WLaURHCtN+8uFoOtHif9VhcYJGXwnkjKQzqtKGVfU74JR1bi5KtOCAO0ahg5/+uKeyuXQ7LSlPlXSsCiBB4ruSG1ppXQvgh0UkMU1cz7kuMEieXGzkwM7hRLV34CtLgNjO4a09+f9LPT4T4jVIH+6ggP3ci8p2HlTDAtf6tmBIwlHTK93f0mFareToheVCIGQawaGlrsf8zk5faZBsOMlMl5P/Rbm24EI16z1T53OGKByPzPmTLcZY8C1ABYdPNjQCB5WdOSzuYk9E4wALKGSDKJGGI53coSfB+40n3vBYFrs9YuQRXiJ2+dz58LQDvhKt2cXEl8lEkTHhM6R0Alw5ASMH9sHojB0Zh+wq0oR4xF4o1DSLpkNzNT5xpUwPJMqIRH31uhNaoG8zdJ7lurQRs27+r7ngKVcq+sVad0tNuFN9SZw+NePiV6w5U0es/UXosP67QgFfqB56yS08JIHvLlPTWY0nK3jI26Ka3l+WM7naCUZiqdkgT8t5jFtrK1FviSMV7/CZf0Dd5M3dw3wn73SzeE4CwgVQCiYM44Vo9Y0lFcVso9Wy6ftvpzK1QKHd4pI1HJPVcerktj+la1ziboJ1rqINfAfleK3NBaikdIj/cq1Bh5KVu+dLSX27NPvYMGnRj0jJwlzi8kdO3mpj6OD5cp/bF/ipJXGdA59hRHt7Kuo50FcVXgOfB/JKpR2G76B94fbucH/bHfMkmR9ae4cJfjc5rwjOyTm7CA26hXZIzNEZbuqkqcTHEs38CipTVnSmGTgssXH9umdnrrj0Ny5+rgpGldk82DtAkUE/l6TdNcSy4OP0Y9E5Y+iBqzetBFz5ArUXGoESdfO/Z+T0G8gAUugkwEQP4NvYhcy35DJDnVqIpuiSttxDGxpvnYy8H8nHzDP5VbeCpUQ/7cOpPCFEbf2oUzfquUpuLfr7WpquuQdjKJR qEpo5J35 XPIhg+R4susV90Wq/GDkZslPRLx8frCzYIAqfbSCNicCTbq2YudTUrcAyJfICVMmoSzeOsn1dOVdEp7l/SwoJvJWKjK50Qitwl3seSyaw5hnYh+Tks7HjrEQKtKJlRftUU3li/mhNTP7ACkMP3qSGRz1c1PaMQ0IGw4wCI4KDBxgjNktM73Injb7mNVvDP1nbmZFXC+5ybG5TfffbJoQz11EVzx1DKUl3gLy4p/QhNZ33TmjMFNXFbjYk2hwiY8dF6gjzqk2vXsgXOhEI44Knvvj8HvseY5qtvRiTDFu0UR25Rwx4gABNvwky7fRNlXkzfduvMSmmSDDJmbg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Nathan Chancellor wrote: > This change as commit 1bd9011ee163 ("netfs: Change the read result > collector to only use one work item") in next-20241114 causes a clang > warning: > = > fs/netfs/read_retry.c:235:20: error: variable 'subreq' is uninitialize= d when used here [-Werror,-Wuninitialized] > 235 | if (list_is_last(&subreq->rreq_link, &stream->subreque= sts)) > | ^~~~~~ > fs/netfs/read_retry.c:28:36: note: initialize the variable 'subreq' to= silence this warning > 28 | struct netfs_io_subrequest *subreq; > | ^ > | =3D NULL > = > May be a shadowing issue, as adding KCFLAGS=3D-Wshadow shows: Yep. I'll remove both shadowing variables (there's also one at line 45 in= the bit that deals with the non-renegotiation case) and use the outermost one. Thanks, David