From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42E01C54EBC for ; Thu, 12 Jan 2023 10:18:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A67AF8E0002; Thu, 12 Jan 2023 05:18:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A18108E0001; Thu, 12 Jan 2023 05:18:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 92D6E8E0002; Thu, 12 Jan 2023 05:18:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 84AAE8E0001 for ; Thu, 12 Jan 2023 05:18:01 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 5E77F1C6431 for ; Thu, 12 Jan 2023 10:18:01 +0000 (UTC) X-FDA: 80345746362.03.FCC3057 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf19.hostedemail.com (Postfix) with ESMTP id BD4F71A0002 for ; Thu, 12 Jan 2023 10:17:59 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=QimElLgA; spf=pass (imf19.hostedemail.com: domain of chao@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=chao@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673518679; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WIWPZIKq2KjEJ51tFDiaRs+SDZBMmPeDICQjCFzQKiU=; b=IzoFKx5IU6tf/9+4b7+49AY/ZgPVFUBezl0w5NyLaqRq4T2QME7bTnqsShM3EsUls4Uoz/ Fwbn9Oo5LoG09I96VAt16uzZa6TleUma3OW6KziogJ2WghyUyXwMuY1TXXLrrJUsxdfnAH 1OJZuSa1R8usAz/RFf3Si9JV3ZuNt7o= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=QimElLgA; spf=pass (imf19.hostedemail.com: domain of chao@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=chao@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673518679; a=rsa-sha256; cv=none; b=Ufz4AkkkRxVr+A0EdZOx2ZxLMCCg+qW8ptvuwAgsX8Ions7t9RR/mb+kUTUXDMagDShwKD rKLS7Yw5IkQ9GLHdQILlXgehpSWngiFND15Do3Xhfm6ilHKsBg5yvKQK02C+hUCe03/V6o oHs9eK8cVuPF3pP3pPyE8SaAMWIUKOo= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B20C061FC6; Thu, 12 Jan 2023 10:17:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CEB3CC433F0; Thu, 12 Jan 2023 10:17:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1673518678; bh=RWmztfAERjHa5tH2ViWsV3yzcmvZGe2nsppJNqvO6nY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=QimElLgAUkm2pWG+9clfVm0g/+I6aeQhLiop1NXH3ggqRgiSMYuDCeVoo/S6+gzJY PNOdc4zkc3g9vyJRLCGGXs4xGlo2bgd5WV5BpGVnWqWkZWHvG4+Twb3PpOcVWA00TQ CtSJ6oBVJZuWds8Gzwxd8uJD8KaK/QeN/ecUiTunWAzFOgwVHZkQpn5DSQxQ5pMdCZ nFZuhHlKq/ihDO4Z6VQ2I0D0Z7OO7T2vhPX7bVGqCpBjEdHbFWFj6FAHk6UWQOIMvG bwAyAfb1J08LRHSsE2RopFWsuG50ER9ahudfzjFNkB4hLI0aND1X18nTETl1T5hHXf F06w0Cy7QBsGA== Message-ID: <9481a114-04d3-7276-bc82-ee18c685b5a6@kernel.org> Date: Thu, 12 Jan 2023 18:17:54 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [f2fs-dev] [PATCH v5 14/23] f2fs: Convert f2fs_write_cache_pages() to use filemap_get_folios_tag() Content-Language: en-US To: "Vishal Moola (Oracle)" , linux-fsdevel@vger.kernel.org Cc: linux-cifs@vger.kernel.org, linux-nilfs@vger.kernel.org, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-mm@kvack.org, ceph-devel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-afs@lists.infradead.org, linux-btrfs@vger.kernel.org References: <20230104211448.4804-1-vishal.moola@gmail.com> <20230104211448.4804-15-vishal.moola@gmail.com> From: Chao Yu In-Reply-To: <20230104211448.4804-15-vishal.moola@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: BD4F71A0002 X-Stat-Signature: oy6n1ytihewsnzu9f7rz4zn4p3d9dh7u X-HE-Tag: 1673518679-613580 X-HE-Meta: U2FsdGVkX1/wks88TXW6GGNAFS2myqrGCIp/voZ2ZumHLLis6Of7G44aq4xP6LZ1/drFgrtXLEM1O0sdhwmd2emkMZlfd5mcV2zw/NELlO5Be77Llxdk8XrXKb31UU+/IUzNg3eK9AdUw/b02Ho+dp4htXOlwcJqQ1fT5Dh3Z/YC0I+qCsbCvyqMb3W+eUIJqCtyPNKgfnSAoF9ko/Cb3s1zJzodW2DIAU4Zo7ZiIBLybDmCo0rZRiNgsJ+m96KbbzXaQ1o+b47lNd/iVzkLbvHQRRBbjPJexr8tYXQmWg0Gef0PJ3mSdwPY6Mgh/ZgeTbeZDZLvOTbF9zMV9t8WRg2MhUmPUmQNDQYr6vIZxqj7mZM56sElV8Ue8qGVQAN0Q1ZDqCO6D90tcNAW87Bdg7XYzw3nx8cthHuOHdmiZNnsad8WQ4DAbpwigH5NijwzcEKZsbHfOA50C2tG8n1FQlY5YlDONveEsm3oKugPZ7U1FcbNubUnB35hYpKdC+YbEpzzanQ121m8fMN8i37UgIJENltDyKbhgC5CEnAwO4O4OMtoDLI/hRuMi8DRJplcUZotUnvEbAji9DBNPlXOmFzBNWVECFcUv010f4QjG6RBGbM7tRYam/YpfM4YZODCWImsqT1F9JU66X9HDEic/jpDHR/fl3jMmwXA/SWDSMi8o2uTQTPhueLG2v7N2gjUqOA41J20SZFVqnZu/pcthMY2alVm7J2g3cdQNOJ7uIcVBNyGxCU8NiZy9oTyL8ZvPv9jXQhqrqqimMx54ukWBEJ4AsKw68CM0I9S9mmiotNUrWsy/I+DxuOFdmOyej1ZfNTD6lLCG8KqC8pwVM1SzTDQKxCMNCoXQD00PfPqrDG/ldQua9xWXV18/o6je93Cjv4nJsYx1j7/L1cc/MRqmHwo3rpv9ezpVb/uWIeInLU9Y5NzgxHeHhAFDYT9iiQcG9o3D4nOWEW5UZJ/iTU FYWXRzI4 fKVj36+ValEAI/C7sNZdvQbhFk09gm2wTOIZJJvkjeuERAfwBemrNlfnNbSGG8iBEf30Q8tfB1M0Ga/JdmKWAxqd7pvOkDffHBZ+UXRQlqm4RsaFgKCTz5AH5801fcvGQgshnKhGkYne+YFgFVwKnHai8yA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/1/5 5:14, Vishal Moola (Oracle) wrote: > Converted the function to use a folio_batch instead of pagevec. This is in > preparation for the removal of find_get_pages_range_tag(). > > Also modified f2fs_all_cluster_page_ready to take in a folio_batch instead > of pagevec. This does NOT support large folios. The function currently > only utilizes folios of size 1 so this shouldn't cause any issues right > now. > > This version of the patch limits the number of pages fetched to > F2FS_ONSTACK_PAGES. If that ever happens, update the start index here > since filemap_get_folios_tag() updates the index to be after the last > found folio, not necessarily the last used page. > > Signed-off-by: Vishal Moola (Oracle) Acked-by: Chao Yu Thanks,