From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CB4CC10F1A for ; Thu, 9 May 2024 14:37:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D970B6B0089; Thu, 9 May 2024 10:37:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D46676B0095; Thu, 9 May 2024 10:37:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BE7D56B0096; Thu, 9 May 2024 10:37:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id A23F76B0089 for ; Thu, 9 May 2024 10:37:11 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 6128AC1316 for ; Thu, 9 May 2024 14:37:11 +0000 (UTC) X-FDA: 82099109862.17.77E6CCC Received: from mail-io1-f54.google.com (mail-io1-f54.google.com [209.85.166.54]) by imf24.hostedemail.com (Postfix) with ESMTP id E6D2A18001F for ; Thu, 9 May 2024 14:37:07 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=D+EU6ztA; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf24.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.54 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715265428; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qhunxhR/OF2icvm3HmEsNbbwCxzb74IsXbKxDT8qkPs=; b=ANvEyBgfopD82plv8DwZx3NaL0I5GGDlFwABHQSU6M9yPPCdIAJT7hcjLejx7Qgl+ArgxM 0dj3rfs6mV73nXubWtHAViQFJaNdhSHARkZuY/nWTHPKHfXUfrBiyQ9/vpVJaJDrtxbxWf RcWbh2fc9QuF0tkhtTns8z5+aPMnOaY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715265428; a=rsa-sha256; cv=none; b=4S02z1GaFPLZ4KoD3FQKC6Qllc4TAcf0YLty6F3UMffYjiuFrKh4cF3wB7Mt/4qaFxQcoU XBwNPBEQdmj8a+7cc1SfsjpB96mOoqYxmoO6TfQRTRitb1mZ17HXTk7KeKsxcdyRJr/07d sh43ETX3m7+WzwnoGVpVOEf8evwSiWU= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=D+EU6ztA; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf24.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.54 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org Received: by mail-io1-f54.google.com with SMTP id ca18e2360f4ac-7d9ef422859so8307139f.0 for ; Thu, 09 May 2024 07:37:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1715265427; x=1715870227; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=qhunxhR/OF2icvm3HmEsNbbwCxzb74IsXbKxDT8qkPs=; b=D+EU6ztAj9bwvMoYSf2tCqBcofz2xMNazdWJCtoZG4prXytum1wmdwuPN+ebgvnaA6 kr+C4zSYGTuBykwc1+iWPjypw4x+O5fC9DeyC66/qHBeNXjryXCpsiqrpa307G9L4qE2 KKnnBcY1C6bbk7Gzm5kWFFxw6ucuBzcm/hl+E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715265427; x=1715870227; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qhunxhR/OF2icvm3HmEsNbbwCxzb74IsXbKxDT8qkPs=; b=JY76gbPxP2qLaYw7bTpFPgaSAEg8FGEdYP4w4M3c0XJcwk+fQCXRiSoYaxXIF7eTxd Rnbs9Y0urTMKG1T0x0CiqBSW2jCEXYcnOTADLOOTmmBPVyeKdz9KabVvx/vTJUW20g1+ w/cj1Q0AJouRxe+FY0SfMyflTekmDHvQsSQO32JjjI6EN7VzH/ngBZn8rxVD9qZczDMf gW4JQQzwkMKqkBI/gNNsFFYLbT87OEiz4SFu/kgi2hPgNLr5CWwA3K7BVEu1kifs2blP qLuE9LD3enq+ewb/FwG7J1XAM8WYBytw9cFK1ki+nocTkZ3rz9JnK2VxcFvNGM7ejJSs Bz9w== X-Forwarded-Encrypted: i=1; AJvYcCU2azHPTbK8o8g5oPFan4AJYUY3Q9sMoimSvxTJXUiORRmfDa8MqpTlLpq4lfGJ+l9dJWgI0R9O+9SnnOHV9IW5DJQ= X-Gm-Message-State: AOJu0Yw6zwTBuWEFEnaRFzSywt/j0YKTjc6xlT0D6/A9PuP/kuueNZiK 0d4Aeb+mwKYQLLmLbEMPpvjFrUbORDS2VqJn5Xqc7JpqMKpyLc9H1eBRmsdhur4= X-Google-Smtp-Source: AGHT+IFLPV3hTUAqtiZSXFMZ3nZtJrVA8/PdzJcN3v/yjJF832scb22cGE7mYooNXziODVFLnPMOaA== X-Received: by 2002:a6b:e618:0:b0:7e1:86e1:cd46 with SMTP id ca18e2360f4ac-7e18fd9a35cmr655432839f.2.1715265426750; Thu, 09 May 2024 07:37:06 -0700 (PDT) Received: from [192.168.1.128] ([38.175.170.29]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4893703c0c8sm386684173.48.2024.05.09.07.37.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 May 2024 07:37:06 -0700 (PDT) Message-ID: <946ae22f-a4af-448a-92e1-60afb6ed9261@linuxfoundation.org> Date: Thu, 9 May 2024 08:37:03 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 0/5] Define _GNU_SOURCE for sources using To: Edward Liaw Cc: shuah@kernel.org, Mark Brown , Jaroslav Kysela , Takashi Iwai , Catalin Marinas , Will Deacon , Nhat Pham , Johannes Weiner , Christian Brauner , Eric Biederman , Kees Cook , OGAWA Hirofumi , Thomas Gleixner , Ingo Molnar , Peter Zijlstra , Darren Hart , Davidlohr Bueso , =?UTF-8?Q?Andr=C3=A9_Almeida?= , Jiri Kosina , Benjamin Tissoires , Jason Gunthorpe , Kevin Tian , Andy Lutomirski , Will Drewry , Marc Zyngier , Oliver Upton , James Morse , Suzuki K Poulose , Zenghui Yu , Paolo Bonzini , Sean Christopherson , Anup Patel , Atish Patra , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , David Hildenbrand , =?UTF-8?Q?Micka=C3=ABl_Sala=C3=BCn?= , Paul Moore , James Morris , "Serge E. Hallyn" , Andrew Morton , Seth Forshee , Bongsu Jeon , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Steffen Klassert , Herbert Xu , =?UTF-8?Q?Andreas_F=C3=A4rber?= , Manivannan Sadhasivam , Matthieu Baerts , Mat Martineau , Geliang Tang , Willem de Bruijn , Fenghua Yu , Reinette Chatre , Mathieu Desnoyers , "Paul E. McKenney" , Boqun Feng , Alexandre Belloni , Jarkko Sakkinen , Dave Hansen , Muhammad Usama Anjum , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kernel-team@android.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-input@vger.kernel.org, iommu@lists.linux.dev, kvmarm@lists.linux.dev, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-security-module@vger.kernel.org, linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org, linux-actions@lists.infradead.org, mptcp@lists.linux.dev, linux-rtc@vger.kernel.org, linux-sgx@vger.kernel.org, bpf@vger.kernel.org, Shuah Khan References: <20240507214254.2787305-1-edliaw@google.com> Content-Language: en-US From: Shuah Khan In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: E6D2A18001F X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: mxzaekohcz68j4g67qmzocdqjjig3aq6 X-HE-Tag: 1715265427-863921 X-HE-Meta: U2FsdGVkX1/CW5cjPjF+iDgR35U4bChhxoIDJBIsbmaRBnEkAQhL4YoJX8Puzu/IQCYWL1hLjygOt76POcNptJbze+5cbfsm+Tthh2/rAQeIRx1cHHD7TiELZ4gqouA5GEZDi+j1FdLfTpOa2xpKaLHOnZ5TroDwKakMW45s1c6ScFnjrdD6y2Yl94EQXkVyBmK/brck7dCyG+mBGJj0dUv/j3elOrPb+ptxVwwZy9iAyArdI2xrab/o1rSz/aXbTaqTpuKVpQfcm50R4IIPajK9sI9m7OADq+lE9KN7KgfRm0ngpeWbsBQSEMIoyFiS9lxHKBFI2FPcTv/704TXWatDhy2RkgFoZMDtQRNgqw5ppN/4Z4Al5r1RvyHcYuTaunf45OoVSVfL4b+gZh8qLPPysqrS3+v9NB7tozg3Di5cSeUs5Gd/ef1wwPW5hbT0leJapF0xgkhFhaIS85jZj5VrSTRMQknX0dF9JpJ34VhLparRGIl6WOlw8Lg7kY3SDb6t1Kln0WhaTnXK6txthf1STcnaYjmiJnfGi9SZ+oZ9ZujjpvwqwVD4bpu/0OD+h89qtir14jgnT9uCSmt9vY5Tnx9k3St8WBQsRhvei9knS6Wgloa6+9NlZOipfTpdYcxJGTw2CzkqqQER6MsPDI51xEH50fhoOm3aV2kut3PE17SEgo29/RNJS9wWEi0sBWR2EFSbxG73VXI/s6JBmXer/ugq/9Sxn8Mio6hXlgeBD2UNflCqZh373Xkmu8rtojHO3o64gfbSt3i8Tbc+Jshchk6TY3zl40jT5EY9GSNAw1fcI0MzjdMRFURK6N0mXJ5C8fed6Qo3VoCNbq2kKtTfyVJbxltH90bjBQt9kJupck6GnJ8f23JCQ35agDZus1fhBuQXjgyWkNOCiR2QD057NJXN5yE8R6CWpGECJX7tQoyc5+oa4zE3EsIuF5QwiXUAFAoaFvM3XbgJFFr PAa62Mo5 mySmEzo4GYmh8rq1HkYoEw62H70pDEaCnRztzmcrhXhpEg6A3VnEU+SprRv6BqZwMHsVbdj60Uz3IE4wuEAd7vtItuVAT73ojluLl91UUnzFSS+Yd3VORZYdFFvpgUQQf017j7Ktn23WFd3EQRIBR7wIbR6bJdszf89r8bCoSnNp5fkK42Qu2OIsb0QM9qZp4gY0RVXvs7ufdpNPV6rlb/U0LYOa4+Ft6likhLN8eVjSaL0slXGpwgT2PLUd7fbB3u4Lm0bsgUsOJAgqIF9XH7HADUwwRy5BFEKEGXrIKtykqwW4Z6fcUY5zn1FwZN1XPakM0FPYObCm1fqmSIwELWP7RYVfgxnKiFArtVLySgp6an5GGsBfrQJRZQV/sFfxzBbzki4fSyXO/3HIlC/lKcfyabRRfNSFuP+tSk8hDqekVZTlKAs2b2llz7QlBw4GAHjQhohCmZQDx1iAzOWljJbV2cpNOKV+3YunHDVC9CxMfYidEitrbx2he9dQwYeevrDXZPRpst1eFzcgZ1RSJzZmsFUI54Rw1r3FINTI80GUy6/f685aG/uFtNnBZM75J+EeRhNnCMuWRurPyJefE85ZgGi+fcQJ59AKxF4fxnM58RlBMkPpVeYrrU3KhVThavSqVm++3F2qAXnrwsWMBrKndgEGJjkjG+dQdoGIW6twVJ0lKIEXq4m7lI1uwzgVtas7A X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 5/9/24 00:13, Edward Liaw wrote: > On Wed, May 8, 2024 at 4:10 PM Shuah Khan wrote: >> >> On 5/7/24 15:38, Edward Liaw wrote: >>> 809216233555 ("selftests/harness: remove use of LINE_MAX") introduced >>> asprintf into kselftest_harness.h, which is a GNU extension and needs >>> _GNU_SOURCE to either be defined prior to including headers or with the >>> -D_GNU_SOURCE flag passed to the compiler. >>> >>> v1: https://lore.kernel.org/linux-kselftest/20240430235057.1351993-1-edliaw@google.com/ >>> v2: add -D_GNU_SOURCE to KHDR_INCLUDES so that it is in a single >>> location. Remove #define _GNU_SOURCE from source code to resolve >>> redefinition warnings. >>> >>> Edward Liaw (5): >>> selftests: Compile kselftest headers with -D_GNU_SOURCE >>> selftests/sgx: Include KHDR_INCLUDES in Makefile >> >> I appled patches 1/5 and 2.5 - The rest need to be split up. >> >>> selftests: Include KHDR_INCLUDES in Makefile >>> selftests: Drop define _GNU_SOURCE >>> selftests: Drop duplicate -D_GNU_SOURCE >>> >> >> Please split these patches pwe test directory. Otherwise it will >> cause merge conflicts which can be hard to resolve. > > Hi Shuah, > Sean asked that I rebase the patches on linux-next, and I will need to > remove additional _GNU_SOURCE defines. Should I send an unsplit v3 to > be reviewed, then split it afterwards? I'm concerned that it will be > difficult to review with ~70 patches once split. Please send them split - it will be easier to review and apply. You might as well wait until the merge window is done. I don't think anybody would have time to review now since merge window starts next week. thanks, -- Shuah