From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26FFFC77B7D for ; Mon, 15 May 2023 08:57:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A132B900003; Mon, 15 May 2023 04:57:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9C351900002; Mon, 15 May 2023 04:57:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 88AD6900003; Mon, 15 May 2023 04:57:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 75ECD900002 for ; Mon, 15 May 2023 04:57:18 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 495F54140C for ; Mon, 15 May 2023 08:57:18 +0000 (UTC) X-FDA: 80791885356.22.A13B8D8 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by imf06.hostedemail.com (Postfix) with ESMTP id 4CC31180004 for ; Mon, 15 May 2023 08:57:15 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=qfOwVI1b; spf=pass (imf06.hostedemail.com: domain of qkrwngud825@gmail.com designates 209.85.214.180 as permitted sender) smtp.mailfrom=qkrwngud825@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684141035; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rG1m6/ZUbXcFAUMvzzP6os9D3LqFPw+qOiQ1spcSC0s=; b=hoW+7PkweIja+zhNb8TQ59ZhXuQXpl+fS5gIHc5L13MDafP+EBkRllw5FPnnvzDCAbapb7 XkkyaY8RcxFPULouvEM3229dxAz2nEkQbYnmV8V7muN5eSJPpUrpXqch4rPwsra/0n7LqQ BF1N+C/0SiKVpQSTANsCAYl4721SB5M= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=qfOwVI1b; spf=pass (imf06.hostedemail.com: domain of qkrwngud825@gmail.com designates 209.85.214.180 as permitted sender) smtp.mailfrom=qkrwngud825@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684141035; a=rsa-sha256; cv=none; b=Q09pLk+N1Q9oMJURVy9G7sJB2ab4sxItzFM1vBhbcZ4ktr50kCU0uXmiEmpXbJVj30PPms MOyzFM6Fl+xG69KGaDhB0qSADNyNKFskk6uuao5Jb/RKzS4l/G8ZOb8iDEqJGyqIaORK6A UGgGp4sOSUOyHoJROCpDLNeHjinDMfw= Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-1ab05018381so115200425ad.2 for ; Mon, 15 May 2023 01:57:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684141034; x=1686733034; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=rG1m6/ZUbXcFAUMvzzP6os9D3LqFPw+qOiQ1spcSC0s=; b=qfOwVI1bjES6z8OWoa6aCTHzIcYwMil7bcYQiVp4/zTotErBmf2f5YyD+R0G+HKL9z pjK98sD/k1xhZ2rTLHsmfwsjjpYhe/E8jqBfzMVyzBe4zedvKPn/ypCuZufwupFTdSWH UFJgIiZCfvvcMHZ3zS9X4WdSPXfzDPT2KEj6FJGxNbYolYnFkFzmhlD7ZZSatm+PeKb2 97xUWwrNbi8c3HwwzwKHkJaVMRL0V2ecTlOmbfi/C0XjARstt6ISJPlrIxlOHJv+QLol iC5jYUO+hKOXBRbEr68f/tNC/+H94uRutP0vbK0sK+qpDjgAOPiyJilea7HD+nr/STpc kkOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684141034; x=1686733034; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rG1m6/ZUbXcFAUMvzzP6os9D3LqFPw+qOiQ1spcSC0s=; b=lOHhR1HiNs+rTQn4C8GWzxiaanY3D2HDwLT2Ppzesb9K5FRSJjo3lDHE1lfOunf+az /1q6+TVZNm5oJ+W4v6sOE5TwiR+XVZgPAy5WbpWKpAEDC2U7qIzT6gCKUjvsClwKQSly oba/Io+rAluuzsEmTVlRG0eMhaDPAokgoU5UkRyiRG6rIH0KGT1hGHQhbCAsFB0alY7L QFbQorln3LA+XstbuRZRQsvcmWfCGCCpp6htxlr//OM9OcBUIFjXLdKjhS1BXzIC9gy3 tnKfasSOcq4w/dTM+CzwEdOCZQStL5IhzfO3s+i2Sl+mTjc9XOpSvDvzfaisGiSRl2ZQ hAtg== X-Gm-Message-State: AC+VfDyZZ68EQrWfZHYoOZUR0kD4S3v18X72xkfnG1qqSle5f09QVQ3w NjNqcQuXmRpuN+Ojg+Vemrw= X-Google-Smtp-Source: ACHHUZ7aImgc01WTtJLddcsEZ6YyRvJXxo8TUI4GeVtryV71WHIgEN3syasvE2FR2iNA1o1UY/5JAQ== X-Received: by 2002:a17:903:2292:b0:1a1:bff4:49e9 with SMTP id b18-20020a170903229200b001a1bff449e9mr45885771plh.23.1684141033765; Mon, 15 May 2023 01:57:13 -0700 (PDT) Received: from [10.150.3.61] ([132.226.22.23]) by smtp.gmail.com with ESMTPSA id b11-20020a170902d50b00b001ac84f87b1dsm12994846plg.155.2023.05.15.01.57.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 May 2023 01:57:13 -0700 (PDT) Message-ID: <9460b08a-7740-42bd-8784-d27ea038e87b@gmail.com> Date: Mon, 15 May 2023 17:57:09 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v2] mm/mmap: Regression fix for unmapped_area{_topdown} To: "Liam R. Howlett" , Michael Keyes , Tad , akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, rick.p.edgecombe@intel.com References: <90777046-a420-b19f-1847-d353b9938131@vigovproductions.net> <20230502140828.hilf3myxj6kpiunz@revolver> <20230502140907.o7fznev4jthtgp4i@revolver> Content-Language: en-US From: Juhyung Park In-Reply-To: <20230502140907.o7fznev4jthtgp4i@revolver> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 4CC31180004 X-Stat-Signature: by8cth7ewo8a5p1agu5wbdxy4pxu8781 X-HE-Tag: 1684141035-34655 X-HE-Meta: U2FsdGVkX1/agtZorQ/MnLXBQfVX57fyUBMtJnFtmn4Nx8wwJVD2HiHmqYiONjFYyZwAIxpxNd0Ik6m3HN3PsUeMQqZFsnoSNTfkhKtJNiOa+djqAqM9wXZrBBmX4tq2TnBzRXrHe/yj0csn5pDp/25EXdIP5HSdf/vccVlLgmWlwvQECiFBtBNhki49MImusKhIeVOxrXo16dzgZpj1xcGdM+U0QWYHKsw/afF3B894qZK2dq8F4bvJDod8RuElOzmfZ8vXY38P4qvc/CzT/5jS/2rnjAqReu+CuN/YMAg0A9nIgionAVO9xveRuBQR2u8rYyhviZnGiIIPTZDT6ej82TWsCsbgUkiNYPQBrtPhXkCvEnvmA9fwURQJ+ZE/l+ljViK1lBqsU5oFj63s0JsYQQ0dE2THOrCoqzYT4Z5IkkQBSGYJjc6kgfPNzOgB2JcXcWzR71MsClF0yMvJULeIIXtBOebqz/9+ezP9VciSKZDHNttJOiG7/QZQprnkBe6Avx/G9d2fB+TCN+FuWXXFGdgsp0F45f2b0uK6e1aJZfYfznJPDe0EMp5Jlj1YngA3jtn8LBrzA880U0YhmJqaQTjG179mli3+22NQ6hUzgzi85EI45i9qmTxchFcNHfeFUEhcLNTAmdW3EQMFdKEXaqkUw7uEKjGAQN8zcaNXuUSJNzDrVvrh/7Tyxbmv6nBrFjT43bJF5gHhc7HQ4rrGvK339iBW2XqqUJ++xv3QzTiNf0KSZJaoEqBI6N9Gn7oXPspZw8cq/v+ETP6mBcayQdOIfiNrQC/2jp6exjxUha1EdJ7MS+bzZIhDUeA3ngAJcO/NCHFhIUCa2lFETnNVg4KppL8J6gvDYrGmT9ThUnI7wAMTIkMTEmhNLIVgAH6xlvt7ZlyLDnQXd+sOlneJh97xwmhFgkbelBij5iRfFm5K5PWzfz5WPs5AV4M6ed6dY2tCAZY9YJcRNrl JvSarfqb vRP7Q0OAi/RzOHnuajPl0NXh8Wmuju0cEyT2mjsPlRQexQKf2Z/DR2WAH+1cAxhoaVmZR9lJA9hVSOorMKYUvNP1TtkI3hi5oScxGFFwIJqIP8RdahLCLeOBkAPtrcqUxFcF0Bes9I2y+RtjXvGE1XWDhaTQGm5txL64hHJoY1gWb1fKTBKKiTvjRtQtO3wSAdlLFZJpJoNgm9V2zPefM+yZK65XR+u8Qs6hh5aKu9AqCtNo/MxqxLZUPARHUt9SU0vgJiE1TD4xdc0ODCKvNhH8L7S8tfwNSQEbVsZNX52yA8Vo7l7DpYU49kJfE6sXuN8dQnEJn3wPQaHHmyIX6i0+ULBffbS71yxskd+hPnye+IEFgz5F/6eRLJjpfODvBDS5YhjCmRGWgmHPjwWfAQ5hNTYd7ycAc4K5+N5xuY07CkGS9XT5dEX0kKsOXpNd6vSNM6bedCYirhgC81kJW79ukuJ9c1CgDNAQi82ADWLcpN6FGrgj4qc7BGaxO46pLbV1v8jEaKeHeRf8jPGaPO/9r53vdmdEkVnjkRYn2zfuAo9yLhmLxkF83sJqwfUk7sYvDqzgbnxdMzO1bR77hDryZLFPWzfwKPYHalxt7ya3/5Ps4M3hrq9KkFOrSLaf5wzEIl9dhIFqJuyoqFA41Dl4TauEflGdpGBpuZxG2jjJpeTLeBdHIdX0oPlkugDDy+TUA X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Liam, It's a bit hard to follow this particular issue on v6.1 as there are many email threads related to this. I just wanted to ask if whether this is fixed on mainline and v6.1 stable yet. If there's a new thread tackling this issue, I'd appreciate it if you can link it here. Thanks, regards On 5/2/23 23:09, Liam R. Howlett wrote: > ...Adding Rick to the Cc this time. > > * Liam R. Howlett [230502 10:08]: >> * Michael Keyes [230430 18:41]: >>> On 29.04.23 15:32, Tad wrote: >>>> This reintroduces the issue described in >>>> https://lore.kernel.org/linux-mm/cb8dc31a-fef2-1d09-f133-e9f7b9f9e77a@sony.com/ >>> Yes, I also ran into this (even though I'd somehow missed it the >>> previous time). >> >> Rick Edgecombe reported something similar [1]. >> >> This is probably to do with my stack guard checks I recently added. >> >>> >>> Apparently the issue arises at mm/mmap.c:1582, where low_limit is set to >>> vm_end_gap(tmp). Occasionally, this returns a 64-bit address (e.g. >>> 0x7fedea581000), which is obviously greater than high_limit for a 32-bit >>> mmap, and causes the next call to mas_empty_area() to fail. >>> >>> I'm not sure why vm_end_gap(tmp) occasionally returns a 64-bit address, >>> or if the best solution is to just check for this and skip the retry if >>> it occurs… >>> >> >> Thanks for the debugging. I will look into it. >> >> I am currently trying to revise how the iterators, prev/next deal with >> shifting outside the requested limits. I suspect it's something to do >> with hitting the limit and what someone would assume the next operation >> means. >> >> [1] https://lore.kernel.org/linux-mm/32f156ba80010fd97dbaf0a0cdfc84366608624d.camel@intel.com/ > >