From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1D89C7618D for ; Thu, 6 Apr 2023 05:20:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 14CBD6B0071; Thu, 6 Apr 2023 01:20:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0FC6D6B0074; Thu, 6 Apr 2023 01:20:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F2E446B0075; Thu, 6 Apr 2023 01:20:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id E51CE6B0071 for ; Thu, 6 Apr 2023 01:20:31 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id AFF581604D8 for ; Thu, 6 Apr 2023 05:20:31 +0000 (UTC) X-FDA: 80649815862.05.CB4A99E Received: from mail-oa1-f41.google.com (mail-oa1-f41.google.com [209.85.160.41]) by imf17.hostedemail.com (Postfix) with ESMTP id E781D4000B for ; Thu, 6 Apr 2023 05:20:29 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=HzBo9Bui; spf=pass (imf17.hostedemail.com: domain of groeck7@gmail.com designates 209.85.160.41 as permitted sender) smtp.mailfrom=groeck7@gmail.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680758430; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=lTQen24Ps++j6vXq82pkSJOfvZNDwo+mL4QS7eMljms=; b=gIB18G8fw9OlC88USZ/VhYg6MfFk4lxksUAg3w4grPAGBoFqWdDcVkTs6Okd32hwz0sDE/ arXQXey2bocV3SZato1Id/S1NCM++3lGra89jJnZgFI+3A5ZVBxgUl3c0YWgpO+jgWJiqb CMwVu58bRoGlPyLAwe1+knkVI3thifI= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=HzBo9Bui; spf=pass (imf17.hostedemail.com: domain of groeck7@gmail.com designates 209.85.160.41 as permitted sender) smtp.mailfrom=groeck7@gmail.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680758430; a=rsa-sha256; cv=none; b=RtunfnUiCacDax35a6TMcY9uJ/cbITa0iwVIEC8ekSbeNZq5cu83OIC5lTrd3WxIm6bL1Y AVH9kLBhh9+HC0UAlX9pc8wAOQw2HwgDm7k1lDn6YRa8udh6DN/u8I9oiDwV/PEfyHS7r0 kj5i1hX9qler9U4ibJRHRsUlKYX+DG8= Received: by mail-oa1-f41.google.com with SMTP id 586e51a60fabf-17ebba88c60so41110894fac.3 for ; Wed, 05 Apr 2023 22:20:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680758429; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :sender:from:to:cc:subject:date:message-id:reply-to; bh=lTQen24Ps++j6vXq82pkSJOfvZNDwo+mL4QS7eMljms=; b=HzBo9BuiVK+ieq4hAereyA6CLygTsynpDqwzI7aS46PfM0znN+VFQbdkLMhaGOapi7 V9Ix9g9UKKzS0+eJnQc2MWb55fRRuN9AjB/rWvza20Xpwq+y924YbjvIGx6QzG5uGiEW JMZXwW0EZVSdlN1170YYJmB3OD7jnSnmA8F8avP8eaB7GI6Eh/L3Xh4ySzrOA18zt6Uj fElxFu4eEghxFn2lSbpgjMy1KXuEgdPQ17HmJkiKqGeOhJrTfYT+Gf/wjvkygerHH5Iy TUBvxPDx4RG7B8ApWr/Mbo5nDa9jUopcXIY4ffiChfJgYHBWgVh8MM+ofRE2T6QV//dN mEBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680758429; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=lTQen24Ps++j6vXq82pkSJOfvZNDwo+mL4QS7eMljms=; b=R41w4QwQ/KQ51TMGY6TPI5/F4tvLflpaYuYM1CQWzibm0fXvve3BAbHo4DmTeajNBE P3cAZoKTDwQbHLOpS4QlmJXSVynf5V7kYdsby/q9EyZAI+uFJXZbKgrv9o+4uXlp039D X+9CVIjYpbF4OI4oOH2mwUos+6XVkcfasBkEb2beSoTdopgl7uWMygImroMDtn/2W9Bi 9v29tKYPmQsF7lfbTkE5VCGfsIWd09aKwDNB7fd1ZMpEcxn5ET3an6MvWM93/7gwFj/R x65hrGT7QcP9IQYyeosSGvVj/DEsZHCytlZfRpt+Wazj5QG7gcUdwLDlEPr7r0jWQUKf oJ0Q== X-Gm-Message-State: AAQBX9cbynakgjZ9qASG5EM3mN49iss2P8rw7MzTXIHUtlXoezCSmfgY /60H2ldFx4cP4zvMFIwZw48= X-Google-Smtp-Source: AKy350ZMcSUgfjJW4sJA7K3zD8hRQ75jOEF9SU+ptU0yJ3k5GPg3yHCF5YmeEC24kg9GBBqzkEFO0A== X-Received: by 2002:a05:6870:d356:b0:177:a92e:ee6 with SMTP id h22-20020a056870d35600b00177a92e0ee6mr4525131oag.54.1680758429001; Wed, 05 Apr 2023 22:20:29 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id y1-20020a056870458100b001777244e3f9sm341041oao.8.2023.04.05.22.20.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Apr 2023 22:20:28 -0700 (PDT) Date: Wed, 5 Apr 2023 22:20:26 -0700 From: Guenter Roeck To: "Kirill A. Shutemov" Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm-treewide-redefine-max_order-sanely-fix.txt Message-ID: <9460377a-38aa-4f39-ad57-fb73725f92db@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: E781D4000B X-Stat-Signature: tyw3m76bzawxjdmtq9wnpu9uwxoxppzj X-Rspam-User: X-HE-Tag: 1680758429-837465 X-HE-Meta: U2FsdGVkX19FJld6wxabx9vcTo61itSE/HfjK/hrEdqjl8hQIl0EOwYJytz6ROuTAJ6JVcBh2rNFNvBl+pJtEPg++VAP3V6NFGBpG+reXSmHhyYWAmfVlpj+RYRRKNhR12hp2GRoZxjnkXfLIrJrdRxGQtC1RtufH1MBtonMmUUE0sCsjr0l4gJjfsZB7WpWj2XMdsm1MgT9A5qnSJ6yzbxTgNZnKuqg/BmKcpIzKwgVSn/NeTxcYFSAnW4Uy80v7EN+9UjXqzc4CfWt32QrAPfozDdb0MROco4nAQaDsCz+68lbN0sv4lJA0rF96BZb/fsrA8kw67MaMNA+BoMFIYlPh/4vQbZKgKsI2wsYQv1AeHSlN8ofYkiy70mx7tlmYNH5HU7zAyqE9kSVxeUArMXaSpf3spilJjgk5oa6hKOL5/5HWDV+1Px1bxYPWC0fkQRfl9NVYENsAJCtWon2IIoDcMvCpAlXYRl0VAfkaURTgwhtQ3+hYDDieVrCGGHzYm5Pg8AX6tq6f6WEhNdWP48g4Ui1T1wb7typfYAwNgdUpLltQICOjX8Cq9tTMCs2DIVUX/EUGpYmvIhw6VaCwQvn56gHpYJwnumqAJ9sSc7BI0gMhy8Nrne+shTo8G2/0Wj1RRox+6dfZ67TcrUS/bqSEo/GJ0+c6tjGJd+ScHaFJr0ztO+FLCLQEbzmV3+EVrWzlbrFpxi/fyjLMZsheQDQqhzw7JpDwLkBv/ulDJYWsuHBO/aYq+i31ljTVXn46e+C7defNkz7+9bjYlkPAg4NMjkMyx/2RNlHnJHCpybG04/4vHt9dFiZsSP6oFJ2l7dqIQi5Hybq+Q5y3RSCFnYodIeRBBGLXb3qXyAQ2/do7Pqh6e9cCjSfIQNC2hjFZRJzsG9bFV7El37CinsFs59RWlDztx/DEyZKBbpundsd0u/GtXVTXuPUwxhNI6Nkg9GrxeuVcoEYx8s8LNf vVUhDjpp +WTCFhIsioRqdbku2WTJVEeGJ2rhEVd0WQVdChVfA/jtTNRXU/BX+SXkyxnc+Z6AQ3HGEN7i+FQOHzB6AhpejM8n+TcdybszouwQeFGZdwQkMIifmkLHFEgw1ynpL39g8S8Y4FXEexZPb4BU17hCHchreLqZ7jZO8sPaHh6YyBwcf1EKz1yYjsIRx/BwExhPOLxUz9KWQoWBohJw8bWtEAt4e2IIKWfKEB9DNUaEQqf89e6zu4kbSGFItp4PrdqPvknryqMQqlU8xKpVMxbrmyoCiDUVIEJJgbZBaeSddm5r2P1zWkZpjGyWQmerWiSYdS1k0YNoYgN38p52JrgBCyDVm88w/5kKLaw12TNgwN0JNwfN97Pxy3ivg3oTP5JB5v78wM5SqJ5xRiURnypOzCiXxLnjtyWONcqro1t19JRgQ4oBUImXC3MYasggxobtzWFQpqGQSTge26s1RxgTjbZJ1fs8M2CW5C3rVAUF2eLeek2o8UDNee071JEXDQ8qB8OJZdGnvwtfoWwaCRzStKioMrSfVN5Ehq3qmpu95zNpag7mb35RTQ+cgXSM9mVis4ABXKzdKmpFK8s6MqzHil8Z/OtURGqIUOwPdXr3xUQ7dnSHBhljtnS688ZeYrQ1/dfeiiY1f/SI0mHTRt7hSBtFx0zveVzVCjX838lPrUpdBHmJSJ5zcocBQsv84SgaDg6kqOYVXv1UCGss2v3RyjHtqJBoefjnaiu1R X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi, On Wed, Mar 15, 2023 at 06:38:00PM +0300, Kirill A. Shutemov wrote: > fix min() warning > > Link: https://lkml.kernel.org/r/20230315153800.32wib3n5rickolvh@box > Reported-by: kernel test robot > Link: https://lore.kernel.org/oe-kbuild-all/202303152343.D93IbJmn-lkp@intel.com/ > Signed-off-by: "Kirill A. Shutemov" > Cc: "Kirill A. Shutemov" > Cc: Zi Yan > Signed-off-by: Andrew Morton This patch results in various boot failures (hang) on arm targets in linux-next. Debug messages reveal the reason. ########### MAX_ORDER=10 start=0 __ffs(start)=-1 min()=10 min_t=-1 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ If start==0, __ffs(start) returns 0xfffffff or (as int) -1, which min_t() interprets as such, while min() apparently uses the returned unsigned long value. Obviously a negative order isn't received well by the rest of the code. Guenter > --- > mm/memblock.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/memblock.c b/mm/memblock.c > index 338b8cb0793e..7911224b1ed3 100644 > --- a/mm/memblock.c > +++ b/mm/memblock.c > @@ -2043,7 +2043,7 @@ static void __init __free_pages_memory(unsigned long start, unsigned long end) > int order; > > while (start < end) { > - order = min(MAX_ORDER, __ffs(start)); > + order = min_t(int, MAX_ORDER, __ffs(start)); > > while (start + (1UL << order) > end) > order--; > -- > 2.39.2