From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 980ADC3DA6E for ; Wed, 3 Jan 2024 11:16:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 271726B034E; Wed, 3 Jan 2024 06:16:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1F92A6B0350; Wed, 3 Jan 2024 06:16:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 04B806B0351; Wed, 3 Jan 2024 06:16:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id DD7D26B034E for ; Wed, 3 Jan 2024 06:16:27 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 8C693C0682 for ; Wed, 3 Jan 2024 11:16:27 +0000 (UTC) X-FDA: 81637746414.04.492565D Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) by imf27.hostedemail.com (Postfix) with ESMTP id BF7E54000E for ; Wed, 3 Jan 2024 11:16:25 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=kbwWiowO; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf27.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.208.51 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704280585; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:dkim-signature; bh=BrSPjHgdnH+nXilbqn4FMcNgLITuz+LIFPl1XscWIj4=; b=cRoV8W8TVBqE2DYCp3hqDOgnOCV6IIfREGWU3crsqgr7pekEAdn4K6qX8qphpxAppCaSuV WHGLyuD5ShxEEZjuStiL86UpWrxmSJOel5/Bnod9dpN4U8o36oGcyeVqDTGVv1OCiOnY/h jNNDDV/ksDm0O1yyb8klnk4scyaItBg= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=kbwWiowO; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf27.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.208.51 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704280585; a=rsa-sha256; cv=none; b=vZDqWvJYjI4lijils2UYgZ8mVJ2rkqhqzAy2UwSVCCC0mySkQjOBLvMk3LeKNZftuw0mPY ZQrpgVUQF2ow4lB4+2Owf+GZFY33nGIQFJ5pDZdfdnUtqJYmLBQMcPXyiJdFVv9NabxYGI y0upzQC1IqNf4BYuRVCLulUnqQkOwI8= Received: by mail-ed1-f51.google.com with SMTP id 4fb4d7f45d1cf-555e07761acso3876024a12.0 for ; Wed, 03 Jan 2024 03:16:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1704280584; x=1704885384; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=BrSPjHgdnH+nXilbqn4FMcNgLITuz+LIFPl1XscWIj4=; b=kbwWiowO+fKZ6eraWCWhlhAzwsY4wXtNEa8CF64AKlJDYN6dAyEi4BcxrmPIHcwQ0g IJZb7ymfnyPj8N2XA4Gz9R4xIaXUpEa5PjdBOxBXFY6PRPFHFWSYJJyAY3rAYBdEe0Lw 6XCO4BKUXZNOWQNHLrIhEcYanxr5oCFBxTGsdo0/wU2EP8GPdwvvH21kIDV5NtEz+lxH iyqX6ZRSm2Z8hjIykDpTEEZ21eX2Vz2CI5rO0gVrzlocNJ+lIq8lCzFKi1B5HJjCF5sg FP1UePh4j2ECVb3UEFJjAi8ibR/7+LBYCI670goL2yAOLS4+4bczdjkpK32x4DGa0wjk Ti9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704280584; x=1704885384; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=BrSPjHgdnH+nXilbqn4FMcNgLITuz+LIFPl1XscWIj4=; b=KnEltb9pB7JQL5EfNWZ9IFC07um1ve2PQ/DEOorYOzrhP7iOMAgYPgczJwnuyY+q8U ay8S88cLzpSZhY+WkbKptAZcLGQmu5oNjmGA+h2ZCDej5drjkaxIF81UKuIvVYZjdmG2 Z/RWD8VcwIaOybSn6E7vuICD3U6c13GUZmqIKcsqRj6Fu5NQJT+2uBEIU7VCDwLWjYfM 51t1zKr6wOCRdIS7RZS6+jdQK9OizFfIdZAq2ksjN6Ae2FXZpn+pQjaeQgqD1Kwa5xn4 MWPmqjaaBF49Zk4vYVy3e7UbfVO1ajrA7HWzDGOyzPJXHOTnq9KgDuFKQM5Sl5J5Mo9W lH/Q== X-Gm-Message-State: AOJu0YyLk/Bt/HZN8MTLENHvpjMESAU77lTnDGbQKx/J/mz8GxLIRwMS T7HtV0hXbovMNUm5aH+Wf2Xab0Ju8bAXRg== X-Google-Smtp-Source: AGHT+IFBs8+CfUnkn5KZED57Ux5CruC7jlDlvcBky02qrjRW+1r7HJfy+cjUpFsYHGo5VhV+D6rBwQ== X-Received: by 2002:a17:906:3858:b0:a27:9e2d:a453 with SMTP id w24-20020a170906385800b00a279e2da453mr2449018ejc.108.1704280583894; Wed, 03 Jan 2024 03:16:23 -0800 (PST) Received: from localhost ([102.140.209.237]) by smtp.gmail.com with ESMTPSA id fi8-20020a1709073ac800b00a272de16f52sm7268505ejc.112.2024.01.03.03.16.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jan 2024 03:16:23 -0800 (PST) Date: Wed, 3 Jan 2024 14:16:20 +0300 From: Dan Carpenter To: oe-kbuild@lists.linux.dev, Gregory Price , linux-mm@kvack.org Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, x86@kernel.org, akpm@linux-foundation.org, arnd@arndb.de, tglx@linutronix.de, luto@kernel.org, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, mhocko@kernel.org, tj@kernel.org, ying.huang@intel.com, gregory.price@memverge.com, corbet@lwn.net, rakie.kim@sk.com, hyeongtak.ji@sk.com, honggyu.kim@sk.com, vtavarespetr@micron.com, peterz@infradead.org, jgroves@micron.com, ravis.opensrc@micron.com, sthanneeru@micron.com, emirakhur@micron.com, Hasan.Maruf@amd.com, seungjun.ha@samsung.com Subject: Re: [PATCH v4 11/11] mm/mempolicy: extend set_mempolicy2 and mbind2 to support weighted interleave Message-ID: <94405fba-8539-425b-b21a-3016cdd7be91@moroto.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231218194631.21667-12-gregory.price@memverge.com> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: BF7E54000E X-Stat-Signature: axb51pzdw9on49rfbf8tf8fkny11ns95 X-Rspam-User: X-HE-Tag: 1704280585-402339 X-HE-Meta: U2FsdGVkX19HFRYytF1ABNcOr/ez7EXmUwB9BfVUdLCx+9yqWvMRMEvSfOpBOlemQPKH5eKaF0N8EY/bgQZxL6IScT3WrtSq4cf/cKjIPdHT4G00P45NDaRXr/8VPfXdnw0Y2vMPYwjJCC34xqnbNDNJXhXNdlKEGoghFtt9VwRpDRGe9n8HZP8Q5Q09Deu5bTsCRLOlWgbcrCq4hWHnC1X5ZC97NpstC49XZ8kg11BtJV1lGlZDw77qn2LLv0rrGPfYxlbGn1FxmSM2bgfabPxmiiM9LirdvJLHC1yMbrr0sjyweoxQhw1pzaKzdWN+CJ5OnGHYTmNpdp+GoLeJBQGiCAf7dk7SSPoT0XA6w7+eaC37safnJyLkudlVPH2sX0hj6T5y1Q3IFVjCG5fZTVq/gcFKXwZ12Ax3xfKlSW6VF6KHvo/WC8/3goGWzU4mmaavG7F6e+6PDXTF0rEYJSQUqFgmZOzSap2kv4EzDj1O416GjGzcSz7qImnrM9vIwqJhQAcJrupzI3o71U5uuCu873W+Yxo1nZQ1YpzaxiOrOWmWHCzVGIa1yOYRKWeY4OFMkLTCW7k6lvXxddAZ3V5EtLTyKYIRvh+AWAV1I9JN4pGMYKc1xGIDtSx+c8j84pwXwNdlJBr2bHX6K61kHq9xQx5s+CBMpWchIGv3oVYhkdzMbJdY1G2oepDQcHKIju9sHLUbgLLo/GJvBuasA5UKZKtJMByghnYHSFo7qO9Av9CTOnMFTiwW/xTElfDHYys/3+KAYZpcIwHx0HxvPFXPrzvIqJ3i88VtaZiOhJ1bqCWErpvlLqn52BiqG1wHQvuEQ+a2KYy/zBdZZMvfEuE7j2DHQ3Rtg87kQEqPKwtc6vkGgXm4r1TFjZDlGxqLShoUlQM/hCggf9ODr1wrhnXcD7kYWJeCvNSiX6KJA9hvpDB50oVOnCXKvHWFqs7WyHDtWR6k+eOmVWeOlFf 4kXW8Rp7 XfDBDT3uGhwoIz6U8cd9xXSbBdksrdNi+Cpf4g9T2LKQZV7hFogOoAwRj5wWfFhkweH5E3O8i/q1t0E+baUXpjF/0LmeBViyOGIMBIts3WJCHbzeAVjvPxDqd6SAnPx0VN1F5gGx+8x15kalX3r3XUgWRndD7egPS0vYT/IXkTjuI/WWOikasAJvI3FSadGTmtO0oKe4euIO2bs+xgedRtG10o3oHWRiXVe2N+G9hMySIIVBMJcnpJW1DS94oUwdcQJn5E/kXkcglBdslPUNa3nhXFmqOiC6cYgIu0uo6opiy1NY2E6T1JGrtjL8qtePmeQjSip5zDA0kX5ex/iupQXKsjwOjfxVSpOD7Wbd/SGsXpq7VqokNiLFZz0CM9XrQWiMAfKzFvAESNRqMHMnZRISTzCxBoZymoNwh0ZZu8q8wyBJeZnGfQm/2ushsw7UEEthW86urBOeRIfR95zfZNOFD1xtutC3P+/bNEQIUOC+GQLMNzU0+t6YlQGz3YyOGP9eaXtKyCxDflK2qIwZTSbSi8JStYFd/6av4Lxs8UZf9h9EHGGijgjje8kL8fOWZtwhn5+wQ9dcHxSi+r/L9hIut8gsZMW2s+89XQjV82zwcqByK5Slj0KQKcNEmfONLH0dzZW7R2Xk14f2DGul8/RW9BjpI/VZympA2dFx+yiaUYLO8AM5qZKMlLGLpLJFXByYFVACWtBDU5YWSS9P9nJbPl+KOsxaxra6dggQKDbkrbRNGK7aZJwwCiu9bU12ydxST/ANmKDFgA4M= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Gregory, kernel test robot noticed the following build warnings: https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Gregory-Price/mm-mempolicy-implement-the-sysfs-based-weighted_interleave-interface/20231219-074837 base: https://git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools.git perf-tools patch link: https://lore.kernel.org/r/20231218194631.21667-12-gregory.price%40memverge.com patch subject: [PATCH v4 11/11] mm/mempolicy: extend set_mempolicy2 and mbind2 to support weighted interleave config: x86_64-randconfig-161-20231219 (https://download.01.org/0day-ci/archive/20231220/202312200223.7X9rUFgu-lkp@intel.com/config) compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202312200223.7X9rUFgu-lkp@intel.com/ smatch warnings: mm/mempolicy.c:2044 __do_sys_get_mempolicy2() warn: maybe return -EFAULT instead of the bytes remaining? mm/mempolicy.c:2044 __do_sys_get_mempolicy2() warn: maybe return -EFAULT instead of the bytes remaining? vim +2044 mm/mempolicy.c a2af87404eb73e Gregory Price 2023-12-18 1992 SYSCALL_DEFINE4(get_mempolicy2, struct mpol_args __user *, uargs, size_t, usize, a2af87404eb73e Gregory Price 2023-12-18 1993 unsigned long, addr, unsigned long, flags) a2af87404eb73e Gregory Price 2023-12-18 1994 { a2af87404eb73e Gregory Price 2023-12-18 1995 struct mpol_args kargs; a2af87404eb73e Gregory Price 2023-12-18 1996 struct mempolicy_args margs; a2af87404eb73e Gregory Price 2023-12-18 1997 int err; a2af87404eb73e Gregory Price 2023-12-18 1998 nodemask_t policy_nodemask; a2af87404eb73e Gregory Price 2023-12-18 1999 unsigned long __user *nodes_ptr; 8bfd7ddc0dd439 Gregory Price 2023-12-18 2000 unsigned char __user *weights_ptr; 8bfd7ddc0dd439 Gregory Price 2023-12-18 2001 unsigned char weights[MAX_NUMNODES]; a2af87404eb73e Gregory Price 2023-12-18 2002 a2af87404eb73e Gregory Price 2023-12-18 2003 if (flags & ~(MPOL_F_ADDR)) a2af87404eb73e Gregory Price 2023-12-18 2004 return -EINVAL; a2af87404eb73e Gregory Price 2023-12-18 2005 a2af87404eb73e Gregory Price 2023-12-18 2006 /* initialize any memory liable to be copied to userland */ a2af87404eb73e Gregory Price 2023-12-18 2007 memset(&margs, 0, sizeof(margs)); 8bfd7ddc0dd439 Gregory Price 2023-12-18 2008 memset(weights, 0, sizeof(weights)); a2af87404eb73e Gregory Price 2023-12-18 2009 a2af87404eb73e Gregory Price 2023-12-18 2010 err = copy_struct_from_user(&kargs, sizeof(kargs), uargs, usize); a2af87404eb73e Gregory Price 2023-12-18 2011 if (err) a2af87404eb73e Gregory Price 2023-12-18 2012 return -EINVAL; a2af87404eb73e Gregory Price 2023-12-18 2013 8bfd7ddc0dd439 Gregory Price 2023-12-18 2014 if (kargs.il_weights) 8bfd7ddc0dd439 Gregory Price 2023-12-18 2015 margs.il_weights = weights; 8bfd7ddc0dd439 Gregory Price 2023-12-18 2016 else 8bfd7ddc0dd439 Gregory Price 2023-12-18 2017 margs.il_weights = NULL; 8bfd7ddc0dd439 Gregory Price 2023-12-18 2018 a2af87404eb73e Gregory Price 2023-12-18 2019 margs.policy_nodes = kargs.pol_nodes ? &policy_nodemask : NULL; a2af87404eb73e Gregory Price 2023-12-18 2020 if (flags & MPOL_F_ADDR) a2af87404eb73e Gregory Price 2023-12-18 2021 err = do_get_vma_mempolicy(untagged_addr(addr), NULL, &margs); a2af87404eb73e Gregory Price 2023-12-18 2022 else a2af87404eb73e Gregory Price 2023-12-18 2023 err = do_get_task_mempolicy(&margs); a2af87404eb73e Gregory Price 2023-12-18 2024 a2af87404eb73e Gregory Price 2023-12-18 2025 if (err) a2af87404eb73e Gregory Price 2023-12-18 2026 return err; a2af87404eb73e Gregory Price 2023-12-18 2027 a2af87404eb73e Gregory Price 2023-12-18 2028 kargs.mode = margs.mode; a2af87404eb73e Gregory Price 2023-12-18 2029 kargs.mode_flags = margs.mode_flags; a2af87404eb73e Gregory Price 2023-12-18 2030 kargs.policy_node = margs.policy_node; a2af87404eb73e Gregory Price 2023-12-18 2031 kargs.home_node = margs.home_node; a2af87404eb73e Gregory Price 2023-12-18 2032 if (kargs.pol_nodes) { a2af87404eb73e Gregory Price 2023-12-18 2033 nodes_ptr = u64_to_user_ptr(kargs.pol_nodes); a2af87404eb73e Gregory Price 2023-12-18 2034 err = copy_nodes_to_user(nodes_ptr, kargs.pol_maxnodes, a2af87404eb73e Gregory Price 2023-12-18 2035 margs.policy_nodes); a2af87404eb73e Gregory Price 2023-12-18 2036 if (err) a2af87404eb73e Gregory Price 2023-12-18 2037 return err; This looks wrong as well. a2af87404eb73e Gregory Price 2023-12-18 2038 } a2af87404eb73e Gregory Price 2023-12-18 2039 8bfd7ddc0dd439 Gregory Price 2023-12-18 2040 if (kargs.mode == MPOL_WEIGHTED_INTERLEAVE && kargs.il_weights) { 8bfd7ddc0dd439 Gregory Price 2023-12-18 2041 weights_ptr = u64_to_user_ptr(kargs.il_weights); 8bfd7ddc0dd439 Gregory Price 2023-12-18 2042 err = copy_to_user(weights_ptr, weights, kargs.pol_maxnodes); 8bfd7ddc0dd439 Gregory Price 2023-12-18 2043 if (err) 8bfd7ddc0dd439 Gregory Price 2023-12-18 @2044 return err; This should return -EFAULT same as the copy_to_user() on the next line. 8bfd7ddc0dd439 Gregory Price 2023-12-18 2045 } 8bfd7ddc0dd439 Gregory Price 2023-12-18 2046 a2af87404eb73e Gregory Price 2023-12-18 2047 return copy_to_user(uargs, &kargs, usize) ? -EFAULT : 0; a2af87404eb73e Gregory Price 2023-12-18 2048 } -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki