From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by kanga.kvack.org (Postfix) with ESMTP id 7C8296B1B34 for ; Mon, 19 Nov 2018 11:06:32 -0500 (EST) Received: by mail-qk1-f199.google.com with SMTP id v74so48106614qkb.21 for ; Mon, 19 Nov 2018 08:06:32 -0800 (PST) Received: from mx1.redhat.com (mx1.redhat.com. [209.132.183.28]) by mx.google.com with ESMTPS id r72si59226qka.123.2018.11.19.08.06.31 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 19 Nov 2018 08:06:31 -0800 (PST) Subject: Re: [PATCH v1 2/8] mm: convert PG_balloon to PG_offline References: <20181119101616.8901-1-david@redhat.com> <20181119101616.8901-3-david@redhat.com> From: David Hildenbrand Message-ID: <94387ebe-9fb3-9471-9fb3-b66abf899a3f@redhat.com> Date: Mon, 19 Nov 2018 17:06:12 +0100 MIME-Version: 1.0 In-Reply-To: <20181119101616.8901-3-david@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, devel@linuxdriverproject.org, linux-fsdevel@vger.kernel.org, linux-pm@vger.kernel.org, xen-devel@lists.xenproject.org, kexec-ml , pv-drivers@vmware.com, Jonathan Corbet , Alexey Dobriyan , Mike Rapoport , Andrew Morton , Christian Hansen , Vlastimil Babka , "Kirill A. Shutemov" , Stephen Rothwell , Matthew Wilcox , "Michael S. Tsirkin" , Michal Hocko , Pavel Tatashin , Alexander Duyck , Naoya Horiguchi , Miles Chen , David Rientjes , Konstantin Khlebnikov , Kazuhito Hagio > > diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h > index 50ce1bddaf56..f91da3d0a67e 100644 > --- a/include/linux/page-flags.h > +++ b/include/linux/page-flags.h > @@ -670,7 +670,7 @@ PAGEFLAG_FALSE(DoubleMap) > #define PAGE_TYPE_BASE 0xf0000000 > /* Reserve 0x0000007f to catch underflows of page_mapcount */ > #define PG_buddy 0x00000080 > -#define PG_balloon 0x00000100 > +#define PG_offline 0x00000100 > #define PG_kmemcg 0x00000200 > #define PG_table 0x00000400 > > @@ -700,10 +700,13 @@ static __always_inline void __ClearPage##uname(struct page *page) \ > PAGE_TYPE_OPS(Buddy, buddy) > > /* > - * PageBalloon() is true for pages that are on the balloon page list > - * (see mm/balloon_compaction.c). > + * PageOffline() indicates that the pages is logically offline although the s/pages/page/ :) -- Thanks, David / dhildenb