linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon@kernel.org>
To: Marek Szyprowski <m.szyprowski@samsung.com>,
	Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
	Keith Busch <kbusch@kernel.org>
Cc: "Leon Romanovsky" <leonro@nvidia.com>, "Jake Edge" <jake@lwn.net>,
	"Jonathan Corbet" <corbet@lwn.net>,
	"Jason Gunthorpe" <jgg@ziepe.ca>,
	"Zhu Yanjun" <zyjzyj2000@gmail.com>,
	"Robin Murphy" <robin.murphy@arm.com>,
	"Joerg Roedel" <joro@8bytes.org>, "Will Deacon" <will@kernel.org>,
	"Sagi Grimberg" <sagi@grimberg.me>,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	"Logan Gunthorpe" <logang@deltatee.com>,
	"Yishai Hadas" <yishaih@nvidia.com>,
	"Shameer Kolothum" <shameerali.kolothum.thodi@huawei.com>,
	"Kevin Tian" <kevin.tian@intel.com>,
	"Alex Williamson" <alex.williamson@redhat.com>,
	"Jérôme Glisse" <jglisse@redhat.com>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-block@vger.kernel.org, linux-rdma@vger.kernel.org,
	iommu@lists.linux.dev, linux-nvme@lists.infradead.org,
	linux-pci@vger.kernel.org, kvm@vger.kernel.org,
	linux-mm@kvack.org, "Niklas Schnelle" <schnelle@linux.ibm.com>,
	"Chuck Lever" <chuck.lever@oracle.com>,
	"Luis Chamberlain" <mcgrof@kernel.org>,
	"Matthew Wilcox" <willy@infradead.org>,
	"Dan Williams" <dan.j.williams@intel.com>,
	"Kanchan Joshi" <joshi.k@samsung.com>,
	"Chaitanya Kulkarni" <kch@nvidia.com>
Subject: [PATCH v9 24/24] nvme-pci: store aborted state in flags variable
Date: Wed, 23 Apr 2025 11:13:15 +0300	[thread overview]
Message-ID: <9432af8b4b3b947ed6b280e722389c188d5c957e.1745394536.git.leon@kernel.org> (raw)
In-Reply-To: <cover.1745394536.git.leon@kernel.org>

From: Leon Romanovsky <leonro@nvidia.com>

Instead of keeping dedicated "bool aborted" variable, let's reuse
newly introduced flags variable and save space.

Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
---
 drivers/nvme/host/pci.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index eb60a486331c..f69f1eb4308e 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -219,6 +219,7 @@ struct nvme_queue {
 enum {
 	IOD_LARGE_DESCRIPTORS = 1, /* uses the full page sized descriptor pool */
 	IOD_SINGLE_SEGMENT = 2, /* single segment dma mapping */
+	IOD_ABORTED = 3, /* abort timed out commands */
 };
 
 /*
@@ -227,7 +228,6 @@ enum {
 struct nvme_iod {
 	struct nvme_request req;
 	struct nvme_command cmd;
-	bool aborted;
 	u8 nr_descriptors;	/* # of PRP/SGL descriptors */
 	unsigned int flags;
 	unsigned int total_len; /* length of the entire transfer */
@@ -1029,7 +1029,6 @@ static blk_status_t nvme_prep_rq(struct nvme_dev *dev, struct request *req)
 	struct nvme_iod *iod = blk_mq_rq_to_pdu(req);
 	blk_status_t ret;
 
-	iod->aborted = false;
 	iod->nr_descriptors = 0;
 	iod->flags = 0;
 	iod->total_len = 0;
@@ -1578,7 +1577,7 @@ static enum blk_eh_timer_return nvme_timeout(struct request *req)
 	 * returned to the driver, or if this is the admin queue.
 	 */
 	opcode = nvme_req(req)->cmd->common.opcode;
-	if (!nvmeq->qid || iod->aborted) {
+	if (!nvmeq->qid || (iod->flags & IOD_ABORTED)) {
 		dev_warn(dev->ctrl.device,
 			 "I/O tag %d (%04x) opcode %#x (%s) QID %d timeout, reset controller\n",
 			 req->tag, nvme_cid(req), opcode,
@@ -1591,7 +1590,7 @@ static enum blk_eh_timer_return nvme_timeout(struct request *req)
 		atomic_inc(&dev->ctrl.abort_limit);
 		return BLK_EH_RESET_TIMER;
 	}
-	iod->aborted = true;
+	iod->flags |= IOD_ABORTED;
 
 	cmd.abort.opcode = nvme_admin_abort_cmd;
 	cmd.abort.cid = nvme_cid(req);
-- 
2.49.0



      parent reply	other threads:[~2025-04-23  8:15 UTC|newest]

Thread overview: 73+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-23  8:12 [PATCH v9 00/24] Provide a new two step DMA mapping API Leon Romanovsky
2025-04-23  8:12 ` [PATCH v9 01/24] PCI/P2PDMA: Refactor the p2pdma mapping helpers Leon Romanovsky
2025-04-26  0:21   ` Luis Chamberlain
2025-04-27  7:25     ` Leon Romanovsky
2025-04-23  8:12 ` [PATCH v9 02/24] dma-mapping: move the PCI P2PDMA mapping helpers to pci-p2pdma.h Leon Romanovsky
2025-04-26  0:34   ` Luis Chamberlain
2025-04-27  7:53     ` Leon Romanovsky
2025-04-23  8:12 ` [PATCH v9 03/24] iommu: generalize the batched sync after map interface Leon Romanovsky
2025-04-23 17:15   ` Jason Gunthorpe
2025-04-24  6:55     ` Leon Romanovsky
2025-04-26  0:52   ` Luis Chamberlain
2025-04-27  7:54     ` Leon Romanovsky
2025-04-23  8:12 ` [PATCH v9 04/24] iommu: add kernel-doc for iommu_unmap_fast Leon Romanovsky
2025-04-23 17:15   ` Jason Gunthorpe
2025-04-26  0:55   ` Luis Chamberlain
2025-04-23  8:12 ` [PATCH v9 05/24] dma-mapping: Provide an interface to allow allocate IOVA Leon Romanovsky
2025-04-26  1:10   ` Luis Chamberlain
2025-04-23  8:12 ` [PATCH v9 06/24] iommu/dma: Factor out a iommu_dma_map_swiotlb helper Leon Romanovsky
2025-04-26  1:14   ` Luis Chamberlain
2025-04-23  8:12 ` [PATCH v9 07/24] dma-mapping: Implement link/unlink ranges API Leon Romanovsky
2025-04-26 22:46   ` Luis Chamberlain
2025-04-27  8:13     ` Leon Romanovsky
2025-04-28 13:16       ` Jason Gunthorpe
2025-04-28 13:20       ` Christoph Hellwig
2025-04-23  8:12 ` [PATCH v9 08/24] dma-mapping: add a dma_need_unmap helper Leon Romanovsky
2025-04-26 22:49   ` Luis Chamberlain
2025-04-23  8:13 ` [PATCH v9 09/24] docs: core-api: document the IOVA-based API Leon Romanovsky
2025-04-23  8:13 ` [PATCH v9 10/24] mm/hmm: let users to tag specific PFN with DMA mapped bit Leon Romanovsky
2025-04-23 17:17   ` Jason Gunthorpe
2025-04-23 17:54   ` Mika Penttilä
2025-04-23 18:17     ` Jason Gunthorpe
2025-04-23 18:37       ` Mika Penttilä
2025-04-23 23:33         ` Jason Gunthorpe
2025-04-24  8:07           ` Leon Romanovsky
2025-04-24  8:11             ` Christoph Hellwig
2025-04-24  8:46               ` Leon Romanovsky
2025-04-24 12:07                 ` Jason Gunthorpe
2025-04-24 12:50                   ` Leon Romanovsky
2025-04-24 16:01                     ` Leon Romanovsky
2025-04-23  8:13 ` [PATCH v9 11/24] mm/hmm: provide generic DMA managing logic Leon Romanovsky
2025-04-23 17:28   ` Jason Gunthorpe
2025-04-24  7:15     ` Leon Romanovsky
2025-04-24  7:22       ` Leon Romanovsky
2025-04-23  8:13 ` [PATCH v9 12/24] RDMA/umem: Store ODP access mask information in PFN Leon Romanovsky
2025-04-23 17:34   ` Jason Gunthorpe
2025-04-23  8:13 ` [PATCH v9 13/24] RDMA/core: Convert UMEM ODP DMA mapping to caching IOVA and page linkage Leon Romanovsky
2025-04-23 17:36   ` Jason Gunthorpe
2025-04-23  8:13 ` [PATCH v9 14/24] RDMA/umem: Separate implicit ODP initialization from explicit ODP Leon Romanovsky
2025-04-23 17:38   ` Jason Gunthorpe
2025-04-23  8:13 ` [PATCH v9 15/24] vfio/mlx5: Explicitly use number of pages instead of allocated length Leon Romanovsky
2025-04-23 17:39   ` Jason Gunthorpe
2025-04-23  8:13 ` [PATCH v9 16/24] vfio/mlx5: Rewrite create mkey flow to allow better code reuse Leon Romanovsky
2025-04-23 18:02   ` Jason Gunthorpe
2025-04-23  8:13 ` [PATCH v9 17/24] vfio/mlx5: Enable the DMA link API Leon Romanovsky
2025-04-23 18:09   ` Jason Gunthorpe
2025-04-24  7:55     ` Leon Romanovsky
2025-04-23  8:13 ` [PATCH v9 18/24] block: share more code for bio addition helper Leon Romanovsky
2025-04-23  8:13 ` [PATCH v9 19/24] block: don't merge different kinds of P2P transfers in a single bio Leon Romanovsky
2025-04-23  8:13 ` [PATCH v9 20/24] blk-mq: add scatterlist-less DMA mapping helpers Leon Romanovsky
2025-04-23  8:13 ` [PATCH v9 21/24] nvme-pci: remove struct nvme_descriptor Leon Romanovsky
2025-04-23  8:13 ` [PATCH v9 22/24] nvme-pci: use a better encoding for small prp pool allocations Leon Romanovsky
2025-04-23  9:05   ` Christoph Hellwig
2025-04-23 13:39     ` Leon Romanovsky
2025-04-23  8:13 ` [PATCH v9 23/24] nvme-pci: convert to blk_rq_dma_map Leon Romanovsky
2025-04-23  9:24   ` Christoph Hellwig
2025-04-23 10:03     ` Leon Romanovsky
2025-04-23 15:47       ` Christoph Hellwig
2025-04-23 17:00         ` Jason Gunthorpe
2025-04-23 15:05     ` Keith Busch
2025-04-27  7:10     ` Leon Romanovsky
2025-04-23 14:58   ` Keith Busch
2025-04-23 17:11     ` Leon Romanovsky
2025-04-23  8:13 ` Leon Romanovsky [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9432af8b4b3b947ed6b280e722389c188d5c957e.1745394536.git.leon@kernel.org \
    --to=leon@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=alex.williamson@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=bhelgaas@google.com \
    --cc=chuck.lever@oracle.com \
    --cc=corbet@lwn.net \
    --cc=dan.j.williams@intel.com \
    --cc=hch@lst.de \
    --cc=iommu@lists.linux.dev \
    --cc=jake@lwn.net \
    --cc=jgg@ziepe.ca \
    --cc=jglisse@redhat.com \
    --cc=joro@8bytes.org \
    --cc=joshi.k@samsung.com \
    --cc=kbusch@kernel.org \
    --cc=kch@nvidia.com \
    --cc=kevin.tian@intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=leonro@nvidia.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=logang@deltatee.com \
    --cc=m.szyprowski@samsung.com \
    --cc=mcgrof@kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=sagi@grimberg.me \
    --cc=schnelle@linux.ibm.com \
    --cc=shameerali.kolothum.thodi@huawei.com \
    --cc=will@kernel.org \
    --cc=willy@infradead.org \
    --cc=yishaih@nvidia.com \
    --cc=zyjzyj2000@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox