From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DBF1C27C77 for ; Wed, 12 Jun 2024 18:41:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 98A8F6B00A2; Wed, 12 Jun 2024 14:41:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 93B7D6B00A3; Wed, 12 Jun 2024 14:41:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 767046B00A4; Wed, 12 Jun 2024 14:41:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 578AD6B00A2 for ; Wed, 12 Jun 2024 14:41:55 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 11E1C1A1838 for ; Wed, 12 Jun 2024 18:41:54 +0000 (UTC) X-FDA: 82223105748.22.7D06FF8 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf11.hostedemail.com (Postfix) with ESMTP id B99A140009 for ; Wed, 12 Jun 2024 18:41:51 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ik+gRK9+; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718217711; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Tt5ThilReFbEyA5Et8oCAm3CfkmDTGwtO66aN/4s1zQ=; b=wXzLNfjRu0P2A77et4nIZhGbpsG7VXsbUMgb+6ES1Me1PijkONrE1V7K9fCb3rDOr6XLf8 vtt9Ae5n1GJJGYHbtgjTN0LyAlJJLaTOXF0Rzz36i8DVRY4Bmiqi5R6vNowg7rdN4bJVyI cRhZA1XtOE2OhL6EY4XPpXUs+h8oSP0= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ik+gRK9+; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718217711; a=rsa-sha256; cv=none; b=aPWm7oRpTavN23P0zb5e9zOyKjV69hoHb7rqW6Dtnq93ux+D/zyajY1DUz/2ANa4J4sl0u r48edaR5HNq5PM+XYCXTLzJ8TwnFvXCK4WMLoou407plTFJkJCN5qQ69OjQYaJDKNsawuY lZbV0PJYi7pPwzoSR+DlkFD3fGKFxtE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718217711; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Tt5ThilReFbEyA5Et8oCAm3CfkmDTGwtO66aN/4s1zQ=; b=ik+gRK9+lo2pNKcDKu2sacnOLQP9rygG9aJhyDrhyc7ddWQmNQ8Yvzr4YTwxL2yVpIRYvm GAflikoOxF1HnL4EFauGDD03ShITGSisUUXF2NLku58HdOQ1rMVgtORg2aIX1DZTvtTCsC 4ZHjczBWzHMK7nKst8VYLfKEKG4LzvI= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-615-9pa8kS3PNviXZPPF8S73rQ-1; Wed, 12 Jun 2024 14:41:49 -0400 X-MC-Unique: 9pa8kS3PNviXZPPF8S73rQ-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-421e17ae038so1378575e9.0 for ; Wed, 12 Jun 2024 11:41:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718217708; x=1718822508; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=Tt5ThilReFbEyA5Et8oCAm3CfkmDTGwtO66aN/4s1zQ=; b=kFtTqAJp2SkfAH81PSEEJn5Ty/Zfh6ApjFTz6MjvveszX8WMODLLARDx89H7utKHS8 g8i7gauWG1+siDmCYMm+m8EYDAnmwrJ9G/5m77NudmbCx2TTMaVwgQVihS+v26tmtJhB /93cFmVN8JWGle5cmivJVdFui5p2OC8k8TEvMxIpSUnHKAIKER9p8JDFHU/vjF7EbW+3 FUGhsN7quWGD7afMQJEmp6QaOyrS/UB3z8Qlby/8Md6LG4uK+hh7/SSHQU3WPKhYe7TV UglFnLEKo3GpbIZbPhX3dmYYte+ih/dGUwkUWBgb//RqE5MtE/GdkghTGctmEt4gMgDQ vgaQ== X-Forwarded-Encrypted: i=1; AJvYcCXC93nEaVt1DY4BjyAdtHleH3EiNgNwN9+VsnwLnF5YKdRztA7vjZTlCsC32Slle4pKETpu1Eip/xm5Y4sPkLkdb+I= X-Gm-Message-State: AOJu0Yz4HQV/dVusmqZcxq/NdjMNvPPOCPPHtr52hJQi00FfXaDYZsZy Gdf5b9L1PFz2InZyyJUs4BfD26+Z4noE+O4tW9gIqJkFTJvUpOBpI4Z0Hg/6JxWh0SDc6tmpztc j53sIGeRjVWvEX0XTVeDYh5AV198lvO8XwMHrWUrVtjtmWuhZ X-Received: by 2002:a05:600c:2154:b0:421:7cab:3b16 with SMTP id 5b1f17b1804b1-422863ae810mr18582795e9.23.1718217708670; Wed, 12 Jun 2024 11:41:48 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFhbzqHIldrlKoQ5aUT9R7op4I+kGF9D3ZZspkrOmzP25Ia0brJwFTBQwPEzsNvUMK10MVEsw== X-Received: by 2002:a05:600c:2154:b0:421:7cab:3b16 with SMTP id 5b1f17b1804b1-422863ae810mr18582705e9.23.1718217708262; Wed, 12 Jun 2024 11:41:48 -0700 (PDT) Received: from ?IPV6:2003:cb:c702:bf00:abf6:cc3a:24d6:fa55? (p200300cbc702bf00abf6cc3a24d6fa55.dip0.t-ipconnect.de. [2003:cb:c702:bf00:abf6:cc3a:24d6:fa55]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-422871f8dcdsm35010835e9.40.2024.06.12.11.41.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Jun 2024 11:41:47 -0700 (PDT) Message-ID: <9419ce11-08b5-4f80-9dc6-8551a7b8daea@redhat.com> Date: Wed, 12 Jun 2024 20:41:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] mm/memory: Don't require head page for do_set_pmd() To: Hugh Dickins , Andrew Morton Cc: Matthew Wilcox , Andrew Bresticker , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240611153216.2794513-1-abrestic@rivosinc.com> <8040793f-e9e9-4a2e-807c-afcb310a48f5@redhat.com> <20240611110622.8e9892e92618ddc36bca11b7@linux-foundation.org> <20240611130729.d53cbcd1767f917b47540cca@linux-foundation.org> <1786b46a-ab24-6032-6a60-93b3e3870c7c@google.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <1786b46a-ab24-6032-6a60-93b3e3870c7c@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: B99A140009 X-Rspamd-Server: rspam10 X-Rspam-User: X-Stat-Signature: aayjni953dyuuw5dxtkc4yz8qught73q X-HE-Tag: 1718217711-405575 X-HE-Meta: U2FsdGVkX1+baP9VNJ0C4yVqNanw7dCftnSrKkCVX7OtfbKaLD2WGWGXFw5invTk01KP0M8ZhFSH4tTxm/jdU9K3iJ7rBxMlXwm5zc+MzRil3lrRhw7i763iNjTQZXQ5236NOO4T0MgIY3ac2TVYse6Yeh+JX4gtUK43RsTglP4fLCFoivgkGgRMwMLoRyHP72s6img7gvNK/KW/4WGRh3XWyVVaR+140AuzrfGESQ53JausAO5A5ux4QWVaDzxZFD7JLY7njRps0+bojCEGcAQlqtRW6lZGYPy6lxl/AX8i1bHXGvbwTUc5dLqtSc30lYJxdn4/IdKnTKEMhm1+8kgUqYLIjtWL86mLE5+bg+AjuN3Wu+Q8aYGCB+Fdos8SMQ+fdwBJCXGLeAnYV7MTW56oGxLoYgh8MazV1x1q5kpbtpfQYT7ScmOCGXWYEaODUwK2e5ipIQJVfnsntZrNVrq/kt/i3qyQtykyCqOGZMLyNuLZI+Gj+Kj24Z1mJnsp8VR8g1tt+bOLhal0YcmFbcxSY1f9bSE2gmeW2cuSNodwmcuWSWdsVCTIxdfiGvxo33GDML8WrRjfFLWq73VyG7yjcvBsYx1Ch3nOFbY6K6e7NrP6Lc9hxpvxmAESyTYwAlFdIQkhqufDQP74lX+rCB8Vl8G56EcVnc6xN084ijGuTGUTf+h5RpZk/S6GExUL0gZB2F7vRVrT6hXzE4+SmC3Fva1EVp2OesnS7DDAqlSaP0pyfM03/D2NlLdHTzIOv8vXL2K48TJvNrCZCIzeKApN19OUMTrqM4DMpjQqhXM6I3qm5tGL6Pdwe6FhX4qC/VkA3UHYdOeLe/7hGLnR1t/Ed2jWnp3Gq15fRV8ZmQu7DuK1lil1Fpf1eP4gH909zoUGRMKX9hObkX+v6oR8nVIKh/ijnvUlyPaBXtnyzJ4F8w4uZfU2kC/so8vYAVnxRBeYLVherDWXPCX56vC ocIZ/8M4 /OBkCXJF3ZkcfW88f7Wd/YlGfC/WnrY+q68t08BT3nGGya22LtJfokZ/Mr1bAHz6bGsUM+JLXLghhznBNMjwKWgt9ATF4DdrlnrY0mmQCXkAL0x2aJiy9GK6cO7a58JfVIWGLtGspB/SvrKe6Jyq601kIOF4SsChY19hyHBq9nc6qb8Lflz+uPOE+V1uBjRdMU8nGEwAhCkJ/CBpz+Zr0xsBKaHo7n85cTZkmfQilFJAlVX+ma+nEw1u+Un+hWH8/frYFzwsqapz2OwxV/dQYbeAORL6TfVIbOAGh6qL4BGA1h00PfwWh3S7MbSRlvIpueeNuprtY5cHvqPcpD5OKoSZqT5Ym1HBqfuH0veVupbRaLK5SMmCAWyxRTDTwXRxLMOf0yn0FYhsEMtkTd9+r9LDq8zkmd/orcavlFoulyPO1QXb5Qqoyv7zIiB2h7ID9IQ69/L0NncmUF8AiBNNriNMRYS0Rx9fZBpKMy/g8Jab9aKZhXMsEMIunVzI4HJDzl02Qc4XYiHvKB6duxei6+FoJjKsT0eYRW3uGOWI27qljSsDpe2aD0bKOWbGqMqyplA7xRLcl0t5QKI2U/7ZezndcQIlaJzPKTM8IzuyYDe6ZVxhyWic4tanz6ZZDCRqKqp5a1LYE7f1Zfx8pC8m+cQvL4mDnOvOFuBb/e+wLD3sfeCn5YNchS63eGFDRZ1i/9YZQ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11.06.24 23:18, Hugh Dickins wrote: > On Tue, 11 Jun 2024, Andrew Morton wrote: >> On Tue, 11 Jun 2024 19:22:03 +0100 Matthew Wilcox wrote: >>> On Tue, Jun 11, 2024 at 11:06:22AM -0700, Andrew Morton wrote: >>>> On Tue, 11 Jun 2024 17:33:17 +0200 David Hildenbrand wrote: >>>> >>>>> On 11.06.24 17:32, Andrew Bresticker wrote: >>>>>> The requirement that the head page be passed to do_set_pmd() was added >>>>>> in commit ef37b2ea08ac ("mm/memory: page_add_file_rmap() -> >>>>>> folio_add_file_rmap_[pte|pmd]()") and prevents pmd-mapping in the >>>>>> finish_fault() and filemap_map_pages() paths if the page to be inserted >>>>>> is anything but the head page for an otherwise suitable vma and pmd-sized >>>>>> page. >>>>>> >>>>>> Fixes: ef37b2ea08ac ("mm/memory: page_add_file_rmap() -> folio_add_file_rmap_[pte|pmd]()") >>>>>> Signed-off-by: Andrew Bresticker >>>>>> --- >>>>>> mm/memory.c | 3 ++- >>>>>> 1 file changed, 2 insertions(+), 1 deletion(-) >>>>>> >>>>>> diff --git a/mm/memory.c b/mm/memory.c >>>>>> index 0f47a533014e..a1fce5ddacb3 100644 >>>>>> --- a/mm/memory.c >>>>>> +++ b/mm/memory.c >>>>>> @@ -4614,8 +4614,9 @@ vm_fault_t do_set_pmd(struct vm_fault *vmf, struct page *page) >>>>>> if (!thp_vma_suitable_order(vma, haddr, PMD_ORDER)) >>>>>> return ret; >>>>>> >>>>>> - if (page != &folio->page || folio_order(folio) != HPAGE_PMD_ORDER) >>>>>> + if (folio_order(folio) != HPAGE_PMD_ORDER) >>>>>> return ret; >>>>>> + page = &folio->page; >>>>>> >>>>>> /* >>>>>> * Just backoff if any subpage of a THP is corrupted otherwise >>>>> >>>>> Acked-by: David Hildenbrand > > Acked-by: Hugh Dickins > >>>> >>>> You know what I'm going to ask ;) I'm assuming that the runtime effects >>>> are "small performance optimization" and that "should we backport the >>>> fix" is "no". >>> >>> We're going to stop using PMDs to map large folios unless the fault is >>> within the first 4KiB of the PMD. No idea how many workloads that >>> affects, but it only needs to be backported as far as v6.8, so we >>> may as well backport it. >> >> OK, thanks, I pasted the above text and added the cc:stable. > > Yes please. My interest in this being that yesterday I discovered > the large drop in ShmemPmdMapped between v6.7 and v6.8, bisected, > and was testing overnight with a patch very much like this one of > Andrew's. I'd been hoping to send mine today, but now no need. > >> >> I didn't move it into the hotfixes queue - it's a non-trivial >> behavioral change and extra test time seems prudent(?). > > It is certainly worth some test soak time, and the bug might have > been masking other issues which may now emerge; but the fix is > just reverting to the old pre-v6.8 behaviour. Right, I don't expect surprises, really. I'm rather surprised that nobody noticed and that the usual 0-day benchmarks don't trigger that case. -- Cheers, David / dhildenb