From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0DF9D591A5 for ; Mon, 18 Nov 2024 16:39:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1EC126B0082; Mon, 18 Nov 2024 11:39:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 14E1C6B0085; Mon, 18 Nov 2024 11:39:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F30D96B0088; Mon, 18 Nov 2024 11:39:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id D1FEB6B0082 for ; Mon, 18 Nov 2024 11:39:38 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 3D139ACAE8 for ; Mon, 18 Nov 2024 16:39:38 +0000 (UTC) X-FDA: 82799775324.23.0A7EC73 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf03.hostedemail.com (Postfix) with ESMTP id B05F520003 for ; Mon, 18 Nov 2024 16:39:13 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Cfq4RUPD; spf=pass (imf03.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731947733; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5TBgXpcOkE91KJWIrvCU0ksBJeSHSjTfC1vv3ct4vww=; b=KwC2kNoAcuIStl+jJIrWhoF6EumgzY9BJM+5ghMXbrR7R0ccyEovFxTGW1KZGODXqoO+Z7 pPvZ8QroV31PX7M+va1KS65GtStkgm1i/avzi9k2KPHzhd282Do1OSlX01ukLS0tCOEnw3 4N5Y9bIu8je8e58yN8pOsdCsU/0jYrc= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Cfq4RUPD; spf=pass (imf03.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731947733; a=rsa-sha256; cv=none; b=tVX/tXLwJ+uWyegrqKBxEcUPdtuCZaqGemUenFI5SvALrsN5RoPnjwiPih7wyB7ZD9xdrH cLvJ6PiClciQm3MR+3kLR9vpf2Qd6+jpz/SeXG4qSS8ayGpJaKKnOzF+gkma5NEeFjaux/ FFIG27AhIsVHfHDEZ4ZppX9UWLnAg6A= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1731947975; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5TBgXpcOkE91KJWIrvCU0ksBJeSHSjTfC1vv3ct4vww=; b=Cfq4RUPDuzUUTdZG/jIqxj2V6vs2OHSm9q7v3uW656eGUSH/g6E6q+Rw6+M30C1mpx+Y7V 9CQE3mtquEMnmvGw9/Rtl4mH9OfpB3GU3F8r5Q24+6EXo6sgR/lptsM2tgBrGHdFhW+VnG OA6gvrFuZEYiPTk98EjPpZ0XKZlyB2I= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-226-r1Nbp_NqPiyaaS_1Yh73TA-1; Mon, 18 Nov 2024 11:39:32 -0500 X-MC-Unique: r1Nbp_NqPiyaaS_1Yh73TA-1 X-Mimecast-MFC-AGG-ID: r1Nbp_NqPiyaaS_1Yh73TA Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 6604A19560BA; Mon, 18 Nov 2024 16:39:28 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.207]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 8E035195607C; Mon, 18 Nov 2024 16:39:21 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <20241108173236.1382366-1-dhowells@redhat.com> <20241108173236.1382366-8-dhowells@redhat.com> To: Kees Bakker Cc: dhowells@redhat.com, Christian Brauner , Steve French , Matthew Wilcox , Jeff Layton , Gao Xiang , Dominique Martinet , Marc Dionne , Paulo Alcantara , Shyam Prasad N , Tom Talpey , Eric Van Hensbergen , Ilya Dryomov , netfs@lists.linux.dev, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 07/33] netfs: Abstract out a rolling folio buffer implementation MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <941711.1731947960.1@warthog.procyon.org.uk> Date: Mon, 18 Nov 2024 16:39:20 +0000 Message-ID: <941712.1731947960@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: B05F520003 X-Stat-Signature: 4j59kdi8bozernigky7kw3xdnsxw48gh X-Rspam-User: X-HE-Tag: 1731947953-292664 X-HE-Meta: U2FsdGVkX1/+522Mrw6C2PBC9YlZ85F+PXsJoyqnq5t9IeMpU2vcM/EK+FuV97jR8WKMcbox3owoqKP5pjL2Tt+qaknVC8C+hPbkXdHBu1cXk10grvXGe3Jvdk6ICDNcvIYgJXpuF6p9dBnnSIaTFeDqm9rr1MN3cdTlHklNRELXZmx/l/Wg6DSU18b6Ex+hYwpR8Lxj96bZLtDOXBcuSyE4EyHRMx3KV8/0Vt6iGVch7V5Ss/rY1r9YiL4KIhZzQn3HNfcGwkgeSn0Mg9GpB9s6PY3ZfeIoYeEwCsIaKjjFCMrI7Bhi53BhXNCsrCU/r6TX3cuBNTS2P7xyaTy10YXfKxi6oCYFafrwuj2ow2f4hv+34YGYZlzlVsnWGB/GoR1O1fCC/GO7M46c1F/pMa+rTMTjERpBJn6fh+XXNt7zAKVrCakrzSKf6Ez9sNsMxgJG9QksAtL1zM0UOK+gJQJG918f/J2nnwSMdccJ0jlTMIglwSfPbggXiTWOOAUANvkenKjGf6ZJ7iiYrB0N+xfgbCmrRwPx6DDmUgWatjjVBysEh+gvJBpa8hBf7M2vWWAIaK747cU99u196nyiqb/4skzxTwzVkdF92YHG079aP2aPI+SM/EMhSxYGcJoPUdtDszIJFtAn6Ni5WaAJg9cOivPzgE5hQskmvh1PHX1Ifqf1QSBuMyHDcoxB3YxdslWKiwxzzJDKFBRxlkCf+vmkYqd2BLSXARVnMqPhOLTo2s60GVBpNztPLXFYaHkdITlIVLRHNzvF7ZovGpi7XbbcT/eBaN/mqk3+qB03lWjH0Hf/E/LfwNNR3nTqg3hDpnTKxyUM23I5y+qLPkmXDcxYiS7geldUyvE7Xo/y36vUtZE74TVP4ZR4sB7jIMUNlvgeP8SrjHWzaz6MCPVwFsXbbChxyIB0l/TLRMc3dZJNV5WAfJMMXPbFsZyMAou5sS53Aa5MAx2AW5x7czE KRMdrqiI aTNFGbwAUhRAeFXC/ugImGqxp8TY60+2+vQ5VaKsOa6B7oDCgaicosuhGk8w2/u4XcpGvBmoVTByY6OPsXu0+JJyJ5DVLTjNkPD14GByWbPH0bQlAkmvIDYpANxsic0Kyg4GyLiXSNNfseDDJpkAFniXyKAOe9TyVnPjGV6acGZexwyTvTQLH77yv0YAs+6jq8S+WxnhX9e5OXMYRlXy2514XEHTTxGQ7Lqg5L/hPFw5bjRqVhV0D3Y7SqZvBog8elzp3vKuOLUJ3xvJqDB1k+10zEvaLsx+6VrJr81uC8ftSTICbhA/j27LVoJyCSagXoy1XiHJA3lJGnkKPUtXUGeL3g1tEGugv8n+6r9DM4a2cCZc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Kees Bakker wrote: > > + wreq->buffer.iter = wreq->buffer.iter; > Is this correct, an assignment to itself? That should just be removed. Both branches of the preceding if-statement set it. David