From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2035DD591A5 for ; Mon, 18 Nov 2024 16:35:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 71AAA6B007B; Mon, 18 Nov 2024 11:35:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6CB036B0082; Mon, 18 Nov 2024 11:35:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5920D6B0083; Mon, 18 Nov 2024 11:35:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 3CB2B6B007B for ; Mon, 18 Nov 2024 11:35:40 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id E43EA1602E8 for ; Mon, 18 Nov 2024 16:35:39 +0000 (UTC) X-FDA: 82799763354.17.A6523A8 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf29.hostedemail.com (Postfix) with ESMTP id 5D28B12000E for ; Mon, 18 Nov 2024 16:34:31 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SxVczH6b; spf=pass (imf29.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731947558; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=F48vEQ6V/tDlXaOtinAU3DdgDvVmHs2S/fGlg/NOvdQ=; b=lGpidTYZ0XWfX+ZHG0hfetR7N2CD9DstaNJdj9Q2r+nqgLz75PoUX3a6LlXxraTDtSxTVp 8ww/lm68ituKfqCKA7ljTAslZmTTyxD9wLU6jDpNgYMxRuFLNUiEWYSpOslEeUAPXDKPjO kn4ZM6PcsoH8wMQMxn2PMPip7ORbrjs= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SxVczH6b; spf=pass (imf29.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731947558; a=rsa-sha256; cv=none; b=rCM7I4G1o/SIdma/WzIMClSqGMarusG/jFrx8LbIIejBLkeGh0MyqdOtPSMcVokSLTF35C BJENAw00BgKumPd74zX0edOb4MSwkhviczPvTF02brHJQ3oPgO0QbZZ5o1ozSqgVRPDyku CT7yig6lTSVkMja6YIhDFOfgF/wTmnk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1731947737; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=F48vEQ6V/tDlXaOtinAU3DdgDvVmHs2S/fGlg/NOvdQ=; b=SxVczH6bvTQk4bsR6YrvO0xCVXvd9kv8B0+sRVUu7BhRZAIQtaWPWnEcwEvb66jlXKvshv tfsm9hR+c3cDwOazjFtCdZh/DSCUjUtQW5vgMYgZiCqo4TQWqhduwrOOJ5FjaAGzK09OKn nVHp3D6YZvIoL1u2BCs82Vsh15vctTM= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-351-HpCdFzANNgKaFZmQE0YgOw-1; Mon, 18 Nov 2024 11:35:33 -0500 X-MC-Unique: HpCdFzANNgKaFZmQE0YgOw-1 X-Mimecast-MFC-AGG-ID: HpCdFzANNgKaFZmQE0YgOw Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D5300197731B; Mon, 18 Nov 2024 16:35:28 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.207]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 710421956054; Mon, 18 Nov 2024 16:35:20 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <17eb79fc-ccd9-4c85-bd23-e08380825c41@ijzerbout.nl> References: <17eb79fc-ccd9-4c85-bd23-e08380825c41@ijzerbout.nl> <20241108173236.1382366-1-dhowells@redhat.com> <20241108173236.1382366-24-dhowells@redhat.com> To: Kees Bakker Cc: dhowells@redhat.com, Christian Brauner , Steve French , Matthew Wilcox , Jeff Layton , Gao Xiang , Dominique Martinet , Marc Dionne , Paulo Alcantara , Shyam Prasad N , Tom Talpey , Eric Van Hensbergen , Ilya Dryomov , netfs@lists.linux.dev, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 23/33] afs: Use netfslib for directories MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <941498.1731947719.1@warthog.procyon.org.uk> Date: Mon, 18 Nov 2024 16:35:19 +0000 Message-ID: <941499.1731947719@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 5D28B12000E X-Stat-Signature: nng7yiqy8j716p7176g4aay56qq6gu4m X-Rspam-User: X-HE-Tag: 1731947671-147634 X-HE-Meta: U2FsdGVkX1/KPKuAisp+hS8TKX2ZpXYwwEtBAbdnB7v6YxiY8L5LyWwG5OjtyF2pTeGuHnxkh4hM3HUZoFHabY1JffFRx8hjyNuQ5vDio6dfDJqqeppt0Pmqy+DQ4T/IzK+MLrmVfjY/NS7QKi/JKzfoiqaD118ihrJHJgFo2UsO562m2K5TINKdMa8/QOU1l1s/CnVZBIHQi2orQ9gLCSSTiYNv+qIcjfvSalCxZWbW4mukEQiJ4OAa6w0k10wojhs6R8Tgrlx5xq4DBr2KesAdDTRDVyhQ2OLO+HQc/2GqxFt1iwJCFWLrLtTLQrPFFEjFFtFjbK1SgwH4/2qMzz3Josp7IbFaoiqM6l0glsKoVtKb3QtqFuWxuHvNJvxujLIQRxZqcbSH9/gLrPZf9b9T+0tt1WW4byxm7H++dpYSHriBjr8+1DEEWI80XJGRfogf/cV7QQfhBBTxU7oEivJEduF5j+AjUN9MV7QDE0ZaIgvHULNwv76plZcgf6b5nwYcV0cNOfJZoU2UsoadEifqN5of7d/NYDYDAEPf+1Klq3rlalouPb/79/O8R0UuPLZFe2n1RTAFWSkxX7jWOeyqmlwslEDU3xx2nDpnNjofXDciwnCymNDo45sEDkkP9so7GEg5gKfGJfZZv145BsFVSQx9v5B/9GUcRN7bW60vA4f5vDAWELULn7IGemSsKseBJ/4u23/J+DHjLnapQW8vZ+nRCw7v5khpuq3ivZZ3b79D902JuyroDwzwyFfahdvzHeBjfCpcuWM6LnngYtfyK6nqJkx+47yWkGz/yuoFXOYCqgcWYp8gUA/MZaSzwmJZEnirw4Jxm6aalnUsMDwXQ+7lNUzFzb8E3G8739ZX5EK/Q1FVT+M9HgVBAaKvRjVOjbU41J2og+0Zme+xEckJsBlC7yL+vCmXAFPifoPY5sStNhU3XvooBRRbqNk2cleP3ricmOkCwTfySe7 vvw3TLkz z414/D+aElOrjpEn0fjhDC/mqqVLuV/bRSJLoxrmoAmFUd3BLWpQ9NrETl9VPLcyMNMzsMngiXnggynKBpHHMJPO1riNYXJmP+lGoNm1x8YKYvTwDeRMebhxnEED8ANObj1K3aewuON3MuKLfA+3JinC+HP/MM/+QztJtcJ4KZ/uWlpSYtGdI2gbtZ5COFgxRQBVxAwywNOOU1fj2O4hm7/zdRetlbziisBj8ganFNAmi9xaaDfkXYp5i83z6XDi3C8UMUXHe3JpbbhBpuH+mhqyYH6zarc9QzjuzXyvjZD/n9wLLJ1mMzFEnQgfRiRQUje7+O4TKvWXTkHa6Fh2x/HMmH6mj7zi5rJtUSDBIxg26N64= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000009, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Kees Bakker wrote: > > + iterate_folioq(&iter, iov_iter_count(&iter), dvnode, ctx, > > + afs_dir_iterate_step); > > + > > + if (ret == -ESTALE) > This is dead code because `ret` is set to 0 and never changed. > > + afs_invalidate_dir(dvnode, afs_dir_invalid_iter_stale); Yeah. I posted a modification for this in response to someone else. ESTALE needs to be set if iterate_folioq() returns 0. David