linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: "David Hildenbrand (Red Hat)" <david@kernel.org>
To: Miaohe Lin <linmiaohe@huawei.com>,
	akpm@linux-foundation.org, shuah@kernel.org
Cc: lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com,
	vbabka@suse.cz, rppt@kernel.org, surenb@google.com,
	mhocko@suse.com, nao.horiguchi@gmail.com, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH 0/3] selftests/mm: add memory failure selftests
Date: Fri, 9 Jan 2026 14:45:33 +0100	[thread overview]
Message-ID: <9413a995-9182-493e-a28a-6d2d3a17236b@kernel.org> (raw)
In-Reply-To: <20260107093710.3928374-1-linmiaohe@huawei.com>

On 1/7/26 10:37, Miaohe Lin wrote:
> Introduce selftests to validate the functionality of memory failure.
> These tests help ensure that memory failure handling for anonymous
> pages, pagecaches pages works correctly, including proper SIGBUS
> delivery to user processes, page isolation, and recovery paths.
> 
> Currently madvise syscall is used to inject memory failures. And only
> anonymous pages and pagecaches are tested. More test scenarios, e.g.
> hugetlb, shmem, thp, will be added. Also more memory failure injecting
> methods will be supported, e.g. APEI Error INJection, if required.

0day reports that these tests fail:

# # ------------------------
# # running ./memory-failure
# # ------------------------
# # TAP version 13
# # 1..6
# # # Starting 6 tests from 2 test cases.
# # #  RUN           memory_failure.madv_hard.anon ...
# # #            OK  memory_failure.madv_hard.anon
# # ok 1 memory_failure.madv_hard.anon
# # #  RUN           memory_failure.madv_hard.clean_pagecache ...
# # # memory-failure.c:166:clean_pagecache:Expected setjmp (1) == 0 (0)
# # # clean_pagecache: Test terminated by assertion
# # #          FAIL  memory_failure.madv_hard.clean_pagecache
# # not ok 2 memory_failure.madv_hard.clean_pagecache
# # #  RUN           memory_failure.madv_hard.dirty_pagecache ...
# # # memory-failure.c:207:dirty_pagecache:Expected unpoison_memory(self->pfn) (-16) == 0 (0)
# # # dirty_pagecache: Test terminated by assertion
# # #          FAIL  memory_failure.madv_hard.dirty_pagecache
# # not ok 3 memory_failure.madv_hard.dirty_pagecache
# # #  RUN           memory_failure.madv_soft.anon ...
# # #            OK  memory_failure.madv_soft.anon
# # ok 4 memory_failure.madv_soft.anon
# # #  RUN           memory_failure.madv_soft.clean_pagecache ...
# # # memory-failure.c:282:clean_pagecache:Expected variant->inject(self, addr) (-1) == 0 (0)
# # # clean_pagecache: Test terminated by assertion
# # #          FAIL  memory_failure.madv_soft.clean_pagecache
# # not ok 5 memory_failure.madv_soft.clean_pagecache
# # #  RUN           memory_failure.madv_soft.dirty_pagecache ...
# # # memory-failure.c:319:dirty_pagecache:Expected variant->inject(self, addr) (-1) == 0 (0)
# # # dirty_pagecache: Test terminated by assertion
# # #          FAIL  memory_failure.madv_soft.dirty_pagecache
# # not ok 6 memory_failure.madv_soft.dirty_pagecache
# # # FAILED: 2 / 6 tests passed.
# # # Totals: pass:2 fail:4 xfail:0 xpass:0 skip:0 error:0
# # [FAIL]
# not ok 71 memory-failure # exit=1


Can the test maybe not deal with running in certain environments (config options etc)?

-- 
Cheers

David


      parent reply	other threads:[~2026-01-09 13:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-07  9:37 Miaohe Lin
2026-01-07  9:37 ` [PATCH 1/3] selftests/mm: add memory failure anonymous page test Miaohe Lin
2026-01-07  9:37 ` [PATCH 2/3] selftests/mm: add memory failure clean pagecache test Miaohe Lin
2026-01-07  9:37 ` [PATCH 3/3] selftests/mm: add memory failure dirty " Miaohe Lin
2026-01-09 13:45 ` David Hildenbrand (Red Hat) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9413a995-9182-493e-a28a-6d2d3a17236b@kernel.org \
    --to=david@kernel.org \
    --cc=Liam.Howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=linmiaohe@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lorenzo.stoakes@oracle.com \
    --cc=mhocko@suse.com \
    --cc=nao.horiguchi@gmail.com \
    --cc=rppt@kernel.org \
    --cc=shuah@kernel.org \
    --cc=surenb@google.com \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox