From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 18FBDD339A0 for ; Fri, 5 Dec 2025 17:27:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 696146B019D; Fri, 5 Dec 2025 12:27:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 64CF46B019F; Fri, 5 Dec 2025 12:27:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4E76A6B01A0; Fri, 5 Dec 2025 12:27:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 355896B019D for ; Fri, 5 Dec 2025 12:27:03 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id D50E6130023 for ; Fri, 5 Dec 2025 17:27:02 +0000 (UTC) X-FDA: 84186097884.16.F391810 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) by imf17.hostedemail.com (Postfix) with ESMTP id 51E2C40004 for ; Fri, 5 Dec 2025 17:27:00 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=YuPWySH+; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf17.hostedemail.com: domain of dave.hansen@intel.com designates 192.198.163.11 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1764955621; a=rsa-sha256; cv=none; b=fYGgn99HxoSyNdNbbqrKteRDSXdFZj9KKU6aHZWWoNN+SRV9/l2iB8ireFEWty6Lw8b3I8 LOy+Mj1vYZc1ZaxCYLyHeiIrDcJhOWZT+kR6kJK8g1/TlCwIrDovWgPQiTUPMndWtnAnaA +uIOYjhTbJKWqsvy0ZArtOVPxJX5lJY= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=YuPWySH+; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf17.hostedemail.com: domain of dave.hansen@intel.com designates 192.198.163.11 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1764955621; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TiOVcOZkI/VIL7to8gRsFacU6zZ3s4rybKs5cLeYlPA=; b=UxNVbG51FJq0aDWO2O4Ixxk9kpd/ymEkPODY2DSCMl6kFnyfo7V4rvpsg2X2X32duPhLUO 1MV6WJSiUYLegrQmvD8cU1aRVDmGnkAH8usVgf6rt1hs0AnAAQZIRwGtD3B//1SdkU2AUY Qpdmke0t0zc1KbJjjsALBhf978OSD3s= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1764955621; x=1796491621; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=TmM8G4lNHaUxZQSRyqB2EBkn6Cn3E5Bi3cEB/xO+pjM=; b=YuPWySH+zDHMg7kv/2AJoctp9qKGvbe8Ew3rdLIRBIWRym6G8IC5e+DG vIZ/e2sUMbgUAX/eTW0u8alf6rJ1EQCJlSK/Fkpgjk44yI4VHiu3mkFuw Y09Aiu4/qBOVjhI6HqwKkFWvGBMJk8wnagDR7ade/3EQFqsnOxpGIctn9 /zciIIbEBhFjpn28ixWrbNpzqPPe44ZWbM1kjG0Mxu3tSPB+c4EcGUi2J SnpkendyJtPIZWEOyGPPMZIfzfMHwN1O7Nj5KRKm5eXQoUYVbEQ1IC4sP LbYCQalolE5liVVAdUkbg1lDLgTGdUevRUJi0MMMhItgkiLkuJcAXQtDO Q==; X-CSE-ConnectionGUID: CQ7fchcdTJu+3BZXNJS5Fw== X-CSE-MsgGUID: QUPgUm7dTe+eZ5ctL25fHQ== X-IronPort-AV: E=McAfee;i="6800,10657,11633"; a="77612343" X-IronPort-AV: E=Sophos;i="6.20,252,1758610800"; d="scan'208";a="77612343" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Dec 2025 09:26:59 -0800 X-CSE-ConnectionGUID: F9P4sbSUS1agtmmb/ST5Xg== X-CSE-MsgGUID: RM8P4RCTRyq268Qov786Aw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.20,252,1758610800"; d="scan'208";a="194646785" Received: from vverma7-desk1.amr.corp.intel.com (HELO [10.125.108.173]) ([10.125.108.173]) by orviesa010-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Dec 2025 09:26:57 -0800 Message-ID: <9409531b-589b-4a54-b122-06a3cf0846f3@intel.com> Date: Fri, 5 Dec 2025 09:26:56 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 01/13] x86: export set_direct_map_valid_noflush to KVM module To: "Kalyazin, Nikita" , "kvm@vger.kernel.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "kvmarm@lists.linux.dev" , "linux-fsdevel@vger.kernel.org" , "linux-mm@kvack.org" , "bpf@vger.kernel.org" , "linux-kselftest@vger.kernel.org" Cc: "pbonzini@redhat.com" , "corbet@lwn.net" , "maz@kernel.org" , "oupton@kernel.org" , "joey.gouly@arm.com" , "suzuki.poulose@arm.com" , "yuzenghui@huawei.com" , "catalin.marinas@arm.com" , "will@kernel.org" , "seanjc@google.com" , "tglx@linutronix.de" , "mingo@redhat.com" , "bp@alien8.de" , "dave.hansen@linux.intel.com" , "x86@kernel.org" , "hpa@zytor.com" , "luto@kernel.org" , "peterz@infradead.org" , "willy@infradead.org" , "akpm@linux-foundation.org" , "david@kernel.org" , "lorenzo.stoakes@oracle.com" , "Liam.Howlett@oracle.com" , "vbabka@suse.cz" , "rppt@kernel.org" , "surenb@google.com" , "mhocko@suse.com" , "ast@kernel.org" , "daniel@iogearbox.net" , "andrii@kernel.org" , "martin.lau@linux.dev" , "eddyz87@gmail.com" , "song@kernel.org" , "yonghong.song@linux.dev" , "john.fastabend@gmail.com" , "kpsingh@kernel.org" , "sdf@fomichev.me" , "haoluo@google.com" , "jolsa@kernel.org" , "jgg@ziepe.ca" , "jhubbard@nvidia.com" , "peterx@redhat.com" , "jannh@google.com" , "pfalcato@suse.de" , "shuah@kernel.org" , "riel@surriel.com" , "baohua@kernel.org" , "ryan.roberts@arm.com" , "jgross@suse.com" , "yu-cheng.yu@intel.com" , "kas@kernel.org" , "coxu@redhat.com" , "kevin.brodsky@arm.com" , "ackerleytng@google.com" , "maobibo@loongson.cn" , "prsampat@amd.com" , "mlevitsk@redhat.com" , "isaku.yamahata@intel.com" , "jmattson@google.com" , "jthoughton@google.com" , "linux-arm-kernel@lists.infradead.org" , "vannapurve@google.com" , "jackmanb@google.com" , "aneesh.kumar@kernel.org" , "patrick.roy@linux.dev" , "Thomson, Jack" , "Itazuri, Takahiro" , "Manwaring, Derek" , "Cali, Marco" References: <20251205165743.9341-1-kalyazin@amazon.com> <20251205165743.9341-2-kalyazin@amazon.com> From: Dave Hansen Content-Language: en-US Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <20251205165743.9341-2-kalyazin@amazon.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: eh99dosos5epx47ywzba6iaaiu3u4q7k X-Rspam-User: X-Rspamd-Queue-Id: 51E2C40004 X-Rspamd-Server: rspam01 X-HE-Tag: 1764955620-17567 X-HE-Meta: U2FsdGVkX1+QYjn1iNx7YX3AeYsfN2m8+YOiu/YoSJNGyEt9vQhwbZMqaT0Rb6SSwnjqk5dGyTjvUmsCUanuVwsR5BhkPRyCKuhV9sxF8ukkFDfM6CZ99BARgbvHbvwJH7DJrYU+9z/keKJNuTExKUP0Jhq9Apu8bcduH5CwmEPIDjd1ceBmsEnrcGr2/jQQH4aws0tvGH3HIq+OMLD3FWjrHMOjjHvSj+M8nA7Dvm/zGxovVLLqT8RSKOEu3WDDvFEBuMAWp06T+S7drVkRUdzv758es3Kg179tAOjp7zQEEAFOAq/a4wJaj0Dsc+thHK/5fkgCQQTYSUU67DkwKJ3ynFkpN2CoHBHY1AqE+3fgFtxoIIyAQA2IvHAT5oI1pYc9VAKrbMLyNnh6m1TQ+YFmxoCF72iXbLdpN8A4KqYSQ4Bx36l7SQ+wVfs8EXaHrp8ZeDcARemhyZO9UFJjn/zgu+8eFp7MSr/ALFr39mnjiS4GlH7y1Ax+W01P/a5d7s45iAIRsr4IQNoNELDnIsJMe6fe0Of3ryBpX1LoLT/+1WMOipxoUyAgDSRMp7GUKFCbndyt5D7SqCJJ7x/Rq2Kv0VTyGl6oWyJwPWoYVrhNK3WqA/YlnGNZs8s3okwD94yShtdy/x7KW+iH4XGqRfIkf6kj4MNyA7WlZOg4zfkganAJVZLZ51gni4VilJSW8M8RtIJXruvWyEhrjOlncIEx+UrpAUccg4gVhar9X52snPc3wjgnm9hNwtBRcgVan56W85WqLR9ZeNvk4WdH/xabdg2qtRvgEVAJrcZBSNfXfRsNioHq/s34+Gp2oGDHgqDv+DS8EZgnPes4ci6NjUgODbCtt8a62RRLKQudgWMhpDtdAO2pxUfa8yyZ36V8LO2ezwukRop52LxQcttm3b3+3MCG8gttVxXrynBVnFcDTyGYfFET7KWKvMBZDMWCx3ru5Lp1ElJ2KeS8c7+ XFE+AqHK fxfISqViEbhshJ3b6CNI6VFKc9/UPyD2C2Ceiwen/G5sIPaAhoxMhBdGlE8+lhbsA+a1Y X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12/5/25 08:57, Kalyazin, Nikita wrote: ... > +EXPORT_SYMBOL_FOR_MODULES(set_direct_map_valid_noflush, "kvm"); I think this export is a bad idea. The interface is abhorrent enough, but exporting it just invites abuse and bugs. I think what this really needs is a pair of helpers that are just: folio_zap_direct_map() and folio_restore_direct_map() that take a folio. *Those* can get exported to modules and those should internally flush the TLB and not expect callers to do it.