From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E4EAE7718B for ; Fri, 20 Dec 2024 14:49:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9E43E6B0089; Fri, 20 Dec 2024 09:49:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 994DC6B008A; Fri, 20 Dec 2024 09:49:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 80E576B008C; Fri, 20 Dec 2024 09:49:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 5F50C6B0089 for ; Fri, 20 Dec 2024 09:49:50 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 10F26AF6DB for ; Fri, 20 Dec 2024 14:49:50 +0000 (UTC) X-FDA: 82915620396.07.426B021 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf15.hostedemail.com (Postfix) with ESMTP id 94B0BA0003 for ; Fri, 20 Dec 2024 14:48:54 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="fuBvznN/"; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734706172; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HK5E/SdnNISM/lzZXdoGhlirZfJ/48n3KlMXZ2+P1dY=; b=gfp184D/AkrK+fbxZrWcZ8hJuH3VR349LvXUedoOuKMy0PtMZXk6cl9J+xFvq+d6TG4IZZ aj1G/l7ZW4ZFKFBq+i/un/oRqSKcGkP3ue2v4MtX32Q5bGvoKt81WkCgUZpV6swpLa5d5N soaXNsyI65PvGZfJbFY958osay8XDls= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="fuBvznN/"; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734706172; a=rsa-sha256; cv=none; b=ClPaXNcxiPfAOSiaKqEq4F/YhryMClpwaqLQJTBIO7fnJ6SIr+JsHsWqOpGEnQ3TiSkog1 /LPrBRNserlPjy1JCVdm5BEHYud1UE1H9aL8pR4sCQqpjqcqnPu/VTVaKm4Wd6AgtZ2GVi omwj7vtJ4ZychQvCGLa7UNYwsJ3EQdc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1734706186; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=HK5E/SdnNISM/lzZXdoGhlirZfJ/48n3KlMXZ2+P1dY=; b=fuBvznN/w9dtVPQoicgiJenItKyL7b3qz7tOzzqyasL78MJyn4t55FJmFEjC7RzQqK+nQG NflhSjXTAIo0A4leQFMeWI7AB6yEO8QPmCZHUBO9eE+nJ+sHFDpvRk8jgpeJm6GZ1rIk2W Uol+FEnC+VT8dBzwKfYowzzNsKOwY2A= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-262-lhJ0mTOQM6KMpwYfRDBLxA-1; Fri, 20 Dec 2024 09:49:45 -0500 X-MC-Unique: lhJ0mTOQM6KMpwYfRDBLxA-1 X-Mimecast-MFC-AGG-ID: lhJ0mTOQM6KMpwYfRDBLxA Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4361ac607b6so17359125e9.0 for ; Fri, 20 Dec 2024 06:49:43 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734706183; x=1735310983; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=HK5E/SdnNISM/lzZXdoGhlirZfJ/48n3KlMXZ2+P1dY=; b=L1rQ8DlHpA1qokvxw9j2aeDxhWa7iWpA4V7bGY1btHD+Qn5mU2Z9Xg0Hw+bEUekKa0 9+9Xt/uf6zo0/shoUz195Z3osutVPO7blgRPh6zraBkMK19Edc9OIDcVPijHgrXITJK+ hbRg6YD71/r2hzFjznhebuGOrAnjd4zFkFx9sDSr9yBlCTydZ8BoPyXbQKBXip1u4QF0 MENdTEeg37xSUkfZoUutROeFn2pW+rz8SN8/ASglpy5AXTHoMUsj197IhwHU8RPANsSA UiRlYmsfisXe0OhzS82hFKzmjP4q96WXlnARh7DRtXeHVS/77aRxh1gqzUAaxO/5IC9i 7tmw== X-Forwarded-Encrypted: i=1; AJvYcCWgfI7QftG5OjYP1vd1srQ90ysskV1UOi8SHko7AToLE4cF1L4iTBYKO4k0QopwYBcGUAcSRyKzww==@kvack.org X-Gm-Message-State: AOJu0Ywg/ha4fPbGxX5rtdbWiEcnaqxQ7pI8QZv2RxHAQlVcsLwxXRzU pLWtrcjgJZrMGryh64bSxH0ga7qtfaM1DWl6Dun2BNsSPOC5ezbPybPxGSRTxHtfmkj7mFRy/K3 HldgVurYSMV/fc48OiRVoqjO61mgcCktgthcYJEbTpXZN0lkK X-Gm-Gg: ASbGncvl85RRJKzVLRXp4HTJl/bb1aWw89/c/6CzQ/CRk65Qhk4gxVobXY62WwVKxHd UQsPHJSW8mSYB9FAcr+1Yjq1gV3Ed86lrJ/1+F1BiG7JZ1nF8oCV/H2yrWHU+9ZvHG2MlcmJPqv 8MW2S5DBw74TIo+1RgSVUOVCuH/sTD8RXMWObn6D3uCDSX9IJglxz3LjQu0W6O15wDsXS/9nK9k edIqk4DDZPSfvNr712CrMBbTtEJEwfcnCpbWtvl0x3pYV9bnZTGZtztF4zt9Hh2tp4SZhwUEbJ5 a6Z3TaoMmBYmXPLSU+4K2/TtPuxCbQIVe5D63ycRWLNgX7RKo5wWGLMX4FkFusORSBiGBRlXPqb HN7GPydxT X-Received: by 2002:a05:6000:4b0b:b0:386:37f5:99e7 with SMTP id ffacd0b85a97d-38a22201897mr3476709f8f.33.1734706182783; Fri, 20 Dec 2024 06:49:42 -0800 (PST) X-Google-Smtp-Source: AGHT+IFTVGz8S78H2tYQeT79FCS/JtBxgzUgnpDemzmSMVJWI71SmGeE4g9J9ThG5UuekeAgxgIrTg== X-Received: by 2002:a05:6000:4b0b:b0:386:37f5:99e7 with SMTP id ffacd0b85a97d-38a22201897mr3476680f8f.33.1734706182396; Fri, 20 Dec 2024 06:49:42 -0800 (PST) Received: from ?IPV6:2003:cb:c708:9d00:edd9:835b:4bfb:2ce3? (p200300cbc7089d00edd9835b4bfb2ce3.dip0.t-ipconnect.de. [2003:cb:c708:9d00:edd9:835b:4bfb:2ce3]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a1c8330e0sm4165079f8f.34.2024.12.20.06.49.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Dec 2024 06:49:41 -0800 (PST) Message-ID: <9404aaa2-4fc2-4b8b-8f95-5604c54c162a@redhat.com> Date: Fri, 20 Dec 2024 15:49:39 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 4/5] mm/migrate: skip migrating folios under writeback with AS_WRITEBACK_INDETERMINATE mappings To: Bernd Schubert , Shakeel Butt , Joanne Koong Cc: Zi Yan , miklos@szeredi.hu, linux-fsdevel@vger.kernel.org, jefflexu@linux.alibaba.com, josef@toxicpanda.com, linux-mm@kvack.org, kernel-team@meta.com, Matthew Wilcox , Oscar Salvador , Michal Hocko References: <43e13556-18a4-4250-b4fe-7ab736ceba7d@redhat.com> <968d3543-d8ac-4b5a-af8e-e6921311d5cf@redhat.com> <7b6b8143-d7a4-439f-ae35-a91055f9d62a@redhat.com> <2e13a67a-0bad-4795-9ac8-ee800b704cb6@fastmail.fm> <2bph7jx4hvhxpgp77shq2j7mo4xssobhqndw5v7hdvbn43jo2w@scqly5zby7bm> <71d7ac34-a5e5-4e59-802b-33d8a4256040@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: PDoabZZbXgfJJAlUZP00vYECLecZ8tIGUaA0XdOJ2UU_1734706183 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 94B0BA0003 X-Stat-Signature: cwrazboo7xyz8nhcp69acgbxcnex4f1j X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1734706134-707634 X-HE-Meta: U2FsdGVkX1+AFXHtewPBpFOlExZ2TXtzKIwUEv+7qWwMkI6Ocpb2eV5tCgTxurnRdV3NPapjuA/zB1qQFKlrEwIkE9Rm0C6DcXtKx5+YJCLohEfN0M+oHZyxY0ZgLncfUBZhJILf4y2qdrNeaDp/5x5gVD211wrwxNMoTEM1sRF376+eoKguqqaUk5mnr64W6c8IviJ/ECu0IFRS7Un6EfrROEdNRcS2pfJB6y6jQZfqeLeLu8Oe21M3IMi+v4Pdzn3RbP2ZEGrdt9CARbgp5DP/Y/6cP+pTTth6cIBJjckmL9ORzIQw8vSPkqUYrL35jhCI26U0gK8Dz7NhFynzj7LuaILY9yXOuRsqHC4p99Ex12cZW8ChS66gHRm6m42YIYmj9vMhbIOflhF/SKl5FxB67t6ZHPAX9NePVkjSqKZPG9osqClzp5jqbU6GN3nHWuAC/R9mUUlRIxy5Bs+qmwFb3Q1KNF0EifpaMU+rg3SOGm6qwum3qRSz7TjcvkZp5qz+xIP7/TqaAISQ9eU+Kk4cV6iBQF9mDIpZHvbC331lCAs+jYCAWOmwmiBSqKRXN6vBhz/LQAMLyh5cspcslod3JT2is/q7e47k+HwZXlsxSkFyu23OC7zor5zQuKMzQ4upUMkOB0Wj50ipTdtrQ1jGt2ojxVAWt+MxbT3bXp+X1pVCMjJ/44EfSuLqs2cLiv3v7zH7IWABw+eYUVl7F1zg7i7Bc0DZJ0lYDYqazF+OzaNSq2j7NAkts3aCK84y0vSyY4aUjI8Z5rfka3XMmZGRVYdOvOChorB1/noEeUu48OLFpzWhvSoPIW31YFRM1sfERAgIkmXGmx5d7abvvcd/2ev/mtawQT9+2y07JOJhto6BXm29mVsPVNhDOTT1ifRzfMUgK3t+2hKNGm+r8oezwvU5gyYcRAOHdQX9LhbSVEUpiwI3dj49yPc7OXi5DNZ1Gt6dI0C5rE+8p5X z32Vc+N3 sC3Gi6Q0RGfDQU71QCKenRFRSdzOR7Y05fauWDH70umgt5k0Taz3qleTnKPBD19w5BLNAaXcFkCrdUFQsXjOVjg0N3aES7PSOVCdFCy7GMCOLoYV5BvmLsb9wVlHFdG7remFazCXg/AD7MKHlSXoGwOSoYHVk9918DjBuK9/USi5HJOde+7ocGwX3NphHMfb/3AoQK8yNwvl/Bsr3o9IMXcn/6BfiPdiXknGYJ+Okmq7B+G5B44HptfrWaTcAAhxxl929W3qy6aOxMKac5IEJ1xF7AbwqAK0fno95fO/dUkDlnS35hHib9V+CfRS5r3cdWnu8opgWrzWx57DeWa3kZCe0fD8HpdTFjJnqs7XD2GOwC3GpltW1ZUs00yEqRgjn9PsahkltlHo6pKLGGGxtpft0wmNrYjXJisIYgT3FOcmzx8Ir5XWr+2WzUR2Gyk5xkd5Z X-Bogosity: Ham, tests=bogofilter, spamicity=0.239057, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: >> I'm wondering if there would be a way to just "cancel" the writeback and >> mark the folio dirty again. That way it could be migrated, but not >> reclaimed. At least we could avoid the whole AS_WRITEBACK_INDETERMINATE >> thing. >> > > That is what I basically meant with short timeouts. Obviously it is not > that simple to cancel the request and to retry - it would add in quite > some complexity, if all the issues that arise can be solved at all. At least it would keep that out of core-mm. AS_WRITEBACK_INDETERMINATE really has weird smell to it ... we should try to improve such scenarios, not acknowledge and integrate them, then work around using timeouts that must be manually configured, and ca likely no be default enabled because it could hurt reasonable use cases :( Right now we clear the writeback flag immediately, indicating that data was written back, when in fact it was not written back at all. I suspect fsync() currently handles that manually already, to wait for any of the allocated pages to actually get written back by user space, so we have control over when something was *actually* written back. Similar to your proposal, I wonder if there could be a way to request fuse to "abort" a writeback request (instead of using fixed timeouts per request). Meaning, when we stumble over a folio that is under writeback on some paths, we would tell fuse to "end writeback now", or "end writeback now if it takes longer than X". Essentially hidden inside folio_wait_writeback(). When aborting a request, as I said, we would essentially "end writeback" and mark the folio as dirty again. The interesting thing is likely how to handle user space that wants to process this request right now (stuck in fuse_send_writepage() I assume?), correct? Just throwing it out there ... no expert at all on fuse ... -- Cheers, David / dhildenb