From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94D58C433FE for ; Fri, 18 Nov 2022 20:51:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F35ED8E0001; Fri, 18 Nov 2022 15:51:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EE6936B0072; Fri, 18 Nov 2022 15:51:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DAD3E8E0001; Fri, 18 Nov 2022 15:51:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id CF6BC6B0071 for ; Fri, 18 Nov 2022 15:51:40 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 7A52C161387 for ; Fri, 18 Nov 2022 20:51:40 +0000 (UTC) X-FDA: 80147759160.12.8B008A3 Received: from mail-oi1-f182.google.com (mail-oi1-f182.google.com [209.85.167.182]) by imf26.hostedemail.com (Postfix) with ESMTP id 2B31414000C for ; Fri, 18 Nov 2022 20:51:39 +0000 (UTC) Received: by mail-oi1-f182.google.com with SMTP id r76so6594790oie.13 for ; Fri, 18 Nov 2022 12:51:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=Pnv/AcibuVlHkWWrn9NvH3zq6Vm135VxzOsOFf6QZKI=; b=gFXMFOqmW0RMul/DdKfwDG62G+ABj0IB78rq9gSetzwIaS+UPKqPErjDSsiBHWUQw9 NUVnruR35lTlrjm81tpWsPTyPAKpWIF/zyxVLwCKeNsy8a9o0Eyp6ilf+oJDMBfS045a ofgKIojFLFodw32oJYhKEar3+MZ2b8NeZ6e4ewYMv1sCAbr9GHTOjNQ3t7zRUp+WbMx/ LC6a9XZo2bfdC7hOns88AaTsh+vSSBw1OidcmcH2hPXIYOjMfgb7WSOUBi8zBYAjpKAV baC7D3smbTLQEzemCPraruuTbPEQDQBJA162eh3lr9jHUvZXK07+zPdenbqM8i5J28OE pL9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Pnv/AcibuVlHkWWrn9NvH3zq6Vm135VxzOsOFf6QZKI=; b=0pVWT4FUpwJ0Dze8CwFwfEUbzvEnJTUH6nvTjeEkLo6u94SS3mkdeObh7E8gOwyTR/ zonpvznHma/40Fy9z9ER1eyTIUozIYWtZDrKzXPEh+v/8zMRgovK1dCPqN8yei99FDXx 9LQkgSdrkPlURzehRCtOMCiGH1HqKmOiEpCBI3rOGSjaRfZHu1RFLKu3s3XOzkwT6x+5 i6dijSKVk1DlbA0qxXnSTALPaAs2xGBLAkcig6aBrm9FC3fMaDKHdPPkyAb8UByy2yJ6 IXDR0Re0kT218NqJ7IhKBIxqfP8+4qlNSF4CS/8ThNPStHh5bZ+kybUeNpS0bK/LULLz z8hA== X-Gm-Message-State: ANoB5pmMhMAOZ4e49pXGINtmNSHNq6c0vzr/GqG/Wk8Zc7yNgd8n6vD4 BojzeKjbLS+Z6OLVic0S0fjACg== X-Google-Smtp-Source: AA0mqf4giCJcjJID1X3/l1Gp967DEW/pJcOXomtJhqPGBJUF6GO8tkq6sBU2omWmjQg/pQRwcqgeuQ== X-Received: by 2002:a05:6808:1d8:b0:35a:3e6f:3635 with SMTP id x24-20020a05680801d800b0035a3e6f3635mr4570376oic.63.1668804699283; Fri, 18 Nov 2022 12:51:39 -0800 (PST) Received: from ripple.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id l32-20020a0568302b2000b00661b5e95173sm2012730otv.35.2022.11.18.12.51.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Nov 2022 12:51:36 -0800 (PST) Date: Fri, 18 Nov 2022 12:51:09 -0800 (PST) From: Hugh Dickins X-X-Sender: hugh@ripple.attlocal.net To: Linus Torvalds cc: Hugh Dickins , Andrew Morton , Johannes Weiner , "Kirill A. Shutemov" , Matthew Wilcox , David Hildenbrand , Vlastimil Babka , Peter Xu , Yang Shi , John Hubbard , Mike Kravetz , Sidhartha Kumar , Muchun Song , Miaohe Lin , Naoya Horiguchi , Mina Almasry , James Houghton , Zach O'Keefe , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 0/3] mm,thp,rmap: rework the use of subpages_mapcount In-Reply-To: Message-ID: <93fa81ae-d848-58c2-9f70-27446bf9baa8@google.com> References: <5f52de70-975-e94f-f141-543765736181@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668804700; a=rsa-sha256; cv=none; b=0ineXVhnSQK7nHpWBPhQfCR9QL9571elP45Wlt+wKcrd4NqrH+h1q0kSoW0/d/HC7HmRVx xnYIC6sBQWoahYmnja7tTpNVEN/YhK+j4pB9yONfr7sW3xq1CmpQtBUP9cHlJI1RZVJoEq mEC9qXjI3+OmR2sGy1ioWx4YyahhOfI= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=gFXMFOqm; spf=pass (imf26.hostedemail.com: domain of hughd@google.com designates 209.85.167.182 as permitted sender) smtp.mailfrom=hughd@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668804700; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Pnv/AcibuVlHkWWrn9NvH3zq6Vm135VxzOsOFf6QZKI=; b=lMtnIaAWLaCN9gCyh00v6cMuFxTQNCx/G82Qo5nQcyYGhesFumRRfJXWOEktlCOni4IfKi 0M/l+xrLtsV7WXpeYP4QZCGLz5kq7ZzxhIqmAQjn/sKzjtX8rlNifUFJwI40NRxFovO/4Z VF3jeAI7yDHYV/zWNWBvTY2DIC1z7y4= X-Stat-Signature: yufpwuwqah4bjwo7izba8n1787ykdsh4 X-Rspamd-Queue-Id: 2B31414000C Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=gFXMFOqm; spf=pass (imf26.hostedemail.com: domain of hughd@google.com designates 209.85.167.182 as permitted sender) smtp.mailfrom=hughd@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1668804699-438292 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 18 Nov 2022, Linus Torvalds wrote: > On Fri, Nov 18, 2022 at 1:08 AM Hugh Dickins wrote: > > > > Linus was underwhelmed by the earlier compound mapcounts series: > > this series builds on top of it (as in next-20221117) to follow > > up on his suggestions - except rmap.c still using lock_page_memcg(), > > since I hesitate to steal the pleasure of deletion from Johannes. > > This looks good to me. Particularly 2/3 made me go "Aww, yes" but the > overall line removal stats look good too. > > That said, I only looked at the patches, and not the end result > itself. But not having the bit spin lock is, I think, a huge > improvement. Great, thanks a lot for looking through. > > I do wonder if this should be now just merged with your previous > series - it looks a bit odd how your previous series adds that > bitlock, only for it to be immediately removed. > > But if you think the logic ends up being easier to follow this way as > two separate patch series, I guess I don't care. I rather like having its evolution on record there, but that might just be my sentimentality + laziness. Kirill did a grand job of reviewing the first series: I think that, at least for now, it would be easier for people to review the changes if the two series are not recombined. But the first series has not yet graduated from mm-unstable, so if Andrew and/or Kirill also prefer to have them combined into one bit_spin_lock-less series, that I can do. (And the end result should be identical, so would not complicate Johannes's lock_page_memcg() excision.) Hugh > > And the memcg locking is entirely a separate issue, and I hope > Johannes will deal with that. > > Thanks, > Linus