From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DE7CC433F5 for ; Wed, 5 Jan 2022 18:06:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4CF9E6B0071; Wed, 5 Jan 2022 13:06:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 47E9A6B0073; Wed, 5 Jan 2022 13:06:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 31FC86B0074; Wed, 5 Jan 2022 13:06:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0194.hostedemail.com [216.40.44.194]) by kanga.kvack.org (Postfix) with ESMTP id 24A236B0071 for ; Wed, 5 Jan 2022 13:06:05 -0500 (EST) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id CB9328EC02 for ; Wed, 5 Jan 2022 18:06:04 +0000 (UTC) X-FDA: 78997012248.02.0D103E2 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf20.hostedemail.com (Postfix) with ESMTP id C22761C000E for ; Wed, 5 Jan 2022 18:05:52 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 41AB81F37C; Wed, 5 Jan 2022 18:06:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1641405961; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=I5OiMQjZ4Uly61/fN+6zYHAEm5AjhzCTIt1GIguWWqM=; b=t3VPdh2ucSv603Rp2ql0r4kTysx5rE9CN6Zoxr9YOKqg2WF9wTWUVFuIYzpeY1FBQdZX9e Nv7w9E+R6DgIy8AvUtsbCZImsVgO1qVa/vve6SHSOTue4HOeCEbSejS0Z7eSufA+ruz64N 48UWfJX1PSfY+SPoomAcQ1Cm1R8N2Kc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1641405961; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=I5OiMQjZ4Uly61/fN+6zYHAEm5AjhzCTIt1GIguWWqM=; b=4k+vL0fGmPFulqMbNIoatz7qBPfx2KN4NUUhyHXPecb62j12fqZn+CAnBswDtR6YHqzgsk x33mjxngpRIlYvAg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1F45413C03; Wed, 5 Jan 2022 18:06:01 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id X9fEBgne1WEBNQAAMHmgww (envelope-from ); Wed, 05 Jan 2022 18:06:01 +0000 Message-ID: <93d5a50c-ad26-f37e-1863-b9635c5cd41f@suse.cz> Date: Wed, 5 Jan 2022 19:06:00 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.1 Subject: Re: [PATCH] mm: Make SLAB_MERGE_DEFAULT depend on SL[AU]B Content-Language: en-US To: Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org Cc: akpm@linux-foundation.org, cl@linux.com, rientjes@google.com, iamjoonsoo.kim@lge.com, penberg@kernel.org References: <20211225060921.13584-1-42.hyeyoo@gmail.com> From: Vlastimil Babka In-Reply-To: <20211225060921.13584-1-42.hyeyoo@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: 4u8kk5wcc75gim14bhzauc6mtbexgatb X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: C22761C000E Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=t3VPdh2u; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=4k+vL0fG; spf=pass (imf20.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none X-HE-Tag: 1641405952-566386 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 12/25/21 07:09, Hyeonggon Yoo wrote: > SLOB always manage objects of different caches in same page regardless of > SLAB_MERGE_DEFAULT. Because it has no effect on SLOB, make it depend on > SLAB || SLUB. > > Signed-off-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> Reviewed-by: Vlastimil Babka I will take this to the slab tree, thanks! > --- > init/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/init/Kconfig b/init/Kconfig > index 4b7bac10c72d..03e1b863f5ce 100644 > --- a/init/Kconfig > +++ b/init/Kconfig > @@ -1933,6 +1933,7 @@ endchoice > config SLAB_MERGE_DEFAULT > bool "Allow slab caches to be merged" > default y > + depends on SLAB || SLUB > help > For reduced kernel memory fragmentation, slab caches can be > merged when they share the same size and other characteristics.