From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB37BC6FD19 for ; Mon, 13 Mar 2023 16:36:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5110C6B0075; Mon, 13 Mar 2023 12:36:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4C22A6B0078; Mon, 13 Mar 2023 12:36:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3619A6B007B; Mon, 13 Mar 2023 12:36:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 208886B0075 for ; Mon, 13 Mar 2023 12:36:50 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id EF9D280D2F for ; Mon, 13 Mar 2023 16:36:49 +0000 (UTC) X-FDA: 80564428938.30.D2334CE Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf18.hostedemail.com (Postfix) with ESMTP id 3E7451C0008 for ; Mon, 13 Mar 2023 16:36:45 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=j6iQskk8; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=ioRERLVv; spf=pass (imf18.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678725406; a=rsa-sha256; cv=none; b=nVDP3N9dVRxRX+AjCLJrSgA/g2N0gDNCKwfdUPYGMTCc1SkvawTSSDMWhHkkRIR89QBo9/ CfUcMHY9CTQkgSEOzyR69QzvX4KbCXS/ZoKc1zPQbMUY1qBItVn+gRTj/80dAlIoMkDIVA K1JNBOdx2wXMFvVsFL5iR0rgi1lwJj8= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=j6iQskk8; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=ioRERLVv; spf=pass (imf18.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678725406; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DX7mBzmKKfcM2HuODm/+5FefEjTjA8Vp+Q98rewow2A=; b=S6M1lj1aTbQXxQUcT7JFmv0xZr4xW7NtId3I3n5na7y9u4oVS4pIHK/jGnTF8GBXjh5O6G gIjf4U1rbwDwqQle+rM1AhuSusID8giI+uYadx7hRlcgAnDYKjmUd2JtefTwfKIrfR3Kf1 1TejlKOD+P3Qsw6cI3siyNnen4Xwl0Q= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id D2B3F20676; Mon, 13 Mar 2023 16:36:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1678725404; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DX7mBzmKKfcM2HuODm/+5FefEjTjA8Vp+Q98rewow2A=; b=j6iQskk8H7diMVNHczY1aV7fkHvRKIwG3bc4Kl9ZbUa+tRDnYLj3RnaHy5sYnzAxw0m3jv M9mVV3eFteDgDImzzbZ+q/TAcIKDKLStcl+drfaTughWYkObovtRaMW30Q1HYD0ff8PxO4 nQrGIT6UCrRa90UneiNISQqL/jWFkWw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1678725404; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DX7mBzmKKfcM2HuODm/+5FefEjTjA8Vp+Q98rewow2A=; b=ioRERLVvqvnqO1qwwQLGqTJRVb3O7tnPx8P0djrxd8iO49bdlnmG5SmCwmrQRiABU/fZ8b 7scvi92G6gdXmvBA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 662B013517; Mon, 13 Mar 2023 16:36:44 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id yp4tGBxRD2ShFAAAMHmgww (envelope-from ); Mon, 13 Mar 2023 16:36:44 +0000 Message-ID: <93d33f35-fc5e-3ab2-1ac0-891f018b4b06@suse.cz> Date: Mon, 13 Mar 2023 17:36:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 0/7] remove SLOB and allow kfree() with kmem_cache_alloc() Content-Language: en-US To: Mike Rapoport Cc: Christoph Lameter , David Rientjes , Joonsoo Kim , Pekka Enberg , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Roman Gushchin , Andrew Morton , linux-mm@kvack.org, rcu@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, patches@lists.linux.dev, netdev@vger.kernel.org, linux-doc@vger.kernel.org, "David S. Miller" , Eric Dumazet , Frederic Weisbecker , Jakub Kicinski , Joel Fernandes , Jonathan Corbet , Josh Triplett , Lai Jiangshan , Mathieu Desnoyers , Mike Rapoport , Neeraj Upadhyay , Paolo Abeni , "Paul E. McKenney" , Steven Rostedt References: <20230310103210.22372-1-vbabka@suse.cz> From: Vlastimil Babka In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 3E7451C0008 X-Rspamd-Server: rspam01 X-Stat-Signature: af4boaygwiqeibfwidqss31w943u94an X-HE-Tag: 1678725405-800101 X-HE-Meta: U2FsdGVkX18kJMNxxAx9wgHojOPQNFJir8pQo7Cg8KHofXJgi0cXi0fKB+fVmfn/F57amTtIEuUnNNJx0eY63O0rClXoLEUfNRDzvOp46xBPjo9iU7Sl9HCYEGi/u2+UqkDjMZUkLmO8kct3ofuYEBebddcHc5qi3YuZtqM8thF1X+fxvqxrXkO1Mw8IrqSO6O8NB9lIPkVtsHDU5hkYqcsC65W6mtIga7RvV2/Eajf9YzCt+s+B59Xk4PtGUgfYgVYlRpW+tHJLBcvckDzuooPQDP/wc4lMJD1LQFPL16ZE11ADTVc2W3l7iUrzhavxwb6tZz7CH+5FChzVRcsxanud1rNTAfwUzEnEkg0aZNOWNq0A07v9IOa4ATk5KSsPoqzMOOToJzB+/igEKvwTGTFYRL8+vBhmnDM3N3adF10Yw9yFB5dbR+etxs5wKvHKEZAb220AkyWg9AEHE1En+e9k2+BWW/hyv3y72Zogh8SkVgwLFmZlmL1UD759VtpqTIXTv2VmzRRb7/HRGUaPDbDKAHL4Cnx6cn2qrJHaV/6f2Q8Roh+nMzIqgAywe7lEjXcbXqns29BUVNqDsydYkwdsIBoSOXCyieH1MaYwfL/JUHIduHaBWhyAGgtW3mJg2BXaPhIpdKxDW+uXlk0CqB/C1AqBk0kQ9kzUFB5Azz6ipXPM2Uvsm8FBArNRtbBPnHHXA0TpTW8kEbt2z1ZuHnmTEdiSziscKXrBH/OTHWe1WC3PAJ2OTuTaQPAa+YuijBj3LwW3G9YXGQzOY5uxfGbAV/DWvrNEsRnGoiuAM5xW4wYPIN+LN5sZOPd+fD3RIiHoNWMSe2LH9oaADpHeCFc12ZKsMox+Q58EAkU6Lm/VL5a7b7YXOoVtE1mtmrhjz+2AHKt/Q5MgLmyzbPP7k57r0R8cEQa3YLv76qbaVx7+1jO2RjYEFmT10PTnwKCWDHOk1Q8zFvrZHHgZlLO bf8NWUw3 z4lyPbrMG8TU120DVGisc70JybmWLKrBgVmi2n0z7K3j42J3O7UEv9BdkV18rjaqtkQxZ7J4NpBN74bdz2reH6pX9JcVbdaOkRXSt1/mhu0y1P7+fcNrf+7TzA+mSpbrPrsF8fH7dmMOOSClAgkgRz4aCXDS4U2JZFLyZWuS2rRCn9QYhioFtFJsXMFVSNcGVY/iHrOqMSR/bP8tIFzvRZtqCKIvKM0OxM87o+jpaC0npiyeiF0rDY9su51vX8h9zYnnVm5eGOq3c4cCj7FPXIaNAFCDJ+CW427vTQ+kyj2X4gCc5b1VC/xfVR9Uj7ZsON+YFhUR1OqX02YyTEaYtTu98RZ9epbWfytFBDBw1TDEsNkUAuB9yMXpiIzWf/GbT/sH4zXz8PWt6kxU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/12/23 10:51, Mike Rapoport wrote: > Hi Vlastimil, > > On Fri, Mar 10, 2023 at 11:32:02AM +0100, Vlastimil Babka wrote: >> Also in git: >> https://git.kernel.org/vbabka/h/slab-remove-slob-v1r1 >> >> The SLOB allocator was deprecated in 6.2 so I think we can start >> exposing the complete removal in for-next and aim at 6.4 if there are no >> complaints. >> >> Besides code cleanup, the main immediate benefit will be allowing >> kfree() family of function to work on kmem_cache_alloc() objects (Patch >> 7), which was incompatible with SLOB. >> >> This includes kfree_rcu() so I've updated the comment there to remove >> the mention of potential future addition of kmem_cache_free_rcu() as >> there should be no need for that now. >> >> Otherwise it's straightforward. Patch 2 is a cleanup in net area, that I >> can either handle in slab tree or submit in net after SLOB is removed. >> Another cleanup in tomoyo is already in the tomoyo tree as that didn't >> need to wait until SLOB removal. >> >> Vlastimil Babka (7): >> mm/slob: remove CONFIG_SLOB >> net: skbuff: remove SLOB-specific ifdefs >> mm, page_flags: remove PG_slob_free >> mm, pagemap: remove SLOB and SLQB from comments and documentation >> mm/slab: remove CONFIG_SLOB code from slab common code >> mm/slob: remove slob.c >> mm/slab: document kfree() as allowed for kmem_cache_alloc() objects >> >> Documentation/admin-guide/mm/pagemap.rst | 6 +- >> Documentation/core-api/memory-allocation.rst | 15 +- >> fs/proc/page.c | 5 +- >> include/linux/page-flags.h | 4 - >> include/linux/rcupdate.h | 6 +- >> include/linux/slab.h | 39 - >> init/Kconfig | 2 +- >> kernel/configs/tiny.config | 1 - >> mm/Kconfig | 22 - >> mm/Makefile | 1 - >> mm/slab.h | 61 -- >> mm/slab_common.c | 7 +- >> mm/slob.c | 757 ------------------- >> net/core/skbuff.c | 16 - >> tools/mm/page-types.c | 6 +- >> 15 files changed, 23 insertions(+), 925 deletions(-) >> delete mode 100644 mm/slob.c > > git grep -in slob still gives a couple of matches. I've dropped the > irrelevant ones it it left me with these: > > CREDITS:14:D: SLOB slab allocator I think it wouldn't be fair to remove that one as it's a historical record of some sort? > kernel/trace/ring_buffer.c:358: * Also stolen from mm/slob.c. Thanks to Mathieu Desnoyers for pointing > mm/Kconfig:251: SLOB allocator and is not recommended for systems with more than Yeah that's a help text for SLUB_TINY which can still help those who migrate from SLOB. > mm/Makefile:25:KCOV_INSTRUMENT_slob.o := n That one I will remove, thanks! > Except the comment in kernel/trace/ring_buffer.c all are trivial. > > As for the comment in ring_buffer.c, it looks completely irrelevant at this > point. > > @Steve? > >> -- >> 2.39.2 >> >