From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5145C3DA4A for ; Thu, 8 Aug 2024 20:45:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 474F86B0095; Thu, 8 Aug 2024 16:45:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 424486B0098; Thu, 8 Aug 2024 16:45:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2D0A16B009A; Thu, 8 Aug 2024 16:45:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 0F22A6B0095 for ; Thu, 8 Aug 2024 16:45:23 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 85621160AD5 for ; Thu, 8 Aug 2024 20:45:22 +0000 (UTC) X-FDA: 82430258484.06.536436F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf28.hostedemail.com (Postfix) with ESMTP id 35E85C0028 for ; Thu, 8 Aug 2024 20:45:20 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Umw8O1jy; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723149888; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=18Rl4NkZJ/Sn5IqfxlHmzBxDnMO4mtO2wKlwMeZkH2Q=; b=qjNtiJW7Z53n6pe5pqWU/RP/NzJSZtdRyXBtQ+8QPC+10YUYpEOM5vUHr+vnNb9+RgajzK pLR+LsHM084pGtj2IhR738zPXwG8fJ6X1K9TgdqrdZV+ZDozYKuzSDlSmD1e5DBltc6lNQ LamiKCltAllytA2Bu/C0gywBj7eCBRY= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Umw8O1jy; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723149888; a=rsa-sha256; cv=none; b=Gmk/OyQy31q8bjydBeCxBIDmSRsl6krQmGJ3zAPsOwKZUoi4rvPDqZmo94EdgKpSuykENE 4heFkV5T2IqSXuXxKRbwPp5n5yxFeVZ4IJYaZohzDzD44ugkANQP11L9L4XEAXqxb3WArN IOUl/rcJD7ZOeYAdPd3BKJojckUo90k= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1723149919; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=18Rl4NkZJ/Sn5IqfxlHmzBxDnMO4mtO2wKlwMeZkH2Q=; b=Umw8O1jyp3RRhTae3+IVJMu0pj6GC99wyEmtoemyf5NF36IuO21stTE/Xm8ay8F9cHZmYG Fk2G/UUHY5xS3iGEqi3VHJvD/OHEKn3LY3g0/xTY4XZ7TNEEQcXuNgotbGJw693HZlGsgb 0nSHyxD6B8JKpvRWKbFW0BqInI4kiKY= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-464-w_jWaJl6Pvm5qnJGPeko-A-1; Thu, 08 Aug 2024 16:45:15 -0400 X-MC-Unique: w_jWaJl6Pvm5qnJGPeko-A-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-36848f30d39so761806f8f.3 for ; Thu, 08 Aug 2024 13:45:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723149914; x=1723754714; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=18Rl4NkZJ/Sn5IqfxlHmzBxDnMO4mtO2wKlwMeZkH2Q=; b=E8Z78aLuoNifg3cVzcpklkTgKVguWGioRqQCLen+w57cFHqIP03SvfuD8e8dlE1PNo Ldj2CV6b37xPOds3zuBbeBZn6q+ryg8NwmFHkKtd5M80QCCk7BFpDM46QAxVhMjaYHYb /KlkuBHy2TgK/xO254zGLgqBF9d5W9ktWodRjgY2smt8//j8kaH8Tpjtg0rc/V1mRoD0 8YwOno4WRN66fTCyMisvthiVL9sPciikpvjfee4razTo49Zxw5vfLMKgXnjBBX3tl9HU LpadYfMNewOZwTgQ3o5jVgb1YEGiPx/lPaC5SnDV56clOZXv+ISVIdpy9nP3DwwUNmPJ iseA== X-Forwarded-Encrypted: i=1; AJvYcCXCRx4dCvH7WOG9QgWD0u/WjnaF9c6nb/Y52Ogg+ju4EJ2oSjW2gGHvnl9cahaxdX8+NuvEpypjJQ==@kvack.org X-Gm-Message-State: AOJu0Yxcc5V2KF/wtAYqSoqslK1QTU8D99BGIgdvJ0OzB784QTW0gajV x64rNdV+Tk1nKlv2TtxCkWS0pDC9Eg+fZ+pYj/JZ8gXEt66SdZubViLjByh6amrejMIaZk0VHSY dHrIY18U11h6g7qyoKI2nKLw3Xl4U13z/7tfsrsMa9ozG/j1S X-Received: by 2002:a05:6000:1843:b0:360:791c:aff2 with SMTP id ffacd0b85a97d-36d275663acmr2629362f8f.47.1723149914615; Thu, 08 Aug 2024 13:45:14 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHSNcY6csiIyW/jq0jTa3ofS8OTkmMsPtIX7Q3oQh+KW6006/qHEu9nQT+rhEGN3BsWo3C6pQ== X-Received: by 2002:a05:6000:1843:b0:360:791c:aff2 with SMTP id ffacd0b85a97d-36d275663acmr2629345f8f.47.1723149914075; Thu, 08 Aug 2024 13:45:14 -0700 (PDT) Received: from ?IPV6:2003:cb:c713:2a00:f151:50f1:7164:32e6? (p200300cbc7132a00f15150f1716432e6.dip0.t-ipconnect.de. [2003:cb:c713:2a00:f151:50f1:7164:32e6]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-36d2716cb01sm3050623f8f.36.2024.08.08.13.45.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Aug 2024 13:45:13 -0700 (PDT) Message-ID: <93cbdc09-8c21-483f-a6a0-f70ed676ec2a@redhat.com> Date: Thu, 8 Aug 2024 22:45:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 5/7] mm/x86: arch_check_zapped_pud() To: Peter Xu , Thomas Gleixner Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, "Aneesh Kumar K . V" , Michael Ellerman , Oscar Salvador , Dan Williams , James Houghton , Matthew Wilcox , Nicholas Piggin , Rik van Riel , Dave Jiang , Andrew Morton , x86@kernel.org, Ingo Molnar , Rick P Edgecombe , "Kirill A . Shutemov" , linuxppc-dev@lists.ozlabs.org, Mel Gorman , Hugh Dickins , Borislav Petkov , Vlastimil Babka , Dave Hansen , Christophe Leroy , Huang Ying References: <20240807194812.819412-1-peterx@redhat.com> <20240807194812.819412-6-peterx@redhat.com> <878qx80xy8.ffs@tglx> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 35E85C0028 X-Stat-Signature: zb1jkr5f4s5ujyhf4o1wchetbfagfjn4 X-HE-Tag: 1723149920-642000 X-HE-Meta: U2FsdGVkX186eJDz+DB9R8NAkG77ri0S6++qbAm5nQe+4OdoG2i6Bn7aJ40bRvEObIuimjKjgSXW9BH4IrAMSOHR67yVFhDNOsy7bPXZ0BhNCAHczwntmixRwKnZBOlKjGgl+FzgsbndZKCVOYjuAGZvynb9+6Xr2FJfeKHltdvCJ+p5pcgUOfVuYHtASG4qxDvb5JewmBBXR2aFIn96VVONO9FGKrnQfcfbAHH2D6212f6Azlo0up4qth5gGWGlTO81j0T4GhzvZrX+wLPPQ2oTSIJ6ohDFdNnFVveRnc4PTNXAz98DL9bD1Fe4FMhM4xrRayTtMD4xAUnpl5REsJZY0T9/x1oYFqedtmbVP/2Ejb3QA8YQzCrAbgEmXepJoK6cW4EOtQqMZWjpqkOkahYbNAdna9iGCkgU4ui7yLkngr+b7Opadgf1NzRv1vjbat8VCPtZ4xnsnz9Kr4vhoSkbJXK7nKeG2rhTeg57nGlLiRx/eJD08Xw/G36KMLnu9MCVRBslKwdvUXOQfZoPjLgR8fqhrv0h44eYYkvoq97S0m6/JwU2GNW+b1rEbKUZabEmxFOAkMzSbq54PNrRrrOhBMPJT6W9IGYycPKnucFER66kGKyM5gsxdvKuqn4ZEYn+MVkwi1CvYcS9mETfv7OqIoVr8qwoeOS1Pp1SmJK3X4GmzJ4ql4VICGIFchNcWRVGbYHI3LG+BQqI/9F/3hAmoChDJ2u57OdXX6vOocq40HQKUJAxrQwq8yD7wUZz9IkJxGmUN7qQnUy7N31nWUJbqoj+esDrR41QVjLllLCBwHBa65irXfbAvyJ7NWcliLMkkIwrfLUyLJI+iPdbU+rGp//4BVagt6JBPxx3e43VBiIzTj8Y1B+AeRnpvkqEH3WMMn0YeLOe3QOt/9tHy3FRHQerWihyR5dR/gz9hyTXFpSOVmtMutbu1c09WYzhKS7y53fz+woYYiUEnJk xGa6ALtW hZiWlqJDNwwc1VXHUQk8hhApw3Uhsz1sBmA6tCqSw3qBnblnwGVCysPtpMG1pyuxR2PD/v8XECBScHYRZ0qI/nBC4EYFzVzHiYXNxNWw+ZcWtmfwE4P422EKZPQnGRAVHCc6SXijfa2ISJW4YhTPj3CUx3ovFYLPk5iTP5Gm3tGXDK1AierZN26RcsqK3rMiKn3XGfbulgARrrfeOlcTK5WptYOs3w37+hZPpEXdS7wNNVkDvYu67GkOj/o256+cpzFGb2QJo3dTWpGdfirPFbYeoAX2uUH4uU5eQ498qLTU2HJVxZJHi9H4hehR7Ijsdr0OJ7+9H5HZVwx6AWmd4Mt60Fc4uBe64sXFKRBboliXKyU7r0vl3BSH6Tb/ZeOYb2HD1n8qA55yl/+ZTeJOxPmOjots0lHE1FZdDtyuY0zD01WM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: >>> +void arch_check_zapped_pud(struct vm_area_struct *vma, pud_t pud) >>> +{ >>> + /* See note in arch_check_zapped_pte() */ >>> + VM_WARN_ON_ONCE(!(vma->vm_flags & VM_SHADOW_STACK) && >>> + pud_shstk(pud)); >> >> Please get rid of the line break. You have 100 characters. > > Coding-style.rst still tells me 80 here: > > The preferred limit on the length of a single line is 80 columns. > > Statements longer than 80 columns should be broken into sensible chunks, > unless exceeding 80 columns significantly increases readability and does > not hide information. > > Maybe this just changed very recently so even not in mm-unstable? > > I'll fix the two line-wrap in this patch anyway, as I figured these two > cases even didn't hit 80.. probably because I used fill-column=75 locally.. > > But still I'll probably need to figure it out for other spots. Please help > me to justify. My interpretation is (the doc is not completely clear to me as well, but checkpatch.pl hardcodes the max_line_length=100) that we can happily use up to 100 chars. I also tend to stay within 80 chars, unless really reasonable. Years of Linux kernel hacking really taught my inner self to not do it. Here I would agree that having the VM_WARN_ON_ONCE in a single would aid readability. An example where 100 chars are likely a bad idea would be when nesting that deeply such that most lines start exceeding 80 chars. We should rather fix the code then -- like the coding style spells out :) -- Cheers, David / dhildenb