From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46F85C433FE for ; Thu, 10 Mar 2022 15:12:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5F36F8D0002; Thu, 10 Mar 2022 10:12:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5A3998D0001; Thu, 10 Mar 2022 10:12:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 492068D0002; Thu, 10 Mar 2022 10:12:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0060.hostedemail.com [216.40.44.60]) by kanga.kvack.org (Postfix) with ESMTP id 3661A8D0001 for ; Thu, 10 Mar 2022 10:12:44 -0500 (EST) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id E1D118249980 for ; Thu, 10 Mar 2022 15:12:43 +0000 (UTC) X-FDA: 79228818606.17.C56A742 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf21.hostedemail.com (Postfix) with ESMTP id 699EE1C0019 for ; Thu, 10 Mar 2022 15:12:43 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8E8E2617D4; Thu, 10 Mar 2022 15:12:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 68071C340E8; Thu, 10 Mar 2022 15:12:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1646925162; bh=BFUvHwTN60WXxxeKnuWJBjn5mWAczCXKRCLX4Mj4DdU=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=CADrilld+RtO3AawOXFDK94n8bj6zDwAh0S0DrVRBCI34uKGpOMlYx3HniUc00KYz lg+euVVep+yREGi2X0a8vfjmQhFiDfihzNy8sgO1eJ4e3X6v3BFqBzrxMW/Hpwq6ZV 5XBlJ8H4KAsWLnphefRjevcXNI5bkH+Q/wQ6zriLOtMFPh7hDPxlDDxcusHNu6ybOV PrQbpW1SZy9HR/Q2/NO1TYFeiik0SVM9WGMkDYLgoYG6ibcQ6z4Oezk6PaQdjhcUky yLymfOAxeF0hEQTtB9Hc1tbr3sblIH7oG0K526fu81ljrIB41L+0HRn67a5MNHh30C H4RVFRaplkHIA== Message-ID: <93bb0a79331882df8ce2bf704b3d4ac28c8cbc3d.camel@kernel.org> Subject: Re: [linux-next:master 4605/11713] kernel/trace/trace_events_synth.c:65:9: warning: 'strncpy' specified bound depends on the length of the source argument From: Tom Zanussi To: kernel test robot Cc: kbuild-all@lists.01.org, Linux Memory Management List , "Steven Rostedt (Google)" Date: Thu, 10 Mar 2022 09:12:39 -0600 In-Reply-To: <202203092349.i2I1pdlw-lkp@intel.com> References: <202203092349.i2I1pdlw-lkp@intel.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam10 X-Rspam-User: X-Stat-Signature: u1idxzgjb9penewnjs5h9cn7n7jtnpgj Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=CADrilld; spf=pass (imf21.hostedemail.com: domain of zanussi@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=zanussi@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Rspamd-Queue-Id: 699EE1C0019 X-HE-Tag: 1646925163-877373 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 2022-03-09 at 23:48 +0800, kernel test robot wrote: > Hi Tom, > > FYI, the error/warning still remains. > > Thanks, the patch below fixes it. I'll submit to lkml, but not sure whether to submit the fix or resubmit the original patch... Tom [PATCH] tracing: Fix strncpy warning in trace_events_synth.c 0-day reported the strncpy error below: ../kernel/trace/trace_events_synth.c: In function 'last_cmd_set': ../kernel/trace/trace_events_synth.c:65:9: warning: 'strncpy' specified bound depends on the length o\ f the source argument [-Wstringop-truncation] 65 | strncpy(last_cmd, str, strlen(str) + 1); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../kernel/trace/trace_events_synth.c:65:32: note: length computed here 65 | strncpy(last_cmd, str, strlen(str) + 1); | ^~~~~~~~~~~ There's no reason to use strncpy here, since the buffer being copied to was just allocated as strlen(str) + 1, and therefore the strcpy() of str will exactly fit, including the null terminator. Fixes: 27c888da9867 ("tracing: Remove size restriction on synthetic event cmd error logging") Reported-by: kernel test robot Signed-off-by: Tom Zanussi --- kernel/trace/trace_events_synth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/trace/trace_events_synth.c b/kernel/trace/trace_events_synth.c index fdd79e07e2fc..a133396ee29d 100644 --- a/kernel/trace/trace_events_synth.c +++ b/kernel/trace/trace_events_synth.c @@ -62,7 +62,7 @@ static void last_cmd_set(const char *str) if (!last_cmd) return; - strncpy(last_cmd, str, strlen(str) + 1); + strcpy(last_cmd, str); } static void synth_err(u8 err_type, u16 err_pos) -- 2.17.1