From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D091FC74A5B for ; Tue, 21 Mar 2023 08:00:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6FD666B0075; Tue, 21 Mar 2023 04:00:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6ADDC6B0078; Tue, 21 Mar 2023 04:00:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 59D336B007B; Tue, 21 Mar 2023 04:00:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 4CB366B0075 for ; Tue, 21 Mar 2023 04:00:08 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 1EE1E81209 for ; Tue, 21 Mar 2023 08:00:08 +0000 (UTC) X-FDA: 80592157296.28.0AC2C0E Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf24.hostedemail.com (Postfix) with ESMTP id E7CD5180004 for ; Tue, 21 Mar 2023 08:00:04 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=AO02s6uj; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=nxfG6i+E; spf=pass (imf24.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679385605; a=rsa-sha256; cv=none; b=lfB5HSSd39eENHqFPmHmsB4adChI3vm6GBoOUjW9WGrlO4dH1Abr4Tu3zbnG5mqdQGwD9r bDqTxiCOuoQ65y2wnmAATaSrSGkXslIiHwmMsQ/KcHcnUN9SNSL8hgNXBkHoxwqb8MsfTO eKsRHfU5yADrW1N7y3d3s9AUXA7poH4= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=AO02s6uj; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=nxfG6i+E; spf=pass (imf24.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679385605; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sUwEiqw/SKliyyK0F22lRGPEA7rIU5pf46IYT4psqJ8=; b=tUjyeg1k4A0q3kN3yYCgRHfIZ9glj7v0GKBskih8160Y6PUy45TXXRqWXiSkHoPI6HIfRw pTJHOVNT+Ad4D89tVu8rf1kLjiTO6j9IOWwZQZYDVrMEK0lwtaijndC0THUZZ1vOf9EKNE EhpV+PGZHaFXS8x45Wl8Wjlfz7QxrI4= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 8D78721A7C; Tue, 21 Mar 2023 08:00:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1679385603; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sUwEiqw/SKliyyK0F22lRGPEA7rIU5pf46IYT4psqJ8=; b=AO02s6ujgE27wmr4i7t4eIh7XSbBk/phGyn8LsRKqi4PjG0Tz70wgbhgtZlZF9UB9/Iwru HUjYssvFNMoGPN3nj4yxDA3NU6MwoKZqRIBOrKN7MoLiikq2pv8Wn+yKwMQnmtCyc0og09 zyKZ1FuPWC+s4bHkLOOHha1f0kMjEDk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1679385603; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sUwEiqw/SKliyyK0F22lRGPEA7rIU5pf46IYT4psqJ8=; b=nxfG6i+EiDjiMqChCtl0kgOT7OwNopMs7qj6wHESD6njKb+Z7pckCih0Ts74LL/PaLWvWh HPdFxNVafKxhPIDA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 4A59013440; Tue, 21 Mar 2023 08:00:03 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 8vpvEQNkGWTHOQAAMHmgww (envelope-from ); Tue, 21 Mar 2023 08:00:03 +0000 Message-ID: <93b37049-af7e-3408-37bf-805f633271e4@suse.cz> Date: Tue, 21 Mar 2023 09:00:03 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 06/10] perf/core: Fix MAX_ORDER usage in rb_alloc_aux_page() Content-Language: en-US To: "Kirill A. Shutemov" , Andrew Morton , Mel Gorman , David Hildenbrand Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , Adrian Hunter References: <20230315113133.11326-1-kirill.shutemov@linux.intel.com> <20230315113133.11326-7-kirill.shutemov@linux.intel.com> From: Vlastimil Babka In-Reply-To: <20230315113133.11326-7-kirill.shutemov@linux.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: E7CD5180004 X-Rspamd-Server: rspam01 X-Stat-Signature: 1si6i8fsbsr8n3j7ha8ko4y9j8k1arnu X-HE-Tag: 1679385604-60211 X-HE-Meta: U2FsdGVkX1/uy/I6rwN6XpPCV8KanbgkJGhGxApi90diKi+SDgtzPhlp3Rv2qp3HCFgubYR3Q9qVGJTYgCjvXGLVehm0SFfLSNxwHw2myKSd5rkL71/DQ7s4DwBTM/ygnUG6XyQ+C0scjch6D1X6IpGR2a8qCBFvQz0yLVDpCIkp40tsrzPUeQRiuS39DVGITuFUzjaUcww60Fn3ASLkZ3pz7R//fQipBBHEz5FlWh0vEaEOGRbBsuKnjoaxHcniIfdPoXFe9a0LKU0Qoi72RuNXakv/uyihi0i1Wz0mbh5LeJCUCp+wYCTRvbTXgzKU0nLiW/6nhMi2WqQMy211w1on9KznMumJHKLUEHdZXH0GS7Z3PHPq2bsLIhOXFTM0Xgdtu7bJaGKjx2jzmAKL9FYMTO2ZsVpbfoBmMQqpUibX29ZNSG4AuTBpNF4NyF78pUjVlbnATi5LLOUcbQwWyZ6jhNZadzsYfg7P2uhnrJP/JGNhHtG5ZgyaOWEBmvxBDVHEETGHYUNjFjl4TdGxHCwM5Kn4HY1MxuRxZ8It/32bA3AgLmNj+JgHamxotBA5TnO5cLq1vvIx83WIbISYxo5cTrGRgp62t8Iye4zFrXA3EEQ6Qhilc0h9Y6m9HPaUPUNADd2gR2SAXlN5bdEzXkRsyTRCQrDEwLD3rV991kIm251KC/AE/pYr29feeSncITSfys1L8mg/CYo4ue64q/3SypmPg7E75NRJfwiox77ajlYG6KBkVfZBvgmVA/hrKHUAIK4+nAOr0OyK+LA3M1zm9PBd/Fw07MNKF1Yf+aM3RaA5K3IfM8qp60ksm7JW6SBeieDdIMZox5YMvQMIPWeim737+VCtnnzd2q8pV3JSXULXm4EhqGvpgR2dM5vhEGzSQ8frlHMpXceKZ7L9dvN8OzIkF0GJF1fkpRMJbUsWFM/M7qVWYzk50S2rvgdPKNBhGHionJ0hudAtx4q WURR6fIe dUkjP5SAEpUt9LymlIAC1n/syT8y5ihvh4xPLE6q44Aaq6ndQmQhA5GeHf6+wRlqDXARlKlxH8nqVQIwpX7B2gEGzC8wYO1Qh0/6V2VN9Brs7klB3VmeDxHWJQJCV+EDkRUiYMRMWcDDEHg/9veB/IAhIcSRhJaVDL5zvQOjSZSwvoIOqsuO1AcoczhYyOdb7fHGnpZaq1JD89rbr71CkH24gjUguLuQV3Rgz1vEg6gqjwp5yue5egOHz/KqphK4T/NfpzAWVQ1NGfREMIgX9elh+S0FZXhXy29i+fxiTwjFjAix+ct5GYscpnAHoHuWK0jOQpFy4d9lxqU2MYrjHrfhSnxuAbHahDb4bCw04DRfQK4FLQvBTxuGcKV+xupm5o71cHeMUK4EPfVQG3n3kdfi/z4Z3nBb/XbqDM3KOuiUTr6nUE+YRErIGPBwjHUPcp+kvgs7MwiWpT74SAo9773dnRmMOhEeb4LGmfD9zH1Ecocr8OoTdU3qdK655mf7rvAvV X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/15/23 12:31, Kirill A. Shutemov wrote: > MAX_ORDER is not inclusive: the maximum allocation order buddy allocator > can deliver is MAX_ORDER-1. > > Fix MAX_ORDER usage in rb_alloc_aux_page(). > > Signed-off-by: Kirill A. Shutemov Acked-by: Vlastimil Babka > Cc: Peter Zijlstra > Cc: Ingo Molnar > Cc: Arnaldo Carvalho de Melo > Cc: Mark Rutland > Cc: Alexander Shishkin > Cc: Jiri Olsa > Cc: Namhyung Kim > Cc: Ian Rogers > Cc: Adrian Hunter > --- > kernel/events/ring_buffer.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/kernel/events/ring_buffer.c b/kernel/events/ring_buffer.c > index 273a0fe7910a..d6bbdb7830b2 100644 > --- a/kernel/events/ring_buffer.c > +++ b/kernel/events/ring_buffer.c > @@ -609,8 +609,8 @@ static struct page *rb_alloc_aux_page(int node, int order) > { > struct page *page; > > - if (order > MAX_ORDER) > - order = MAX_ORDER; > + if (order >= MAX_ORDER) > + order = MAX_ORDER - 1; > > do { > page = alloc_pages_node(node, PERF_AUX_GFP, order);