From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E46FAC6FD1D for ; Mon, 20 Mar 2023 20:43:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0018B6B0074; Mon, 20 Mar 2023 16:43:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EF41F6B0078; Mon, 20 Mar 2023 16:43:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DBBED6B007B; Mon, 20 Mar 2023 16:43:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id CB7DC6B0074 for ; Mon, 20 Mar 2023 16:43:15 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 9152EA9C85 for ; Mon, 20 Mar 2023 20:43:15 +0000 (UTC) X-FDA: 80590451550.20.8F20903 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by imf30.hostedemail.com (Postfix) with ESMTP id DB47080017 for ; Mon, 20 Mar 2023 20:43:12 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=LtqSNv5+; spf=none (imf30.hostedemail.com: domain of tim.c.chen@linux.intel.com has no SPF policy when checking 134.134.136.100) smtp.mailfrom=tim.c.chen@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679344993; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Xh48h3P5lYzGrY3rj0eOtuEn4AXrQc0aOeCiiIeB+nM=; b=YOFz3Mr4YZC9v6hu+f+NATxoAEOjjBkd1v1oNwOLkHmwZBqjAY20zagJv+4fIApjT/nz4F 5r3HXu0cqFTR0xnuJeNDTAG0sjw7j5eA37s8jGVchON/IZVwZmgWJfXPnOnElDA4jbi2ir nyXvrV69XmLneUDeAkJrqLs65wj+jSg= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=LtqSNv5+; spf=none (imf30.hostedemail.com: domain of tim.c.chen@linux.intel.com has no SPF policy when checking 134.134.136.100) smtp.mailfrom=tim.c.chen@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679344993; a=rsa-sha256; cv=none; b=CBcLPoyqYQlX70Puxh0QYyVzGeLnQtGS3msn3/D8Nzd5RIk7UPvCE9CzEkO0mmqIYiys4K Bm7b+P0KD+j3vFruQctmKuxvxiu2ExlHI/BahzdXmne4tys95kubOgRyreAn+l3NJ0KOnk hwtFI0nTziypVPruueo6qcTsco6T7tk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1679344992; x=1710880992; h=message-id:subject:from:to:cc:date:in-reply-to: references:content-transfer-encoding:mime-version; bh=Z0cSL+M1qbeo4dWHqt9xR8/EfLh7XeU49eCBlMRw1+A=; b=LtqSNv5+mRyjiTBCyAEqGshIeHgtu75BBuPL769rVDiENP2yuDGB3RzE 3vBrW0TgZn1FmAbrcACa7vxc23USSQqlBwfTtXzcWORBPmYCnTQN/0ArE AxPTfOkENg6kwPxk1r5M7/u3Voy06rdEn4MrYYUZZj2PmRR/SpjBAE5/v UR6CCp2hBrdeQa4OpwizjDoe9/fTdgJIj7XHpVvlfHlldrb/GVVppjiYv nz5/WQFTy9vPjmyBkx1PYlVLbwWQsD8lSUOKKGcfhOMh4sW0YxZhspnyz qfuEpN5fmEadr4kjxItbxLVwaIUJO0Yfi5OzczeRcX/Bxvn7ZDQ6LFiLy A==; X-IronPort-AV: E=McAfee;i="6600,9927,10655"; a="403646056" X-IronPort-AV: E=Sophos;i="5.98,276,1673942400"; d="scan'208";a="403646056" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Mar 2023 13:43:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10655"; a="927101749" X-IronPort-AV: E=Sophos;i="5.98,276,1673942400"; d="scan'208";a="927101749" Received: from tblanzy-mobl.amr.corp.intel.com (HELO [10.209.0.34]) ([10.209.0.34]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Mar 2023 13:43:10 -0700 Message-ID: <93b293341866a4366b2f2a614f8742ca94ff4e3c.camel@linux.intel.com> Subject: Re: [PATCH v7 13/13] vmstat: add pcp remote node draining via cpu_vm_stats_fold From: Tim Chen To: Marcelo Tosatti , Christoph Lameter Cc: Aaron Tomlin , Frederic Weisbecker , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Russell King , Huacai Chen , Heiko Carstens , x86@kernel.org, Vlastimil Babka , Michal Hocko Date: Mon, 20 Mar 2023 13:43:09 -0700 In-Reply-To: <20230320180745.858515310@redhat.com> References: <20230320180332.102837832@redhat.com> <20230320180745.858515310@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.4 (3.44.4-2.fc36) MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: DB47080017 X-Stat-Signature: 49sosdon8gfinc86c75cyud1hy3jqzwz X-HE-Tag: 1679344992-268233 X-HE-Meta: U2FsdGVkX1/BggUYnzecX/ecSUh3NTEdRbnTo646vdWeOGxRtWGs1Bt21Kdm/C4dQ6+6XDIWt674OxFPbYpQb6BFpWoaeOnPG7OlLYzANnLBufDsFCMURwBANmvJ8Kbf81hpnRbiMG0TtKbz6lDLpIEpeiAdobGRoT56aIdc0k+cl44Qdqn5j/O68Mrxq4brksMafOlH5D5ygpIcNVzMXVpbDLADMt2O0KnaPPRdh5bhzjm6hgPlHknLBe7773RiVVfICNrJB/CPxsgGBn9PiQLiknxHAf8BBiRcQT3iyKXsWRQhpFIhLq6wAYUtdUA8k/ktLlwZQt2xCXv72Xxi85rpduhaEjQ9fhF3fKRYExwj20tUVoFBsGtUOJ7dNAtboneYFLagfjBZBj0gtCX/JjyieDJTY4ZFUvpqm1zcAgD8FStxhVN6BBzYTcWSUqEeIPhS9uR6z0HcSqI8/aEo80XuX339034Yqu3VjKWFj+kO255BiqNQxScD4HjJVzZ+jZJJiVipUgA/bpyecG3QOAO8FQo+TMzWgqAfpXHIjI2K1Urolm7XqlSfC/rfTDW0nkGmQbzFa5MkdUxBdxdtrpoUw2K4B6mjme/h8nJzroJ4EmAuHx0keoxXwoaLBKrcbnMDAqW56iE0tKo67RW9/8DbPDRLszPpVGzkDgKTX3XWX32KZcVFW2AlSy8Rw47J91NtagzQMVw49qaCRhrU/+UR5VGbuZw0HVoGvSo7mHi8yBMb6449m5wXv4IJGey2ILN6RDlZdMowr8W6JaPzTgrKxXbVxCyyJ9Xs9Kz9p3qJ6TH5qkYKARRGXq0UxkqYHn+AWFqofbp46lCyjaA05W61geD3hvK7soELC20kDDY68dBHT4pPkStmA0URdvei8fKNyjd8kRo4vgW7f0Y6VvVi262yZnJSmf7q6G3d+Q9S7Iccr47Ziv/gpQJSnlG9+Mpjz4sB+JydN5IZmyh MBZpiBnd Depd7WRanQsEtoGSlPR1u6lGLjRokGlrY1L9FrNOLLtciLFBwtCkZBIAVt8qlPxzhchoWYDCj8iLTQHLSuwOhRXf+MkhvbL1+0GgmVUr+lfDPtmKdz6oc+f2hdQWo45FRVzEeMIDP0rCR3mOmgH1/2BKSB6onaenPyTM528nN96pp7z+tmTAivd0yzqxWBdd4iH3T X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 2023-03-20 at 15:03 -0300, Marcelo Tosatti wrote: >=20 > + > + if (do_pagesets) { > + cond_resched(); > + /* > + * Deal with draining the remote pageset of a > + * processor > + * > + * Check if there are pages remaining in this pageset > + * if not then there is nothing to expire. > + */ > + if (!pcp->expire || !pcp->count) > + continue;refresh_cpu_vm_stats > + > + /* > + * We never drain zones local to this processor. > + */ > + if (zone_to_nid(zone) =3D=3D cpu_to_node(cpu)) { > + pcp->expire =3D 0; > + continue; > + } > + > + WARN_ON(pcp->expire < 0); > + /* > + * pcp->expire is only accessed from vmstat_shepherd context, > + * therefore no locking is required. > + */ > + if (--pcp->expire) > + continue; > + > + if (pcp->count) > + drain_zone_pages(zone, pcp); > + } This logic is the same to that for the do_pagesets portion of code in refre= sh_cpu_vm_stats(). Is it possible to consolidate to avoid replicating the logic across two fun= ctions? Tim=20