From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85242C433F5 for ; Thu, 10 Mar 2022 16:08:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EDE128D0002; Thu, 10 Mar 2022 11:08:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E8B9A8D0001; Thu, 10 Mar 2022 11:08:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D535C8D0002; Thu, 10 Mar 2022 11:08:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0225.hostedemail.com [216.40.44.225]) by kanga.kvack.org (Postfix) with ESMTP id C20DB8D0001 for ; Thu, 10 Mar 2022 11:08:24 -0500 (EST) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 819C8181CAC4C for ; Thu, 10 Mar 2022 16:08:24 +0000 (UTC) X-FDA: 79228958928.23.A191D50 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf12.hostedemail.com (Postfix) with ESMTP id EBDBA40015 for ; Thu, 10 Mar 2022 16:08:23 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 87582B82544; Thu, 10 Mar 2022 16:08:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AEEBBC340E8; Thu, 10 Mar 2022 16:08:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1646928501; bh=Mz9lcl7Mz+bpTA0eBommZqufCA9FpDz9aP+9Tl+lFxA=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=QrMAowze7PSr6TMe5m+uyL3B4o1tGIdp26Lp98wQ1V1BFtFH2rUyPjNO4b1Y6phCG 6m2cApsZ+4e0JSTyXRcSkjyb1aSqLQ8fqyMJCe9wUJaWDDjbLzB6E8Szt03HSU8Cgz zuqYHgrdU4M86jF11fSyHqyJ6s/fkg78GBDCt62jDMg764tLc1cjxqfkmG9t1EoHkd VefmXpPJ4XbM1xBQ9Olm+gqmdvobyFhCVPEUqTT3Bt0HwOCuUQCrUFwUvA5CphvwhY NK7YsfoeuWERdw7fEQbPM631FlsXsAqm37AXzZOmCwscolnTsIk12nqKpuIMOaIIjt AhrSUTtuThycg== Message-ID: <93ac51c2b0aa9d5a3777bce935990d7b9da176f4.camel@kernel.org> Subject: Re: [linux-next:master 4605/11713] kernel/trace/trace_events_synth.c:65:9: warning: 'strncpy' specified bound depends on the length of the source argument From: Tom Zanussi To: Steven Rostedt Cc: kernel test robot , kbuild-all@lists.01.org, Linux Memory Management List Date: Thu, 10 Mar 2022 10:08:18 -0600 In-Reply-To: <20220310104951.60d0adb6@gandalf.local.home> References: <202203092349.i2I1pdlw-lkp@intel.com> <93bb0a79331882df8ce2bf704b3d4ac28c8cbc3d.camel@kernel.org> <20220310104951.60d0adb6@gandalf.local.home> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: EBDBA40015 X-Stat-Signature: rnkar6isstccuq5sa6gorcozsangzxz4 Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=QrMAowze; spf=pass (imf12.hostedemail.com: domain of zanussi@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=zanussi@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-HE-Tag: 1646928503-471954 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Steve, On Thu, 2022-03-10 at 10:49 -0500, Steven Rostedt wrote: > On Thu, 10 Mar 2022 09:12:39 -0600 > Tom Zanussi wrote: > > > On Wed, 2022-03-09 at 23:48 +0800, kernel test robot wrote: > > > Hi Tom, > > > > > > FYI, the error/warning still remains. > > > > > > > > > > Thanks, the patch below fixes it. I'll submit to lkml, but not > > sure > > whether to submit the fix or resubmit the original patch... > > I don't rebase my linux-next branch unless there's a really go reason > to do > so. But I also have this patch going through my testing: > > > https://lore.kernel.org/all/20220308110736.479e3cc9@gandalf.local.home/ > > Which I believe fixes the issue. > > But we can use this patch too, but I do get nervous about plain > strcat(). > This patch is for the last_cmd_set() in trace_events_synth.c, yours is for trace_events_hist.c, which also has last_cmd_set(). The one in trace_events_synth.c is much simpler, so it seemed to me that strcpy() would be ok there. Tom > -- Steve