Re: [linux-next:master 4605/11713] kernel/trace/trace_events_synth.c:65:9: warning: 'strncpy' specified bound depends on the length of the source argument

[Tom Zanussi <zanussi@kernel.org>]

Hi Steve,

On Thu, 2022-03-10 at 10:49 -0500, Steven Rostedt wrote:
> On Thu, 10 Mar 2022 09:12:39 -0600
> Tom Zanussi <zanussi@kernel.org> wrote:
> 
> > On Wed, 2022-03-09 at 23:48 +0800, kernel test robot wrote:
> > > Hi Tom,
> > > 
> > > FYI, the error/warning still remains.
> > > 
> > >   
> > 
> > Thanks, the patch below fixes it.  I'll submit to lkml, but not
> > sure
> > whether to submit the fix or resubmit the original patch...
> 
> I don't rebase my linux-next branch unless there's a really go reason
> to do
> so. But I also have this patch going through my testing:
> 
>   
> https://lore.kernel.org/all/20220308110736.479e3cc9@gandalf.local.home/
> 
> Which I believe fixes the issue.
> 
> But we can use this patch too, but I do get nervous about plain
> strcat().
> 

This patch is for the last_cmd_set() in trace_events_synth.c, yours is
for trace_events_hist.c, which also has last_cmd_set().

The one in trace_events_synth.c is much simpler, so it seemed to me
that strcpy() would be ok there.

Tom


> -- Steve