From: Qi Zheng <zhengqi.arch@bytedance.com>
To: peterz@infradead.org, agordeev@linux.ibm.com,
kevin.brodsky@arm.com, alex@ghiti.fr, andreas@gaisler.com,
palmer@dabbelt.com, tglx@linutronix.de, david@redhat.com,
jannh@google.com, hughd@google.com, yuzhao@google.com,
willy@infradead.org, muchun.song@linux.dev, vbabka@kernel.org,
lorenzo.stoakes@oracle.com, akpm@linux-foundation.org,
rientjes@google.com, vishal.moola@gmail.com, arnd@arndb.de,
will@kernel.org, aneesh.kumar@kernel.org, npiggin@gmail.com,
dave.hansen@linux.intel.com, rppt@kernel.org,
ryan.roberts@arm.com
Cc: linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org,
linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org,
linux-s390@vger.kernel.org, sparclinux@vger.kernel.org,
linux-kernel@vger.kernel.org, x86@kernel.org,
linux-arch@vger.kernel.org, linux-csky@vger.kernel.org,
linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev,
linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org,
linux-openrisc@vger.kernel.org, linux-sh@vger.kernel.org,
linux-um@lists.infradead.org,
Qi Zheng <zhengqi.arch@bytedance.com>,
Alexandre Ghiti <alexghiti@rivosinc.com>
Subject: [PATCH v5 02/17] riscv: mm: Skip pgtable level check in {pud,p4d}_alloc_one
Date: Wed, 8 Jan 2025 14:57:18 +0800 [thread overview]
Message-ID: <93a1c6bddc0ded9f1a9f15658c1e4af5c93d1194.1736317725.git.zhengqi.arch@bytedance.com> (raw)
In-Reply-To: <cover.1736317725.git.zhengqi.arch@bytedance.com>
From: Kevin Brodsky <kevin.brodsky@arm.com>
{pmd,pud,p4d}_alloc_one() is never called if the corresponding page
table level is folded, as {pmd,pud,p4d}_alloc() already does the
required check. We can therefore remove the runtime page table level
checks in {pud,p4d}_alloc_one. The PUD helper becomes equivalent to
the generic version, so we remove it altogether.
This is consistent with the way arm64 and x86 handle this situation
(runtime check in p4d_free() only).
Signed-off-by: Kevin Brodsky <kevin.brodsky@arm.com>
Signed-off-by: Qi Zheng <zhengqi.arch@bytedance.com>
Acked-by: Dave Hansen <dave.hansen@linux.intel.com>
Reviewed-by: Alexandre Ghiti <alexghiti@rivosinc.com>
---
arch/riscv/include/asm/pgalloc.h | 22 ++++------------------
1 file changed, 4 insertions(+), 18 deletions(-)
diff --git a/arch/riscv/include/asm/pgalloc.h b/arch/riscv/include/asm/pgalloc.h
index f52264304f772..8ad0bbe838a24 100644
--- a/arch/riscv/include/asm/pgalloc.h
+++ b/arch/riscv/include/asm/pgalloc.h
@@ -12,7 +12,6 @@
#include <asm/tlb.h>
#ifdef CONFIG_MMU
-#define __HAVE_ARCH_PUD_ALLOC_ONE
#define __HAVE_ARCH_PUD_FREE
#include <asm-generic/pgalloc.h>
@@ -88,15 +87,6 @@ static inline void pgd_populate_safe(struct mm_struct *mm, pgd_t *pgd,
}
}
-#define pud_alloc_one pud_alloc_one
-static inline pud_t *pud_alloc_one(struct mm_struct *mm, unsigned long addr)
-{
- if (pgtable_l4_enabled)
- return __pud_alloc_one(mm, addr);
-
- return NULL;
-}
-
#define pud_free pud_free
static inline void pud_free(struct mm_struct *mm, pud_t *pud)
{
@@ -118,15 +108,11 @@ static inline void __pud_free_tlb(struct mmu_gather *tlb, pud_t *pud,
#define p4d_alloc_one p4d_alloc_one
static inline p4d_t *p4d_alloc_one(struct mm_struct *mm, unsigned long addr)
{
- if (pgtable_l5_enabled) {
- gfp_t gfp = GFP_PGTABLE_USER;
-
- if (mm == &init_mm)
- gfp = GFP_PGTABLE_KERNEL;
- return (p4d_t *)get_zeroed_page(gfp);
- }
+ gfp_t gfp = GFP_PGTABLE_USER;
- return NULL;
+ if (mm == &init_mm)
+ gfp = GFP_PGTABLE_KERNEL;
+ return (p4d_t *)get_zeroed_page(gfp);
}
static inline void __p4d_free(struct mm_struct *mm, p4d_t *p4d)
--
2.20.1
next prev parent reply other threads:[~2025-01-08 6:59 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-08 6:57 [PATCH v5 00/17] move pagetable_*_dtor() to __tlb_remove_table() Qi Zheng
2025-01-08 6:57 ` [PATCH v5 01/17] Revert "mm: pgtable: make ptlock be freed by RCU" Qi Zheng
2025-01-08 6:57 ` Qi Zheng [this message]
2025-01-08 6:57 ` [PATCH v5 03/17] asm-generic: pgalloc: Provide generic p4d_{alloc_one,free} Qi Zheng
2025-01-08 11:01 ` Arnd Bergmann
2025-01-08 6:57 ` [PATCH v5 04/17] mm: pgtable: add statistics for P4D level page table Qi Zheng
2025-01-08 6:57 ` [PATCH v5 05/17] arm64: pgtable: use mmu gather to free p4d " Qi Zheng
2025-01-13 16:26 ` Will Deacon
2025-01-14 2:26 ` Qi Zheng
2025-01-17 13:25 ` Will Deacon
2025-01-08 6:57 ` [PATCH v5 06/17] s390: pgtable: add statistics for PUD and P4D " Qi Zheng
2025-01-08 16:12 ` Alexander Gordeev
2025-01-08 6:57 ` [PATCH v5 07/17] mm: pgtable: introduce pagetable_dtor() Qi Zheng
2025-01-08 15:57 ` Alexander Gordeev
2025-01-08 6:57 ` [PATCH v5 08/17] arm: pgtable: move pagetable_dtor() to __tlb_remove_table() Qi Zheng
2025-01-08 6:57 ` [PATCH v5 09/17] arm64: " Qi Zheng
2025-01-13 16:29 ` Will Deacon
2025-01-08 6:57 ` [PATCH v5 10/17] riscv: " Qi Zheng
2025-01-08 6:57 ` [PATCH v5 11/17] x86: pgtable: convert __tlb_remove_table() to use struct ptdesc Qi Zheng
2025-01-08 8:31 ` Kevin Brodsky
2025-01-08 6:57 ` [PATCH v5 12/17] x86: pgtable: move pagetable_dtor() to __tlb_remove_table() Qi Zheng
2025-01-08 6:57 ` [PATCH v5 13/17] s390: pgtable: consolidate PxD and PTE TLB free paths Qi Zheng
2025-01-08 15:58 ` Alexander Gordeev
2025-01-08 6:57 ` [PATCH v5 14/17] mm: pgtable: introduce generic __tlb_remove_table() Qi Zheng
2025-01-08 11:03 ` Arnd Bergmann
2025-01-08 6:57 ` [PATCH v5 15/17] mm: pgtable: completely move pagetable_dtor() to generic tlb_remove_table() Qi Zheng
2025-01-08 6:57 ` [PATCH v5 16/17] mm: pgtable: move __tlb_remove_table_one() in x86 to generic file Qi Zheng
2025-01-08 6:57 ` [PATCH v5 17/17] mm: pgtable: introduce generic pagetable_dtor_free() Qi Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=93a1c6bddc0ded9f1a9f15658c1e4af5c93d1194.1736317725.git.zhengqi.arch@bytedance.com \
--to=zhengqi.arch@bytedance.com \
--cc=agordeev@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=alex@ghiti.fr \
--cc=alexghiti@rivosinc.com \
--cc=andreas@gaisler.com \
--cc=aneesh.kumar@kernel.org \
--cc=arnd@arndb.de \
--cc=dave.hansen@linux.intel.com \
--cc=david@redhat.com \
--cc=hughd@google.com \
--cc=jannh@google.com \
--cc=kevin.brodsky@arm.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-csky@vger.kernel.org \
--cc=linux-hexagon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-openrisc@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=loongarch@lists.linux.dev \
--cc=lorenzo.stoakes@oracle.com \
--cc=muchun.song@linux.dev \
--cc=npiggin@gmail.com \
--cc=palmer@dabbelt.com \
--cc=peterz@infradead.org \
--cc=rientjes@google.com \
--cc=rppt@kernel.org \
--cc=ryan.roberts@arm.com \
--cc=sparclinux@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=vbabka@kernel.org \
--cc=vishal.moola@gmail.com \
--cc=will@kernel.org \
--cc=willy@infradead.org \
--cc=x86@kernel.org \
--cc=yuzhao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox