From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35D8FC433E0 for ; Thu, 25 Jun 2020 19:55:06 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id EB02E206A1 for ; Thu, 25 Jun 2020 19:55:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="b12qVYGk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EB02E206A1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7E2226B0006; Thu, 25 Jun 2020 15:55:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 792F86B0007; Thu, 25 Jun 2020 15:55:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 680B66B0008; Thu, 25 Jun 2020 15:55:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0043.hostedemail.com [216.40.44.43]) by kanga.kvack.org (Postfix) with ESMTP id 4CDA46B0006 for ; Thu, 25 Jun 2020 15:55:05 -0400 (EDT) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id CF403824556B for ; Thu, 25 Jun 2020 19:55:04 +0000 (UTC) X-FDA: 76968787728.17.wax97_2203b3726e4f Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin17.hostedemail.com (Postfix) with ESMTP id 5DF45180D0185 for ; Thu, 25 Jun 2020 19:55:04 +0000 (UTC) X-HE-Tag: wax97_2203b3726e4f X-Filterd-Recvd-Size: 4408 Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by imf50.hostedemail.com (Postfix) with ESMTP for ; Thu, 25 Jun 2020 19:55:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1593114903; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eQ7xMdZhc6TjsSubIw6leY1n9g5aMHwCo2Yl/5e6Ysk=; b=b12qVYGkx8o3v5sAOkmjxp6H1O+3oTVG8MrIH65hXNK6Y7tv2u1tAAK0GPGek+rex7AO4e MA8TREIs2+591l26IU3Uzz5RYi22VDh8UNTSqXR7vUO3OjbVizHSrdNCU/hgYr5yRsrIQ5 tgnq9zJeE5H5FCuq4F9QFgR1Aka+gcU= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-8-XoYjQsOQMPiujVIEnaKOrA-1; Thu, 25 Jun 2020 15:54:59 -0400 X-MC-Unique: XoYjQsOQMPiujVIEnaKOrA-1 Received: by mail-ed1-f72.google.com with SMTP id j15so2073589edq.11 for ; Thu, 25 Jun 2020 12:54:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:content-transfer-encoding:from:mime-version :subject:date:message-id:references:cc:in-reply-to:to; bh=wMmWD42emjWTjisxH2mhg8ooA/tzTNuz83b0inCszAo=; b=KqJd/N3a0Auhlm4ilpSSO0tRZmu4BFHHzRu8kP1D/T7QKtTI67mdL93vYD9/yunSJm SlTGS8/VG59o50aMu+D6W05X0oE8pYh+79Sr9cBiLjgngIAo/93USRIwmM7YtwiSt5ak +pQ/N0jSJuhGziQXIvvwQp1RlKGIoDGzGYMGGFpb1SvBhyxWFCukV/RN6lZCZ7OLvUuX zca+PSRe8uPphFaLzJroUJKr6cyUyPC/dao1y5M+aV/w6bjSHvfAQAqiJRzu7BQaXMam yhMmXZCbvcNKRmVfBPQzCCYdm9ioqJmq7HqUHEyG3uc7q3ivPeV2To/2/Ek1vCU0EJWB pszw== X-Gm-Message-State: AOAM531uYeQTdLPL5TY8WssRKCy/LElDso5v3yJi8+xoBXBgIA7Ycwha D6XsOtDCK0cjNTJjUoLOkAlJIXBqawZp+WapYwfku/7haU7TSDmDRMWL1ndy3qe4W/shQ8NnYg2 +vmVttX996uE= X-Received: by 2002:a17:906:81d2:: with SMTP id e18mr3825021ejx.341.1593114898270; Thu, 25 Jun 2020 12:54:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy5E/w1rTnVuKXZNENv7G0eGJhbp6+G0E9LkJ3uLdKtkufHLsXOdh6ZMYC+QQ77kfhoMtI4gw== X-Received: by 2002:a17:906:81d2:: with SMTP id e18mr3825008ejx.341.1593114898113; Thu, 25 Jun 2020 12:54:58 -0700 (PDT) Received: from [192.168.3.122] (p4ff23f47.dip0.t-ipconnect.de. [79.242.63.71]) by smtp.gmail.com with ESMTPSA id d12sm12947661edx.80.2020.06.25.12.54.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 Jun 2020 12:54:57 -0700 (PDT) From: David Hildenbrand Mime-Version: 1.0 (1.0) Subject: Re: [PATCH RFC] s390x/vmem: get rid of memory segment list Date: Thu, 25 Jun 2020 21:54:56 +0200 Message-Id: <93B4CEE2-3C8D-481F-89BC-09C931866201@redhat.com> References: <20200625193837.GA5050@osiris> Cc: David Hildenbrand , linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, linux-mm@kvack.org, Vasily Gorbik , Christian Borntraeger , Andrew Morton , Gerald Schaefer In-Reply-To: <20200625193837.GA5050@osiris> To: Heiko Carstens X-Mailer: iPhone Mail (17F80) Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 5DF45180D0185 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > Am 25.06.2020 um 21:38 schrieb Heiko Carstens = : >=20 > =EF=BB=BFOn Thu, Jun 25, 2020 at 05:00:29PM +0200, David Hildenbrand wrot= e: >> This smells like a leftover from ancient times, let's get rid of it. We >> can now convert vmem_remove_mapping() into a void function - everybody >> ignored the return value already. >=20 > This buys us what? Except that we get rid of a bit of code? I=E2=80=98m looking into virtio-mem support for s390x, including vmemmap/vm= em optimizations. Virtio-mem adds/removes memory in memory block granularit= y, which results in one list entry for essentially each memory section. Tha= t seems to be easy to avoid. Thanks