From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F696CD3420 for ; Sun, 1 Sep 2024 20:24:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C63318D0055; Sun, 1 Sep 2024 16:24:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C13208D002D; Sun, 1 Sep 2024 16:24:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A8C768D0055; Sun, 1 Sep 2024 16:24:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 8A1938D002D for ; Sun, 1 Sep 2024 16:24:15 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 1102B1C051E for ; Sun, 1 Sep 2024 20:24:15 +0000 (UTC) X-FDA: 82517296470.06.9910D68 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf27.hostedemail.com (Postfix) with ESMTP id B6A6D40008 for ; Sun, 1 Sep 2024 20:24:12 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=N30BngqE; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=wjEeYsr4; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=N30BngqE; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=wjEeYsr4; spf=pass (imf27.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725222161; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eTLsgq6ewR/Q+Y/oXGUSrZvLL070T1nTyz+OQqaph54=; b=ZSvW2x6pDWKH2h6gsD1oFPoezWtLqo0DwPs7+gP9l8dO1lTPDEtcbgSB1HK2qjpnKyEaog RjCziZoRIWT/VxyCRL6Fj7SLstwsCxE/rkJCB7YEE02yA8Xk4sqaqhOriNnUIPxUPA7lWu i8xIKckwRNqHcv+5BUihnVlja6cTlGg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725222161; a=rsa-sha256; cv=none; b=ZJZzKL2VMeFAa+j+0zRbK4F3usFHr36ybt8nloF7/LakJJJxmurfYErFg8kBScWl3+k37c EVPySqeUpMUg4fLj9d68tzOAL9wWwkjLpd/T8hH3eh7Y7vWAVQnqunmSxaJ7kVR86z4fGL 2zxDr1AEhaNZrtltQl5BEFl+mcNJiMQ= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=N30BngqE; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=wjEeYsr4; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=N30BngqE; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=wjEeYsr4; spf=pass (imf27.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id F32471FB68; Sun, 1 Sep 2024 20:24:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1725222251; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=eTLsgq6ewR/Q+Y/oXGUSrZvLL070T1nTyz+OQqaph54=; b=N30BngqEA/1nkuYR6ShicN6/6yWDHO/a7SscwfjxAJVb6HpuPz6FzYyCdeq94JkhgJu/XM yjQoS5qZq8A3suN1mljqhU1AM9Ap/AqW+5IVRUKdgvNXXQFsXgawpme1dXGxjMgD7pFYDj +5I/IY9IZ52lIe3XNItG4R4X3XrpEBA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1725222251; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=eTLsgq6ewR/Q+Y/oXGUSrZvLL070T1nTyz+OQqaph54=; b=wjEeYsr48N/HV+EKuuCiwJ6XkH0J0UNUZpc+cHjnI+DfqzROQp4MJwbbIOEptOBmpISvtA JBT9tIVCRD07nbAQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1725222251; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=eTLsgq6ewR/Q+Y/oXGUSrZvLL070T1nTyz+OQqaph54=; b=N30BngqEA/1nkuYR6ShicN6/6yWDHO/a7SscwfjxAJVb6HpuPz6FzYyCdeq94JkhgJu/XM yjQoS5qZq8A3suN1mljqhU1AM9Ap/AqW+5IVRUKdgvNXXQFsXgawpme1dXGxjMgD7pFYDj +5I/IY9IZ52lIe3XNItG4R4X3XrpEBA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1725222251; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=eTLsgq6ewR/Q+Y/oXGUSrZvLL070T1nTyz+OQqaph54=; b=wjEeYsr48N/HV+EKuuCiwJ6XkH0J0UNUZpc+cHjnI+DfqzROQp4MJwbbIOEptOBmpISvtA JBT9tIVCRD07nbAQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id D814F1397F; Sun, 1 Sep 2024 20:24:10 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 8RpSNGrN1GaIAQAAD6G6ig (envelope-from ); Sun, 01 Sep 2024 20:24:10 +0000 Message-ID: <9390b0ab-fd2c-45e3-b48f-94796ecbbbda@suse.cz> Date: Sun, 1 Sep 2024 22:24:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] mm: Add memalloc_nowait_{save,restore} Content-Language: en-US To: Yafang Shao , Christoph Hellwig Cc: akpm@linux-foundation.org, viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz, david@fromorbit.com, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Kent Overstreet , Michal Hocko References: <20240812090525.80299-1-laoar.shao@gmail.com> <20240812090525.80299-2-laoar.shao@gmail.com> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: B6A6D40008 X-Stat-Signature: try3c8c9isu4usxrtqaqqkks78hygqcc X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1725222252-961594 X-HE-Meta: U2FsdGVkX1/O1SFMVeAVGYlk/YlL1Uzg9TAUTQQyAV2a81c6uoJTfJ6liaHCem5ipmD6t46R2u2AfzSRJ95s0SOwE+nFwEwRIkeEuEDyh3F19h/cCN7iIVaL4+rlmc6/LFouNr13lonuWmLPZp0gfXjzkil0s3/8TwaYPjEEsdrY4olonpaZQM/0he7Q74NCpjaLVqpiYr99oJGKXfZD/p2MDh3UasFPSJCvFv3M7U846d0/22RzQD1CQmYN4riLBBqzawPUfLgdgPM8SibRqV6uFlqHPUOKxfDZGO3SrqwuJxgqdb4Nb4z1rxVrOuJEWGGGn1iiMDEXuPgTgxea2OIpY14ETs6/nCDBCGhKCImOB5fdgOgY2ft2PNzQck5Sl0qaYsKn7zT8QENOfzEzKU3Ir6G2tfTra5KtJKr9KUhDEM+i3DqHcXAf+BLHna0M6n7FitnGDsGCCYcH3vtvqjRk7t6JC/NJaZx5vA444BQv8zBhGVnrN0UVbk7Et03o7IiGTyQRtwJi6YSJgr++Igapge5IKEB+RB5O3p3kPDtbExuGBAM0duAGmv7iHfauOwjHMREmy0yj1ELAcRAyqcikcJl3+Z1qdZvT4d6y4+83TZIMx38M4fSdkBLTIGbYaPcSXAfFsLvtwNBvNAyrma1u4iqSwYcLw88SUd0DHN5TUcGIJWjOSHfhjgCFjyBU+iAH2V9G/W547976oSzYFHbQJQmRw495XYWt4J2H9vX1wMZctQf7xhxpPmxWpTEBxhhEC5pzLu0SMoxO/jc4Co4frB3BTIbBDQmOUhh4hpZ/y+VUe7xBOTzVxIDl2qg+8QmKrTzgm3mSXBQeBkoGxCKRvSzY3T8jSwbYcZblcWbfxh6kvzUi0SxvaA3vC3AwX6kGPjB8gGeNmB4jAm3qO729ddh3fgZln8qiMLEAh9OLH4xa/8I8guxWRFkUQRUYLUx9g+qMVVsxPLf48oN lxqIClS9 xkmAdadKvZqSqeq0DZHZ6+2jMPCTTYultauzqXFd40xOfrmAa+OZc1/aFNqOAnkBed29tvExHYvGgGU/CauIZCgctGAV09J/Yy1udFxcer3Rf06mCq9HGlhkAVaRMxyB1n+/X3XVXAL4gIuBfr5GwRYw2T7nmeehZniQI8IumIKSUX/Pxaan37EoKEbNYJUOQvohCtlG6x/N+13sf0F1EUxFo71OwPqtEC9dUmXC0sspNzdKSfJocPBvwC4/5DqxHV3iU3ukw8ryH5rQP/4Mbj1U1o3Yuea+EcBj1khTJz/d5KxvdjFb0TCLYE3AsqV2jTi0ou6BsnfPwbIIB86mHorlYjs9FHwrmGiQrpJmCyu9Hsb4yh8EDu0EmWRZptB6GJM1EhJxePAz8Qqsf04zaRetrJtdbu02j5wnB6CLXEOjTJMA0C9+FAHkHXcA+Ihv5008A/6yEAYKm2c84zcPBOqb6/nffsrqihIrPszktqUKekUg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000173, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 8/14/24 09:33, Yafang Shao wrote: > On Wed, Aug 14, 2024 at 1:27 PM Christoph Hellwig wrote: >> >> > There are already memalloc_noreclaim_{save,restore} which imply __GFP_MEMALLOC: >> > >> > memalloc_noreclaim_save - Marks implicit __GFP_MEMALLOC scope. >> >> .. and those are horrible misnamed :( Yes I agree, sorry about that. > What about renaming it to memalloc_memalloc_save ? While it looks weird, it could be indeed better than the current name. It's not obvious, so it should force the user to read the description. memalloc_noreclaim_save() might look too obviously "this disables reclaim" but it's misleading as that's not the full story of PF_MEMALLOC. >> >> If we can't even keep our APIs consistently name, who is supposed >> to understand all this? >> >