From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5712E7718B for ; Sat, 21 Dec 2024 15:33:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2CAF76B0085; Sat, 21 Dec 2024 10:33:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 27A116B0088; Sat, 21 Dec 2024 10:33:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0F3F66B0089; Sat, 21 Dec 2024 10:33:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id E306B6B0085 for ; Sat, 21 Dec 2024 10:33:01 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 3D1191C81D9 for ; Sat, 21 Dec 2024 15:33:01 +0000 (UTC) X-FDA: 82919357640.03.2342323 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf13.hostedemail.com (Postfix) with ESMTP id 381D52000B for ; Sat, 21 Dec 2024 15:32:24 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hUx13wPm; spf=pass (imf13.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734795162; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2ABinJ2CHN5O7jAt/zV4Jh9JhZIidzEF3+Y/hIrc4AU=; b=Rt+f/+8XTRHf9HOmRMH4Jp5HKOwVsAFbu66TuzyyxIAVukvfoRY29PGY9F+wVYQHCLUfi/ s76SvuMG8B0RBHXO03xaNUSKZwAuSe+Mjm9qEZgSbg97u2J3tcS7vPkS6aSN9cEyQOqfSF pDoElLPf/3bXH+OorBb0lhQYOBrSBIM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734795162; a=rsa-sha256; cv=none; b=Ilig++3+3DOJFAHdIhTYhgJoqascc/BjgBneQu8rX7faJ2BQDKVpm4WiD2U2h4iXEG16C/ 5FzZ28opgGIDvGCxJQFns4ejf5Du5PqniRQqLZKURkU35hY5wlMNHDbjS0+nWv13tHO4oa AeOo0eeUInWUkl1wN50MTmhlb4y3rm0= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hUx13wPm; spf=pass (imf13.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1734795178; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=2ABinJ2CHN5O7jAt/zV4Jh9JhZIidzEF3+Y/hIrc4AU=; b=hUx13wPmAvLYQhnBCyGtBwtlzl01FU0To9ii1EvXEZamNlVX1l4vezarxAcb8jgt63K9pI 5wFFgBOmSe4ghbwUqZ/nopfX15+ESMwMFv5XiDNM7TQN/eMpZTr+FwAzgqEfjl4nnUa7aN ULzBAuO8z89gl9t2Cti9gpiHeYCMlXk= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-26-a6X0iX1mOryy_bFEoSAmlw-1; Sat, 21 Dec 2024 10:32:56 -0500 X-MC-Unique: a6X0iX1mOryy_bFEoSAmlw-1 X-Mimecast-MFC-AGG-ID: a6X0iX1mOryy_bFEoSAmlw Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-436219070b4so14852195e9.1 for ; Sat, 21 Dec 2024 07:32:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734795175; x=1735399975; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=2ABinJ2CHN5O7jAt/zV4Jh9JhZIidzEF3+Y/hIrc4AU=; b=quVQJ966fKuTevCcnhZTwCugdqUL1RiaxhO3WXOuSMVZBvV7jxCmnhe7X3SLeby6iq VDzwNoHnMRKH3HOJku9x26TNCisgov28fp+SehVkVV4xK8lez7Ur7JnfygqOY7u+DC3+ /KJTswglQbHEz2SZJfcw6QHf/4zXv1nDTxQaj21EgppVbzBvaCLt+hFZGUeweWOnyLrD p4MnI8TMxpgCepOdSu/hAEYQY0inJR4KoSXCmznjUu1O/1XuHOLZLahP/23PLhKCC0w7 imhWCUyf8AqElrK/E7HTUfbj+FVxSGUvDyDZhUlsKQhtda6Naz2a5yibqgQESaIDQCpF Im0g== X-Forwarded-Encrypted: i=1; AJvYcCUkRslRl4lcANgpLcvlF6Zj44hT2A7ZgtksUsXk+kYNsm7NVn5/OFgWjXM5aaBUG05O6d+cqczleQ==@kvack.org X-Gm-Message-State: AOJu0Yy0czzXFRbSbObbEjc7KLJj69kelFWV3JdL/ybGqM8o5CmaO1aF orqXDcfD1oISKwowL0zLSIW5TSodH88+XpnRul9h/Ekd0a/3FawOyEPtaRmBph8CM8i1es3FQXx VU+JbJHC9BZ3Qy5oXodQEDFUPVvHHHe3X3atFTDRYL69Rmmc+ X-Gm-Gg: ASbGncv7yQUEXGB3HkrlBhKi94oXJ9oApAnoMZ5c+TLC3bubszwd5dV/V6cwbPV1GiP VsOIucfoWImPkJiqXTZMqORxN1DGMWRvVnMwgX1Hb5C8m8Gp8lFNbXyl+YsOtd9JMbWJ+7Y+tQV 52zTHiaYuUE/X+pU8sAVsDZjuiUgY0rz5ICQvYmoNj9enaEHD0Tfs+B9nigNF+cHQAV6A1a6Jrc ouuHreoAhQimvOULF7y3F2s80OUYIFH5n35TwWpnk7Iu6asfMikXsyArB/4jW+xIXtk1nl+xmdB IfrNbqLDkSzx8bHorPO4uEcMeQQft46gBxik+gY5BU7MAKibhOAkOOWseFfSDUf5+FqTGcR1irY 5Ul8//r1c X-Received: by 2002:a05:600c:5246:b0:42c:bb96:340e with SMTP id 5b1f17b1804b1-43668b7857amr62571235e9.31.1734795175564; Sat, 21 Dec 2024 07:32:55 -0800 (PST) X-Google-Smtp-Source: AGHT+IGEIODI5dAnbxmy4Insz5jV68t6Y9lfEiN3ZEPhNsQhW1qv+O/ueu0pIAXNcleIcCKRQc4W6A== X-Received: by 2002:a05:600c:5246:b0:42c:bb96:340e with SMTP id 5b1f17b1804b1-43668b7857amr62571035e9.31.1734795175193; Sat, 21 Dec 2024 07:32:55 -0800 (PST) Received: from ?IPV6:2003:cb:c70e:d000:4622:73e7:6184:8f0d? (p200300cbc70ed000462273e761848f0d.dip0.t-ipconnect.de. [2003:cb:c70e:d000:4622:73e7:6184:8f0d]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-436612008b1sm77930105e9.15.2024.12.21.07.32.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 21 Dec 2024 07:32:53 -0800 (PST) Message-ID: <938c59d4-9ad4-4fdb-bd3d-0de139a940c3@redhat.com> Date: Sat, 21 Dec 2024 16:32:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: remove unnecessary calls to lru_add_drain To: Shakeel Butt , Rik van Riel Cc: Andrew Morton , Chris Li , Ryan Roberts , "Matthew Wilcox (Oracle)" , linux-mm@kvack.org, kernel-team@meta.com, linux-kernel@vger.kernel.org References: <20241219153253.3da9e8aa@fangorn> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: FhT_LIZCHxCjE-78hSrMx_7EczWRSq1XF38gRNRC_P0_1734795175 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 381D52000B X-Stat-Signature: 14ebg6uxo9i5q9e6qoxg15zo1o3jbhw1 X-Rspam-User: X-HE-Tag: 1734795144-751671 X-HE-Meta: U2FsdGVkX19qQKnfn01Oum9twRf84CYAowi63ybrt+GzI/Y4T0I4gwCpJ8rrv4h4c8UJxSANXJXmFYErjGh1y487XCYPPbdfPnipMnsqHgnHB1pVl4nvgNzfXkcBFW41yJYTCFF9eaWVTXolpmZ/pbonE9KpZ9B51xlu0lf12B8ylYBHWiJVRS7liw2Ig4TACvirpvC5OTZsftNzKMN3/1qStPb2UMPy2sWOaqY+DB196PtnBtqfKFrNNEgu2R+NuhpOWs73rHJwTUZPccH1euuzVMort66L1u3Zz1LTT+7vjFJ98hUqTat1KAEindXJRn1xPehudqB0bOmTSu6lIP6st8A2rHJv2rvJ+urMqyn1q4IkovkfizZWnx1tYRN9k58de0gPgr5uC3eiKpYDU1YzaACfVtqcKr0qD6OiYPy2lwe00OXzkbb7ZEMBNokDqNJWpbtx1u2s1ZiqHVccVU5yLbpNMuZkmJ84CkUVERAoQyN1O+v0GO0LUBofhsWJMaAZTTiazbEqN98n1DOnCSIdJB/QYNrCB5vZHyPYJkNvgv3JW8RCN5isuGa+70c6mW3FNuOigvYyGZDfg9lC557qtSFx1ZKJ1XT33d2RxPcE2rNLDVDiFghg/4LRv+jeJ3et4/fKLCpNTc6auAV6X7HMzl/vGF3+cclw72FeF24bLtOZJ0ZqxILGCkD3jbocUMD90p3iBRED9BSCokk1C+VbT3kqkmODTDubn3Jlo8UpR9XJ9N6t/FrP2HBBovWUjD+igXeqI28AxiVc94ITzhSbVB24dtUX2D4yEB25WOe/Xpq29MJB0c4i1KSx2RH4wdrKA8ABewJBSlTEB8Dm9ZWpBvjPnfGxFIQFk3elOXzAuyN/DacCQ9uT16v6gdi1D6Mio5KIyJlVMYmjd4iziG/H2Nk8koGs9HxybJHvf8r7j5ijqJY9/zESlE64S9qyaC31ZyT0KK8b80FWace 4/wHcBcZ L0AwZ4/OfUJ3bO1NFPm4+Llc1vpbic9VfuM64bYX7MOavvP2ZjExV1M9HZhZOLjPQCTlM+r4kDms0mSHfUlw+IWdPyrraVxkdnpVaqae6/41BQuPjMwvafiRGtfaoCCkuQCKnbQipXd4AOWq92oyS5NKaPQYlgthBPD6SrC3Gr0Iap9y0Wrh9HCWJLvM6QRdJyda0WSnWw043m73/6LUwmB+mzUCV/q08mQpVAKVkJgp2NGXXgy7h+vwrTQJhTc0uWYnXojBY+72tSdOrUoKxGudt/0Q676zJUNlbiNLhFCGd7N+xvsr/GvvIasfUcS4HJV3gzC2JysIIhSbL0krp08ltef2L5lzze9dOlAX3jsG3yD45PLuIj67+Z83oOD/DachDZi8KDCtUha2eeRSkz0MYnzDYPyMmA8fpn5dO8arNEUuJyNH1h9feWgVSzvFJMg2xodsMqHmes00Am0Xz0TEQBQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.004997, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > >> tlb_gather_mmu(&tlb, vms->vma->vm_mm); >> update_hiwater_rss(vms->vma->vm_mm); >> unmap_vmas(&tlb, mas_detach, vms->vma, vms->start, vms->end, > > I hope this much history is good enough to convince Andrew. With that > please add: > > Acked-by: Shakeel Butt > Yes, seems reasonable to me. Does it matter on small (32bit?) machines? Hard to judge, but being too careful here likely does not make sense until we learn that there is a real problem. Acked-by: David Hildenbrand -- Cheers, David / dhildenb