From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC4E4C4167B for ; Tue, 14 Nov 2023 13:02:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4F6AB6B02A8; Tue, 14 Nov 2023 08:02:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4A6CE6B02AC; Tue, 14 Nov 2023 08:02:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 347486B02AE; Tue, 14 Nov 2023 08:02:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 24CF86B02A8 for ; Tue, 14 Nov 2023 08:02:33 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id D669380A4E for ; Tue, 14 Nov 2023 13:02:32 +0000 (UTC) X-FDA: 81456573744.28.D571849 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf22.hostedemail.com (Postfix) with ESMTP id 4F6BCC001E for ; Tue, 14 Nov 2023 13:02:28 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="DX/3+my2"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699966949; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/PpHFx76sSgssuhlgI/it3pK9ND5UI7tAiNSjVt9NKs=; b=MBNuhuSMRPld1ur1q06sgTeMWM18NAReoMmQjSdJ3glW0q8po9IO60pERSVcGYOY/MPefq Qa5WFJ2CAsym2QYNRvngwusYMLF78ukJY+nG49EzPil51wcBzmzoaFEZ/owYhLYsW50Xfj G4L8Fzvz5OLFrhNQRZaVk8958Wh0muQ= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="DX/3+my2"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699966949; a=rsa-sha256; cv=none; b=AH28sb86iICkXKJW2XI/OP194R2tpMWbrajayqQUw2zQ1BW4QjnxfrOBLN4DpcJ8sCFj3k IRt6rdlYbB99Z5cxVUp5ionulVs05YNGfrrhbKWdrmxj4sr0rWwDtIAnK9GZ6n+OoE1ep7 TMBvLc3ujyTaLRHIMNqqNuL5rVCL0rM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1699966948; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=/PpHFx76sSgssuhlgI/it3pK9ND5UI7tAiNSjVt9NKs=; b=DX/3+my2UfhqHRbl8m6aBU1EqogWt29x5ZZUI0uV+4de8bNw5kW+BNQ80h3lO1LsvJHBdk 8vF65/gLsts5O2FDfZq27i+3RsKSJKFssz0vT7mSINuZiGMv4Fbc4SEltN9FCPkN94kzAb x33izUkfBtOzwuVb2l9TXB6tIN3wnAA= Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-591-i6h2o5RaMA-7-xXWPipDWQ-1; Tue, 14 Nov 2023 08:02:26 -0500 X-MC-Unique: i6h2o5RaMA-7-xXWPipDWQ-1 Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-41cdffe4d1cso63599131cf.0 for ; Tue, 14 Nov 2023 05:02:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699966946; x=1700571746; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/PpHFx76sSgssuhlgI/it3pK9ND5UI7tAiNSjVt9NKs=; b=hHf/gLzSruqvb1TZSkHFQ99gs0pvOdvpJgmmT5RlsAQiiJ4ASz0iNQ+BCtAcVtMfsJ 9yjVO605662+DDrM0zsYM9hjmTsk0TaC6AapYW93S9lJ0uswWsxKNnfzMjjalr2X6N5U aWWbxll7Pz4N8YKWCZ09f3gG/TPV1bYWrEDBaTWUIEOZH5tC4/Jd51I3+tFFjPUsVFJs L8IYPx8MDgDTyaVGv5gZlOk+xdMv4tjMIXP5Ap6d/ebioFm6Plxt+NegCStYn7stcLYE F8TAG7y2GHpMP5ZYpv9jP6HqUD7TKKnxhpJZF1YnPP731t4dJRBa+MKiuuTsYHyLHJvn FH/Q== X-Gm-Message-State: AOJu0Yy5gX9kA7yspSQNaSDDQiVbnainUt9t3uKUsNwX8lyCdDWp9Emk JI/6txBBl1qedFNT9d38IYCUiLOJ8P1Pd3wNtI3uFSJDePj2z+A8qhVvBR6l81cuXeM/GMMhFrB u0DVPk6UnMnM= X-Received: by 2002:a05:622a:2c5:b0:41e:2948:5389 with SMTP id a5-20020a05622a02c500b0041e29485389mr1937763qtx.15.1699966946242; Tue, 14 Nov 2023 05:02:26 -0800 (PST) X-Google-Smtp-Source: AGHT+IGGbtC/AuEHWZGStv8kD3co7XIIL4fDlNb8E1kr57e9bFjbpfSGsPLhNV5zUmENX9IPwyAvww== X-Received: by 2002:a05:622a:2c5:b0:41e:2948:5389 with SMTP id a5-20020a05622a02c500b0041e29485389mr1937731qtx.15.1699966945824; Tue, 14 Nov 2023 05:02:25 -0800 (PST) Received: from ?IPV6:2003:cb:c73e:8900:2d8:c9f0:f3fb:d4fd? (p200300cbc73e890002d8c9f0f3fbd4fd.dip0.t-ipconnect.de. [2003:cb:c73e:8900:2d8:c9f0:f3fb:d4fd]) by smtp.gmail.com with ESMTPSA id g4-20020ac870c4000000b004181e5a724csm2708828qtp.88.2023.11.14.05.02.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Nov 2023 05:02:25 -0800 (PST) Message-ID: <938be193-8a73-432e-b424-53afa9f8c38e@redhat.com> Date: Tue, 14 Nov 2023 14:02:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] ksm: delay the check of splitting compound pages To: yang.yang29@zte.com.cn, akpm@linux-foundation.org Cc: imbrenda@linux.ibm.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, ran.xiaokai@zte.com.cn, xu.xin.sc@gmail.com, xu.xin16@zte.com.cn, jiang.xuexin@zte.com.cn, wang.yong12@zte.com.cn References: <202311142036302357580@zte.com.cn> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <202311142036302357580@zte.com.cn> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4F6BCC001E X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: mgcrfh81xc33oznidikgzpx64a7xs6na X-HE-Tag: 1699966948-979202 X-HE-Meta: U2FsdGVkX18/RdbY0l/d57zTnggVtLhPoABUXq4h6BKKGO4R5WIsHkES+Gs7ScKWvKhR05dbXPP36Y36crRs92/yOiJ6wBYJyMuPgZ7PmobEim25UkUOlYJ0svt/xXPtDHUSt45QbLYk+etFV/NQhWux8SLhCDdRgqhZnH3a8VXp0NfFGnb3tGXibDkLrkpAsgAJgTvtekPIJK4mnzFm6zgLw/iI9t6NKC73gyAyeL3q8hcnqqky+h8u2K193TDFU1ffQw3DyHJp2QttUyN4bMu0EbfBivxwACZu0Epe1GzlZmiAI5ohsBJiXpa5XClSQ++9Ozr+K2ndVNMPcFTAK823CsUanKkOzcDFxQ1H9VtFm2kpfZNk55a1oEV9mV/cL2qo0kuxAelW9E+Ci2dXOOydOpm2pW8GObBxJ64kxS2gAnNdNHjsl4u2VoQhwzWhgf2rMgdaTZrBQp1yumAbpl6aySRyzVP55nbS45UXocfeKdj6djfMhcXDzdm+PilL6AvLBr5c/sCO5kCvqFLn2HSA2GAP7wv0gU7tMgr8KJT92h1dFKhXTe9gX7VP99pCr0s5tpT4mmpaIfDr8aw9c0JVAvxJei/Wud6hrCL1SNhl8mP5U7zJly1MuHr+NjVlKdNuA3VlmhefT5+vveKg1Vf3Ojov3d5Es0fJ+98QsOFs0SJ3Bd0Eb/4JFNJShHOn0A5l4K2d+miir8YA1CZXfGFcbk9D/eZpA8nvlrhkqOGL4LOZowOcqoHOODFAOq3+zsgfMzuM31aUOiLph39ofCvKO/wDZZXbFUl3MQ1eogXk5iMfLrj6MPMLcqxG0+GkVWvT0zFfJmaVtKOSE/+fAb+pQK/vaSlwPdMzHEfU+duWpA77JrydwrRXT8ZnyaavuBRTYJUaie2g0cY0abpHgcJdtWfToua/3odpJ77mQq6LCt4USfXSp2ZeaWI0ooXS5LJQ0CQAfW1Ms0TIfzZ 9pbJUf7K cxjNIxEx711mCXlQbP0ZGWqYUFEHVaa9dPNPhrazREuYweWWzpKhAgaZZDUsq0kVHBYJU/cs8AVv4npwLILoQnQe6W1/rpfSWsnjqCmhEUFnVC/jC3uTUZ6A2Ae4f9Pvlt72MrcJQ2Vse6dmMjlaUPQt2lfecwzcamDSt7dYUe49oSKqZ2FauJloBp8+hs9QFjvwJNVVlhmOK1nBVRI3xFNgjDrLvzQUzEmm6P1bNiwDZSrIyaZ95YqahpDz2OXZC0c/FYSU7PaF6QDnntNE10viDgZCppy+mhOv2wDuu1DwUPxAmxL+y1qgu+1Sqd+fbbZ6CgJiE/Dzii1IV4m7K25MrDgZTBpRBoIjoNjnWxayEDqmT+onuN53iYVk0l8+oop0oJ/t8VU+9nAaUe9INTreh3GXzLf9OOMPk7BnhqxVxWAygCHCGmXTH06smcLM8tn1HzzEC/CASWlx1VGfDgFPEi+9u92yQsngEOyccMbiXNiqthzabaKki0mIiRb3Cwqn/pi7ADeROjU+fAdxjfTi9QyOL7jtNZEYNBQC+kNF4Q8Q= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 14.11.23 13:36, yang.yang29@zte.com.cn wrote: > From: xu xin > > Background > ========== > When trying to merge two pages, it may fail because the two pages > belongs to the same compound page and split_huge_page fails due to > the incorrect reference to the page. To solve the problem, the commit > 77da2ba0648a4 ("mm/ksm: fix interaction with THP") tries to split the > compound page after try_to_merge_two_pages() fails and put_page in > that case. However it is too early to calculate of the variable 'split' which > indicates whether the two pages belongs to the same compound page. > > What to do > ========== > If try_to_merge_two_pages() succeeds, there is no need to check whether > to splitting compound pages. So we delay the check of splitting compound > pages until try_to_merge_two_pages() fails, which can improve the > processing efficiency of cmp_and_merge_page() a little. > > Signed-off-by: xu xin > Reviewed-by: Yang Yang Can we please add a unit test to ksm_functional_tests.c so we actually get it right this time? -- Cheers, David / dhildenb