From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04FDAC5B552 for ; Mon, 9 Jun 2025 10:34:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 96AF56B0099; Mon, 9 Jun 2025 06:34:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 91B726B009A; Mon, 9 Jun 2025 06:34:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 859096B009B; Mon, 9 Jun 2025 06:34:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 67B176B0099 for ; Mon, 9 Jun 2025 06:34:23 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 234CDC19FE for ; Mon, 9 Jun 2025 10:34:23 +0000 (UTC) X-FDA: 83535502806.08.0C78D8A Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) by imf19.hostedemail.com (Postfix) with ESMTP id 240CB1A0006 for ; Mon, 9 Jun 2025 10:34:20 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=neon.tech header.s=google header.b=jkWPpXWf; spf=pass (imf19.hostedemail.com: domain of sharnoff@neon.tech designates 209.85.208.51 as permitted sender) smtp.mailfrom=sharnoff@neon.tech; dmarc=pass (policy=reject) header.from=neon.tech ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749465261; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kPFw96LcZwktws5xLzqqPvxWDw8Thkx4RgtuQnSXllU=; b=qX3wzNZb3WXpchNp/IRqQ7/H4UVXXam39rNkHX9vjyTBVzneQDmUzuu51PuaHM9H/KqwKe fSto9vhwysMJP+g/fs1MNLuON+TaLjISoCTgflAO0r+TtpfMwyigxFJJCLI61AOuaIyLNf /e2ea0wHUcf1HmLssFTB6qTbTW8WjMI= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=neon.tech header.s=google header.b=jkWPpXWf; spf=pass (imf19.hostedemail.com: domain of sharnoff@neon.tech designates 209.85.208.51 as permitted sender) smtp.mailfrom=sharnoff@neon.tech; dmarc=pass (policy=reject) header.from=neon.tech ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749465261; a=rsa-sha256; cv=none; b=bFfWE8P7NLjBFZ9z86bQfLDLdShJyKtkXW3l0k5TMW8VW14UIB2O5iznbY+aO/VyqpLufD 4FQ6n3UGF4aPW73EKGemiwPEN/X2TIFJpSNwZrRcPVI1PydKf+14oCkpz8gmKSgQzKVwOi 7JVgerpWdCVA1mXsKNzoppWXZ1mtisk= Received: by mail-ed1-f51.google.com with SMTP id 4fb4d7f45d1cf-605b9488c28so6663575a12.2 for ; Mon, 09 Jun 2025 03:34:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neon.tech; s=google; t=1749465260; x=1750070060; darn=kvack.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=kPFw96LcZwktws5xLzqqPvxWDw8Thkx4RgtuQnSXllU=; b=jkWPpXWft8o3Prx0hxS5nGO2xZXr43ngDlxZMk8HbweT3p3vztUQ0L3FgX5bVTxIJ5 JmE1QgXJMI1b4fdmYdHXy1HuTm0LtoiX0MTP9L11yvggG3ztHIgDwjyuC4t7K8Va8Mz7 js6/k1RMnxa21WQIjaCCgms07roK49ED0Xq2A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749465260; x=1750070060; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kPFw96LcZwktws5xLzqqPvxWDw8Thkx4RgtuQnSXllU=; b=ucrxhRfF3NZ872MA3Is8ltAI+w/G1t3l+tJCp8cZk90EaSf1YtVjYEg0GoZ+qviwEP LTl9Uh6jaeQpgjW65Fd/9n2o2/SsyQDoUw3F8LbHiq7mK7J1ieXJbbHvWOxnP6CDjCo6 1nPNh5ttRnvQarl0bAKLlnymgouPKY4FnXDo947lrsnuzPJQfMYOOwGJdwUOuXFgMHKS Y1mi+yhU4L7S2t/6vvkb1yLV9+4vUs4VfIDlNLbT+xkny+OD598U1Rg46PiRUKZ46BO5 wIXL2KOcuWbNDuIrP2/D4FsiqZqTZ4O3hhUuj3GKFLpKaTIYdb//Li/cZJoUvc2k9fr5 n2uw== X-Forwarded-Encrypted: i=1; AJvYcCUfMbAS2+d9Md7XhpGoJR5wI4qts59Yf+CTgzFX1KurZUjxB/Uhk5RDIJ9jYZ5feHWoxcP3H8lhhA==@kvack.org X-Gm-Message-State: AOJu0YzB/xyurNQBw93XySwOVCE1gnDUgH9/1DoB/DMMuozRTLDQ+I67 NvmqqpsT/wOz0rEWnWz3O/qGAO2cCnzsPXZBhNYoNLq5/vpDwbIGxnhirCBD4h6/G+s= X-Gm-Gg: ASbGnct8iOKfhL3BWZfA2Trk7tji5Gkf6x+1DmVD/OjT2J9RNzXy1fJMmol5i1W/ylx 7yZEn1f73pixaIJldB40CrYvX2cHHNdwWEdlpEhlLXcsKdEuwcIw9dECJFv10CEDaLn0ZS6VSuJ fFITZ7a/ssaiMfub5AVTpMhakGFXWOi6sYpGOX1zgTS59A+bOcQaw/3ctfBjSjZ4EPjyS++gqFf /LRvIO9ivW1NndaC2QEAaMSC/nKiQPGZKDbco1pIoOmySS8k5vAJFkiKCMEKs/YbE/4DBpnkIGp tf2iIjQ0PdbTqJw2wuCax8xuWD04VriLHDHQdAXo+FJ1HcqZRlFSs+hfexPbMvMsXg== X-Google-Smtp-Source: AGHT+IFl/hTMXfTGlX5BQe31tgUG2iMar2OR7eu8laWIXpp/pAXK65O+l/opJrf5bs7GemkIXNgwgA== X-Received: by 2002:a05:6402:2551:b0:607:116e:108d with SMTP id 4fb4d7f45d1cf-6077479d4b5mr9637962a12.21.1749465259634; Mon, 09 Jun 2025 03:34:19 -0700 (PDT) Received: from [192.168.86.142] ([84.65.228.220]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-607783701bdsm4477721a12.2.2025.06.09.03.34.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Jun 2025 03:34:19 -0700 (PDT) Message-ID: <9386a5f6-e663-405b-9b28-dcfeffc83fb0@neon.tech> Date: Mon, 9 Jun 2025 11:34:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH v2 2/2] x86/mm: Use GFP_KERNEL for alloc_low_pages() after boot From: Em Sharnoff To: linux-kernel@vger.kernel.org, x86@kernel.org, linux-mm@kvack.org Cc: Ingo Molnar , "H. Peter Anvin" , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Borislav Petkov , "Edgecombe, Rick P" , Oleg Vasilev , Arthur Petukhovsky , Stefan Radig , Misha Sakhnov References: <0ce5e150-19e0-457f-bec3-ee031c0be7e7@neon.tech> Content-Language: en-US In-Reply-To: <0ce5e150-19e0-457f-bec3-ee031c0be7e7@neon.tech> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 240CB1A0006 X-Stat-Signature: cf9gj9myw5dqprwjin8eaurok5ht9thz X-Rspam-User: X-HE-Tag: 1749465260-743801 X-HE-Meta: U2FsdGVkX18l/ysH2MVVd6o0ORKFRruHYjhGnY6G1tNnOUrVZ3HgRkmQw7ufnrPAdcu/zWswWqqTSTf73t5XFohIDXgoUqxHqp4tMijG51cIy2o0iuCm1yyJtlLjhMEZ/wD9iur3+4SXrfioISvD0m5x1EsNbXDaDgWmT3uHdnvGGnm0swECfZOk8tmFEq8RzmLAWAZ8ClTB9u0BH91qmG6M+D7h4buKjCBo92LaLcAiJ8DsO6kmJ1cLmfmTeE2L5P72um5YwKN69l8HzTT3h7SlRq3+q4S24ptGUHm15RQmhunMjMFdi5lELeZVJCBXH/PTToZY3moLPBQh7I6Ice6DLjjwWY/h01M5C6W6DBv9IXKAVG1QivasojsS5dLYbP1Wc929YNU3mpnSdPMif+oapDDBDFepEIjWoF6QoSpoe/6kIjdR3H9g2PCPZ5Ks7d2WETAgbXm4T/N10d6NU0K0ITsolP096/6APZQu50yJVPiWJ0W14S403TZ+RgoCjjjWA3vgf6m3upmQlvyLMTjUNWS+G3k63iDNtW2aW4buYKxeFOishg4jSThHj+7BKqvDOwDTSoEG2xOwKvA4Hf3+p7pDMk4zQeTxK6j6nmMFz7cxF8tVtgkcs5HeNIjpV1NdLPQnAKHPTgw32oO9uZIGOS7VLUNnLKM9C4Db3D2olYA9+06+ypLtGjM2xd9FUWva2MqByTMuGm8rQUZg1Ma3YK8p1GPNo0DMmqVG54OYzxdcQbUW8IIk7QtjJDmu+wnGQVThvlNbivG+JZphCiSS0pfXxEF+X0wTjbOQv4XH9mqlpAwEEn/CoNSBk4OrBRMH9lA6XJpBE+uLSD49mOXHRn7OHWHwe0KLqsaRvXc5lkd3WjmV6ol+inCPQpA85JUAqZNxyL617g2/lrRiCerLsiBoY6FB6qayHTPc1xBXEAnbaUoqRu2kIaxB+sfQ1t79q1A4DD730siIzqI cjBg0HOs jpmas+m/o5zf7xpBKHjyxqUFe2iFpf/D78ag93ruf04PD9fhvDn17+PU/dPN8zAtsaMcvVLKYc2JfWfl6qo/UOISvFCjV8Tgdoj3r9LQaVn/8LPJ4ZrBMA+ItcXQ0wdZDo5MP2MOdHWYWUFzJ3NYUtNfri0viWHsNQgx2O4ADU9mCBbde6ZzmrXih2U1h4rPp/irMcmY4x0Wv96aRrRhtcyT+35ONN1FDAKkVEGHc/vcrMOgXfwjm8w8VVLdXWRdrU9DBnAWlylnF+6qmjSlguqoIRC6R30T6yzYWQ/pgvuNw+pd4LFnQEH99mwNEcfwnDIRo5gv41YhsOwucWaTWQfiO8VQq7eIi0nzk3ePL1DINQli1OrThnqtqO+cpfeOHVgligejJ9tQtotEvQu8vxCIkjO9mtjd254TuZbNOyeo87+FjbCuob/GhBPu37Z4zKOxKcPRp48drggevnZPVvBeu84wz8vzK97OiXRN8G0onqJShFuTA4uItxQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Currently it's GFP_ATOMIC. GFP_KERNEL seems more correct. >From Ingo M. [1] > There's no real reason why it should be GFP_ATOMIC AFAICS, other than > some historic inertia that nobody bothered to fix. and previously Mike R. [2] > The few callers that effectively use page allocator for the direct map > updates are gart_iommu_init() and memory hotplug. Neither of them > happen in an atomic context so there is no reason to use GFP_ATOMIC > for these allocations. > > Replace GFP_ATOMIC with GFP_KERNEL to avoid using atomic reserves for > allocations that do not require that. [1]: https://lore.kernel.org/all/aEE6_S2a-1tk1dtI@gmail.com/ [2]: https://lore.kernel.org/all/20211111110241.25968-5-rppt@kernel.org/ Signed-off-by: Em Sharnoff --- Changelog: - v2: Add this patch --- arch/x86/mm/init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/mm/init.c b/arch/x86/mm/init.c index 82dd5ce03dd6..bb5fe21f4794 100644 --- a/arch/x86/mm/init.c +++ b/arch/x86/mm/init.c @@ -131,7 +131,7 @@ __ref void *alloc_low_pages(unsigned int num) unsigned int order; order = get_order((unsigned long)num << PAGE_SHIFT); - return (void *)__get_free_pages(GFP_ATOMIC | __GFP_ZERO, order); + return (void *)__get_free_pages(GFP_KERNEL | __GFP_ZERO, order); } if ((pgt_buf_end + num) > pgt_buf_top || !can_use_brk_pgt) { -- 2.39.5