From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A8D3C433FE for ; Wed, 23 Mar 2022 13:19:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9A0506B0072; Wed, 23 Mar 2022 09:19:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9502C6B0073; Wed, 23 Mar 2022 09:19:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7F06B6B0074; Wed, 23 Mar 2022 09:19:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.a.hostedemail.com [64.99.140.24]) by kanga.kvack.org (Postfix) with ESMTP id 6C6E96B0072 for ; Wed, 23 Mar 2022 09:19:33 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 31D2124383 for ; Wed, 23 Mar 2022 13:19:33 +0000 (UTC) X-FDA: 79275707826.15.1540652 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf22.hostedemail.com (Postfix) with ESMTP id 7639FC0037 for ; Wed, 23 Mar 2022 13:19:32 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id E2EBE1F37F; Wed, 23 Mar 2022 13:19:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1648041570; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=skAPDzFpHTiodgB8Q02pBrdUfjbG2DP3aT/OV2kUCTg=; b=ExWKBH5gbebZ2qLYLYhoqyuTeCoOFEeTDXcHTyKzVTsy7cEJjCYK6VddO3UW7yGD+ja2Cu SrZnNBg0QIK1yZsSQPDEIxkQ45o4i57nTrErjU5qicqaZABRbr95w4AvNZ3e9QyzZnujTs nm7tAt0Q1y8Sf0+UfJEtEENErmnZCco= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1648041570; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=skAPDzFpHTiodgB8Q02pBrdUfjbG2DP3aT/OV2kUCTg=; b=xJJQhmlpXwoElCRd9f8SJOA1NqCjyl8IfEx5JKFWYW8GBDuHAdGI+N76EUs5DvqbMFysNf vQk/tHT2uqjB5mDQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 6F60C12FC5; Wed, 23 Mar 2022 13:19:30 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id ud/kGWIeO2KkJgAAMHmgww (envelope-from ); Wed, 23 Mar 2022 13:19:30 +0000 Message-ID: <93851312-6443-31ec-c194-8117e483f5d4@suse.cz> Date: Wed, 23 Mar 2022 14:19:29 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v6 27/39] kasan, mm: only define ___GFP_SKIP_KASAN_POISON with HW_TAGS Content-Language: en-US To: Sebastian Andrzej Siewior Cc: andrey.konovalov@linux.dev, Andrew Morton , Andrey Konovalov , Marco Elver , Alexander Potapenko , Dmitry Vyukov , Andrey Ryabinin , kasan-dev@googlegroups.com, linux-mm@kvack.org, Vincenzo Frascino , Catalin Marinas , Will Deacon , Mark Rutland , linux-arm-kernel@lists.infradead.org, Peter Collingbourne , Evgenii Stepanov , linux-kernel@vger.kernel.org, Andrey Konovalov References: <44e5738a584c11801b2b8f1231898918efc8634a.1643047180.git.andreyknvl@google.com> <63704e10-18cf-9a82-cffb-052c6046ba7d@suse.cz> From: Vlastimil Babka In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: k5qpyy6teg6meahiy6f6togtngk7r4rn Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ExWKBH5g; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=xJJQhmlp; dmarc=none; spf=pass (imf22.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 7639FC0037 X-HE-Tag: 1648041572-158231 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/23/22 14:02, Sebastian Andrzej Siewior wrote: > On 2022-03-23 12:48:29 [+0100], Vlastimil Babka wrote: >>> +#ifdef CONFIG_KASAN_HW_TAGS >>> #define ___GFP_SKIP_KASAN_POISON 0x1000000u >>> +#else >>> +#define ___GFP_SKIP_KASAN_POISON 0 >>> +#endif >>> #ifdef CONFIG_LOCKDEP >>> #define ___GFP_NOLOCKDEP 0x2000000u >>> #else >>> @@ -251,7 +255,9 @@ struct vm_area_struct; >>> #define __GFP_NOLOCKDEP ((__force gfp_t)___GFP_NOLOCKDEP) >>> >>> /* Room for N __GFP_FOO bits */ >>> -#define __GFP_BITS_SHIFT (25 + IS_ENABLED(CONFIG_LOCKDEP)) >>> +#define __GFP_BITS_SHIFT (24 + \ >>> + IS_ENABLED(CONFIG_KASAN_HW_TAGS) + \ >>> + IS_ENABLED(CONFIG_LOCKDEP)) >> >> This breaks __GFP_NOLOCKDEP, see: >> https://lore.kernel.org/all/YjoJ4CzB3yfWSV1F@linutronix.de/ > > This could work because ___GFP_NOLOCKDEP is still 0x2000000u. In Hm but already this patch makes gfp_allowed_mask to be 0x1ffffff (thus not covering 0x2000000u) when CONFIG_LOCKDEP is enabled and the KASAN stuff not? 0x8000000u is just even further away. > ("kasan, page_alloc: allow skipping memory init for HW_TAGS") > https://lore.kernel.org/all/0d53efeff345de7d708e0baa0d8829167772521e.1643047180.git.andreyknvl@google.com/ > > This is replaced with 0x8000000u which breaks lockdep. > > Sebastian >