From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EBE8E64A93 for ; Tue, 3 Dec 2024 13:33:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C728C6B0089; Tue, 3 Dec 2024 08:33:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C214C6B008A; Tue, 3 Dec 2024 08:33:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AE9D56B008C; Tue, 3 Dec 2024 08:33:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 8F0E26B0089 for ; Tue, 3 Dec 2024 08:33:29 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id E4051AE50C for ; Tue, 3 Dec 2024 13:33:11 +0000 (UTC) X-FDA: 82853738604.30.8C0FC80 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf07.hostedemail.com (Postfix) with ESMTP id 161FE4000E for ; Tue, 3 Dec 2024 13:32:55 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=3BI+y1Zx; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=1mYxALwo; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=3BI+y1Zx; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=1mYxALwo; spf=pass (imf07.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733232775; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jdmQf9A9c3+pcii2FDFPbM18TTsEtfAMO3Iwr/KW5xk=; b=In1sexIzzDQ+9rIVgqJmAo2eVm0kCw+pgqWDexbTFysTwQuxlimGmEtne967M7Pui7LEGP MiXhWxpkV5VP1eMzH+MefFRhIl0aqkxgg4V2q6sSpaqzIdFtbSUD2TfRs2yvNCtf8Gd8Gb IzNkWNyubXmVjCOir351HshYaG9CeCQ= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=3BI+y1Zx; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=1mYxALwo; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=3BI+y1Zx; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=1mYxALwo; spf=pass (imf07.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733232775; a=rsa-sha256; cv=none; b=n3DbbsimJfyxuECJk6TtCi3gU7PYAWUqdx6c1vbcN2d2Bj0+qS4UFjE1OOumiJGriUbO6N wAhRFVYLd5gsB+1NXrz/PTuBEEvY2z9w623RfSPiC4R2NyHe//N2IyXoDIJ7Wnc62JYWkt enWAJbHyT1PZ91CdUzp5ckcdx7W32L4= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id F3E371F453; Tue, 3 Dec 2024 13:33:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1733232788; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jdmQf9A9c3+pcii2FDFPbM18TTsEtfAMO3Iwr/KW5xk=; b=3BI+y1Zx5pK8pEkAYDlNNxGsUYH79LE8hNS6sv4umXISbA+A35iKYgNl+Dyt3gCIBlBGwt 49BTNXSBUEcqH/7XNxo7D39GflzLxqqJwHSULnpJt7N81ZOwE9quzF/7sT9lI2F0mwH1c6 iO+g9CwJpG4hY8eZbo0TYDahIiB6UgU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1733232788; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jdmQf9A9c3+pcii2FDFPbM18TTsEtfAMO3Iwr/KW5xk=; b=1mYxALwof+5OJlVTprquUJGOpEGw4EFe6sgO/3cVSflyf5paULj9ngRZTi+XPYMJDNthIn wZlkTI7GYlCwyrAg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1733232788; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jdmQf9A9c3+pcii2FDFPbM18TTsEtfAMO3Iwr/KW5xk=; b=3BI+y1Zx5pK8pEkAYDlNNxGsUYH79LE8hNS6sv4umXISbA+A35iKYgNl+Dyt3gCIBlBGwt 49BTNXSBUEcqH/7XNxo7D39GflzLxqqJwHSULnpJt7N81ZOwE9quzF/7sT9lI2F0mwH1c6 iO+g9CwJpG4hY8eZbo0TYDahIiB6UgU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1733232788; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jdmQf9A9c3+pcii2FDFPbM18TTsEtfAMO3Iwr/KW5xk=; b=1mYxALwof+5OJlVTprquUJGOpEGw4EFe6sgO/3cVSflyf5paULj9ngRZTi+XPYMJDNthIn wZlkTI7GYlCwyrAg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id D833313A15; Tue, 3 Dec 2024 13:33:07 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id XsJfNJMIT2e6IQAAD6G6ig (envelope-from ); Tue, 03 Dec 2024 13:33:07 +0000 Message-ID: <93808ae8-4607-41b1-ba6c-20c78279d6f7@suse.cz> Date: Tue, 3 Dec 2024 14:33:07 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RESEND v2 3/6] mm/page_alloc: make __alloc_contig_migrate_range() static Content-Language: en-US To: David Hildenbrand , linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, Andrew Morton , Oscar Salvador , Zi Yan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Madhavan Srinivasan References: <20241203094732.200195-1-david@redhat.com> <20241203094732.200195-4-david@redhat.com> From: Vlastimil Babka In-Reply-To: <20241203094732.200195-4-david@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 161FE4000E X-Rspam-User: X-Stat-Signature: pnpqnbnhfcg4737rykg4cypcoiikwu3k X-HE-Tag: 1733232775-496653 X-HE-Meta: U2FsdGVkX1+VTK4tJ8LQm8sEcMzvyTFeEzFlW4L09SWcafW2kEuiVgp4cvwvv68dYgn4lGwJ3jSeSGTncPoK2J/40uJw4EPw8s1yHTtf06d8V187ONBDaXmFhP9E2uKiFbk3Biz80/No93n6FOvUETJ+N96fCA9TAwhzV5K5cZg6Uo0Mzf97HaPkv5mSq+Ikt3mNzVYG8W2mUyFaHWVj1xyD4RWSik2jPI4cZQ8HDguBkS4iLbuVIiJfG1hDizbR6UAVD91hgy6tBz+l3Tr5WPGbHQ0fAwFmMUt5b3xG99cQ1/B2UFEaz+7hvI78MFDvi8TNFCiGbmaHA6aezybt1U2t5RUBbH7TBtYQDulRdx/coUTFb4Btz+9c/dV0JOeOReGeTIAo1qa5tROGmWYSorrVZN8Yq1HQ4vC/8I3znJ/TgLuO30dfc3yqtxz2Oa4D9ueowDzhJWE6fXUi++ovGlfMa9GoBfFTGA42NawXduOgNqPjrxGkJaIfaqBpM6wnwobwHZZNx+nmYjKxTfE62NQ78m163MmS6n/SQ1kaexkgFCLefeJlUetz3Mqjrm2xUdpRH2T1x5dYie6XNIs0yggGz/0VSRZYPjTcJ5zvvv4pa85IjVfZSCUc3KC2drHgmmN1peXn9qxsIm1+LvjRtmmeWxHhiiWxl1k3UIFO4AY05vrl3KZgIaEorWva78ecGqXTw4Q01dfjT81kFxRqZthcvILONmj5huLErHzGJsIrHcasuFYsHrWteRp+Zc/1uc2+pK6SZK4L3eX6VspMk1jHWk/2bIDc6nOQlIz7lviJH8i6+eQiaNEKSh6e4PjiHjHysaQ3iQiBCw4WNWqP5Z1jzPaWxe75wMGymZ8yc6JqP5CHnQm7uW+/KnMkXqeWQEeRaCoKoE34PivppixO4AobPQ6XyEIU4taRTfdlMpHVPfMJ56pO0zbsqICZTVJYsrX9iIHvOCdxgAtt86M OYHnDS8V odoAhUiMFc3E/DoNBIApoGKVh6xeAyQPBwSY1/qX++SnHzIYnoLTaeZ7F6GxBCS0AUIy432z3oY4IxoN7XRCu48vBXte+BEagekDTYFbpa31pTfInMpxCh6K3tnL8tmD8wmK1alyQzsBLVbWFmczvLq96u7Whr49xZV5EOIxTPdtU21OBCxA+uDtwA4QQxc2tKUNMYDqR6mkAjoiRaWwAXYmvbv5k9A7HSuoeZbQAHxiYJQllOrJ2AURXJ45D3Hz1m/A2f+wQZyRKoaGrOyNfjm08/rijJ4HICQKlWWuGBUcU4SP0W3AsnSNdglp+s6Peg1gbYuRkgk+FX546LjwHSS14zl6Is0g3WcscrSs+p+F0LBH4oItbRnqxIicsFt716FLa X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12/3/24 10:47, David Hildenbrand wrote: > The single user is in page_alloc.c. > > Reviewed-by: Zi Yan > Signed-off-by: David Hildenbrand Reviewed-by: Vlastimil Babka > --- > mm/internal.h | 4 ---- > mm/page_alloc.c | 5 ++--- > 2 files changed, 2 insertions(+), 7 deletions(-) > > diff --git a/mm/internal.h b/mm/internal.h > index 74713b44bedb..4bd3685c33ef 100644 > --- a/mm/internal.h > +++ b/mm/internal.h > @@ -839,10 +839,6 @@ int > isolate_migratepages_range(struct compact_control *cc, > unsigned long low_pfn, unsigned long end_pfn); > > -int __alloc_contig_migrate_range(struct compact_control *cc, > - unsigned long start, unsigned long end, > - int migratetype); > - > /* Free whole pageblock and set its migration type to MIGRATE_CMA. */ > void init_cma_reserved_pageblock(struct page *page); > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index f371fbf2145b..ce7589a4ec01 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -6284,9 +6284,8 @@ static void alloc_contig_dump_pages(struct list_head *page_list) > * @migratetype: using migratetype to filter the type of migration in > * trace_mm_alloc_contig_migrate_range_info. > */ > -int __alloc_contig_migrate_range(struct compact_control *cc, > - unsigned long start, unsigned long end, > - int migratetype) > +static int __alloc_contig_migrate_range(struct compact_control *cc, > + unsigned long start, unsigned long end, int migratetype) > { > /* This function is based on compact_zone() from compaction.c. */ > unsigned int nr_reclaimed;