From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FA34C4727F for ; Tue, 29 Sep 2020 20:20:20 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 78D7720774 for ; Tue, 29 Sep 2020 20:20:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="BPLY8Xv4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 78D7720774 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9F7226B005C; Tue, 29 Sep 2020 16:20:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9A7956B005D; Tue, 29 Sep 2020 16:20:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 86E326B0062; Tue, 29 Sep 2020 16:20:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0092.hostedemail.com [216.40.44.92]) by kanga.kvack.org (Postfix) with ESMTP id 726BB6B005C for ; Tue, 29 Sep 2020 16:20:18 -0400 (EDT) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 2E59D181AE865 for ; Tue, 29 Sep 2020 20:20:18 +0000 (UTC) X-FDA: 77317216116.04.door33_54071b32718d Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin04.hostedemail.com (Postfix) with ESMTP id 115D180108A7 for ; Tue, 29 Sep 2020 20:20:18 +0000 (UTC) X-HE-Tag: door33_54071b32718d X-Filterd-Recvd-Size: 4938 Received: from mail-oi1-f193.google.com (mail-oi1-f193.google.com [209.85.167.193]) by imf23.hostedemail.com (Postfix) with ESMTP for ; Tue, 29 Sep 2020 20:20:17 +0000 (UTC) Received: by mail-oi1-f193.google.com with SMTP id 26so6930992ois.5 for ; Tue, 29 Sep 2020 13:20:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=wY55VXytWU5dCb+yWsv+Hifz95sQhPM0ZRLjoZrF/Ks=; b=BPLY8Xv4N6HnAC2bhuVuHqsZLkqCRc3/qbrl8KFAlCtq8Kx4wgRywyzRbbG4+67cnz 7MPFNhrMkC2n4w3iaRpN03wj667JrqGXdCmrbRnqmqQbtDSx0PAMYXaCLv3Cb5UGGdQv eBY42MTMnDfHkjUH2avoe0cnVozJtma7NQnuo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=wY55VXytWU5dCb+yWsv+Hifz95sQhPM0ZRLjoZrF/Ks=; b=N44yhBAdnQu9fI+9ZQDqrE/qCqXg7Ow6GDlwhIMVKGV60thRbokEDGA+M/pXkSLMs4 0U5JiwauOCNJlXBXSf/+bWUMhKltWOIhLe0MQLZNN/s1U2JxzURpO3cgO5QE9huaCMKr BR7cztr+Xg3tWt13Cx/5W5B0b8Zuuan2Zh3+hJ3fuNJEZRcJJd6g9EJ01ooLnzRyvnY9 bx2c9wDKeUFzV+w7aUR1kcIs4ZTgP/3zOCNgfeu//4Qm3FLBCNGtVYqD1se6K1TO0e0V KQ5jdgIp+ge/rERoL3++Ky9MQkGCdgcIcRoYnA/+PZNyQAhMxZfw7sxeMLsuI2Q0Gc8L fFyA== X-Gm-Message-State: AOAM533ffqZsuOmJwgDT0V5oA/tkftTatR+gkiyueWeDvRL5pP6jQw43 debT5ZjJPrezuAtyCM96VFXjoQ== X-Google-Smtp-Source: ABdhPJx2G75pZmtHUCD3k52jfMCL7SVqKa2890dy8PwYAsBGtG2hEWWaiVsDUDtlALJU/ySZWzcVKw== X-Received: by 2002:aca:df84:: with SMTP id w126mr3834010oig.103.1601410816915; Tue, 29 Sep 2020 13:20:16 -0700 (PDT) Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net. [24.9.64.241]) by smtp.gmail.com with ESMTPSA id 65sm1238278otj.75.2020.09.29.13.20.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Sep 2020 13:20:16 -0700 (PDT) Subject: Re: [PATCH 2/8] selftests/vm: use a common gup_test.h To: John Hubbard , Jason Gunthorpe Cc: Andrew Morton , Jonathan Corbet , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Ralph Campbell , Shuah Khan , LKML , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org, linux-s390@vger.kernel.org, Shuah Khan References: <20200928062159.923212-1-jhubbard@nvidia.com> <20200928062159.923212-3-jhubbard@nvidia.com> <20200928125739.GP9916@ziepe.ca> <6481e78f-c70d-133a-ff4a-325b5cd8fd5d@nvidia.com> <20200929163507.GV9916@ziepe.ca> <20200929175524.GX9916@ziepe.ca> <715c49ec-d2a8-45cb-8ace-c6b1b4b8f978@nvidia.com> <20200929190816.GY9916@ziepe.ca> <3022912c-f11b-f564-3a8a-f516ca259a37@nvidia.com> <20200929195356.GZ9916@ziepe.ca> <64bb5ba7-77f7-2f09-44f0-29ee9329b183@linuxfoundation.org> <554699c6-cc01-4c3c-3ed5-26d22ac3bac0@nvidia.com> From: Shuah Khan Message-ID: <9372727e-1a79-913b-5391-e0c4a85bf5a7@linuxfoundation.org> Date: Tue, 29 Sep 2020 14:20:14 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <554699c6-cc01-4c3c-3ed5-26d22ac3bac0@nvidia.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 9/29/20 2:11 PM, John Hubbard wrote: > On 9/29/20 1:00 PM, Shuah Khan wrote: >> On 9/29/20 1:53 PM, Jason Gunthorpe wrote: >>> I only remarked because I didn't know it wasn't using kbuild. I >>> thought it would have used the existing HOSTCC stuff, not sure why it >>> is special. >>> >>> The only investment that seems worthwhile would be to switch it to use >>> the normal kbuild stuff?? >>> >> >> I explored switching to kbuild at the kernel summit last year during >> my kselftest where are we talk. >> >> There was push back from several developers. We can definitely explore >> it as long as we can still support being able to build and run >> individual subsystem tests and doesn't break workflow for developers. >> > > Do you have a link or two for that? Especially about the pushback, and > conclusions reached, if any. > Unfortunately no. A I recall it was workflow related issues and ease of running individual subsystem tests and backwards compatibility with stables. Let's start a new discussion and see where we land. thanks, -- Shuah