From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 516ABC88CB6 for ; Mon, 12 Jun 2023 16:30:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CC0A86B0074; Mon, 12 Jun 2023 12:30:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C71646B0075; Mon, 12 Jun 2023 12:30:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B38826B0078; Mon, 12 Jun 2023 12:30:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id A37136B0074 for ; Mon, 12 Jun 2023 12:30:43 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 5CEBC802B0 for ; Mon, 12 Jun 2023 16:30:43 +0000 (UTC) X-FDA: 80894634366.22.5788202 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by imf20.hostedemail.com (Postfix) with ESMTP id 038771C002C for ; Mon, 12 Jun 2023 16:30:39 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=b1FMm2fM; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf20.hostedemail.com: domain of dave.hansen@intel.com designates 192.55.52.136 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686587440; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=o8NkCv+nmFe6PYuIX7T0kcYFlC/1dGxjV3PE4Wgqex8=; b=uCHGjhMMw5sfpTtjX94d6KaY+SUE6RFp4ooIQ61fNeJKfPNBWMvfNy4vDu2evp1QbfjsYF aUAWeDwu4iNUNjJOflqpPpJnbXQHNWKAO45gpEIiWf3ID8+Oo0A6AFKeTglcVtsiQlk5qa KZ9Fq6LHqCQMQrjaCB3CWgF8HatWBYI= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=b1FMm2fM; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf20.hostedemail.com: domain of dave.hansen@intel.com designates 192.55.52.136 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686587440; a=rsa-sha256; cv=none; b=PemcSDCQBERRjWtwWdut3iA2Qux/CxlFAeBLHWMl1PaWzQUCxOasjyik3eOrzh9Qlyy16V EVS9aTe+laYFN5UfUDPzmgFMhpy7XeBDe+uXRdN55FpicIU6simIqjLXKU+kPBhN7GWYYj hF/C7uuRfFBB244B2BhAH96kom5hO0s= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1686587440; x=1718123440; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=QhNATEJQnWJ6d9I9Xkx5FpQ9VU6vwCfeDSbUV8NvC4c=; b=b1FMm2fMIsry/A7jREFCDE+wjPC48RgDXLxivqe0ApJCnAECXb79qh7k cNgdtw+//6trHHrZCKrMcUQocxgp8M2ksfl3FrYiZJq9NqE6ImRHn9esN Klqs3n2rYHe67YT1tUJO7N3aEtUM+9T0O082U0jpEyoxopdWE5shsPhLd BHpv/cO81x9bhmobHZ6SM6eiupDkLeG9cS8eByq5cc8AFlLu1yGk+IHOW f5MMlbjc8/WaX4S8u+wczvXIjgy0G1WCdOhh5GqDk/twrJxCdT9kUHKuz glNrQu8KnEPZ+yJpEPwrOmM+I42gwDetiTxQLtJElwhTG1BTJ/9vWEDvX g==; X-IronPort-AV: E=McAfee;i="6600,9927,10739"; a="337729022" X-IronPort-AV: E=Sophos;i="6.00,236,1681196400"; d="scan'208";a="337729022" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jun 2023 09:30:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10739"; a="1041415457" X-IronPort-AV: E=Sophos;i="6.00,236,1681196400"; d="scan'208";a="1041415457" Received: from spmantha-mobl1.amr.corp.intel.com (HELO [10.209.43.2]) ([10.209.43.2]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jun 2023 09:30:36 -0700 Message-ID: <93654914-c3d9-8927-8ab2-ee4597426924@intel.com> Date: Mon, 12 Jun 2023 09:30:35 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH RFC v9 12/51] x86/fault: Report RMP page faults for kernel addresses Content-Language: en-US To: Michael Roth , kvm@vger.kernel.org Cc: linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com, ardb@kernel.org, pbonzini@redhat.com, seanjc@google.com, vkuznets@redhat.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, dovmurik@linux.ibm.com, tobin@ibm.com, bp@alien8.de, vbabka@suse.cz, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, marcorr@google.com, sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com, dgilbert@redhat.com, jarkko@kernel.org, ashish.kalra@amd.com, nikunj.dadhania@amd.com, liam.merwick@oracle.com, zhi.a.wang@intel.com References: <20230612042559.375660-1-michael.roth@amd.com> <20230612042559.375660-13-michael.roth@amd.com> From: Dave Hansen In-Reply-To: <20230612042559.375660-13-michael.roth@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: fhwdj9jxcb8ir4k6bqf3fs55r3oazxrc X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 038771C002C X-HE-Tag: 1686587439-542943 X-HE-Meta: U2FsdGVkX18Y6CPfCKcj9yrWjGKVCro6fHWGdi5Kyjn+Vx2OMjr1rqxFW1i9iF5zPKkhwubE7sQmcpoEVLx0zWTA0NbLMGk3/Fi/Rt7KK0GczcBjlG5EzlNykjmK4ifbJhjw5r4kI2t3Zqf3t8roFpXDy7+Ge3UMmxL347ejuPVwACjUWALegBKX4A+QfU6h4dttkk3Y4RERvxKvld0aWN+HgHDRq1dQxTRVF937RvW7uXczCg9P2yEmBxwyXJ9fihl3XxNvOsr3njylvH4bv87BmFDalAiTxRqEZpACJEp7SY1ycozoiPOVCZzu/1LwgooAzw6EHNIf0ADzBDssc7TJKs6jPGv2dUx5bJcvE/OSvDN20NZNptTqqZ3L34WvDnBD8cwcjFXboFID5uVvb3gXrL2aDY/elzdi0XqrC6pr2aq139lXhTCGEnCyAGCJRF3QsCD0/ghIdqXaWu0yfBPiIq2ikYq+8m0lSnwv5+wICaYhjljNwG/IRr/8q6L9x7DfT3aqV/c8fJUlx7AH4uqcA56gH2bbmOvZzJ4DjEHEcCXcaPmmxnCv+XRYRdfxagMun/2YIa6x8ptRJgj/m9W0cXVFSHjqwEAP70LbGAUrIay87zFfisZY0qQOEmtlqtuRZP+1OiHP/EMHbaDUUGnCWbueqvwJeHza+7JwjM0fla7i0yTYxWoDsWM7wuQ7bHsM3H6dqZYpmmMnQhCQnlQHgzLcwHxYYksLPdu8crm3dGkh3NRv0l2GkV3aqhC18Wk3XxkrebGeAYlJ6JKADzakY+Px6VCRxDuhn13mqmiLBxRy29I1tbgfpxj/TNLH/CqFpBPmZV/5ocF4ol/5TMHn/2pT+j5o/q602YBJ7oG0z2/8+AnaxZTJiPixcfEsEph9HLdpJ/MAJ5WD+PD54ve0Ir3gJ13GOTmV0siwSOI7YMayB5h1st7pMQ8qJMPVKH8mIIpuI1KWf8PSbC/ bB+Lv3NB 2vOj9qH99dJhBpRam/w8lNKyQ7WrGd6hE5ZXadglqYmvXB1ktyWdG+Y6kRyhpmWsD1WKSnrXFR0UPM1Ti7b8nwxFp2zWBvsqqV4usuNofjk+i/iV/2vRJPzRv+H4ZDGtIIRomIhBW8Up45yz5GW6QcXgvLA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 6/11/23 21:25, Michael Roth wrote: > dump_pagetable(address); > + > + if (error_code & X86_PF_RMP) { > + unsigned int level; > + pgd_t *pgd; > + pte_t *pte; > + > + pgd = __va(read_cr3_pa()); > + pgd += pgd_index(address); > + pte = lookup_address_in_pgd(pgd, address, &level); > + > + sev_dump_rmpentry(pte_pfn(*pte)); > + } > } It would be nice to trim this hunk down. Can you make it: if (error_code & X86_PF_RMP) sev_dump_rmpentry(address); and hide the rest of the logic in the helper? Oh, and lookup_address_in_pgd() can return NULL. It's not great to page fault in the page fault handler. Could you fix that up too, please?