From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5147C30653 for ; Wed, 26 Jun 2024 11:51:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5F7AD6B0093; Wed, 26 Jun 2024 07:51:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5A81D6B0096; Wed, 26 Jun 2024 07:51:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 448A06B0098; Wed, 26 Jun 2024 07:51:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 27C206B0093 for ; Wed, 26 Jun 2024 07:51:31 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id A585140F1B for ; Wed, 26 Jun 2024 11:51:30 +0000 (UTC) X-FDA: 82272874740.07.57D634D Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) by imf18.hostedemail.com (Postfix) with ESMTP id 9BF201C000D for ; Wed, 26 Jun 2024 11:51:27 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=igalia.com header.s=20170329 header.b=CeHbkMGt; dmarc=none; spf=pass (imf18.hostedemail.com: domain of tvrtko.ursulin@igalia.com designates 178.60.130.6 as permitted sender) smtp.mailfrom=tvrtko.ursulin@igalia.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719402670; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iamY6AWMHg1NOm0ChQZW+78oF/bE5eWOuQYihbOeRCY=; b=fW3hhNZRy9zxulDLn30SrZpSIu2FggkrvG09GjvESpnlz7k4VQBzBinUZcz3C09z+vwhzM af1kwAWm80bKTPHsQfG8KMNlUq3pRKcp4LWoqbyybCthm8N0yNMOnH0znTqpZJqfBtS7Py 7++s6mbE34wGRMyPYTM/5oNpUFjxyAg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719402670; a=rsa-sha256; cv=none; b=FvP303qfRbJsrB7tfFv+smCFITQGp7NkRQB7+ji+ibGneSgX1Q36b9OJtxbdz88qcFYRfc xIdwOcELSsvt0chCz14lwuNMGTBka+MkbZRBg5QzAoQO28xwKzCUIFWltcbzg0jYUJCKv0 tRhqrYkeO/P0FirU8KZMIrhhnGvmwVE= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=igalia.com header.s=20170329 header.b=CeHbkMGt; dmarc=none; spf=pass (imf18.hostedemail.com: domain of tvrtko.ursulin@igalia.com designates 178.60.130.6 as permitted sender) smtp.mailfrom=tvrtko.ursulin@igalia.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=iamY6AWMHg1NOm0ChQZW+78oF/bE5eWOuQYihbOeRCY=; b=CeHbkMGtyB+sj7tlpBsY3v9dpK X5ecP043F4rtH+O8CQGJlfKNtLidtzF7JxrakJ6Fn2Umdl2wGyKwceESxRWAYz6xR50b3nP5K9Zqv Jyzn7SkA7vio3gRk0NHQMqbwh4tP3xJjYxSX7AIST/0MEEMXczpO0hN53YWJByZLH5l4Khhr3Yfg5 nl927b0ZRknmQa1BAVsY3dIEE3Vwan7VosbfsPFclcnaMmdoMVTUPPq8n+Xmh8p8nMidX7YuTgmmC O9L0avUFq4M7V529NUbRexemR76AYYy0cMEJji+29sAbQFgl77/ruUc8rgllIdfUmi6N/9wefZmz6 7SdrtzoQ==; Received: from [84.69.19.168] (helo=[192.168.0.101]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1sMRB7-007gpS-Tw; Wed, 26 Jun 2024 13:51:09 +0200 Message-ID: <9355e4b3-9892-4e5c-9288-103c93bd3bca@igalia.com> Date: Wed, 26 Jun 2024 12:51:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/numa_balancing: Teach mpol_to_str about the balancing mode To: "Huang, Ying" , Tvrtko Ursulin Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-dev@igalia.com, Mel Gorman , Peter Zijlstra , Ingo Molnar , Rik van Riel , Johannes Weiner , "Matthew Wilcox (Oracle)" , Dave Hansen , Andi Kleen , Michal Hocko , David Rientjes References: <20240625132605.38428-1-tursulin@igalia.com> <87r0ckozs4.fsf@yhuang6-desk2.ccr.corp.intel.com> Content-Language: en-GB From: Tvrtko Ursulin In-Reply-To: <87r0ckozs4.fsf@yhuang6-desk2.ccr.corp.intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 9BF201C000D X-Stat-Signature: tndgd7m31443gzi19hgmbgg5hjyfs1gz X-Rspam-User: X-HE-Tag: 1719402687-97492 X-HE-Meta: U2FsdGVkX19m76DRBiJE4NU82dGhs7ZA1bszieG3X+d1pZ4fCCzHJ+5X9wDy0f1TakQFPBL4xbWfCK4LRzyaoKUFrJN+ji/VxqwkCtbxFS8X3k/Alss2QsrngLcVuhWLtAsDXmtMgkAN+poPiJQt9sSgOiiPv/CUyJ3z0fKqyt2DPldb6WRNqJS4Pj14sp1kUI4eCjNcfI2Opl+OWA4hncRxqGKJUCY+VY2k8zAVfZHtS1NLNQgbfc7cN4FGqGqLq4ij1ShBV/jBL4uIySoC0oqi3/psniZThvDGdXXPan68vMR4p+o0diD55tRTzrqlKC7Ui34LlHiPO1caLWoFQBAUfEkc1Ccb0FOtl/QFRpENggTqDUf5XGhcn9/X9LxG7CPBPM2BOdZ2EQAOJYPtkrsIxLACpdWfLC5Rin2eYTzV4EuqcRHdW2fk7SuJ4aBLoBF3vZgNX8v9FuR4XAR/bSrd0sBl50p3u7Qi1ARlGilptnDTMcnbDMR1BwDmDARW73js4xSZLtzzBPqMvvnUaJATm+chjZkmztNp2mL0lzB/W/3yPq4vdFe1TRJXiYen89eK5tGlN9IXPU/jZWl28bB+ttW4vNwUpUPO4lDiSURT9ztnVi7WUU+3eDVQ+i6E2JMXlItVBj0kuywy7d599Le0wpKR6pd/XW1V8EmbEpbAIKTu8yHcttgO3LvKnRLaHJgl1whofaFMrhW7eAmZ6sMOMoGvQns+bY4ssJfGRpjhKRI4acQ3xF53Hr7M6HhhIobLOj20fBehWH8D7OfIp2f3jZ8fqtMufL334ARQe8QAkx7tNZP9L19QhuQnBHU7HzvlqsnZ3bzZI1AfEavwi8FkQ6frwcEasP0YDxvOttSDbRosE82SwWeK8ZiagF4ySDioUg/SdOZGxEsRjwRYx0nWZMXfz4nE5vW8XKHMnd05LeaTDAPiTUPDtkBjbssoO4BsxtlorUHYVLjNexd 7/1oQWm1 p/lJDKAmPs/7p4Jby7e1scpTS3yrOPNmwAckDXCGz8k8kjDYP176Nyf7fTgcPd4y7qK9IrNPC+m6Czv96XEFSLVOHPTrsYnrPDkDF4ZAP4G1/zeiOQU/U0XVbwdGo/a4jpp7/1UH2GoQzIIVWXGBxXjjo9zb7l5cG+Okb2h/OUD6og/iKII6lAAUh9Y+ftFoIK/ystgotc7ns6BvkrzEdaEphbV/d3/d7lba6mTQu5fSOPe75RECwpCw+CF72ISIZTaFxndCk66k/05S/JNuSIv6CyyPi/a7MTIJjnzeFrtfz94OmhVIBuVmhoqmKaEivgZl62JxbMAmxue0CzYBJ6sQ//7EQCIr7OnzwhchWekwb/38zLpigif4+ty5r7DQIP2uXg8UlkRo0ImY44Kzp82fdQvm7ZvTiHbJXhU5XTqPD8Cw3FaRB8T/ufDKvatTHsmk1rIP9J1N4GgDMwZD5fAo5hv2V0rLoyKyhrQs98NsdQY6r/FfQUzRg7+2Y1P1ixAwkjPz9pFlvEUNWXv29WM73RRP63HXvx/zVYjVeDfVapI8xI4EfXs6w+KK76PaodPqQ8DtfBqFQhRg3toCSMDy6Cg1sSoZCuzT4yG4qVktzzXJK69wPfYGIgDvPavZKe+Z8Q564jqEE6UnGMKp5ZN7PMw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 26/06/2024 09:48, Huang, Ying wrote: > Tvrtko Ursulin writes: > >> From: Tvrtko Ursulin >> >> If a task has had MPOL_F_NUMA_BALANCING set it is useful to show that in > > IIUC, MPOL_F_NUMA_BALANCING works for VMA area via mbind() too. Ah okay.. I think I forgot to actually check and went by what commit text of bda420b98505 said, which is probably outdated. >> procfs. Teach the mpol_to_str helper about its existance and while at it >> update the comment to account for "weighted interleave" when suggesting >> a recommended buffer size. > > Otherwise LGTM, Thanks! > > Reviewed-by: "Huang, Ying" Thank you! Would you have an idea of which tree this should go to aka which maintainer to ask to merge it? Second question - I also have a patch which enables choosing balancing for tmpfs (mpol_parse_str) but I am unsure of its value. It would make things symmetrical, but is there some other benefit I don't know. Any thoughts on this? Regards, Tvrtko >> Signed-off-by: Tvrtko Ursulin >> References: bda420b98505 ("numa balancing: migrate on fault among multiple bound nodes") >> Cc: Huang Ying >> Cc: Mel Gorman >> Cc: Peter Zijlstra >> Cc: Ingo Molnar >> Cc: Rik van Riel >> Cc: Johannes Weiner >> Cc: "Matthew Wilcox (Oracle)" >> Cc: Dave Hansen >> Cc: Andi Kleen >> Cc: Michal Hocko >> Cc: David Rientjes >> --- >> mm/mempolicy.c | 10 +++++++--- >> 1 file changed, 7 insertions(+), 3 deletions(-) >> >> diff --git a/mm/mempolicy.c b/mm/mempolicy.c >> index aec756ae5637..d147287c4505 100644 >> --- a/mm/mempolicy.c >> +++ b/mm/mempolicy.c >> @@ -3293,8 +3293,9 @@ int mpol_parse_str(char *str, struct mempolicy **mpol) >> * @pol: pointer to mempolicy to be formatted >> * >> * Convert @pol into a string. If @buffer is too short, truncate the string. >> - * Recommend a @maxlen of at least 32 for the longest mode, "interleave", the >> - * longest flag, "relative", and to display at least a few node ids. >> + * Recommend a @maxlen of at least 42 for the longest mode, "weighted >> + * interleave", the longest flag, "balancing", and to display at least a few >> + * node ids. >> */ >> void mpol_to_str(char *buffer, int maxlen, struct mempolicy *pol) >> { >> @@ -3331,12 +3332,15 @@ void mpol_to_str(char *buffer, int maxlen, struct mempolicy *pol) >> p += snprintf(p, buffer + maxlen - p, "="); >> >> /* >> - * Currently, the only defined flags are mutually exclusive >> + * The below two flags are mutually exclusive: >> */ >> if (flags & MPOL_F_STATIC_NODES) >> p += snprintf(p, buffer + maxlen - p, "static"); >> else if (flags & MPOL_F_RELATIVE_NODES) >> p += snprintf(p, buffer + maxlen - p, "relative"); >> + >> + if (flags & MPOL_F_NUMA_BALANCING) >> + p += snprintf(p, buffer + maxlen - p, "balancing"); >> } >> >> if (!nodes_empty(nodes))