From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE895C54E58 for ; Mon, 11 Mar 2024 21:07:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DEE496B012B; Mon, 11 Mar 2024 17:07:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D9E656B012C; Mon, 11 Mar 2024 17:07:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C65E16B012D; Mon, 11 Mar 2024 17:07:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id B531C6B012B for ; Mon, 11 Mar 2024 17:07:08 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 6198316035C for ; Mon, 11 Mar 2024 21:07:08 +0000 (UTC) X-FDA: 81885993336.06.225EFFB Received: from gentwo.org (gentwo.org [62.72.0.81]) by imf12.hostedemail.com (Postfix) with ESMTP id EB7A540009 for ; Mon, 11 Mar 2024 21:07:05 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=none; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=linux.com (policy=none); spf=softfail (imf12.hostedemail.com: 62.72.0.81 is neither permitted nor denied by domain of cl@linux.com) smtp.mailfrom=cl@linux.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710191226; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=s/ozaYNUtKw6Qf0v1iIoV55VqQY9Ix86/T1SYVBG6/o=; b=V0o5GEWgLkb77zHZXGFw4fJfJ8U/22+QLhII8EOGS2/HMrsfbA3SCY8qGNXZfxcCzaslW8 2Oq1Wt8N7Fld+Evd9fugZGoxevLmnrLlY27UoABuvcxCTn4FMsChgUFhCWeAQlhza9xqQa jg3qzSD1ymDNROGCTA/MMFYrW5ruRUk= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=none; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=linux.com (policy=none); spf=softfail (imf12.hostedemail.com: 62.72.0.81 is neither permitted nor denied by domain of cl@linux.com) smtp.mailfrom=cl@linux.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710191226; a=rsa-sha256; cv=none; b=w2epg7Xn2efoTKvwlbBt1ICdSsz/DHU8mgcGlfSgydLse5SzSbCmaPeDesNsvhntAmvlIA SvBQNv8mrCfYtWyfPH1AeuKHJNnSjlznCk5BzcW7rIdu9519zsbu+FrFRIbR7/QMW/jBdk 1dfOmpv+A3GLE3QA2oyLVq0ZuBTXlYs= Received: by gentwo.org (Postfix, from userid 1003) id 84FD440940; Mon, 11 Mar 2024 14:07:04 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by gentwo.org (Postfix) with ESMTP id 83FD84093E; Mon, 11 Mar 2024 14:07:04 -0700 (PDT) Date: Mon, 11 Mar 2024 14:07:04 -0700 (PDT) From: "Christoph Lameter (Ampere)" To: Catalin Marinas cc: Marek Szyprowski , Mark Rutland , "linux-pm@vger.kernel.org" , "Rafael J. Wysocki" , Viresh Kumar , Will Deacon , Jonathan.Cameron@huawei.com, Matteo.Carlini@arm.com, Valentin.Schneider@arm.com, akpm@linux-foundation.org, anshuman.khandual@arm.com, Eric Mackay , dave.kleikamp@oracle.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux@armlinux.org.uk, robin.murphy@arm.com, vanshikonda@os.amperecomputing.com, yang@os.amperecomputing.com, Nishanth Menon , Stephen Boyd Subject: Re: [PATCH v3] ARM64: Dynamically allocate cpumasks and increase supported CPUs to 512 In-Reply-To: Message-ID: <9352f410-9dad-ac89-181a-b3cfc86176b8@linux.com> References: <37099a57-b655-3b3a-56d0-5f7fbd49d7db@gentwo.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed X-Rspamd-Queue-Id: EB7A540009 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: jp1m14qc6ahi9u74da56a5aiifmfb6g4 X-HE-Tag: 1710191225-977337 X-HE-Meta: U2FsdGVkX19c/FI+v5mbWfHBs1vEqecZXXWr6zaHmQlCzVWUTJ96T5RgDAxE4nxeivRk6qWgU/PMkUovzDS504bBKL9GiPMk53bpQMUkd/qILWHuLKDbjNYLzC4uDQPPbtHiJGjUrl92CgNVmgFMwM6HzEsTt5NNMGjlSeap/Ga2Y5WuydrGsSS4H2jfoUgLOv/m5R82smsDtKUvCaX2S10lIZV7YH/0tUpt7/u7z7xG2zd2E7ZiEhn7SQMbdd09zGwwC51VwOe9T58ui18/ofqbIYspJpuBN5LANKlHvoKizw2Oa9V7L0zJ0bovkTDxRO5xHCcwn+eBWL1V7FReZbdEWZuUmERepGXa2IazmSd1Xxvb5pcCaHHJ959A6qd7+itQzI+A3valcgAeDCqrwpqWZI9Wk/aivwMl23crzy8LqTUhWykMTSXWMwSCWzU8VPjhu/GXudnH1pdDWbLC8G0JN1ulGj5/V+Ivoy68s28UQ5zr37v0momUorTa/pW+nJ+8VRk7G/ZPdQtFTrIpnHuFyXYXw7aFlvYQJBbr+Y/NCpciSBjgl9JKZ525MT9IIl7Z2Gwpit6iAt4KFkmq6EnC52EPSWpoBQ993onquwYLtTLAg3oCh6TZFprlenk4utxf7yLSvvmNYp5nEPjaw+bfwRCvDJ+ku5FMS4DJHWt17esDgSOphRp9H7DX9f7HWZaQLG5By3u4eGprTnQy0ePQot2ulhl5I/7QQ7WiL0uBltZLACtXOEeZb8j/R6ZWICQSUVLRribxzEawHCgfkmB4OjWahv6oiF7Lr+A5oOe8eCXr6gY2+6zkU50fulq1/0+Y5YuzzywlvRrF98mri6zKn3apy7/UPW3TAcjecY/+nxxR68r+1+RbZTioi7it X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 11 Mar 2024, Catalin Marinas wrote: >> This patch landed in today's linux-next as commit 0499a78369ad ("ARM64: >> Dynamically allocate cpumasks and increase supported CPUs to 512"). >> Unfortunately it triggers the following warning during boot on most of >> my ARM64-based test boards. Here is an example from Odroid-N2 board: > > I spent a big part of this afternoon going through the code paths but > there's nothing obvious that triggered this problem. My suspicion is > some memory corruption, algorithmically I can't see anything that could > go wrong with CPUMASK_OFFSTACK. Unfortunately I could not reproduce it > yet to be able to add some debug info. > > So I decided to revert this patch. If we get to the bottom of it during > the merging window, I can still revive it. Otherwise we'll add it to > linux-next post -rc1. I also looked through the opp source and I cannot find even anything that even uses the functionality changed by the OFFSTACK option. This could be an issue in the ARM64 arch code itself where there maybe an assumption elsewhere that a cpumask can always store up to NR_CPU cpus and not only nr_cpu_ids as OFFSTACK does. How can I exercise the opp driver in order to recreate the problem? I assume the opp driver is ARM specific? x86 defaults to OFFSTACK so if there is an issue with OFFSTACK in opp then it should fail with kernel default configuration on that platform.