From: Markus Elfring <Markus.Elfring@web.de>
To: "Dan Carpenter" <dan.carpenter@oracle.com>,
"Dan Williams" <dan.j.williams@intel.com>,
"Jérôme Glisse" <jglisse@redhat.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org, Jason Gunthorpe <jgg@ziepe.ca>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Ralph Campbell <rcampbell@nvidia.com>,
Wei Yongjun <weiyongjun1@huawei.com>
Subject: Re: [PATCH v3] mm/hmm/test: use after free in dmirror_allocate_chunk()
Date: Sat, 26 Sep 2020 15:10:11 +0200 [thread overview]
Message-ID: <93514131-71d4-0d32-e05b-224770779226@web.de> (raw)
In-Reply-To: <20200926121402.GA7467@kadam>
> One problem with the kernel QC process is that I think everyone marks
> the bug as "old/dealt with"
Will this view trigger any more clarifications?
> so it was only because I was added a new
> check for resource leaks that it was found when it was re-introduced.
I would like to point once more out that the commit 786ae133e07f2a6b352a0efad16b555ee45a2898
("lib: fix test_hmm.c reference after free" from 2020-06-26)
indicated questionable implementation details according to a coccicheck run.
The available scripts for the semantic patch language can also remind you again
for desirable software improvements.
Examples:
* https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/scripts/coccinelle/free/kfree.cocci?id=7c7ec3226f5f33f9c050d85ec20f18419c622ad6#n2
* https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/scripts/coccinelle/null/deref_null.cocci?id=7c7ec3226f5f33f9c050d85ec20f18419c622ad6#n3
Will any more adjustments be achieved with the help of advanced source code
analysis tools?
Regards,
Markus
next prev parent reply other threads:[~2020-09-26 13:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-25 19:30 [PATCH v2] " Markus Elfring
2020-09-26 12:14 ` [PATCH v3] " Dan Carpenter
2020-09-26 13:10 ` Markus Elfring [this message]
2020-09-26 22:17 ` Jason Gunthorpe
2020-09-29 0:52 ` Andrew Morton
2020-09-29 1:25 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=93514131-71d4-0d32-e05b-224770779226@web.de \
--to=markus.elfring@web.de \
--cc=Julia.Lawall@lip6.fr \
--cc=dan.carpenter@oracle.com \
--cc=dan.j.williams@intel.com \
--cc=jgg@ziepe.ca \
--cc=jglisse@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rcampbell@nvidia.com \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox