From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A95D3C021B3 for ; Mon, 24 Feb 2025 07:44:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D89D46B007B; Mon, 24 Feb 2025 02:44:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D39B36B0083; Mon, 24 Feb 2025 02:44:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BD9E56B0085; Mon, 24 Feb 2025 02:44:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id A01AB6B007B for ; Mon, 24 Feb 2025 02:44:12 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id E5757C0CFF for ; Mon, 24 Feb 2025 07:44:11 +0000 (UTC) X-FDA: 83154049902.27.EBFC2BF Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf29.hostedemail.com (Postfix) with ESMTP id 9E97C120005 for ; Mon, 24 Feb 2025 07:44:09 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=m1spmCwf; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=BabmiIEP; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=IJxaAq2p; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=y8bf96hv; spf=pass (imf29.hostedemail.com: domain of hare@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=hare@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740383049; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kWXS8JmPOEyuTcSWXxAAIEFmUJk1QrnZ6ccr5EFg9zM=; b=OETzQfpy1g76ktUqr3wLVlQUr5Ss0dil04GKNlt6cZD9LILpmRGmfaRWSS7BkGgoI4ht7D 8HtxnI670FMYGhZvyEB3QkVuloFpWZzUYgS3t6A8C/h1SjnPmFuez/+iKtffx2wZfUVW7q fwK2pLHNPkaWcP+LShF1/5ctAF7Wiqc= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=m1spmCwf; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=BabmiIEP; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=IJxaAq2p; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=y8bf96hv; spf=pass (imf29.hostedemail.com: domain of hare@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=hare@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740383049; a=rsa-sha256; cv=none; b=TxUsu0u1PUWz9JPT6aEw7Paynv5XZwitoLRISU3kvmZOCwjo8b9uyYCbUFvLdPZDlx/2lr 3nUtDUNKzjfWO3mSLjpJQ5fYvTHDAnL0LEVpzHW6vfAAgORrgdkIQwoaJlEfFEHGEKUy+j +OTpjES6Z1c2KLab2+6IDYwzzCvVBFI= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id CEF7021171; Mon, 24 Feb 2025 07:44:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1740383048; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kWXS8JmPOEyuTcSWXxAAIEFmUJk1QrnZ6ccr5EFg9zM=; b=m1spmCwfs7XNK/xA9cFjLwDZe+HsdFMuqEa4pkN+MGehEJZJtSQL6VDdX63dKpyvZYujxa /71gPQLGNnQu/aCbS/qQRWqkE6RqfVmggSLGN/1+AEe2B0fNnf43NN0BvyiTxXiodzCJGH W+VXV1wKV6u0mrntOjKRCJNWaLqYhLY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1740383048; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kWXS8JmPOEyuTcSWXxAAIEFmUJk1QrnZ6ccr5EFg9zM=; b=BabmiIEPgs4ysbQewC3UCd4Qg73P/gx5CbxtTcJVAKosCBrsNjWMvxd847TrEAXh7RILNx 8xXUJ0MnaORg7BBA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1740383047; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kWXS8JmPOEyuTcSWXxAAIEFmUJk1QrnZ6ccr5EFg9zM=; b=IJxaAq2pgu8YU+W1MCKZDIrFaob9C67qUn0+dB3KATsoryuI22qTLO6I/yljXStod4Bklu EeteFNsysIVkf0dF6odCBhL30eLW6lAtLUPtsuH6lNWlqnhCDqkbmLwuMd9RrgOGK9lbel 1aoubYrcwmgQ1K7ZnYCPZb+dCYaXcPs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1740383047; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kWXS8JmPOEyuTcSWXxAAIEFmUJk1QrnZ6ccr5EFg9zM=; b=y8bf96hvjfIDovcNjOZ82J0TsSB2vrvf6IlI7DQA2xoJ5ZJ++twfO41l0iGYSTjOHgcsxB FFivQo43wz3LB5Bg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 2426113707; Mon, 24 Feb 2025 07:44:07 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id aQrkBkcjvGf1QwAAD6G6ig (envelope-from ); Mon, 24 Feb 2025 07:44:07 +0000 Message-ID: <934358f5-ec6b-41b6-ae2c-09e9fb10fbb1@suse.de> Date: Mon, 24 Feb 2025 08:44:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 4/8] fs/mpage: use blocks_per_folio instead of blocks_per_page To: Luis Chamberlain , brauner@kernel.org, akpm@linux-foundation.org, willy@infradead.org, dave@stgolabs.net, david@fromorbit.com, djwong@kernel.org, kbusch@kernel.org Cc: john.g.garry@oracle.com, hch@lst.de, ritesh.list@gmail.com, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-block@vger.kernel.org, gost.dev@samsung.com, p.raghav@samsung.com, da.gomez@samsung.com, kernel@pankajraghav.com References: <20250221223823.1680616-1-mcgrof@kernel.org> <20250221223823.1680616-5-mcgrof@kernel.org> Content-Language: en-US From: Hannes Reinecke In-Reply-To: <20250221223823.1680616-5-mcgrof@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Action: no action X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 9E97C120005 X-Stat-Signature: i7b4xkts753oh96hr4eetf8yx9r1zezn X-Rspam-User: X-HE-Tag: 1740383049-495273 X-HE-Meta: U2FsdGVkX18iiV6mGtzafbPxb0HTU49O0Avdf9sUxtz5HO+8UB5Cg0Y82wceo9qes8RvR901iATkhJbjZjNOtrKOpSkVzTMpSkAEr5Hdlgw2BRKpd+FBCDN9wplEiEFlEMV+pxPfr8Is2TdZydbVzT+rXbmcVVgnMMccHEj6i5dYMDHZHemqzC+PrKDq85T8sdpZHiwZ6D6jFSvX5fGxpw8ye7t/EvOLQzFgLiNbLCTwi4YU0wxc/qroqTA9XyXQYyBxhInevdsapKlB1LsPHsGTZf56W+k+cQ5O+/mhkZjd3J4pfGGf9lLrnPeZM/3miCULFjA+ziIpB6Tj9ahOu6HYZgpvTDic+WFQfAYjUUE/dMkZei190AOMZDdNfsAgrL5iM0r48YXX83RMfHyzkv4kp40sLDEEIMfq2sn5U0VPB3vjMKu9Kc0amW6G5tME40NFoWlWiLWPeoGs16iQfXWMZmbaIdCLjAb1IzWnK7ZDBkHI6PVMRpXjWbM4njFcfZZeZpLN89YMc/RNCaWdZnKI8F75U0gGOnCltE+hYTd+52y/oUheWbUqscFMYnMGEfnje4gg+GKfjsLc371UfRzvrcErLfWlszpIRKdjqCac5X7DNwgrcfumBmTkdtxtI5bd69M+p+Enn5m7FrmbR33H/fZkWLG4i2t+Kbmbql71ylKbygE8Ib9iMAyxgXRLPcD8lsBzwGbqGfQy3tzeXMdxObd235+KfIEMLLZtxbI0STb9hAhrZIcnPbYZPXQ+kNfogD4MgyadWZQA9e2p4LGPVVBparHOYI3LIM4VJcONIUe+iLCQ6GV39dp4Myu2z12M+JlMWcQkNgPFBqhISZOVukosOcRnTEefOxDI/aVwAgeUrwKqbwCw/QFoeMI8ZqNUfh9VC25g43jQOChjwpJLDJtAyGS2WiYcItsJGOCU80xZ6ok+3EkF9u00tBiM3oezIzImeSTYPKJ1IPK YnsihLAH 0jliYrroGNYQZZL1npgCGTqRhN+3MUdoSnGNbl6y86i3YWHXbPvm0Y64GmNURLHSOorjPlNk3LYipQ1hLY4pTCyr+FRxNV4kjvXaatW2doBFlGJOX6z1y9AuNwePsZ08Ew6L777AQIBouaEjc9EcQMzuIZ/WXK5ejpE8iYjuzQuXqSPK1ipAYRTlhqtYbzLyr3zeOql8I+8XA/aqWw+8zHtFuYTJSHx6r+Hw41/m1qoSRHVtyv4cLCzpOpIuuZgEuZq/vlHUNKdzkulyl/MTwvhoUK81vWjaXV5KFm5IuRl4WrlnWotqdIczpNq8MeI2Uwe7BHqJVd4rxY6/35CrSBHAxjLHb2iSqHYFrLV/A3NSXEQoMw0eFV52jRV2YVZVJASihF8NfrzTd6+bA8Wg/+2obM8zWlMdFNzwdIM0+jwKjPciitFjO+6buLvuf8DfPPjYddiBkSCgd36lkm3d/tPa8DvGo/1KPtT/F X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/21/25 23:38, Luis Chamberlain wrote: > Convert mpage to folios and adjust accounting for the number of blocks > within a folio instead of a single page. This also adjusts the number > of pages we should process to be the size of the folio to ensure we > always read a full folio. > > Note that the page cache code already ensures do_mpage_readpage() will > work with folios respecting the address space min order, this ensures > that so long as folio_size() is used for our requirements mpage will > also now be able to process block sizes larger than the page size. > > Originally-by: Hannes Reinecke > Signed-off-by: Luis Chamberlain > ---by: H > fs/mpage.c | 42 +++++++++++++++++++++--------------------- > 1 file changed, 21 insertions(+), 21 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich