From: Dev Jain <dev.jain@arm.com>
To: "jianyun.gao" <jianyungao89@gmail.com>, linux-mm@kvack.org
Cc: Muchun Song <muchun.song@linux.dev>,
Oscar Salvador <osalvador@suse.de>,
David Hildenbrand <david@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm/hugetlb: Fix some typos in hugetlb module
Date: Sun, 28 Sep 2025 18:26:09 +0530 [thread overview]
Message-ID: <933cfdc7-9e3f-4dec-a5d9-bb193b0b7f13@arm.com> (raw)
In-Reply-To: <20250927064926.1496579-1-jianyungao89@gmail.com>
On 27/09/25 12:19 pm, jianyun.gao wrote:
> There are som typos in the code comments as follows:
>
> differenciate ==> differentiate
> refernece ==> reference
> permissons ==> permissions
> indepdenent ==> independent
> Spliting ==> Splitting
>
> Just fix it.
>
> Signed-off-by: jianyun.gao <jianyungao89@gmail.com>
> ---
> mm/hugetlb.c | 6 +++---
> mm/hugetlb_vmemmap.c | 6 +++---
> 2 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/mm/hugetlb.c b/mm/hugetlb.c
> index eed59cfb5d21..8ff9edd09504 100644
> --- a/mm/hugetlb.c
> +++ b/mm/hugetlb.c
> @@ -2954,7 +2954,7 @@ typedef enum {
> * NOTE: This is mostly identical to MAP_CHG_NEEDED, except
> * that currently vma_needs_reservation() has an unwanted side
> * effect to either use end() or commit() to complete the
> - * transaction. Hence it needs to differenciate from NEEDED.
> + * transaction. Hence it needs to differentiate from NEEDED.
> */
> MAP_CHG_ENFORCED = 2,
> } map_chg_state;
> @@ -5998,7 +5998,7 @@ void __unmap_hugepage_range(struct mmu_gather *tlb, struct vm_area_struct *vma,
> /*
> * If we unshared PMDs, the TLB flush was not recorded in mmu_gather. We
> * could defer the flush until now, since by holding i_mmap_rwsem we
> - * guaranteed that the last refernece would not be dropped. But we must
> + * guaranteed that the last reference would not be dropped. But we must
> * do the flushing before we return, as otherwise i_mmap_rwsem will be
> * dropped and the last reference to the shared PMDs page might be
> * dropped as well.
> @@ -7179,7 +7179,7 @@ long hugetlb_change_protection(struct vm_area_struct *vma,
> } else if (unlikely(is_pte_marker(pte))) {
> /*
> * Do nothing on a poison marker; page is
> - * corrupted, permissons do not apply. Here
> + * corrupted, permissions do not apply. Here
Can also fix the extra space between "apply" and "Here".
> * pte_marker_uffd_wp()==true implies !poison
> * because they're mutual exclusive.
> */
> diff --git a/mm/hugetlb_vmemmap.c b/mm/hugetlb_vmemmap.c
> index ba0fb1b6a5a8..e6f79b2c63ee 100644
> --- a/mm/hugetlb_vmemmap.c
> +++ b/mm/hugetlb_vmemmap.c
> @@ -75,7 +75,7 @@ static int vmemmap_split_pmd(pmd_t *pmd, struct page *head, unsigned long start,
> if (likely(pmd_leaf(*pmd))) {
> /*
> * Higher order allocations from buddy allocator must be able to
> - * be treated as indepdenent small pages (as they can be freed
> + * be treated as independent small pages (as they can be freed
> * individually).
> */
> if (!PageReserved(head))
> @@ -684,7 +684,7 @@ static void __hugetlb_vmemmap_optimize_folios(struct hstate *h,
> ret = hugetlb_vmemmap_split_folio(h, folio);
>
> /*
> - * Spliting the PMD requires allocating a page, thus lets fail
> + * Splitting the PMD requires allocating a page, thus lets fail
lets -> let's or let us
> * early once we encounter the first OOM. No point in retrying
> * as it can be dynamically done on remap with the memory
> * we get back from the vmemmap deduplication.
> @@ -715,7 +715,7 @@ static void __hugetlb_vmemmap_optimize_folios(struct hstate *h,
> /*
> * Pages to be freed may have been accumulated. If we
> * encounter an ENOMEM, free what we have and try again.
> - * This can occur in the case that both spliting fails
> + * This can occur in the case that both splitting fails
> * halfway and head page allocation also failed. In this
> * case __hugetlb_vmemmap_optimize_folio() would free memory
> * allowing more vmemmap remaps to occur.
As Wei says, this patch can be merged with the earlier, thanks.
next prev parent reply other threads:[~2025-09-28 12:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-27 6:49 jianyun.gao
2025-09-28 1:32 ` Wei Yang
2025-09-28 1:58 ` Jianyun Gao
2025-09-28 12:56 ` Dev Jain [this message]
2025-09-28 13:20 ` Jianyun Gao
2025-09-29 0:58 ` Jianyun Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=933cfdc7-9e3f-4dec-a5d9-bb193b0b7f13@arm.com \
--to=dev.jain@arm.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=jianyungao89@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=muchun.song@linux.dev \
--cc=osalvador@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox