From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DB13C36010 for ; Fri, 4 Apr 2025 20:57:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EA1126B0010; Fri, 4 Apr 2025 16:57:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E26CD6B0012; Fri, 4 Apr 2025 16:57:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C797A6B002F; Fri, 4 Apr 2025 16:57:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A2B4A6B0010 for ; Fri, 4 Apr 2025 16:57:01 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 136D1C081D for ; Fri, 4 Apr 2025 20:57:02 +0000 (UTC) X-FDA: 83297571084.15.C298DAC Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf25.hostedemail.com (Postfix) with ESMTP id AFBD4A000C for ; Fri, 4 Apr 2025 20:56:59 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CxRSj0Ki; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743800219; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sO3UQqypsxo1Y61Nt/Ug7nFQr6xB1gJPZRCYoB22hZg=; b=xaDLdhiasCb5myCLYqgPhuQgrJuUWWx5vUvEpxCxs4P2PQSY0csF6RKrtRFVx+H83xMAIu 3BdMx8iKjK04K0nPTsMtMDFN1vGiyHLQFKRCpbIuR9iSVfV0PGYwuQPccafqHIf13A9s/+ JfLchX0pcx8yVDZ6ttWk/hc7hFzVLao= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CxRSj0Ki; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743800219; a=rsa-sha256; cv=none; b=N4nucrZvKD55KUOGAKeGOT9CszRieEM1FGQtsvS1CGkeWuRKik+RI6UUaNn2BN5vOWORKo w4RQG9dxOcD/yYdASBugcjyOwN2ZiMlOwEmza05R9X2mWRtREJ1h96AxFRIRg/47+akxqL d7moOs37LnH6z5rtKI6coEU4zHOS+ic= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1743800219; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=sO3UQqypsxo1Y61Nt/Ug7nFQr6xB1gJPZRCYoB22hZg=; b=CxRSj0KiV8RsyVV6zcJbbJ83zmEEnLXVQHLAS0jAl5QGuosqgZC0muLxbgGBgC9XwwkONS EKWTkYj9RfPx4lqNxwMtSDKbzS6HG+qVMQfr5CNdQ1azqymwnMO90TOg9O8YmFtu7M+nus 9hhUCkOoQELpzIYrti2Ybc7legnJm0A= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-68-0UXY8Y3PPKu-UDJip6Yt2w-1; Fri, 04 Apr 2025 16:56:58 -0400 X-MC-Unique: 0UXY8Y3PPKu-UDJip6Yt2w-1 X-Mimecast-MFC-AGG-ID: 0UXY8Y3PPKu-UDJip6Yt2w_1743800217 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-43d6c65dc52so20454195e9.1 for ; Fri, 04 Apr 2025 13:56:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743800217; x=1744405017; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=sO3UQqypsxo1Y61Nt/Ug7nFQr6xB1gJPZRCYoB22hZg=; b=jOPNjLj3H6aXBdUAdc+zthE/GwsnsxrJZ6T72wJiJlx9+Z0WdYPeNhAPxEcShPLylS iVTZkd7OmEncq7P0K15fwhLftFEsb56wuK4THHLSaPnlT1upeC3dAvA5ZJ1CQczzdzx4 ZpxCf+rkXc4hAOeDaXqdZXoaltWEGzpkLW3eQcWUuqRCwO1uwgb9sRHPDTTHFmspGa/A LJ8Kzd6/ZvrS6HrD4gYfBl3IyL0oAblN7/R5iZEe0AAwdny0IsbZKbGXM1YA7nTVH6Fe eg+nlKa4O6OY1lrishzHOQhNifUCmJlWwlNrqtLQ6md5pzuUBPOaRmAxpbdGpQjBHo7c Ym+w== X-Gm-Message-State: AOJu0YyWOiFYWjCtpUyIk9yEt0GVOvqmp5AgzZ4f5H1TMesvfoqYgFYB Rm2WFkNmW3tRdWr86w9IKHxDn0/B8EzzwKTTYpKRl0ZPZRkxFWXdyApqjlDx7Y+JB0MvI4wLfHk vEmgEKpcfuqbjslCOifJO7xGVO3JZXoi89DhgyrDSKB9EPCoJ2r5c9/e/h5OF4Q== X-Gm-Gg: ASbGncs/iQohzlLJIP5jccL5sRqVAmdZ8rxoph3gi0LIis571qO18GRmGbGYiFHy71T Bk+nOV/V4ZvfCRxIRBoY9xu8pznP1kssjPY3Jn9uNB2S9AssFQ9QL3BYwUET1Z/ELO7hMmu78qW 8ln95LQV9afkoRq1cRQLk6IIzFdo891zLLD5BN1uTyX3/4Brd8UEPwxxENwdfL2tLBD6D0alrqX jzLBtXhU9GdqzNbSUn4RyABAuAfQEO0Mt3DjbHg228HlJCJowi6ROmEgNO05jwAFO4vya0yb002 vExnuFlox4D9W1K9Tnv5BaAUwwbTEwr2EmQLLQ/IfXg/jwzlCR+QQwAZ24E+U83PJEoahMjU7cX Y2/oxjR+DOi03FZY9gf8tGVrbGiHOsurKsjNKxb3OSo4= X-Received: by 2002:a5d:6d84:0:b0:391:20ef:6300 with SMTP id ffacd0b85a97d-39d6fd18c1fmr555083f8f.37.1743800216840; Fri, 04 Apr 2025 13:56:56 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEhMC9Q1PpfIla1nLJoN6o8Xo5pYx7vsN93z+bf9YyETVOZPvKV2nCp4AMMA3VNwSYsJ6ZcJQ== X-Received: by 2002:a5d:6d84:0:b0:391:20ef:6300 with SMTP id ffacd0b85a97d-39d6fd18c1fmr555076f8f.37.1743800216475; Fri, 04 Apr 2025 13:56:56 -0700 (PDT) Received: from ?IPV6:2003:cb:c71b:7900:8752:fae3:f9c9:a07e? (p200300cbc71b79008752fae3f9c9a07e.dip0.t-ipconnect.de. [2003:cb:c71b:7900:8752:fae3:f9c9:a07e]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c300968cfsm5300264f8f.16.2025.04.04.13.56.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Apr 2025 13:56:55 -0700 (PDT) Message-ID: <9338b7ca-13ba-4831-a257-2b081c375de9@redhat.com> Date: Fri, 4 Apr 2025 22:56:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/8] iov_iter: Convert iov_iter_extract_xarray_pages() to use folios To: "Matthew Wilcox (Oracle)" , Andrew Morton Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org References: <20250402210612.2444135-1-willy@infradead.org> <20250402210612.2444135-5-willy@infradead.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250402210612.2444135-5-willy@infradead.org> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Dm0r5C7K1mFQ06lZy3C5thpMmvkjcBpUPuXApSUlEzs_1743800217 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam01 X-Stat-Signature: agpy5ramjpcqnqis1humbaohsw8w7fx6 X-Rspam-User: X-Rspamd-Queue-Id: AFBD4A000C X-HE-Tag: 1743800219-891873 X-HE-Meta: U2FsdGVkX1/lUPeAhckmUs4NehnrLVInjwl9VcHnv/e+ue5/KOSvWHOsDYKtSVLDx1VCDY4VOszgYc/g/E/AnSO7z/SpHQBwadzh9kRmPXCIyBWxr92/2v9s6Yx8EaznzrPyfxwNIg4TJMWYWIQI/XaeFPdNcWVcuhCQEMMnIij9vRYrAdUGAmsR/FHjV2YdLOauppPcQWD5R2mBYW9ssR0370yOqxyty+cjEraFuHh1JQG0KVKXAVUCG1f6ISE4sIV7tbJlZgvDWRTqHyz8Ip5DK+ypcUj2SnV2e5oqX6Rm6afiTDwR617qPhIuQFUwxwhjZMlQAnezkX5gLC+MCHRFJkdCrmnp91J+HAOuq73wQB//PxLmhy+0yPu/Tjw/mIZfy73cCbyj0jibCuG584d+nK5P9xR4xJVNQup+vVhWl2+906MwqiieFSaZ5C+xLhFXTeK3CgG9n4v4q/FH9DCRpXS/lz6NEBjoUDAD0q57HlsA70st1c0L/gHW9W81o510tgTfZqgCpc+/bXGUSK/5hFxc/awlKbYxGF95K03KfJeV3Po2J3wmhaxBOqteYybNcL+4oCedw07MJvrLgtUmPFDEfJdssTNB08pWMULVhJ0Ps6NMNbLgKvCo6g/9gHWIJ34FGBJl1LeRykYOeFoo4Wbx7TLNpRgEwbr7C7CBxWdq0o1Jgx4T2cNoSynes+OEVd+f0tXpD5ICL5AtEtPBtNnhNQmdw0GUu8U7gdk99w/cbWy/5WWgIAVEKLqZ17MG8cLm6nm9qvCcL4+Yf8FXoRUwAxXCDgi8hlI/avbEkwqK+vCYJgMwOhtfs32APM+HPQ4/1PuyPsFQJeX3Gz7nKxpiAueyosmOX62C8ixzJE3oEDkSCHK2iXPEyIlvaikdYh+AG9rl0mj7PNm0hC2xSRJ4L8OO382mozID2jjFLPcYCNtijNLSwO9881IEsa8sZENxTpWiZA2BOrv DGTe7lUO V23k7wt+nW/hJ0hEX8TOZ7GTlJjaf6i4PBGLQX0RBku1y3T6wXeJGL3XG1HkrjW0WqEJWm5ivfLK1j8cfJ2xPzQmzJDqRC684mqoHcHv7L0GuTe3HNVzWrxiRzt+SL5EEg7uOTVD2zuiCFRRm9TJ89icTJLJ6vQV05g0MrgMWCvymaiuXJKQso/VKav+og43DKg8eHwvVD3xb76ZqLllLrMmCbgKAPhTwcnVsUzVDkGdgkYCRNSIMUcWzjpQpC9Bo6BCO5nt26pxDPiDmHgbBISE4OHvos3UkKwdr6lHmnEzoa6+nD9S9tZ2m3nj0hrtsMhuIUSm7x+jew5djLFQHCJyDzn7EqQW3uWd0F1WgFAIEXSWYt2GQNDu82raMKiwgOHENAECU/WpoV8xm3xIZEhfsknd9TygNW6v4uqAVUDJRlb6KgmULqxsFWlMImK21SNwggye1ufquQxG2QcH7o3/AcjmnS8aTDPODObvzQHn4xy1XeNfJ6WwWYr6pGg2+PruxtupVlDOGYYf56ND1vMsOeQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 02.04.25 23:06, Matthew Wilcox (Oracle) wrote: > ITER_XARRAY is exclusively used with xarrays that contain folios, > not pages, so extract folio pointers from it, not page pointers. > Removes a use of find_subpage(). > > Signed-off-by: Matthew Wilcox (Oracle) > --- > lib/iov_iter.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/lib/iov_iter.c b/lib/iov_iter.c > index 7c50691fc5bb..a56bbf71a5d6 100644 > --- a/lib/iov_iter.c > +++ b/lib/iov_iter.c > @@ -1650,11 +1650,11 @@ static ssize_t iov_iter_extract_xarray_pages(struct iov_iter *i, > iov_iter_extraction_t extraction_flags, > size_t *offset0) > { > - struct page *page, **p; > + struct page **p; > + struct folio *folio; > unsigned int nr = 0, offset; > loff_t pos = i->xarray_start + i->iov_offset; > - pgoff_t index = pos >> PAGE_SHIFT; > - XA_STATE(xas, i->xarray, index); > + XA_STATE(xas, i->xarray, pos >> PAGE_SHIFT); > > offset = pos & ~PAGE_MASK; > *offset0 = offset; > @@ -1665,17 +1665,17 @@ static ssize_t iov_iter_extract_xarray_pages(struct iov_iter *i, > p = *pages; > > rcu_read_lock(); > - for (page = xas_load(&xas); page; page = xas_next(&xas)) { > - if (xas_retry(&xas, page)) > + for (folio = xas_load(&xas); folio; folio = xas_next(&xas)) { > + if (xas_retry(&xas, folio)) > continue; > > - /* Has the page moved or been split? */ > - if (unlikely(page != xas_reload(&xas))) { > + /* Has the folio moved or been split? */ > + if (unlikely(folio != xas_reload(&xas))) { > xas_reset(&xas); > continue; > } > > - p[nr++] = find_subpage(page, xas.xa_index); > + p[nr++] = folio_file_page(folio, xas.xa_index); > if (nr == maxpages) > break; > } I'm curious, if we would have a large folio in there, and we'd want to extract multiple pages ... wouldn't we only extract one page per large folio only? :/ Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb