From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70996C54EE9 for ; Mon, 19 Sep 2022 11:05:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B7CC66B0073; Mon, 19 Sep 2022 07:05:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B2C9A6B0074; Mon, 19 Sep 2022 07:05:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9A6B16B0075; Mon, 19 Sep 2022 07:05:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 8CB3E6B0073 for ; Mon, 19 Sep 2022 07:05:30 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 6F545A05F4 for ; Mon, 19 Sep 2022 11:05:30 +0000 (UTC) X-FDA: 79928554020.18.440C3A9 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf29.hostedemail.com (Postfix) with ESMTP id 79729120014 for ; Mon, 19 Sep 2022 11:05:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1663585529; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IulqkCtEaGt099GbXE/BHeOG0mRKOudTYkQ9exTVP/g=; b=CgOJI4DhH784acAXv5v3pqO/5DDxyYmEfpWnFCiPfMUnoceDMP2hZpKllkUpMaQb5/nmsj cSWBUxKPH1PV0KszpKRdKLTNfx7gf5HwNAjYGfd8vRvvK81dWFNmXE5WHF6nW2P2tKDlph 067ns/rlRnDoOTEPmi9hig5PgsjH6ZU= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-187-WY7qbDqgOnql3VTWXQoZeg-1; Mon, 19 Sep 2022 07:05:27 -0400 X-MC-Unique: WY7qbDqgOnql3VTWXQoZeg-1 Received: by mail-wm1-f71.google.com with SMTP id o25-20020a05600c339900b003b2973dab88so15027725wmp.6 for ; Mon, 19 Sep 2022 04:05:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date; bh=IulqkCtEaGt099GbXE/BHeOG0mRKOudTYkQ9exTVP/g=; b=wqGG6CGVD2gT2HGGCzjs3Hcyon6w1IuPCUNFYpG+7By3L/JEqE6nvmNwQOD874/osu h9YAxYnkwkSjtPtSgUPtEy3+iou7Q9fLzF/X9/gO6WFYju1MPEnvOrx1UYQMjWENIyZN o1fzMu6qzBNd8ctMpyHOQuVJtuuUJDteIR4Mh9Pj4gnH+CoqM1/tHL3ni5gYl8jOKdCk KjDpDJdJ0E8aujZCDuRDufapcHBMiVd67vVVPMtX9umLEKx99gIYEQaP1GK9Xx+91Xrs omD+TbFK+/RK17p+AnSl00rpDdHvxHoZtRYvZUMpZCR1GrlThoURY5O2c+Wg+HClb4X0 kUGg== X-Gm-Message-State: ACrzQf3sJvHU+1oXWekM1NMGc9Zz6hmRXif5Zh8casgw8n6CIVuFJWy3 utQE7YZvIG7qxVdaBBWOQ3ZqwUds9h1jkIDkG6kM6FWv9UoKxQLpozibrZTRKbS21kiVMNgQ5nA H/pM/h5zscwo= X-Received: by 2002:a05:6000:114b:b0:228:ab76:fa00 with SMTP id d11-20020a056000114b00b00228ab76fa00mr10087457wrx.628.1663585526746; Mon, 19 Sep 2022 04:05:26 -0700 (PDT) X-Google-Smtp-Source: AMsMyM57vq8QjEFjVNsIk+CislbvrnvNW7MFRM57slGULMzKF0ghTms9waLzTbyAJnL91m2L8CeC3Q== X-Received: by 2002:a05:6000:114b:b0:228:ab76:fa00 with SMTP id d11-20020a056000114b00b00228ab76fa00mr10087440wrx.628.1663585526436; Mon, 19 Sep 2022 04:05:26 -0700 (PDT) Received: from ?IPV6:2003:cb:c703:c100:c136:f914:345f:f5f3? (p200300cbc703c100c136f914345ff5f3.dip0.t-ipconnect.de. [2003:cb:c703:c100:c136:f914:345f:f5f3]) by smtp.gmail.com with ESMTPSA id bx26-20020a5d5b1a000000b0022afcc11f65sm3939718wrb.47.2022.09.19.04.05.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Sep 2022 04:05:25 -0700 (PDT) Message-ID: <93339a97-ea08-0880-b0cf-e5270179079a@redhat.com> Date: Mon, 19 Sep 2022 13:05:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH -next v2 1/5] docs: notifier-error-inject: fix non-working usage of negative values To: zhaogongyi , Akinobu Mita Cc: "linux-doc@vger.kernel.org" , LKML , "linux-mm@kvack.org" , "linux-kselftest@vger.kernel.org" , Jonathan Corbet , "osalvador@suse.de" , "shuah@kernel.org" References: <076b1f2a38ab4ca4a61e6a79c765bcba@huawei.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <076b1f2a38ab4ca4a61e6a79c765bcba@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663585530; a=rsa-sha256; cv=none; b=kudU1yNiVgC29+dh4fV/SC4q2QkQHtknt/6Qz0GiPSTT34h5lmeqXUPXr2DZhM58rIgidQ 2WH1ynC6b/MXKnfYhmhY+gve4TBxcjrk5ey1KS6Pca9C0eV3I0sXtQcdkliq3ejZ4h88eo pBF9GA3eRU6a2lmBdUJ2XnQDI5VYAdc= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CgOJI4Dh; spf=pass (imf29.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663585530; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IulqkCtEaGt099GbXE/BHeOG0mRKOudTYkQ9exTVP/g=; b=KquI4oPX59Hsh5UsybZGH57R8uEG4IqFMY3Mb9gu0iI1JddkLNvwirqCdgZ4RzPwzhXGd2 nGD5Oc8CvgfZ6YhikTkyeV5LVDJW6QVXFdjgWwgJCB2OW3QuJrCH/0zWmBZzEAYa95V7QB gMGsvWxykKlkXlwXggZTVq5xT9Tau8Q= X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 79729120014 Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CgOJI4Dh; spf=pass (imf29.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Stat-Signature: udor8by1j8maugqk6spx6hkeae9k17ds X-HE-Tag: 1663585529-165401 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 19.09.22 11:01, zhaogongyi wrote: > Hi! > >> >> On 17.09.22 07:39, Akinobu Mita wrote: >>> 2022年9月15日(木) 18:01 Zhao Gongyi : >>>> >>>> Fault injection uses debugfs in a way that the provided values via >>>> sysfs are interpreted as u64. Providing negative numbers results in >>>> an error: >>>> >>>> # cd sys/kernel/debug/notifier-error-inject/memory >>>> # echo -12 > actions/MEM_GOING_ONLINE/error >>>> -bash: echo: write error: Invalid argument >>>> >>>> Update the docs and examples to use "printf %#x " in these cases. >>> >>> I'd rather fix the notifier-error-inject module than change the user >> interface. >>> I'll send a patch, so could you check if that solves the problem. >>> >> >> That will also make patch #2 unnecessary, correct? > > Yes. But there is another commit 005747526d4f3c2ec995891e95cb7625161022f9 that has the same problem. > > Thanks! Right. See my reply to the other patch: https://lkml.kernel.org/r/93c044ca-7d2f-e23f-8eb4-72c133737a15@redhat.com simple_attr_read()/simple_attr_write() fmt behavior is odd. -- Thanks, David / dhildenb