From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91EDBC6FD18 for ; Wed, 29 Mar 2023 23:33:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 213426B0075; Wed, 29 Mar 2023 19:33:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1C4256B0078; Wed, 29 Mar 2023 19:33:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 064E86B007B; Wed, 29 Mar 2023 19:33:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id E76656B0075 for ; Wed, 29 Mar 2023 19:33:04 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id B1E19C0E9B for ; Wed, 29 Mar 2023 23:33:04 +0000 (UTC) X-FDA: 80623538688.23.B1B8D8E Received: from esa1.hgst.iphmx.com (esa1.hgst.iphmx.com [68.232.141.245]) by imf24.hostedemail.com (Postfix) with ESMTP id 1B358180008 for ; Wed, 29 Mar 2023 23:33:01 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=wdc.com header.s=dkim.wdc.com header.b=qV9kKLOD; dkim=pass header.d=opensource.wdc.com header.s=dkim header.b=EYPDnYeY; spf=pass (imf24.hostedemail.com: domain of "prvs=44543d287=damien.lemoal@opensource.wdc.com" designates 68.232.141.245 as permitted sender) smtp.mailfrom="prvs=44543d287=damien.lemoal@opensource.wdc.com"; dmarc=pass (policy=quarantine) header.from=opensource.wdc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680132782; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=j25xVus8NheocSkcjQw9AmlJ/7ysuPLFwjSpcM+3bT8=; b=nnjhQMvNKRq/bqS6GpZdvA53Dd5VuyRWuYEAehBdmveFL9nHHT6es+4hMY5TPGoNVGejbQ B1O+A4SPqw6GuH9g2ZYds+aQRN3UtYGJ4Ycys1H27syh2L3kVo1VFYXJSLnzgP7MBpFpSH NWRdBo4sS62doj+j/o5IGDwGd3nUU14= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=wdc.com header.s=dkim.wdc.com header.b=qV9kKLOD; dkim=pass header.d=opensource.wdc.com header.s=dkim header.b=EYPDnYeY; spf=pass (imf24.hostedemail.com: domain of "prvs=44543d287=damien.lemoal@opensource.wdc.com" designates 68.232.141.245 as permitted sender) smtp.mailfrom="prvs=44543d287=damien.lemoal@opensource.wdc.com"; dmarc=pass (policy=quarantine) header.from=opensource.wdc.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680132782; a=rsa-sha256; cv=none; b=3rovPXOHmOETIyL5gSInQeu9LSFKm4YtAcbmrs7lWYdqZR3YU4Hx9KFnuHGOmCJoRLha8N jUzGRT6wVvPV0tZHwwAQeQPsc+rTbx0g0U7mOumQwf0M5lRbs5/GRS7pqnGkziooqqoE8o Y2H4DtiPrPpWSqyBfp4Kejs7b6dEAW8= DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1680132782; x=1711668782; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=APb6MZhJtx+BKA0st8ClsB22pp0y9Pqig7XgT6sLxmI=; b=qV9kKLOD/QOC17xE+vFhSJC/QvImLn9CJrX+nYgbB5OWWs2sfyKYSUtE 42iaDpRT6Bsxc368Va6tbiwk2mz1ncTcnmJ6XmeekqqnrDlVTJRHejg3A ZlIOxVwzQj83LgfyoqzgXhdTcupij8nzHJzImQuD3YmfH39ZUUQnRNtp6 Liu5fHSlVafY71EGR1ZBGg44tXLYAxXK0JjuBfO9jNpWurTU3Uj+RBkry vf5PY9uycn/AOFIrfNH3965MYKFxtBZXtTGDrsx0UnROJ3p5GJjIXHeLb K5QoG6T2idw7aF2E3uPWou1PRFCnWHoeCCYZk3rmYLrHNjVsTtGT7qX4Y Q==; X-IronPort-AV: E=Sophos;i="5.98,301,1673884800"; d="scan'208";a="338903968" Received: from h199-255-45-14.hgst.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 30 Mar 2023 07:33:00 +0800 IronPort-SDR: bVFLwSwgm1N/D8SoHvFCtbxvFCfycQeo4lew+NTozycqBAoNx+Or7OF29uGkdeoo9ZCwSKiMog 7xdx2GhrXIO2HmU0G7RJm6RdlPAp8xhEYJvrO2gl+4RAizHTE087xtS5dvcEWd5tVn3wFL8xuv 3w39wQgaV3iFVrog5HNI9zkAChvdWzUkwqEx8ZvW/k4DxXiN/gQFYKC62FRjQZ9gUBQUFv8wIC 1McFq2eYW2XC9gE+5Bwx1CSaF8ce/RJstuE55SpfB8rsuThd9ZG0ARaBkdHTHemeQWKAgvyNeT IsY= Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 29 Mar 2023 15:49:08 -0700 IronPort-SDR: 1lfH95MedKeSxWBuhVfqFqZTEKSTA9oGUuwLZvF7XspHV4TsKG6D775IeYZCoZQQvYQa/kTBWt GwsdfnIMbs+AQ7pniELGFSnqFmVLGBTLnQsOuNi/7Sd5RGDjpnRlIbY6bZlscqe4uZx8FFivl9 YxuxU7ozADez3SBicPu9yfcoLHr/rpmK1CRXyKoyox9d2rWMsjaozmggMeSxEn1ii2ITIr3deW Uinl7bGgBU7lxN8BIzLpZvzGMuEoBB0fg2eyxCXWkMP1pSmH5vGpjlXJjfzTcLIrEpZq8Zv0Vp 6eM= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 29 Mar 2023 16:33:00 -0700 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4Pn2sl698Cz1RtVx for ; Wed, 29 Mar 2023 16:32:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= opensource.wdc.com; h=content-transfer-encoding:content-type :in-reply-to:organization:from:references:to:content-language :subject:user-agent:mime-version:date:message-id; s=dkim; t= 1680132779; x=1682724780; bh=APb6MZhJtx+BKA0st8ClsB22pp0y9Pqig7X gT6sLxmI=; b=EYPDnYeYBXvIPZU4yIKMtwumuioUV+FfuJ8fPXn7WoGbUKa7gK8 7zyK1PX1ztxSUnflTcanHerZGll9o1DObBU+bLHw03SR356wtqMJKa09n0qcvgMS vZWj5aB/mrLRcKD+ZLaMWZavI1BMEp4d64WqsbKtIuhCcLZQRoyst2pdWD8Q3ya+ ByQ8/RWystsxIVYmNeYNkH7soMStSvU7GBy5Z6O0BckSLdQn+7R88KD6YesLFa8q MYecYOCLxyWkIdz2hhL6x1SyTg5ktN5Fm733y5g6M9KOTaT0AtP36cbIMuLZhZ81 iYFb15wzt+oKQjUeF0cNSTKYAFDWutLqRVQ== X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id UmKRpmuyXYs8 for ; Wed, 29 Mar 2023 16:32:59 -0700 (PDT) Received: from [10.225.163.116] (unknown [10.225.163.116]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4Pn2sh28h9z1RtVm; Wed, 29 Mar 2023 16:32:56 -0700 (PDT) Message-ID: <93331778-cc12-5d26-34a5-7cd8834a0309@opensource.wdc.com> Date: Thu, 30 Mar 2023 08:32:55 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 07/19] md: raid5: use __bio_add_page to add single page to new bio Content-Language: en-US To: Johannes Thumshirn , Jens Axboe Cc: Christoph Hellwig , Hannes Reinecke , Chaitanya Kulkarni , Ming Lei , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, dm-devel@redhat.com, Song Liu , linux-raid@vger.kernel.org, Mike Snitzer , Matthew Wilcox , Dave Kleikamp , jfs-discussion@lists.sourceforge.net, cluster-devel@redhat.com, Bob Peterson , Andreas Gruenbacher , David Sterba , linux-btrfs@vger.kernel.org References: <7ba6247aa9f7a7d6f73361386cc7df5395436c33.1680108414.git.johannes.thumshirn@wdc.com> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <7ba6247aa9f7a7d6f73361386cc7df5395436c33.1680108414.git.johannes.thumshirn@wdc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: q81314ye4zd9e9ef6jxrec5fsb8un8fx X-Rspam-User: X-Rspamd-Queue-Id: 1B358180008 X-Rspamd-Server: rspam06 X-HE-Tag: 1680132781-860035 X-HE-Meta: U2FsdGVkX19tfRV37aeQPPUj/gHlbmhyNRikjDDq2kAnmxMpbcWl7EnuSu58/6O9hXisvavQeEZpQC7JBiUJfcOPgBXCEjIzrR3LUTR4Kc1NIKYo1o7mcQgzBlBZSiehlsTDst+BuDgQ9TAD40ovyx2AG3/Zri4nQYxM06mxamR6n91Fy4to3QgJUFFgVrgnsrr0npHE1wwL8+KA5jMsngGKeIoGTh7EYWs2pHvkAN51/xr3gekEBUCRz89yUjYznjTQQE1jE9dVX6kFO8+K1OMfUU5rWcGb9GqR3rql9P9pXQQLWXtExXMX2X/R+rjcA48/EtwXW+MJuwbuhxghIWMG9TVu/HGMweORzIxVDq42g9hVd974rMUCN6zBwN91ptwHsUotfNneJ8VAluouCDlpxgT75OPrshlmkZBoBMBSjzsxOKBpCMmcDNpjx32m1/Bc+hvOE5SGSvkkfu1XP5/UPZlMv5Ln7m8yu6h2cccsQ0ubDZoyOJEH1xJd1Wj4GFmOIUEKvEq1YMkODIIqI7kYiN4OtyDqJw4kyF003NMRqCRTuo5caJb7gE5xGfR1P6YAIxCQIKzUajbgg5TlNrfynV+K+ioMq76hIMnNZQ3B36V4L5la1A9NS/eneSx10xqMya0PObYwMc5tR1j+2aPxstvdR5UojdPf2lmw+8Mo1HlFRH8G7ANqYL48jZNChD1p/zGp2pQLzo5y7nd7VUrXuvL4Z5//rfbiRTBWDYtjG+lIkCXaX69xeYooSQp/UMR9Qt2iGzHUVRbUMg/iufowEEI54HWBPe1nCwfL3jdlDRfF4S68U6BvsGAiIh4i74k4pgju6ylGxRqHSKfWR31gMze2gW0MRIG+bcWhdnQk5g3bfqqkiu10xyB0NAu5FJUf0M40I2pML+98Ki75ZgSSMr/QyuF8hMwSfItLstcyJ2IFL+1RSW6AFAzIFJEhYxbZtaIN2vxUFm9S3l5 exT4IzNZ 8WAOqDAfeBEB0qqZpENyv94Bb2SSpJU6pgv8FUiK02ehmLBJEl06dBePdN8hGS+FaeZeO7HCJ1sAeINDYSjVLqwUdDkeiebTwAfOMy0e/7FBkvf/kvFFWKl/g/tyeGTb2VRn/ZBKQrRAJb2GBRIBHMhMSE8AdTxctisHWk7V1bxgwy2Mo8xm4jBJVVrHPZYMZn/Y2Fc3HUX+YuvwGqpjvszlK8Pkvnwj95KuefB+5SSWq+E1VxgimMpMN/oZyqpn4pejuE1HUlV84RD87IPmbsBdzHdZ/5jon9tAekEsOukexQpWGHZNv5jIr+2gdNXAQOlDoCmSQ9rarG07WASfreaxwi4CSl0oztlHt1JCU1hx7Gnpt43t/k6UxTAQrYs+mAtI0vDyK4LFkXV4Nkr8Kp8dMSkvYDP9OeifLuD90SS/YfA5hTSy/3cZRGnTxjAqgkSpBc4iqM7LdCUw9p/IcqcFVczZSYekjBIlnVyJ1/f21WEjjWeVvYDX7OSxjwFd/gHYkG/pyvTAWVGr7JPfD0cq37ScE7ORSJf+6NNLuX0XrQD6xhfrj++zWflhahWgm5bavWVu33DMEsJ3wwm2mh9TDkSwYvcht0lf+dbzf08zAdD9zHPKEFH2qYStRVGhoNRk3zwvT5Gzf7UsNRrLBc4IdXoiZvvlxJiNCdOLUXgAzja5VcsL93INGgw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/30/23 02:05, Johannes Thumshirn wrote: > The raid5-ppl submission code uses bio_add_page() to add a page to a > newly created bio. bio_add_page() can fail, but the return value is never > checked. For adding consecutive pages, the return is actually checked and > a new bio is allocated if adding the page fails. > > Use __bio_add_page() as adding a single page to a newly created bio is > guaranteed to succeed. > > This brings us a step closer to marking bio_add_page() as __must_check. > > Signed-off-by: Johannes Thumshirn Reviewed-by: Damien Le Moal -- Damien Le Moal Western Digital Research