From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8704FC433F5 for ; Tue, 12 Apr 2022 03:15:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1DBF66B0073; Mon, 11 Apr 2022 23:15:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 18A9A6B0074; Mon, 11 Apr 2022 23:15:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0529F6B0075; Mon, 11 Apr 2022 23:15:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0254.hostedemail.com [216.40.44.254]) by kanga.kvack.org (Postfix) with ESMTP id EBC4F6B0073 for ; Mon, 11 Apr 2022 23:15:21 -0400 (EDT) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id A9BCFA89A3 for ; Tue, 12 Apr 2022 03:15:21 +0000 (UTC) X-FDA: 79346761242.27.20EA488 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf06.hostedemail.com (Postfix) with ESMTP id CB9A3180003 for ; Tue, 12 Apr 2022 03:15:20 +0000 (UTC) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.56]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4KcrQf18fWzgYdP; Tue, 12 Apr 2022 11:13:30 +0800 (CST) Received: from [10.174.177.76] (10.174.177.76) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Tue, 12 Apr 2022 11:15:18 +0800 Subject: Re: [PATCH v2 1/9] mm/vmscan: add a comment about MADV_FREE pages check in folio_check_dirty_writeback To: Christoph Hellwig CC: , , , , , References: <20220409093500.10329-1-linmiaohe@huawei.com> <20220409093500.10329-2-linmiaohe@huawei.com> From: Miaohe Lin Message-ID: <932f5586-f0d9-4046-1b9d-8da43f86abf8@huawei.com> Date: Tue, 12 Apr 2022 11:15:17 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.76] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected X-Stat-Signature: 5omygpm917gqmbdbgxdtqueg1sbzpame X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: CB9A3180003 Authentication-Results: imf06.hostedemail.com; dkim=none; spf=pass (imf06.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com X-Rspam-User: X-HE-Tag: 1649733320-870212 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/4/11 22:16, Christoph Hellwig wrote: > On Sat, Apr 09, 2022 at 05:34:52PM +0800, Miaohe Lin wrote: >> The MADV_FREE pages check in folio_check_dirty_writeback is a bit hard to >> follow. Add a comment to make the code clear. >> >> Suggested-by: Huang, Ying >> Signed-off-by: Miaohe Lin >> --- >> mm/vmscan.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/mm/vmscan.c b/mm/vmscan.c >> index c77d5052f230..4a76be47bed1 100644 >> --- a/mm/vmscan.c >> +++ b/mm/vmscan.c >> @@ -1436,6 +1436,9 @@ static void folio_check_dirty_writeback(struct folio *folio, >> /* >> * Anonymous pages are not handled by flushers and must be written >> * from reclaim context. Do not stall reclaim based on them > > While you touch this please add a period at the end of the above > sentence. Will do. > > Otherwise looks good: > > Reviewed-by: Christoph Hellwig Many thanks for review! > . >