From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3D38C3DA4A for ; Sat, 27 Jul 2024 15:39:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 151166B0089; Sat, 27 Jul 2024 11:39:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 100776B008A; Sat, 27 Jul 2024 11:39:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EE2D56B008C; Sat, 27 Jul 2024 11:39:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id CD2B36B0089 for ; Sat, 27 Jul 2024 11:39:00 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 4D7CCC011C for ; Sat, 27 Jul 2024 15:39:00 +0000 (UTC) X-FDA: 82385940840.01.05F7599 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) by imf15.hostedemail.com (Postfix) with ESMTP id 5CE7AA0020 for ; Sat, 27 Jul 2024 15:38:58 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b="2fA/b1bX"; dmarc=none; spf=pass (imf15.hostedemail.com: domain of axboe@kernel.dk designates 209.85.216.53 as permitted sender) smtp.mailfrom=axboe@kernel.dk ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722094681; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8HNKPiNpgoslt8uTd91g/kgBmz+xn5BZUJtIHzALliI=; b=dtYh2tgMdV5C/Eo12f0rI0z9Bm+jjRG2atEUDrPb3/+V7DSC/W/FSkyUg4p2nOzprl/Al2 RZxbE1geBFRwyWQBxBowqCzHaofYOtZLtGR+wnAKHe4d7KAx3yAjXNFTFXqalYvgZ8P8BY 113jsUXke5CPIKI6WzBA5nUuIA1XMe0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722094681; a=rsa-sha256; cv=none; b=YBYwUc6MR7DFY1NHguS3EoJ5R8Y4r4rBVJe0YdzqcgY6dXeEZxzeNxFjbhvZF4K2/j6V64 rTh+HZ194phedAUEsT8uzEi6LpNY4JUXNjIUYWN8EV6VJ/GeVBvKSmVp7XAazwehNf74t0 Y/mZmfqdAmI6QSiYHszZU6Pf2LRNWdI= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b="2fA/b1bX"; dmarc=none; spf=pass (imf15.hostedemail.com: domain of axboe@kernel.dk designates 209.85.216.53 as permitted sender) smtp.mailfrom=axboe@kernel.dk Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-2cb77ecd7a2so317146a91.1 for ; Sat, 27 Jul 2024 08:38:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1722094737; x=1722699537; darn=kvack.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=8HNKPiNpgoslt8uTd91g/kgBmz+xn5BZUJtIHzALliI=; b=2fA/b1bXPu2RMxpGeh3D7S3dcnpRYtVCtNZ3dcFOfIEyVQyEJpnB+Rn5KFctg8NO82 G3f9FADAHwiZvd/04C7OGM2ZIxx4tdoAjOpaZj2Crg3Nv9qJ/Jmb48+5jGal3kEM+zCq GFxMXW+fJDKbEoyH7GrvprdVxwkwnZsT6ylTpZCBVO9o8mIFuIepf6Nm1O/h+B/oPUdo fyOiIgIr2heW8gzdKCaL7dXNj6NEuB2xZ1cJWZ5RdGZHv3j3YVytwXDIObrO/VyPT/pm 0G6raLs84tKduxeF7ViILmeDf2lihm3GQa0XRzYdoD7K6yoGZhPAzfXnsIqpdxPcrpOT bjnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722094737; x=1722699537; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8HNKPiNpgoslt8uTd91g/kgBmz+xn5BZUJtIHzALliI=; b=TIyJnfGo3IksIboamEFcZg+2vCbZO73R0usBgbLmIUOqIZAV5VB4u1HHTnGPQ2cm0A u1OeKdUcBaPdjQ/VJm+ZmaZUjwdOgH9nDSnW8DLoOIN2Z89J3DByZBAYh9eCCr+nQzj9 YtrqI+yNZ/AbXd7K5DdsvOFfoFC5Rpq74/o4toJPI3p1qakicE+bJWh/oPw+Tvx77Ynm 2i7itB54r2OqX8yHoZa4HTbMVQw/8EeBQPiUZ3WRrblEUgQse7FYecIoWR6oS6AvvC65 syYNdQGwkySOZb1WYD4IrFrFMVv5pfVXJD9XGGcncFyMml6mnjzTRgN4mfiThUZh9JX6 jP5Q== X-Forwarded-Encrypted: i=1; AJvYcCWJAfjs5o5j1N9mB7KHZDmPXQk8bAVDgamUMCAp2e8ykL02ueyyCk5trq32j3zcu78diuHkP3LtHQ==@kvack.org X-Gm-Message-State: AOJu0YzQEXT93Qv3IIaHSzHDZgwnde83dp2nvDdO5l78WxxjopamFMcp iVuzj72MtrL1i+AHB5X/ldV6PRVWnnQQ6SpAnl9wCGxhRyVmvcYAE3PahfsSovU= X-Google-Smtp-Source: AGHT+IFwQKbF0uBw5pgFxMEyfaar+PEss1lta3c/RwRkh8twV305KiNARJFmDgSWlSUjiqJFzl3SXg== X-Received: by 2002:a17:90a:c914:b0:2c8:af45:adb9 with SMTP id 98e67ed59e1d1-2cf24bde04cmr6059841a91.0.1722094736937; Sat, 27 Jul 2024 08:38:56 -0700 (PDT) Received: from [192.168.1.150] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2cf28c7b092sm5464321a91.20.2024.07.27.08.38.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 27 Jul 2024 08:38:56 -0700 (PDT) Message-ID: <93243310-22cf-4d44-810c-17629b46a33e@kernel.dk> Date: Sat, 27 Jul 2024 09:38:54 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/7] minmax: reduce compilation time From: Jens Axboe To: Linus Torvalds , Lorenzo Stoakes Cc: David Laight , "linux-kernel@vger.kernel.org" , "Matthew Wilcox (Oracle)" , Christoph Hellwig , Andrew Morton , Andy Shevchenko , Dan Carpenter , Arnd Bergmann , "Jason@zx2c4.com" , "pedro.falcato@gmail.com" , Mateusz Guzik , "linux-mm@kvack.org" References: <23bdb6fc8d884ceebeb6e8b8653b8cfe@AcuMS.aculab.com> <902a9bf3-9404-44e8-9063-03da3168146a@lucifer.local> <137646a7-7017-490d-be78-5bd5627609c3@lucifer.local> <36aa2cad-1db1-4abf-8dd2-fb20484aabc3@lucifer.local> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 5CE7AA0020 X-Stat-Signature: jibqgpwzfq5ybhtdjb3qfwt4ii8noioh X-Rspam-User: X-HE-Tag: 1722094738-948462 X-HE-Meta: U2FsdGVkX19Hm3IYXpI1ozjh6JhGUMjOuaqYajpWZ0jCj+m4vXx1rywKUt4wiB1QI+SYfYwda1qIkGIgUG4pzX+m9/euEsZMD4DdEz4LvMa0xoRXkCEgprzIiRZu0FeQTGZQUb5ESc+jn97oTomXcfftXqB3mXEkNqMGeCDYAndplTbe1eLA8JF7bzUBce3MWgCLonwWNlfHlPCEQ/r++QmSHMlZaLusnzeV0lzVK5HIWo52cCGYJK/dlV2COG+DVAE9RnQF5mK7tlig8rYehPfWzIit7fXncOtKffxYCUlaeJAi7dW8NNQNNtHbDRxlYBzcJkOzQZ8y1kVAsCGYTM7ScqbOSjIk5HbMxoDs68Bfc4dmPpcAOGioCQiaPI8dY9QQBAdOn1fzWsOdzSPaY1Y7Y5RxRiSZKndMclMob1sgctrN5E7m87d9EniXvbDeBJEcAV8PpnQxVBsdb4lE0DoCybR88lyvBlpRGSTeIrkzmhfIMFVDRiTMxpzSuG+hMuB4sqHX6hJdsY7ZgSEWRHmnb+hfqYB1lewgWvKcKWgoQJLrxVpauR1qEFeNf51mpZy7K/o4AO2EuR+XE4+w/olLoxy77hJrP5CooyQpkbVkvZaHs4J0nJlXUI0MAppHEG5K1L1A4p2EE+2HJdJ0U2vB52Mlk0TSffygtPmSMQF6+Kw2PWtKUoKAdPNoSn28yHBU3vm4iVgXu2uyDqrtWPiIFMdYaLIbVWn9ZTgelGnmvLh8rtvZhyOmmOKPdea4IJcVHWeYUqi4ScfC+6GqOSd5UFo58/onUQiTwBHP7W6TJmnykVioLyDRFTIHjMq0lgah63yBcYQ87KWYc84wxw2L9eAJoLuldFs9PHKupAmG4wcfE3hV2x4A1Xlqp6MZoU6RnXpZcwgYMwm6ewr+OdgYivPG1FD8UdzrjNmOmWz4WnkCAJFLpgZB7eJA8dWpuiCYEHd9yyMwwFNnM9b SE/xsPT6 gkbutWijs/6E7tMKKRYq/EI3l6WpHP7lH8GnPuklda74lxL3MPVN3EeXj4si+P6ZMf4zJDRCgOrOYmIpOw/oPOxV0KNTQOdXhdrspwt6Xb+96jQItrDVbbouz2Zqgnen6YDqTE4b14uvD33sxybt40oHnxHCgMeVG8WXpH6O9ip5B/U96Ip3ypIVY8jkpEJ/Vek2lWYzsMKrEx89fcZ5OP4MAAnuxybIhySCdn/o9SFMl/1uhMV9O5K00+Mo2CpQ4d+Wb1Qn2tNGpSlsBfxYt6KCS1nYSl3/H7snD9yijK2nvli+8UN5z1HpEJYzRNyg/FHEVCQUvZq+CFrBZVni9KE4a2D0GHRvEtyjHbOWeFxHfe2TrMcMzvjbFf77Li8mj2+oGFGzlhf+VuzHslURb0o0AWZa07tydwHcIMRKQ9u3e29fjXR41cvr33hmJHi5NBtlV X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 7/27/24 9:30 AM, Jens Axboe wrote: > On 7/26/24 4:48 PM, Linus Torvalds wrote: >> I didn't even look at what the issue was with the >> bio_for_each_segment() expansion, in the hope that Jens will make that >> one look better. > > I did take a quick look, pretty obviously bvec_iter_bvec() which makes > it horrible, which came from Kent's immutable work quite a while ago. > Not sure yet what to do about it, will spend some time on this next > week. Maybe something like this, totally untested... diff --git a/include/linux/bvec.h b/include/linux/bvec.h index f41c7f0ef91e..9ccccddadde2 100644 --- a/include/linux/bvec.h +++ b/include/linux/bvec.h @@ -130,12 +130,15 @@ struct bvec_iter_all { (mp_bvec_iter_page((bvec), (iter)) + \ mp_bvec_iter_page_idx((bvec), (iter))) -#define bvec_iter_bvec(bvec, iter) \ -((struct bio_vec) { \ - .bv_page = bvec_iter_page((bvec), (iter)), \ - .bv_len = bvec_iter_len((bvec), (iter)), \ - .bv_offset = bvec_iter_offset((bvec), (iter)), \ -}) +static inline struct bio_vec bvec_iter_bvec(struct bio_vec *bv, + struct bvec_iter iter) +{ + return (struct bio_vec) { + .bv_page = bvec_iter_page(bv, iter), + .bv_len = bvec_iter_len(bv, iter), + .bv_offset = bvec_iter_offset(bv, iter) + }; +} static inline bool bvec_iter_advance(const struct bio_vec *bv, struct bvec_iter *iter, unsigned bytes) -- Jens Axboe