From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22700C41535 for ; Fri, 22 Dec 2023 05:14:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B06376B007D; Fri, 22 Dec 2023 00:14:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AB55B6B0080; Fri, 22 Dec 2023 00:14:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9A5716B0081; Fri, 22 Dec 2023 00:14:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 86DED6B007D for ; Fri, 22 Dec 2023 00:14:57 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 5FD4C8037F for ; Fri, 22 Dec 2023 05:14:57 +0000 (UTC) X-FDA: 81593289834.02.B08BBDA Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) by imf16.hostedemail.com (Postfix) with ESMTP id A08B9180004 for ; Fri, 22 Dec 2023 05:14:55 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=tTYurzrw; spf=pass (imf16.hostedemail.com: domain of rientjes@google.com designates 209.85.214.175 as permitted sender) smtp.mailfrom=rientjes@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1703222095; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8EpVJPwV8xdpCi/BHsDHoW6FS2qv5qcoyo7OpZbQn6A=; b=mNYqC13VnVnHZiWBBxW4FKyB9ehSn+C92HGsDXl+FxElhsNp4G8zESSUzhRPxDbmCrI1u6 vwoLZRrCy6tU2zFQJolcelfYpU1qGoCxeiQPZuEKX4lBnbuilNEkgdaCy13vnt7aEXJhS+ /nIQhrfgpJdeM1ZJYQBNxg81yZ6ZZzw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1703222095; a=rsa-sha256; cv=none; b=YVANMpl4sjN8a9BIoSIokN4AIhjMDLhH3N8+dTuG4nPKv4yDy/+ExSW0M3mzuJRgnxHV8F v4DCeMVKouc+XwPfwc+nbaRCKVFgRjL7h8EBCHeC/aRrvIQDlIT+Ajl/06+1UqdbcNifB7 IoEWZLt8aRC1kuHa7MSqQ07S/a4CcJA= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=tTYurzrw; spf=pass (imf16.hostedemail.com: domain of rientjes@google.com designates 209.85.214.175 as permitted sender) smtp.mailfrom=rientjes@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-1d3a9b9634dso99395ad.0 for ; Thu, 21 Dec 2023 21:14:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1703222094; x=1703826894; darn=kvack.org; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=8EpVJPwV8xdpCi/BHsDHoW6FS2qv5qcoyo7OpZbQn6A=; b=tTYurzrwVw12PdIlOU1UjUeExJOV0RiUe6KxNJJcr3FsIcWCsnUkAmU2ORXpBLS0G3 +8aZXXYkLUaRrgFCHdS78f4PRgpOIcswnwbqKKqbukZXofeq4khQtySHGEi0P6S3stRo hc6H7jfYaaZ7zBgu08Z5RjUq4X4G1vEylY6VKhwy6tGw05edpuLMK1+hwniKBUCkA+Qy KJ+NVHBNFJQGRUWCgpoFTxyiN30CboP1cG1iO2T3Eu0cLzDYXczw8bUxSFaPe3W411hq qokBcSjsfe+Fhv0NHco7VGadwENgyIgt9k0SY9FiNlI2CyNaHuijVy63w2st301FoVYm bSuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703222094; x=1703826894; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8EpVJPwV8xdpCi/BHsDHoW6FS2qv5qcoyo7OpZbQn6A=; b=FWWWpk1UbsV28ef8Vu2oY2b8KFI9+YtZC+XKwGAxce1gyMrYrPAz0XHTz64AF6GDi9 cG05gefnWDMDNPjTrpUslL9FeRuDtlSjPMpH9EipTPto3lvU3NwVPWpgxBi5xvEPVFmG kz3JrWJ2t8WUmksc4bTBXd6CR9+9KMzOg0tASq+qUdxq0kbK7Px+azIDg9Bq3Vwzmen9 +GGBAmIJYhl+K5kq8/fx82A0UhUNiBPBCD89fHZTjHLoVxZMsnWmOkV2ANOpS3csHJLM g1f36lK2pHvp5p9ypSM6zlo1LEEpVIncLur3kW1wfxBr0v5sulUjfs/mm1vIMHQ9mjZu ZJnw== X-Gm-Message-State: AOJu0YwAPMMpTautMvEsPf1ywboSpiz5wHs6INio+5TJTHqyAGX0UN69 vGFTaUBdFJpDAqu0kMQnr/jaU4T4BRyp X-Google-Smtp-Source: AGHT+IGwoh3X7adS7L4evXjC4NNt2+Ju49v+fiMnSiMHHPnVEmAeTX8TfE9pYRDSDNridjP5qtla6A== X-Received: by 2002:a17:903:2310:b0:1d3:dc24:31c with SMTP id d16-20020a170903231000b001d3dc24031cmr61138plh.3.1703222094173; Thu, 21 Dec 2023 21:14:54 -0800 (PST) Received: from [2620:0:1008:15:a7bc:c7f0:fb7e:556d] ([2620:0:1008:15:a7bc:c7f0:fb7e:556d]) by smtp.gmail.com with ESMTPSA id y21-20020a17090ad71500b0028b43d3250csm2653671pju.43.2023.12.21.21.14.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Dec 2023 21:14:53 -0800 (PST) Date: Thu, 21 Dec 2023 21:14:52 -0800 (PST) From: David Rientjes To: Yu Zhao cc: Henry Huang , yuanchu@google.com, akpm@linux-foundation.org, =?UTF-8?B?6LCI6Ym06ZSL?= , linux-kernel@vger.kernel.org, linux-mm@kvack.org, =?UTF-8?B?5pyx6L6JKOiMtuawtCk=?= Subject: Re: [RFC v2] mm: Multi-Gen LRU: fix use mm/page_idle/bitmap In-Reply-To: Message-ID: <931f2e6d-30a1-5f10-e879-65cb11c89b85@google.com> References: <20231222024458.12441-1-henry.hj@antgroup.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="2003067076-520779642-1703222093=:711362" X-Stat-Signature: 55c1u1pyz9ss4uyqbji4miswjojcwn8t X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: A08B9180004 X-Rspam-User: X-HE-Tag: 1703222095-550316 X-HE-Meta: U2FsdGVkX19jujZqdYT+SHpC+ZfIfiH+nw630KPd7WWvJcfUAgnMBKVjP9vOgTYKqXe9jqpCKgt04eYhkDUldmp510LPE4CNeTCyPN3nRiR4GT1+sdcDoG1uYPmwh7euvuDhQzd8aY3mXGhrCRWqABrSMNMn5+BwjxANNONA0MzJrYiA/7hXIIodRkEZ+VjWxn/MYMsDyQNcGqTSl7NDkQbV/OVRu3lJJi44e6Nk8BvA4h7SPzMMVAGM9nRvKX/sr2bZjCnnhY4jDgkcSCL13VUNKe3lRRG3/vOVewC2q+fjejdWIhb+rvZrxELJ101EAxBYNKBpEgmXiHo8kD7uDrAYtzqnhO9O1d5JrFeogRMD1ycCPxWeOMxA/SCDn8otC93XCQqrvkmV3tWqFHgJTOyt+m5ig9LiIuW2j3VCZmv7XzL4a3O3hsMCwwLcMga9kootr7Kcgqv6tQkrSlKCysG6eIBFFrvG88ESrjyGrpwNAz1hrOH9FZOM1cI2L3QQdtKDlqdna+t00ve1BDowBxUNjMHf6mNSNUJQRwVxKUL2A9TwHuvHfPWaAD8qtyNNnnyR6xBjalInaaF9Sjqrx/WQrffDr7nhyyuAcgGduf1UnOpCSJDf3HQW/MnWYUAK2TLv6qTqo5LXEkE56TOVhq0rrEih4gwVOQDIOuJwM00b0G6qqb35WJ6cJzudc830gChVJQExU7z0i8J+9aNCLSEceQGOprtXyzLPwweRxrbNel3kNVHZoEESv3D3l3YhHpoSEXJlRICo89TEQ1ggCjKA/n3yL7geG02wcrx6RiQmMF0IKd7kp8tCDpQv/xuecSsCLCoL3BGn8Dbse1X/FYafONvTejtk5m+TBcNvk8Ikpj8ok1PlyzbsXDueDMmild/skd1/60Ln9YOkvCly5dpU7CS7+hjkzOODwY6hoxXrrd7/GTSev884qG0J0/ieJB+VT6aQa0ckaexNrCy HGSbcu09 iU8DmRc+Tob16w0wbjXrzIo0QEfB3+XZt3l5TcmgOMNNTQTw3aUZxKwXw5rEWxIvMrvCbSs/wP7yC7csxpxgqTOiWY/f58XCR2kxMphgjw37cT+v2uZbprM7IE/s0OrGhIS0zdYZnTIDwLmSIYxR6dVlVcF1wyq4cNQOAeZA3HNXfaOR1fvKmopU5nGivFIpRxf8A6TE61qoppiKQP0p7i8GMr+eGG9bJsJjglNOtdw02AGa3j5awPYUWlpEdcNs95xlUfhCW4cYFXHNS2ZX45oSgery1HTpLngb/oRJVgJkGH/zx8s34kQ/kFByp+9vuByk2dSo0+Bk58NNEFPa9bKJ2iYZRFBjpF0JoiB+tWPZBNK0fYBId5WVwKv6DHchHmFdBWTYKOD5unfjE5f5PxtyoTEAIbKWgduct3WD78lE5fZH1tgLrrUGjsO9FEvmoMo2WgoVsvg75lP+MzNytwC3mHJ5WhP/Hd3fHHAiaKy9xbQo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.016092, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --2003067076-520779642-1703222093=:711362 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Thu, 21 Dec 2023, Yu Zhao wrote: > > Thanks for replyting. > > > > On Fri, Dec 22, 2023 at 07:16 AM Yuanchu Xie wrote: > > > How does the shared memory get charged to the cgroups? > > > Does it all go to cgroup A or B exclusively, or do some pages get > > > charged to each one? > > > > Some pages get charged to cgroup A, and the other get charged to cgroup B. > > Just a side note: > We can potentially "fix" this, but it doesn't mean this is a good > practice. In fact, I think this is an anti-pattern to memcgs: > resources should be preferably isolated between memcgs, or if a > resource has to be shared between memcgs, it should be charged in a > predetermined way, not randomly to one of the memcgs sharing it. > Very interesting thread, a few questions for Henry to understand the situation better: - is the lack of predeterministic charging a problem for you? Are you initially faulting it in a manner that charges it to the "right" memcg and the refault of it after periodic reclaim can causing the charge to appear "randomly," i.e. to whichever process happened to access it next? - are pages ever shared between different memcg hierarchies? You mentioned sharing between processes in A and A/B, but I'm wondering if there is sharing between two different memcg hierarchies where root is the only common ancestor? - do you anticipate a shorter scan period at some point? Proactively reclaiming all memory colder than one hour is a long time :) Are you concerned at all about the cost of doing your current idle bit harvesting approach becoming too expensive if you significantly reduce the scan period? - is proactive reclaim being driven by writing to memory.reclaim, by enforcing a smaller memory.high, or something else? Looking forward to learning more about your particular issue. --2003067076-520779642-1703222093=:711362--