From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBFF8C282D0 for ; Fri, 28 Feb 2025 17:20:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 62578280006; Fri, 28 Feb 2025 12:20:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5D505280005; Fri, 28 Feb 2025 12:20:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 476E8280006; Fri, 28 Feb 2025 12:20:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 2909A280005 for ; Fri, 28 Feb 2025 12:20:19 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id DB27E160F03 for ; Fri, 28 Feb 2025 17:20:18 +0000 (UTC) X-FDA: 83170016916.28.4CCAED2 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf16.hostedemail.com (Postfix) with ESMTP id 2E023180010 for ; Fri, 28 Feb 2025 17:20:16 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=none; spf=pass (imf16.hostedemail.com: domain of dev.jain@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=dev.jain@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740763217; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JSyEKEwDihfuun2bKXobKzhUq88MEcnz73AdcCVRYOg=; b=wPtqNHIgMRlNEMJ8O35XrWbuAMonegNAB9B4qxgP/R3gxFjOn+r2Kh9vkZG+ulZct7xEWS CqgBQftldMJrBkp6PDh28y0mhWObaUl3tnGnzRY7mCXTZ5FVLq1Ln7Wssl+XJTkftKxT9T GYfBp+uCOa69X/J2TYf8vJ+y3Od8/d8= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=none; spf=pass (imf16.hostedemail.com: domain of dev.jain@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=dev.jain@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740763217; a=rsa-sha256; cv=none; b=HlMg833RO47kp3E/wjmrvZftg4YD3cT3y57UJHuGr/MDG3wUwPF7t3yAfv5SRIks2HV2WE BD6L2hj/UZ6dTrNucX79ynPgvu/qhyWaprzwk3CXzhdvI5iB6MBst+cgKz9DS1eIH5lzb0 tmvp7fqbU7/0CIoRsxu09ex++XYJ0h0= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4223E150C; Fri, 28 Feb 2025 09:20:31 -0800 (PST) Received: from [10.163.40.175] (unknown [10.163.40.175]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7D8DE3F6A8; Fri, 28 Feb 2025 09:20:11 -0800 (PST) Message-ID: <931caf2f-4404-4d7f-ba81-df237cf53d6f@arm.com> Date: Fri, 28 Feb 2025 22:50:07 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 02/10] selftests/mm: Skip uffd-stress if userfaultfd not available To: Brendan Jackman , Lorenzo Stoakes , Andrew Morton , Shuah Khan Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250228-mm-selftests-v3-0-958e3b6f0203@google.com> <20250228-mm-selftests-v3-2-958e3b6f0203@google.com> Content-Language: en-US From: Dev Jain In-Reply-To: <20250228-mm-selftests-v3-2-958e3b6f0203@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: kiwxebszt31r1u98hdpbzdccx9cjbiwo X-Rspamd-Queue-Id: 2E023180010 X-Rspamd-Server: rspam07 X-HE-Tag: 1740763216-328290 X-HE-Meta: U2FsdGVkX18+VvRI2uMEFRmX2M6BJlvRiM5zYasg+TGxouWCyBFFCy6hM3D2sUMtpHj0M3neaGGs4W9/Bb75rPIH3/LBHH9BRL5OFZAoB0oOB09KlZ7dI9d7PKlEajPT8lNhEtFt24ipyjwV6BboVSEqhUnNY8f9+rSmAez2RGcx+nBoKNECkcenqJfCX7Oa504lp2/ncbgV2pyEp3cz7Eqq5qMQ6PIJpAdb7LX7ULN0Y1nOQ/J74yJ5SGamyN8THratF++oAYmzmqg+DRaTUh22KAJpgx/vAie19gpSh6NltuO2NCO7qlWabbk9jS66vNsyvASTgCcN19calQwpdRfwaIKlQ8ho5XWhiFDt1k/MazAKWPlgfAvkTQ1nCSIH7Rwq4BEVEThPbnXZ+PLfkIja4RSFvEBsP228VY1KN0ne2l6K/WuMJQsnxrzYqgeo46r+QWgAayixMV6rpFgkUBk9PuRgfftFQMdq2h0Kk3jLcvig9gEkWRNTRZB9fTPQcD8phLo9elEA6Z2ezC72J1EgpeESQH3AH3329UujXaPrptZE8XA9MG3p4Kww5ZM+bopeDQGJP//Wdi2jgQDMdguFY8I6HVhSYxWwPo6Ngd/JMt+Rw6y+2SpnAW/ozZUkjdVoe2GXoybLJDQWxMKAiwyNQuLtUnK4xNUQMlq3NOXWWAynhlkkZF1CFCNwDHcA1Z6j+zT6hLWYsQCN8Xn5nVufl/87DRdZES24geoqvqpc/6vDNmfG+pP8wWcaoYAcpdWlI0b4U4Jdij7WeXefFAJyEjLr+xi6MzRwS0sSGEbYFMUCr6zOLkzymeejADSKLqaoWEDt7K7cO/eOS1ORzFP/LT+P2k0vduol+sF56SEnac4cpNykanMenbkgO8MUxOij3tvF/0kidvnX/t0Bs1Sr3h7s6Rvqgp0WobfiFc2gOnao7Onsl2zs0S8+oISzWVYTLD0kiHSVt4uQinQ /XdPslsh mSAe575c2Rcpy6+BKsMcFNKvunxq5ujz27gL/OWCCAn0xJLFKySuDQboXjF5tsJMfCs07YySQ3aW4yLQQq35lgwgJRMSdGZHko7Pz9VZ2h1RFyXib8PwYxczgP2WNFPy9UKD3rCc26hfbuuLV5OFbe7LB0Mhkw0uQxHYK X-Bogosity: Ham, tests=bogofilter, spamicity=0.050175, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 28/02/25 10:24 pm, Brendan Jackman wrote: > It's pretty obvious that the test wouldn't work if you don't have the > feature enabled. But, it's still useful to SKIP instead of failing so > the reader can immediately tell that this is the reason why. > > Signed-off-by: Brendan Jackman > --- > tools/testing/selftests/mm/uffd-stress.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/mm/uffd-stress.c b/tools/testing/selftests/mm/uffd-stress.c > index a4b83280998ab7ce8d31e91d8f9fbb47ef11d742..ed68436fac62c76e2ca7060c661487f2f8a6ab45 100644 > --- a/tools/testing/selftests/mm/uffd-stress.c > +++ b/tools/testing/selftests/mm/uffd-stress.c > @@ -411,8 +411,8 @@ static void parse_test_type_arg(const char *raw_type) > * feature. > */ > > - if (uffd_get_features(&features)) > - err("failed to get available features"); > + if (uffd_get_features(&features) && errno == ENOENT) > + ksft_exit_skip("failed to get available features (%d)\n", errno); Is it possible that uffd_get_features(&features) returns non-zero without errno == ENOENT?