linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Tim Chen <tim.c.chen@linux.intel.com>
To: Andrew Morton <akpm@linux-foundation.org>,
	Michal Hocko <mhocko@kernel.org>
Cc: Dave Hansen <dave.hansen@intel.com>,
	Honglei Wang <honglei.wang@oracle.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	linux-mm@kvack.org
Subject: Re: memcgroup lruvec_lru_size scaling issue
Date: Tue, 15 Oct 2019 11:23:20 -0700	[thread overview]
Message-ID: <9312ef18-bce9-7ad5-f71d-b68fd67ade48@linux.intel.com> (raw)
In-Reply-To: <20191014151430.fc419425e515188b904cd8af@linux-foundation.org>

On 10/14/19 3:14 PM, Andrew Morton wrote:
> On Mon, 14 Oct 2019 20:31:07 +0200 Michal Hocko <mhocko@kernel.org> wrote:
> 
>> Please put all that to the changelog. It would be also great to see
>> whether that really scales with the number of cgroups if that is easy to
>> check with your benchmark.
> 
> I restored this, with some changelog additions.
> 
> Tim, please send along any updates you'd like to make to this, along
> with tested-by, acked-by, etc.
> 
> I added the Fixes: tag.  Do we think this is serious enough to warrant
> backporting into -stable trees?  I suspect so, as any older-tree
> maintainer who spies this change will say "hell yeah".

Johannes' changes that introduced the sum over all percpu counters
in lruvec_lru_size only got merged recently in 5.2. I tested 5.1 kernel and
it does not have this particular scalability issue.

So backport is only needed for 5.2 stable. 

Feel free to add 

Acked-by: Tim Chen <tim.c.chen@linux.intel.com>
Tested-by: Tim Chen <tim.c.chen@linux.intel.com>

Thanks.

Tim


  parent reply	other threads:[~2019-10-15 18:23 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-14 17:17 Tim Chen
2019-10-14 17:37 ` Michal Hocko
2019-10-14 17:49   ` Dave Hansen
2019-10-14 17:59     ` Michal Hocko
2019-10-14 18:06       ` Tim Chen
2019-10-14 18:31         ` Michal Hocko
2019-10-14 22:14           ` Andrew Morton
2019-10-15  6:19             ` Michal Hocko
2019-10-15 20:38               ` Andrew Morton
2019-10-16  7:25                 ` Michal Hocko
2019-10-15 18:23             ` Tim Chen [this message]
2019-10-14 18:11       ` Dave Hansen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9312ef18-bce9-7ad5-f71d-b68fd67ade48@linux.intel.com \
    --to=tim.c.chen@linux.intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=dave.hansen@intel.com \
    --cc=hannes@cmpxchg.org \
    --cc=honglei.wang@oracle.com \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox