linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: John Hubbard <jhubbard@nvidia.com>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
	Linus Torvalds <torvalds@linux-foundation.org>
Cc: Uros Bizjak <ubizjak@gmail.com>, Miguel Ojeda <ojeda@kernel.org>,
	"Andrew Morton" <akpm@linux-foundation.org>, <linux-mm@kvack.org>,
	<mm-commits@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL] MM updates for 6.14-rc1
Date: Wed, 29 Jan 2025 12:10:06 -0800	[thread overview]
Message-ID: <9312cc52-71d0-405f-b317-3fdccbd998e5@nvidia.com> (raw)
In-Reply-To: <CANiq72=fj0MHiwy5i=FWZxfP_=XsFpjojywF91N6ygdumtQbwQ@mail.gmail.com>

On 1/26/25 12:58 PM, Miguel Ojeda wrote:
> On Sun, Jan 26, 2025 at 7:30 PM Linus Torvalds
> <torvalds@linux-foundation.org> wrote:
>>
>> That seems to be a reasonable assumption. I guess some crazy setup
>> *could* install a bindgen that uses a different llvm version than
>> rustc itself, but that sounds pretty damn broken.
> 
> Tangential to the issue, but a note on this: we have a few warnings in
> that `rust_is_available.sh` script for things that "do not look
> great", such as bindgen's libclang != Clang when `CC` is Clang, and we
> could have a warning for the case you mention, i.e. bindgen's libclang
> != rustc's LLVM.
> 
> However, currently some kernel developers use toolchains from upstream
> Rust (e.g. from `rustup`) instead of their distributions, so that

Yes, because the distros themselves actually recommended it (Arch Linux,
anyway).

I took a reasonably careful look at the Rust setup for the basics to
build the kernel, for Arch Linux, a couple times, and for 2024 at least,
the answer clearly seemed to be:

     Use the distro's rustup package
         Use rustup to get rustc

     Use the distro's bindgen packaged

Maybe that is All Wrong for 2025+. But this stuff is changing as Rust
and Rust-for-Linux start to settle down, and I'm a little concerned
about warnings unless they warn about something that *really*
matters.

> could be annoying for them (since their bindgen may be picking
> libclang from their distribution).

Trust me, the Rust installation is already sufficiently annoying.
But maybe I'm just being paranoid, and the new warnings will direct
me to a better setup.

I'll take a look at this if you CC me, though, and see how Arch
behaves.

> 
> But eventually when things stabilize more it could make sense, if most
> developers stop using those, as a by-default warning.
> 
> Cheers,
> Miguel
> 

thanks,
-- 
John Hubbard



      reply	other threads:[~2025-01-29 20:10 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-25  0:22 Andrew Morton
2025-01-25 22:09 ` Linus Torvalds
2025-01-26  5:00   ` Andrew Morton
2025-01-26  7:34     ` Linus Torvalds
2025-01-26  8:27     ` Stephen Rothwell
2025-01-26 12:10     ` Uros Bizjak
2025-01-26  9:57   ` Uros Bizjak
2025-01-26 17:21     ` Uros Bizjak
2025-01-26 18:29       ` Linus Torvalds
2025-01-26 19:46         ` Uros Bizjak
2025-01-26 20:06           ` Uros Bizjak
2025-01-26 21:59           ` Linus Torvalds
2025-01-26 23:27             ` Uros Bizjak
2025-01-27  0:08               ` Linus Torvalds
2025-01-27  7:29                 ` Uros Bizjak
2025-01-26 20:28         ` Miguel Ojeda
2025-01-26 21:19           ` Matthew Wilcox
2025-01-26 21:35             ` Miguel Ojeda
2025-01-26 20:58         ` Miguel Ojeda
2025-01-29 20:10           ` John Hubbard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9312cc52-71d0-405f-b317-3fdccbd998e5@nvidia.com \
    --to=jhubbard@nvidia.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=miguel.ojeda.sandonis@gmail.com \
    --cc=mm-commits@vger.kernel.org \
    --cc=ojeda@kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=ubizjak@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox