From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63B9FC36018 for ; Tue, 17 Sep 2024 12:02:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E29956B0093; Tue, 17 Sep 2024 08:02:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DD98C6B0095; Tue, 17 Sep 2024 08:02:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C79736B0098; Tue, 17 Sep 2024 08:02:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id AA8926B0093 for ; Tue, 17 Sep 2024 08:02:29 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 331F0A8EE1 for ; Tue, 17 Sep 2024 12:02:29 +0000 (UTC) X-FDA: 82574092818.15.DC0CC36 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf25.hostedemail.com (Postfix) with ESMTP id E799BA001E for ; Tue, 17 Sep 2024 12:02:25 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ePGPdRET; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726574514; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dTizJfqYrZ1eGNFNnTVt8fMRPv3GrUVc+z4dSs5TcXw=; b=dBaUSKNbBRIK1ZTbX5Kia77mVhxXufnp7+dXhIMb40/pI0LzjS2kYJpOvDy2b9qmwDdgpE 6fBiC2vKu3HTkR1hIoKpYXJwxXIlVv4hoseV8q8MX6aj89lXt88fU/yciGuEE3iwmfI6Sd REkysGVW/FlCZpU7ljGBflUCJxIM3pM= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ePGPdRET; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1726574514; a=rsa-sha256; cv=none; b=KoMIOrrJyea0vh5W2T//e2vpNeJr8wu7XEicEys2fqshtmUW4twxV/99bvophElJPmOkJt 4uobOY1/yq0ms6kvcaVBJ+Jt1Anlnyj1Vae9qAM8TteRHEdmSOuucQONv2FHuXW7HVA9ew VDjBKNWRj1qUeQwR4ZOXXdUFiMqpizM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1726574545; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=dTizJfqYrZ1eGNFNnTVt8fMRPv3GrUVc+z4dSs5TcXw=; b=ePGPdRETPkEAY3mlHNROf22lBx6QYNLLE9b9/Ia+c9QdUbvYLjO3tTN4yqzJYRHyH6xFnt 7fUX0miyoO7NwSSJI6xYIIetvm21PnefF2egnknPandS367jztWDxCWWnBbR7WM9WKPVSF fQBBDdhIFMaH6DY+jTnKKAI+Op/lcTM= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-466-t0w63YLOOo-BK1uuhWlUfg-1; Tue, 17 Sep 2024 08:02:24 -0400 X-MC-Unique: t0w63YLOOo-BK1uuhWlUfg-1 Received: by mail-ej1-f71.google.com with SMTP id a640c23a62f3a-a8ff95023b6so389754466b.3 for ; Tue, 17 Sep 2024 05:02:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726574543; x=1727179343; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=dTizJfqYrZ1eGNFNnTVt8fMRPv3GrUVc+z4dSs5TcXw=; b=LZqq55PVkgBngcUSi3OJU0AQtYTaisCYAHbVm+dAVCrWYPfU7cPl7H91pOUjEH4Ajt lY/leEPJkwzEwt3UW83MDVa7LJlEZ3p25iIvpKBOQ/TL1QSx9rlWJp0v4ojHYqOST/ft 1HVbqS1t6Ese+/WgzZDQlUGw0RgcUJifCqihkqSzS+CvIkDzQs7zJByT44IYWesseMSF psOkS19E2igjK6si/NBsgjqvbyarcX9OVkwDHPp4+hungifTyu+H7w0FSGryYLGg++Ha ls2DlBZU6dZI8fNKre7uRWgSmboGOvbVSAPrA9hY1/RksNC1gn+Ims/idutEi1bVyjI6 vo8g== X-Forwarded-Encrypted: i=1; AJvYcCUVg80nN0kO5jv7JO77puNR8DmEO6TQldUz2UNHWixMhDbqGKwaNwlCNebr46gRLYHkvdmAcGCMag==@kvack.org X-Gm-Message-State: AOJu0YySQ8rrVwc3XQayzU1hgV6meDkPtbZiGJ2PlejvwSxn+puBL0df ZWjjH1RmOR0xuX2iP0HXWQrVRSIJsr4d7/jKIu0xMIXVUjh4WCPC13DXd0TmnMDiH+c3IvscPPb AEuMP5cTvf0davqsCk+OOxjDFhjcjWHlV0zOwXx47o96GmelmGzbW8dGS X-Received: by 2002:a17:906:fe04:b0:a8a:1ffe:70f1 with SMTP id a640c23a62f3a-a9029617496mr1746619066b.50.1726574543031; Tue, 17 Sep 2024 05:02:23 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH/AYIL3HnAmcyaVMGU1v9PWUkTCOfJxKQ0ma5ztCblUGaRbWU1amACDso+3ibXc3mKulVbqw== X-Received: by 2002:a17:906:fe04:b0:a8a:1ffe:70f1 with SMTP id a640c23a62f3a-a9029617496mr1746615166b.50.1726574542445; Tue, 17 Sep 2024 05:02:22 -0700 (PDT) Received: from [192.168.55.136] (tmo-113-196.customers.d1-online.com. [80.187.113.196]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a90610f44fasm435751066b.79.2024.09.17.05.02.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Sep 2024 05:02:22 -0700 (PDT) Message-ID: <92f97c8e-f23d-4c6e-9f49-230fb4e96c46@redhat.com> Date: Tue, 17 Sep 2024 14:02:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC] mm: mglru: provide a separate list for lazyfree anon folios To: Barry Song <21cnbao@gmail.com>, akpm@linux-foundation.org, linux-mm@kvack.org Cc: mhocko@suse.com, fengbaopeng@honor.com, gaoxu2@honor.com, hailong.liu@oppo.com, kaleshsingh@google.com, linux-kernel@vger.kernel.org, lokeshgidra@google.com, ngeoffray@google.com, shli@fb.com, surenb@google.com, yipengxiang@honor.com, yuzhao@google.com, minchan@kernel.org, Barry Song References: <20240914063746.46290-1-21cnbao@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240914063746.46290-1-21cnbao@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: mu68dgxzegeb1xycprbysz855nzkxae3 X-Rspamd-Queue-Id: E799BA001E X-Rspamd-Server: rspam11 X-HE-Tag: 1726574545-221039 X-HE-Meta: U2FsdGVkX1+5r60vhw+CHw7OGczJU9BxQ+Z3zqg5hMp/SOq4vkAimXckkCVs7FZ5xAysk6KJWCbkTtCanIDkS6YHCppd9M2Ud9/t9i1uZ97taLflvqlnguu1Z4+JW20dx29JGS4lz77eTNYw33byS8gLs0mHxDrSxAaZn2LoskSbRgMq96DEmvM9w4LZrDPJZSB8OT8hQ7qwee1KVfZTwL/eGnHbedl8/ydYmmmYuyUBF/k2/2EFJ27gVi7EH0rWtj+cyGUm8bYiuqKLmcvBXK9e3nGHM+5X/Ny7FYmtc2xHsLO/uNuyJ302F2g5yp7B+Qk0/o9FeXD+XEUjPJ/ssUs03tTZrztWOGCnfa7XDO6uq2BbhVETJ6pjhF9vvD7PTvu7fJZHu7DjV4Laq7bufxVCkJnljenOJPThImiASZtVFzhuU9rAu8HdHf61iRtusgPK6BssorGVCEn2JpJ0rNOqO6KtPMDLO6ssxTd8pPZEjBrvu6xl5RuJ6+90s7g1BNtT/DZt77zKOXuxvr8p+ZJqQf4RGVymM7S41N+NtV3M5oIAiW0fw6E6ZzWXLwltxL6ZQxtJmFdw8m0QQy5Dhp3bNLg4R8p/lbuOV0Ke0FGEiEGM7uKudX8AfBbqnbgf2BrNF9hwe5v4aJoksglwGeYOUSaNy7sQMf+pXaauGH8cj7WFc26FKGsq1Vuz5RHmN7l05tYhanmoTZ6GYteckcF20WlcnWxMrNIA6bxnO5r1+GE5Ce3jwX7w7Zm+E9YUD+0qEk13Vv7BmXfuGbY/5O/1n5TDvMfP4aH3JHOdt+OmfKC6eRgcoF4/a/wmLS49y0b11cF6fdWqL8LwfKy9PStoHfgIPCFJn0Em44X50EXq+LhJOavdggAsC1jBm5iiIQeNZWdi8wyMOasrhvZtkDbDEheC9ZCuyqgGdpQQG1MQttJNJWgSCq+WcqEk7E+CqsyBt4SqLFRJqTP9FKq 69nsn2ZJ kulJzoPQV8rjM6bspSw4neSjssk9amWI5CI1lSVAsd72W1GYWsQToGq/hsJnJVF1P2XQsBhxmmOT8aPsdqwyhjonp4DFnDXth60/YqXPujcE/XYiz3YI8fRbV+8iWJ7lrhYIyh9D12XwfWjIorn+OV2RHPVihreiu6EilxgUSdBGKkHVmYRzEVJ4+yoRaXB2zPjuGtb/h8SejAC4H0AfHIhXv5JA/0TLjfpJ4T5Pc7eNabQv3EI6M3VaBl49U+ttyc9biYcFX/GKoe8K1sFsw5FlcOPQtvaTsL51cpIwyVT1YyPpXrFAQOIDUstt5LK0sTueSSQ1DTl4TvnjOZUhKOIxTeZD5b1kL3Es6OIUZIWjfhrMkZz4GZ78Oyzf0Zeoq9XmUeHoNPdouOtY8IUYxLK6qRqpP02BZj63HuYXOcn4NS+r6BVIgK6AplA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 14.09.24 08:37, Barry Song wrote: > From: Barry Song > > This follows up on the discussion regarding Gaoxu's work[1]. It's > unclear if there's still interest in implementing a separate LRU > list for lazyfree folios, but I decided to explore it out of > curiosity. > > According to Lokesh, MADV_FREE'd anon folios are expected to be > released earlier than file folios. One option, as implemented > by Gao Xu, is to place lazyfree anon folios at the tail of the > file's `min_seq` generation. However, this approach results in > lazyfree folios being released in a LIFO manner, which conflicts > with LRU behavior, as noted by Michal. > > To address this, this patch proposes maintaining a separate list > for lazyfree anon folios while keeping them classified under the > "file" LRU type to minimize code changes. These lazyfree anon > folios will still be counted as file folios and share the same > generation with regular files. In the eviction path, the lazyfree > list will be prioritized for scanning before the actual file > LRU list. > What's the downside of another LRU list? Do we have any experience on that? -- Cheers, David / dhildenb